Re: [SMW-devel] Removing "nameproperty" from SRF "graph" format because of unclear intention

[Jeroen De Dauw]

Hey Sebastian,

The nameproperty parameter appears to be unused which means it can be
removed without changing behavior. Actually on second look the parameter
does not even seem to exist, just some code that uses it if it did.

Given its name I suspect it was meant to get the name of a printeout to use
for some label on the graph. Similar to
https://github.com/ProfessionalWiki/ModernTimeline/issues/9#issuecomment-523070103

Cheers

--
Jeroen De Dauw | www.EntropyWins.wtf  |
www.Professional.Wiki 
Software Crafter | Entrepreneur | Speaker | Strategist | Contributor
to Wikimedia
and Open Source
~=[,,_,,]:3
___
Semediawiki-devel mailing list
Semediawiki-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel

[SMW-devel] Removing "nameproperty" from SRF "graph" format because of unclear intention

[Sebastian]

As part of refactoring the the "graph" format in SemanticResultFormats [0] I want to 
remove the "nameproperty" parameter [1] because of unknown intention [2].

[0] https://github.com/SemanticMediaWiki/SemanticResultFormats/pull/507
[1] https://www.semantic-mediawiki.org/wiki/Help:Graph_format
[2]https://github.com/SemanticMediaWiki/SemanticResultFormats/issues/533

--
Sebastian Schmid
Software Engineer

Telefon: +49 9435 65218-21
E-Mail: sebastian.sch...@gesinn.it

gesinn.it GmbH & Co. KG
Sitz: Am Koweiher 8f, 92521 Schwarzenfeld
Registergericht: Amtsgericht Amberg, HRA 3263

Persönlich haftende Gesellschafterin:

gesinn.it Verwaltungs GmbH
Sitz: Am Koweiher 8f, 92521 Schwarzenfeld
Registergericht: Amtsgericht Amberg, HRB 5168
Geschäftsführer: Alexander Gesinn

___
Semediawiki-devel mailing list
Semediawiki-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/semediawiki-devel