Re: Spring migration
Like Eric already pointed out, current james trunk is the place you want to have a look at. Its based on spring-container. So just have a look and come back to us when you have questions etc. And yes we love contributions, so patches welcome :) Bye, Norman 2010/10/9 Eric Charles e...@apache.org: Hi, James 3 will be soon release and runs on Spring. You can check it out from http://svn.apache.org/repos/asf/james/server/trunk/. Just compile it with mvn package and use it (dist zip is in spring-deployement/target). There some open JIRA for 3.0-M1 on https://issues.apache.org/jira/secure/BrowseVersion.jspa?id=10411versionId=12314294showOpenIssuesOnly=true, but come back on mailing list to talk about. Tks, Eric On 9/10/2010 06:10, Dhrubo wrote: Hello All, I would like to contribute to the Spring port of JAMES. It will be very good if some one tells me the steps. I do not see any bug tracker for the Spring port yet on JIRA. Kind Regards... Dhrubo - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Resolved: (JAMES-1051) split spoolmanager module into mailetcontainer-api and mailetcontainer-impl.
[ https://issues.apache.org/jira/browse/JAMES-1051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved JAMES-1051. -- Resolution: Fixed done split spoolmanager module into mailetcontainer-api and mailetcontainer-impl. Key: JAMES-1051 URL: https://issues.apache.org/jira/browse/JAMES-1051 Project: JAMES Server Issue Type: Task Components: SpoolManager Processors Reporter: Norman Maurer Assignee: Norman Maurer Fix For: 3.0-M1 We should split spoolmanager module to mailetcontainer-api and mailetcontainer-impl to better show the usage -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Resolved: (JAMES-1031) Only use MailClaimCheck / MailEnricher when a treshold is hit
[ https://issues.apache.org/jira/browse/JAMES-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved JAMES-1031. -- Resolution: Invalid The enricher / claimcheck is not used anymore Only use MailClaimCheck / MailEnricher when a treshold is hit - Key: JAMES-1031 URL: https://issues.apache.org/jira/browse/JAMES-1031 Project: JAMES Server Issue Type: Improvement Components: SpoolManager Processors Reporter: Norman Maurer Assignee: Norman Maurer Fix For: 3.0 At the moment we store the MimeMessage of the Mail on fs before we hand the rest of to jms. This is needed for very big messages but for small messages its a way faster to just store them directly in the JMS Queue. We should make it configurable at which message size it need to get stored out-of-band. Maybe we should even consider to store it via a BlobMessage then -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Resolved: (JAMES-826) Source distribution build is broken
[
https://issues.apache.org/jira/browse/JAMES-826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Norman Maurer resolved JAMES-826.
-
Resolution: Fixed
Fix Version/s: (was: 3.0)
3.0-M1
Assignee: Norman Maurer
Just checked.. building from -src package works here.
Source distribution build is broken
---
Key: JAMES-826
URL: https://issues.apache.org/jira/browse/JAMES-826
Project: JAMES Server
Issue Type: Bug
Components: Build System
Affects Versions: 3.0
Reporter: Bernd Fondermann
Assignee: Norman Maurer
Priority: Blocker
Fix For: 3.0-M1
The zip/tarball artefacts created during build named
james-server-with-phoenix-${version}-src are not complete with respect to
contained java sources and it is not buildable (ant aborts early).
As it is the main release artefact, this must be fixed before releasing.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Updated: (JAMES-616) Add chi-square-based spam filter approach to BayesianAnalyzer.
[ https://issues.apache.org/jira/browse/JAMES-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated JAMES-616: Fix Version/s: (was: Trunk) (was: 3.0) Not sure this will happen for 3.0 so move it Add chi-square-based spam filter approach to BayesianAnalyzer. -- Key: JAMES-616 URL: https://issues.apache.org/jira/browse/JAMES-616 Project: JAMES Server Issue Type: Improvement Components: Matchers/Mailets (bundled) Affects Versions: 3.0 Reporter: Vincenzo Gianferrari Pini Assignee: Vincenzo Gianferrari Pini We should add chi-square-based spam filter approach to BayesianAnalyzer, based on Gary Robinson's blog and paper (http://garyrob.blogs.com//handlingtokenredundancy94.pdf). I will first of all write him an email asking for some clarifications. My impression for now is that the work should not be so difficult. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Updated: (JAMES-948) Composite pattern employed to implement And, Or, Xor and Not matcher.
[ https://issues.apache.org/jira/browse/JAMES-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated JAMES-948: Fix Version/s: 3.0 Will be in 3.0 Composite pattern employed to implement And, Or, Xor and Not matcher. - Key: JAMES-948 URL: https://issues.apache.org/jira/browse/JAMES-948 Project: JAMES Server Issue Type: New Feature Components: Matchers/Mailets (bundled) Affects Versions: 2.3.2 Environment: Proposal Reporter: Ralph B Holland Assignee: Norman Maurer Priority: Minor Fix For: 3.0 Attachments: 20100111-rbh-patch-V2.3.txt Original Estimate: 120h Remaining Estimate: 120h Composite matchers can be added to James V2.3.3 via mofication to JamesSpoolManager, Matcher and MatcherLoader interface, and JamesMatcherLoader. Patches supplied. Some time will be needed to migrate the concept to the Unreleased HEAD -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006120 - /james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
Author: norman
Date: Sat Oct 9 09:12:41 2010
New Revision: 1006120
URL: http://svn.apache.org/viewvc?rev=1006120view=rev
Log:
cleanup
Modified:
james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
Modified:
james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java?rev=1006120r1=1006119r2=1006120view=diff
==
---
james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
(original)
+++
james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
Sat Oct 9 09:12:41 2010
@@ -35,6 +35,7 @@ import org.apache.commons.configuration.
import org.apache.commons.logging.Log;
import org.apache.james.lifecycle.Configurable;
import org.apache.james.lifecycle.LogEnabled;
+import org.apache.james.mailrepository.MailRepository;
import org.apache.james.mailstore.MailStore;
import org.apache.james.services.InstanceFactory;
@@ -45,16 +46,9 @@ import org.apache.james.services.Instanc
*/
public class JamesMailStore implements MailStore, LogEnabled, Configurable {
-// Prefix for repository names
-private static final String REPOSITORY_NAME = Repository;
-
-// Static variable used to name individual repositories. Should only
-// be accessed when a lock on the AvalonMailStore.class is held
-private static long id;
// map of [destinationURL + type]-Repository
-@SuppressWarnings(unchecked)
-private Map repositories;
+private MapString, MailRepository repositories;
// map of [protocol(destinationURL) + type ]-classname of repository;
private MapString,String classes;
@@ -71,9 +65,6 @@ public class JamesMailStore implements M
private InstanceFactory factory;
- //private LoaderService loader;
-
-
public void setLog(Log logger) {
this.logger = logger;
}
@@ -191,7 +182,6 @@ public class JamesMailStore implements M
*Configuration or retrieving the
*MailRepository
*/
-@SuppressWarnings(unchecked)
public synchronized Object select(HierarchicalConfiguration repConf)
throws StoreException {
String destination = null;
@@ -207,7 +197,7 @@ public class JamesMailStore implements M
String type = repConf.getString([...@type]);
String repID = destination + type;
-Object reply = repositories.get(repID);
+MailRepository reply = repositories.get(repID);
StringBuffer logBuffer = null;
if (reply != null) {
if (getLogger().isDebugEnabled()) {
@@ -252,7 +242,7 @@ public class JamesMailStore implements M
}
try {
-reply =
factory.newInstance(Thread.currentThread().getContextClassLoader().loadClass(repClass),
logger, config);
+reply = (MailRepository)
factory.newInstance(Thread.currentThread().getContextClassLoader().loadClass(repClass),
logger, config);
repositories.put(repID, reply);
if (getLogger().isInfoEnabled()) {
@@ -275,18 +265,4 @@ public class JamesMailStore implements M
}
}
-
-/**
- * pReturns a new name for a repository./p
- *
- * pSynchronized on the AvalonMailStore.class object to ensure
- * against duplication of the repository name/p
- *
- * @return a new repository name
- */
-public static final String getName() {
-synchronized (JamesMailStore.class) {
-return REPOSITORY_NAME + id++;
-}
-}
}
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006121 - /james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
Author: norman
Date: Sat Oct 9 09:21:34 2010
New Revision: 1006121
URL: http://svn.apache.org/viewvc?rev=1006121view=rev
Log:
Can be other classes then implementations of MailRepository (this should prolly
get revisited)
Modified:
james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
Modified:
james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java?rev=1006121r1=1006120r2=1006121view=diff
==
---
james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
(original)
+++
james/server/trunk/mail-library/src/main/java/org/apache/james/mailstore/JamesMailStore.java
Sat Oct 9 09:21:34 2010
@@ -35,7 +35,6 @@ import org.apache.commons.configuration.
import org.apache.commons.logging.Log;
import org.apache.james.lifecycle.Configurable;
import org.apache.james.lifecycle.LogEnabled;
-import org.apache.james.mailrepository.MailRepository;
import org.apache.james.mailstore.MailStore;
import org.apache.james.services.InstanceFactory;
@@ -48,7 +47,7 @@ public class JamesMailStore implements M
// map of [destinationURL + type]-Repository
-private MapString, MailRepository repositories;
+private MapString, Object repositories;
// map of [protocol(destinationURL) + type ]-classname of repository;
private MapString,String classes;
@@ -197,7 +196,7 @@ public class JamesMailStore implements M
String type = repConf.getString([...@type]);
String repID = destination + type;
-MailRepository reply = repositories.get(repID);
+Object reply = repositories.get(repID);
StringBuffer logBuffer = null;
if (reply != null) {
if (getLogger().isDebugEnabled()) {
@@ -242,7 +241,7 @@ public class JamesMailStore implements M
}
try {
-reply = (MailRepository)
factory.newInstance(Thread.currentThread().getContextClassLoader().loadClass(repClass),
logger, config);
+reply =
factory.newInstance(Thread.currentThread().getContextClassLoader().loadClass(repClass),
logger, config);
repositories.put(repID, reply);
if (getLogger().isInfoEnabled()) {
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Created: (JAMES-1060) Use javamail system properties in startup scripts to let javamail handle bad formated messages more friendly
Use javamail system properties in startup scripts to let javamail handle bad formated messages more friendly Key: JAMES-1060 URL: https://issues.apache.org/jira/browse/JAMES-1060 Project: JAMES Server Issue Type: Improvement Reporter: Norman Maurer Fix For: 3.0-M1 javmail offers a lot of system properties to let it not throw MessagingExceptions on bad formated messages. We should make use of them -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006122 - in /james/server/trunk: pom.xml spring-deployment/pom.xml
Author: norman
Date: Sat Oct 9 09:37:40 2010
New Revision: 1006122
URL: http://svn.apache.org/viewvc?rev=1006122view=rev
Log:
Add javmail system properties to startup scripts to let javamail handle bad
formated messages more friendly (JAMES-1060)
Modified:
james/server/trunk/pom.xml
james/server/trunk/spring-deployment/pom.xml
Modified: james/server/trunk/pom.xml
URL:
http://svn.apache.org/viewvc/james/server/trunk/pom.xml?rev=1006122r1=1006121r2=1006122view=diff
==
--- james/server/trunk/pom.xml (original)
+++ james/server/trunk/pom.xml Sat Oct 9 09:37:40 2010
@@ -1147,7 +1147,20 @@
jsieve.version0.4/jsieve.version
jackrabbit.version2.1.0/jackrabbit.version
commons.logging.version1.1/commons.logging.version
-
+!-- For more details see --
+!--
http://java.sun.com/products/javamail/javadocs/javax/mail/internet/package-summary.html
--
+javamail.system-properties
+ -Dmail.mime.multipart.ignoremissingendboundary=true
+ -Dmail.mime.multipart.ignoremissingboundaryparameter=true
+ -Dmail.mime.ignoreunknownencoding=true
+ -Dmail.mime.uudecode.ignoreerrors=true
+ -Dmail.mime.uudecode.ignoremissingbeginend=true
+ -Dmail.mime.multipart.allowempty=true
+ -Dmail.mime.base64.ignoreerrors=true
+ -Dmail.mime.encodeparameters=true
+ -Dmail.mime.decodeparameters=true
+ -Dmail.mime.address.strict=false
+/javamail.system-properties
/properties
/project
Modified: james/server/trunk/spring-deployment/pom.xml
URL:
http://svn.apache.org/viewvc/james/server/trunk/spring-deployment/pom.xml?rev=1006122r1=1006121r2=1006122view=diff
==
--- james/server/trunk/spring-deployment/pom.xml (original)
+++ james/server/trunk/spring-deployment/pom.xml Sat Oct 9 09:37:40 2010
@@ -52,7 +52,7 @@
includeConfigurationDirectoryInClasspathtrue/includeConfigurationDirectoryInClasspath
environmentSetupFileNamesetenv/environmentSetupFileName
!-- set some sane defaults for memory --
- extraJvmArguments-Xms128m -Xmx512m
-Djava.system.class.loader=org.apache.james.container.spring.JamesClassLoader/extraJvmArguments
+ extraJvmArguments-Xms128m -Xmx512m
-Djava.system.class.loader=org.apache.james.container.spring.JamesClassLoader
${javamail.system-properties}/extraJvmArguments
!-- Generate bin scripts for windows and unix per default --
platforms
platformwindows/platform
@@ -136,6 +136,10 @@
namewrapper.java.additional.1/name
value-Djava.system.class.loader=org.apache.james.container.spring.JamesClassLoader/value
/property
+property
+ namewrapper.java.additional.2/name
+ value${javamail.system-properties}/value
+/property
/configuration
/generatorConfiguration
/generatorConfigurations
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006123 - /james/server/trunk/spring-deployment/src/main/config/james/torque.properties
Author: norman Date: Sat Oct 9 09:39:26 2010 New Revision: 1006123 URL: http://svn.apache.org/viewvc?rev=1006123view=rev Log: Torque is gone so remove old config file Removed: james/server/trunk/spring-deployment/src/main/config/james/torque.properties - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006124 - /james/server/trunk/spring-deployment/src/main/config/james/mailboxManagerSqlResources.xml
Author: norman Date: Sat Oct 9 09:44:17 2010 New Revision: 1006124 URL: http://svn.apache.org/viewvc?rev=1006124view=rev Log: Leftover from torque, remove it Removed: james/server/trunk/spring-deployment/src/main/config/james/mailboxManagerSqlResources.xml - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
RE: [jira] Updated: (JAMES-948) Composite pattern employed to implement And, Or, Xor and Not matcher.
Norman. Thanks for scheduling these changes. I have been working really hard on our product www.arising.com.au/ir-gis in my spare time outside my normal work hours to the exclusion of the rest of my life. This is the first weekend off since Feb 2010 and I actually went flying, a hobby of mine.. Regards, Ralph Holland Managing Director Arising Technology System Pty Limited BH:61 2 61271265 AH:61 2 62312869 Fax:61 2 62312768 Mob: 0417 312869 (AH/weekends only) ™ Innovative Real-time Geographic Information System www.arising.com.au/ir-gis __ This email message and any accompanying attachments may contain information that is confidential and intended only for the use of the addressee(s) named above. It may also be privileged. If you are not the intended recipient do not read, use, disseminate, distribute or copy or take any action in reliance on it. If you have received this message in error, please notify the sender immediately, and delete this message. It is your responsibility to check attachments for viruses or defects. __ -Original Message- From: Norman Maurer (JIRA) [mailto:server-...@james.apache.org] Sent: Saturday, 9 October 2010 6:56 PM To: ra...@arising.com.au Subject: [jira] Updated: (JAMES-948) Composite pattern employed to implement And, Or, Xor and Not matcher. [ https://issues.apache.org/jira/browse/JAMES-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated JAMES-948: Fix Version/s: 3.0 Will be in 3.0 Composite pattern employed to implement And, Or, Xor and Not matcher. - Key: JAMES-948 URL: https://issues.apache.org/jira/browse/JAMES-948 Project: JAMES Server Issue Type: New Feature Components: Matchers/Mailets (bundled) Affects Versions: 2.3.2 Environment: Proposal Reporter: Ralph B Holland Assignee: Norman Maurer Priority: Minor Fix For: 3.0 Attachments: 20100111-rbh-patch-V2.3.txt Original Estimate: 120h Remaining Estimate: 120h Composite matchers can be added to James V2.3.3 via mofication to JamesSpoolManager, Matcher and MatcherLoader interface, and JamesMatcherLoader. Patches supplied. Some time will be needed to migrate the concept to the Unreleased HEAD -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006129 - in /james/server/trunk: core-library/src/test/java/org/apache/james/services/ fetchmail/src/main/java/org/apache/james/fetchmail/ lmtpserver/src/main/java/org/apache/james/lmtps
Author: norman Date: Sat Oct 9 10:38:43 2010 New Revision: 1006129 URL: http://svn.apache.org/viewvc?rev=1006129view=rev Log: Rename James.xml to mailserver.xml + rename James bean to mailserver Added: james/server/trunk/spring-deployment/src/main/config/james/mailserver.xml - copied, changed from r1004708, james/server/trunk/spring-deployment/src/main/config/james/James.xml Removed: james/server/trunk/spring-deployment/src/main/config/james/James.xml Modified: james/server/trunk/core-library/src/test/java/org/apache/james/services/MockJSR250Loader.java james/server/trunk/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java james/server/trunk/fetchmail/src/main/java/org/apache/james/fetchmail/FetchScheduler.java james/server/trunk/lmtpserver/src/main/java/org/apache/james/lmtpserver/DataLineLMTPMessageHookHandler.java james/server/trunk/lmtpserver/src/main/java/org/apache/james/lmtpserver/netty/NioLMTPServer.java james/server/trunk/mailetcontainer-impl/src/main/java/org/apache/james/mailetcontainer/JamesMailetContext.java james/server/trunk/mailets/src/main/java/org/apache/james/transport/mailets/AbstractRedirect.java james/server/trunk/mailets/src/main/java/org/apache/james/transport/mailets/AbstractVirtualUserTable.java james/server/trunk/mailets/src/main/java/org/apache/james/transport/mailets/AbstractVirtualUserTableMailet.java james/server/trunk/mailets/src/main/java/org/apache/james/transport/mailets/LocalDelivery.java james/server/trunk/mailets/src/main/java/org/apache/james/transport/mailets/RemoteDelivery.java james/server/trunk/mailets/src/main/java/org/apache/james/transport/mailets/SieveMailet.java james/server/trunk/pop3server/src/main/java/org/apache/james/pop3server/netty/NioPOP3Server.java james/server/trunk/remotemanager/src/main/java/org/apache/james/remotemanager/core/AddUserCmdHandler.java james/server/trunk/remotemanager/src/main/java/org/apache/james/remotemanager/core/ListUsersCmdHandler.java james/server/trunk/remotemanager/src/main/java/org/apache/james/remotemanager/netty/NioRemoteManager.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/AuthRequiredToRelayRcptHook.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/DataLineJamesMessageHookHandler.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/JamesDataCmdHandler.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/JamesMailCmdHandler.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/JamesRcptCmdHandler.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/SendMailHandler.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/SenderAuthIdentifyVerificationRcptHook.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/fastfail/ValidRcptHandler.java james/server/trunk/smtpserver/src/main/java/org/apache/james/smtpserver/netty/NioSMTPServer.java james/server/trunk/spring-deployment/src/main/config/james/log4j.properties james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml Modified: james/server/trunk/core-library/src/test/java/org/apache/james/services/MockJSR250Loader.java URL: http://svn.apache.org/viewvc/james/server/trunk/core-library/src/test/java/org/apache/james/services/MockJSR250Loader.java?rev=1006129r1=1006128r2=1006129view=diff == --- james/server/trunk/core-library/src/test/java/org/apache/james/services/MockJSR250Loader.java (original) +++ james/server/trunk/core-library/src/test/java/org/apache/james/services/MockJSR250Loader.java Sat Oct 9 10:38:43 2010 @@ -37,7 +37,7 @@ public class MockJSR250Loader extends Ab // TODO Do we still need that? //servicesByName.put(org.apache.james.LoaderService, this); -mappings.put(James, org.apache.james.services.MailServer.class.getName()); +mappings.put(mailserver, org.apache.james.services.MailServer.class.getName()); mappings.put(filesystem, org.apache.james.services.FileSystem.class.getName()); mappings.put(dnsservice, org.apache.james.dnsservice.api.DNSService.class.getName()); mappings.put(users-store, org.apache.james.api.user.UsersStore.class.getName()); Modified: james/server/trunk/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java URL: http://svn.apache.org/viewvc/james/server/trunk/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java?rev=1006129r1=1006128r2=1006129view=diff == --- james/server/trunk/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java (original) +++
svn commit: r1006130 - /james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml
Author: norman Date: Sat Oct 9 10:41:05 2010 New Revision: 1006130 URL: http://svn.apache.org/viewvc?rev=1006130view=rev Log: Don't register a shutdown hook for activemq. Spring will take care to shutdown on JVM exit. This helps to ensure that activemq broker will not get destroyed while ActiveMQMailQueue is still using it Modified: james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml Modified: james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml URL: http://svn.apache.org/viewvc/james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml?rev=1006130r1=1006129r2=1006130view=diff == --- james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml (original) +++ james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml Sat Oct 9 10:41:05 2010 @@ -129,7 +129,7 @@ /camel:camelContext !-- lets create an embedded ActiveMQ Broker -- -amq:broker useJmx=false persistent=true dataDirectory=filesystem=file://var/activemq-data/ schedulerSupport=true id=broker +amq:broker useJmx=false persistent=true dataDirectory=filesystem=file://var/activemq-data/ schedulerSupport=true useShutdownHook=false id=broker amq:destinationPolicy amq:policyMap amq:policyEntries - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006131 - /james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml
Author: norman Date: Sat Oct 9 10:44:29 2010 New Revision: 1006131 URL: http://svn.apache.org/viewvc?rev=1006131view=rev Log: rename amq broker from localhost to james. Because a broker name should be unique and localhost is the default Modified: james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml Modified: james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml URL: http://svn.apache.org/viewvc/james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml?rev=1006131r1=1006130r2=1006131view=diff == --- james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml (original) +++ james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml Sat Oct 9 10:44:29 2010 @@ -129,7 +129,7 @@ /camel:camelContext !-- lets create an embedded ActiveMQ Broker -- -amq:broker useJmx=false persistent=true dataDirectory=filesystem=file://var/activemq-data/ schedulerSupport=true useShutdownHook=false id=broker +amq:broker useJmx=false persistent=true brokerName=james dataDirectory=filesystem=file://var/activemq-data/ schedulerSupport=true useShutdownHook=false id=broker amq:destinationPolicy amq:policyMap amq:policyEntries @@ -147,7 +147,7 @@ /amq:broker -amq:connectionFactory id=amqConnectionFactory brokerURL=vm://localhost?create=false / +amq:connectionFactory id=amqConnectionFactory brokerURL=vm://james?create=false / !-- CachingConnectionFactory Definition, sessionCacheSize property is the number of sessions to cache -- bean id=jmsConnectionFactory class=org.springframework.jms.connection.CachingConnectionFactory - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006132 - in /james/server/trunk/spring-deployment/src/main/config/james: mailstore.xml spring-beans.xml
Author: norman Date: Sat Oct 9 10:47:42 2010 New Revision: 1006132 URL: http://svn.apache.org/viewvc?rev=1006132view=rev Log: Don't start Jackrabbit by default. Just waste of memory in default configuration Modified: james/server/trunk/spring-deployment/src/main/config/james/mailstore.xml james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml Modified: james/server/trunk/spring-deployment/src/main/config/james/mailstore.xml URL: http://svn.apache.org/viewvc/james/server/trunk/spring-deployment/src/main/config/james/mailstore.xml?rev=1006132r1=1006131r2=1006132view=diff == --- james/server/trunk/spring-deployment/src/main/config/james/mailstore.xml (original) +++ james/server/trunk/spring-deployment/src/main/config/james/mailstore.xml Sat Oct 9 10:47:42 2010 @@ -107,7 +107,9 @@ modelCACHE/model /models /repository - + +!-- If you enable this you need to make sure that embedded Jackrabbit instance is started as well. Check the container configuration -- +!-- repository class=org.apache.james.mailrepository.JCRMailRepository protocols protocoljcr/protocol @@ -122,5 +124,6 @@ workspacedefault/workspace /config /repository +-- /repositories /mailstore \ No newline at end of file Modified: james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml URL: http://svn.apache.org/viewvc/james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml?rev=1006132r1=1006131r2=1006132view=diff == --- james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml (original) +++ james/server/trunk/spring-deployment/src/main/config/james/spring-beans.xml Sat Oct 9 10:47:42 2010 @@ -346,6 +346,7 @@ !-- JCR implementation of IMAP Storage-- +!-- Make sure that Jackrabbit is configured as well -- !-- bean id=imapCndLoader class=org.springframework.beans.factory.config.MethodInvokingFactoryBean property name=targetObjectref local=jcrUtils//property @@ -427,15 +428,16 @@ /bean !-- Jackrabbit JCR Repository -- +!-- bean id=jcrRepository class=org.apache.jackrabbit.core.RepositoryImpl destroy-method=shutdown constructor-arg index=0 ref=config / /bean -!-- Jackrabbit config -- bean id=config class=org.apache.jackrabbit.core.config.RepositoryConfig factory-method=create constructor-arg index=0 value=filesystem=file://conf/jcr-repository.xml/ constructor-arg index=1 value=filesystem=file://var/jackrabbit / /bean +-- !-- -- /beans - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: [jira] Updated: (JAMES-948) Composite pattern employed to implement And, Or, Xor and Not matcher.
Hi Ralp, maybe I even get it into the source tree before M1. But I can not promise it atm.. Thx, Norman 2010/10/9 Ralph B Holland ra...@arising.com.au: Norman. Thanks for scheduling these changes. I have been working really hard on our product www.arising.com.au/ir-gis in my spare time outside my normal work hours to the exclusion of the rest of my life. This is the first weekend off since Feb 2010 and I actually went flying, a hobby of mine.. Regards, Ralph Holland Managing Director Arising Technology System Pty Limited BH: 61 2 61271265 AH: 61 2 62312869 Fax: 61 2 62312768 Mob: 0417 312869 (AH/weekends only) ™ Innovative Real-time Geographic Information System www.arising.com.au/ir-gis __ This email message and any accompanying attachments may contain information that is confidential and intended only for the use of the addressee(s) named above. It may also be privileged. If you are not the intended recipient do not read, use, disseminate, distribute or copy or take any action in reliance on it. If you have received this message in error, please notify the sender immediately, and delete this message. It is your responsibility to check attachments for viruses or defects. __ -Original Message- From: Norman Maurer (JIRA) [mailto:server-...@james.apache.org] Sent: Saturday, 9 October 2010 6:56 PM To: ra...@arising.com.au Subject: [jira] Updated: (JAMES-948) Composite pattern employed to implement And, Or, Xor and Not matcher. [ https://issues.apache.org/jira/browse/JAMES-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer updated JAMES-948: Fix Version/s: 3.0 Will be in 3.0 Composite pattern employed to implement And, Or, Xor and Not matcher. - Key: JAMES-948 URL: https://issues.apache.org/jira/browse/JAMES-948 Project: JAMES Server Issue Type: New Feature Components: Matchers/Mailets (bundled) Affects Versions: 2.3.2 Environment: Proposal Reporter: Ralph B Holland Assignee: Norman Maurer Priority: Minor Fix For: 3.0 Attachments: 20100111-rbh-patch-V2.3.txt Original Estimate: 120h Remaining Estimate: 120h Composite matchers can be added to James V2.3.3 via mofication to JamesSpoolManager, Matcher and MatcherLoader interface, and JamesMatcherLoader. Patches supplied. Some time will be needed to migrate the concept to the Unreleased HEAD -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006135 - /james/server/trunk/spring-deployment/src/main/config/james/log4j.properties
Author: norman Date: Sat Oct 9 10:51:20 2010 New Revision: 1006135 URL: http://svn.apache.org/viewvc?rev=1006135view=rev Log: Use WARN as default debug level for activemq Modified: james/server/trunk/spring-deployment/src/main/config/james/log4j.properties Modified: james/server/trunk/spring-deployment/src/main/config/james/log4j.properties URL: http://svn.apache.org/viewvc/james/server/trunk/spring-deployment/src/main/config/james/log4j.properties?rev=1006135r1=1006134r2=1006135view=diff == --- james/server/trunk/spring-deployment/src/main/config/james/log4j.properties (original) +++ james/server/trunk/spring-deployment/src/main/config/james/log4j.properties Sat Oct 9 10:51:20 2010 @@ -137,8 +137,8 @@ log4j.appender.DOMAINLIST.layout.Convers log4j.logger.org.apache.jackrabbit=ERROR, CONS, FILE # logger for activemq -log4j.logger.org.apache.xbean.spring=INFO, CONS, FILE -log4j.logger.org.apache.activemq=INFO, CONS, FILE +log4j.logger.org.apache.xbean.spring=WARN, CONS, FILE +log4j.logger.org.apache.activemq=WARN, CONS, FILE # logger for camel log4j.logger.org.apache.camel=WARN, CONS, FILE - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Created: (JAMES-1061) NPE when connect to smtpserver with ipv6 ipaddress
NPE when connect to smtpserver with ipv6 ipaddress -- Key: JAMES-1061 URL: https://issues.apache.org/jira/browse/JAMES-1061 Project: JAMES Server Issue Type: Bug Affects Versions: 3.0, 3.0-M1, Trunk Reporter: Norman Maurer Priority: Critical Fix For: 3.0-M1 See below: java.lang.NullPointerException at org.apache.james.util.inetnetwork.model.Inet4Network.maskIP(Inet4Network.java:91) at org.apache.james.util.inetnetwork.model.Inet4Network.contains(Inet4Network.java:58) at org.apache.james.util.netmatcher.NetMatcher.matchInetNetwork(NetMatcher.java:105) at org.apache.james.util.netmatcher.NetMatcher.matchInetNetwork(NetMatcher.java:88) at org.apache.james.smtpserver.netty.NioSMTPServer$SMTPHandlerConfigurationDataImpl.isRelayingAllowed(NioSMTPServer.java:241) at org.apache.james.smtpserver.netty.SMTPNettySession.init(SMTPNettySession.java:62) at org.apache.james.smtpserver.netty.SMTPNettySession.init(SMTPNettySession.java:66) at org.apache.james.smtpserver.netty.SMTPChannelUpstreamHandler.createSession(SMTPChannelUpstreamHandler.java:67) at org.apache.james.protocols.impl.AbstractChannelUpstreamHandler.channelBound(AbstractChannelUpstreamHandler.java:56) at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:144) at org.jboss.netty.channel.Channels.fireChannelBound(Channels.java:205) at org.jboss.netty.channel.socket.nio.NioAcceptedSocketChannel.init(NioAcceptedSocketChannel.java:50) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink$Boss.registerAcceptedChannel(NioServerSocketPipelineSink.java:279) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink$Boss.run(NioServerSocketPipelineSink.java:247) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:637) DEBUG 12:12:51,117 | james.smtpserver | Unable to process request java.nio.channels.ClosedChannelException at org.jboss.netty.channel.socket.nio.NioWorker.cleanUpWriteBuffer(NioWorker.java:648) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:604) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.handler.codec.oneone.OneToOneEncoder.handleDownstream(OneToOneEncoder.java:60) at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleDownstream(ChunkedWriteHandler.java:114) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:207) at org.apache.james.smtpserver.netty.SMTPChannelUpstreamHandler.exceptionCaught(SMTPChannelUpstreamHandler.java:90) at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:144) at org.jboss.netty.handler.codec.frame.FrameDecoder.exceptionCaught(FrameDecoder.java:238) at org.jboss.netty.channel.Channels.fireExceptionCaught(Channels.java:432) at org.jboss.netty.channel.AbstractChannelSink.exceptionCaught(AbstractChannelSink.java:52) at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:144) at org.jboss.netty.channel.Channels.fireChannelBound(Channels.java:205) at org.jboss.netty.channel.socket.nio.NioAcceptedSocketChannel.init(NioAcceptedSocketChannel.java:50) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink$Boss.registerAcceptedChannel(NioServerSocketPipelineSink.java:279) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink$Boss.run(NioServerSocketPipelineSink.java:247) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:637) DEBUG 12:12:51,122 | james.smtpserver | Dispose objects while closing channel 1654545953 DEBUG 12:12:51,123 | james.smtpserver | Unable to process request java.lang.NullPointerException at org.apache.james.protocols.smtp.core.WelcomeMessageHandler.onConnect(WelcomeMessageHandler.java:45) at
svn commit: r1006138 - /james/server/trunk/spoolmanager/src/main/java/org/apache/james/transport/JamesSpoolManager.java
Author: norman
Date: Sat Oct 9 11:03:47 2010
New Revision: 1006138
URL: http://svn.apache.org/viewvc?rev=1006138view=rev
Log:
wait on shutdown for threads
Modified:
james/server/trunk/spoolmanager/src/main/java/org/apache/james/transport/JamesSpoolManager.java
Modified:
james/server/trunk/spoolmanager/src/main/java/org/apache/james/transport/JamesSpoolManager.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/spoolmanager/src/main/java/org/apache/james/transport/JamesSpoolManager.java?rev=1006138r1=1006137r2=1006138view=diff
==
---
james/server/trunk/spoolmanager/src/main/java/org/apache/james/transport/JamesSpoolManager.java
(original)
+++
james/server/trunk/spoolmanager/src/main/java/org/apache/james/transport/JamesSpoolManager.java
Sat Oct 9 11:03:47 2010
@@ -219,14 +219,13 @@ public class JamesSpoolManager implement
}
long stop = System.currentTimeMillis() + 6;
-// give the spooler threads one minute to terminate gracefully
-/*
+// give the spooler threads one minute to terminate gracefully
while (numActive.get() != 0 stop System.currentTimeMillis()) {
try {
Thread.sleep(1000);
} catch (Exception ignored) {}
}
-*/
+
logger.info(JamesSpoolManager thread shutdown completed.);
}
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Created: (JAMES-1062) Upgrade to spring 3.0.4-RELEASE
Upgrade to spring 3.0.4-RELEASE --- Key: JAMES-1062 URL: https://issues.apache.org/jira/browse/JAMES-1062 Project: JAMES Server Issue Type: Task Reporter: Norman Maurer Assignee: Norman Maurer Fix For: 3.0-M1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006140 - /james/server/trunk/pom.xml
Author: norman Date: Sat Oct 9 11:34:14 2010 New Revision: 1006140 URL: http://svn.apache.org/viewvc?rev=1006140view=rev Log: Upgrade to spring 3.0.4-RELEASE (JAMES-1062) Modified: james/server/trunk/pom.xml Modified: james/server/trunk/pom.xml URL: http://svn.apache.org/viewvc/james/server/trunk/pom.xml?rev=1006140r1=1006139r2=1006140view=diff == --- james/server/trunk/pom.xml (original) +++ james/server/trunk/pom.xml Sat Oct 9 11:34:14 2010 @@ -1141,7 +1141,7 @@ derby.version10.5.3.0_1/derby.version camel.version2.4.0/camel.version activemq.version5.4.1/activemq.version -spring.version3.0.2.RELEASE/spring.version +spring.version3.0.4.RELEASE/spring.version imap.version0.2-SNAPSHOT/imap.version protocols.version1.2-SNAPSHOT/protocols.version jsieve.version0.4/jsieve.version - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Resolved: (JAMES-1062) Upgrade to spring 3.0.4-RELEASE
[ https://issues.apache.org/jira/browse/JAMES-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved JAMES-1062. -- Resolution: Fixed done Upgrade to spring 3.0.4-RELEASE --- Key: JAMES-1062 URL: https://issues.apache.org/jira/browse/JAMES-1062 Project: JAMES Server Issue Type: Task Reporter: Norman Maurer Assignee: Norman Maurer Fix For: 3.0-M1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006141 - /james/server/trunk/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/camel/JamesCamelConstants.java
Author: norman Date: Sat Oct 9 11:36:35 2010 New Revision: 1006141 URL: http://svn.apache.org/viewvc?rev=1006141view=rev Log: Removed unused class Removed: james/server/trunk/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/camel/JamesCamelConstants.java - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Resolved: (JAMES-1060) Use javamail system properties in startup scripts to let javamail handle bad formated messages more friendly
[ https://issues.apache.org/jira/browse/JAMES-1060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Norman Maurer resolved JAMES-1060. -- Resolution: Fixed Assignee: Norman Maurer Use the following properties for now: -Dmail.mime.multipart.ignoremissingendboundary=true -Dmail.mime.multipart.ignoremissingboundaryparameter=true -Dmail.mime.ignoreunknownencoding=true -Dmail.mime.uudecode.ignoreerrors=true -Dmail.mime.uudecode.ignoremissingbeginend=true -Dmail.mime.multipart.allowempty=true -Dmail.mime.base64.ignoreerrors=true -Dmail.mime.encodeparameters=true -Dmail.mime.decodeparameters=true -Dmail.mime.address.strict=false Use javamail system properties in startup scripts to let javamail handle bad formated messages more friendly Key: JAMES-1060 URL: https://issues.apache.org/jira/browse/JAMES-1060 Project: JAMES Server Issue Type: Improvement Reporter: Norman Maurer Assignee: Norman Maurer Fix For: 3.0-M1 javmail offers a lot of system properties to let it not throw MessagingExceptions on bad formated messages. We should make use of them -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006150 - /james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java
Author: norman
Date: Sat Oct 9 13:06:51 2010
New Revision: 1006150
URL: http://svn.apache.org/viewvc?rev=1006150view=rev
Log:
Workaround for altering message-id (JAMES-1010 and JAMES-875)
Modified:
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java
Modified:
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java?rev=1006150r1=1006149r2=1006150view=diff
==
---
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java
(original)
+++
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java
Sat Oct 9 13:06:51 2010
@@ -155,6 +155,18 @@ public class MimeMessageWrapper
}
/**
+ * Overrides default javamail behaviour by not altering the Message-ID by
+ * default. Ê Ê
+ * Ê Ê
+ * @see JAMES-875 / JAMES-1010
+ * @see javax.mail.internet.MimeMessage#updateMessageID()
+ */
+protected void updateMessageID() throws MessagingException {
+if (getMessageID() == null)
+super.updateMessageID();
+}
+
+/**
* Returns the source ID of the MimeMessageSource that is supplying this
* with data.
* @see MimeMessageSource
@@ -458,8 +470,10 @@ public class MimeMessageWrapper
super.setDataHandler(arg0);
}
-/**
- * @see org.apache.avalon.framework.activity.Disposable#dispose()
+
+/*
+ * (non-Javadoc)
+ * @see org.apache.james.lifecycle.Disposable#dispose()
*/
public void dispose() {
if (sourceIn != null) {
@@ -500,7 +514,7 @@ public class MimeMessageWrapper
* future JavaMail. But if there are other Return-Path header
* values, let's drop our placeholder.
-MailHeaders newHeaders = new MailHeaders(new
ByteArrayInputStream((RFC2822Headers.RETURN_PATH + :
placeholder).getBytes()));
+MailHeaders newHeaders = new MailHeaders(new
ByteArrayInputStream((f.RETURN_PATH + : placeholder).getBytes()));
newHeaders.setHeader(RFC2822Headers.RETURN_PATH, null);
newHeaders.load(is);
String[] returnPathHeaders =
newHeaders.getHeader(RFC2822Headers.RETURN_PATH);
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Commented: (JAMES-1010) MSGID_FROM_MTA_HEADER
[ https://issues.apache.org/jira/browse/JAMES-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12919494#action_12919494 ] Norman Maurer commented on JAMES-1010: -- Could you give us the message headers for the message which hit this ? MSGID_FROM_MTA_HEADER - Key: JAMES-1010 URL: https://issues.apache.org/jira/browse/JAMES-1010 Project: JAMES Server Issue Type: Bug Components: James Core Affects Versions: 2.3.2 Environment: Ubuntu Linux 9.0.3 Reporter: Gavin Chiu Fix For: 3.0-M1 Hi, I thought this was fixed from https://issues.apache.org/jira/browse/JAMES-875, but: I have the latest JAMES 2.3.2 running and I am getting this error in the Barracuda header report from all the email I send from this JAMES mail server: X-Barracuda-Spam-Score: 1.50 X-Barracuda-Spam-Status: No, SCORE=1.50 using global scores of TAG_LEVEL=3.5 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=5.0 tests=DKIM_SIGNED, DKIM_VERIFIED, HTML_MESSAGE, MSGID_FROM_MTA_HEADER, MSGID_FROM_MTA_HEADER_2 X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.2.30982 Rule breakdown below pts rule name description -- -- -0.00 DKIM_VERIFIED Domain Keys Identified Mail: signature passes verification 0.00 DKIM_SIGNED Domain Keys Identified Mail: message has a signature 0.00 HTML_MESSAGE BODY: HTML included in message 0.00 MSGID_FROM_MTA_HEADER Message-Id was added by a relay 1.50 MSGID_FROM_MTA_HEADER_2 Message-Id was added by a relay Have I implement the new version incorrectly? Please advise. Thanks -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006152 - /james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java
Author: norman Date: Sat Oct 9 13:09:48 2010 New Revision: 1006152 URL: http://svn.apache.org/viewvc?rev=1006152view=rev Log: remove invalid chars Modified: james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java Modified: james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java URL: http://svn.apache.org/viewvc/james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java?rev=1006152r1=1006151r2=1006152view=diff == --- james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java (original) +++ james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageWrapper.java Sat Oct 9 13:09:48 2010 @@ -156,8 +156,8 @@ public class MimeMessageWrapper /** * Overrides default javamail behaviour by not altering the Message-ID by - * default. Ê Ê - * Ê Ê + * default + * * @see JAMES-875 / JAMES-1010 * @see javax.mail.internet.MimeMessage#updateMessageID() */ - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006153 - /james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java
Author: norman
Date: Sat Oct 9 13:10:22 2010
New Revision: 1006153
URL: http://svn.apache.org/viewvc?rev=1006153view=rev
Log:
Cleanup
Modified:
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java
Modified:
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java?rev=1006153r1=1006152r2=1006153view=diff
==
---
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java
(original)
+++
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageInputStreamSource.java
Sat Oct 9 13:10:22 2010
@@ -24,6 +24,8 @@ package org.apache.james.core;
import javax.mail.MessagingException;
import javax.mail.util.SharedFileInputStream;
+import org.apache.commons.io.FileUtils;
+import org.apache.commons.io.IOUtils;
import org.apache.james.lifecycle.Disposable;
import java.io.BufferedOutputStream;
@@ -182,27 +184,12 @@ public class MimeMessageInputStreamSourc
public void dispose() {
// explicit close all streams
for (int i = 0; i streams.size(); i++) {
-try {
-streams.get(i).close();
-} catch (IOException e) {
-// ignore on dispose
-}
-}
-if (out != null) {
-try {
-out.close();
-} catch (IOException e) {
-// TODO Auto-generated catch block
-e.printStackTrace();
-}
-}
-try {
-if (file != null file.exists()) {
-file.delete();
-}
-} catch (Exception e) {
-//ignore
+IOUtils.closeQuietly(streams.get(i));
}
+IOUtils.closeQuietly(out);
+out = null;
+
+FileUtils.deleteQuietly(file);
file = null;
}
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006157 - /james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/AbstractAsyncServer.java
Author: norman
Date: Sat Oct 9 13:32:30 2010
New Revision: 1006157
URL: http://svn.apache.org/viewvc?rev=1006157view=rev
Log:
use tcpNoDelay as we use it only as TCP server. Just improve performance a bit..
Modified:
james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/AbstractAsyncServer.java
Modified:
james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/AbstractAsyncServer.java
URL:
http://svn.apache.org/viewvc/james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/AbstractAsyncServer.java?rev=1006157r1=1006156r2=1006157view=diff
==
---
james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/AbstractAsyncServer.java
(original)
+++
james/protocols/trunk/impl/src/main/java/org/apache/james/protocols/impl/AbstractAsyncServer.java
Sat Oct 9 13:32:30 2010
@@ -90,6 +90,7 @@ public abstract class AbstractAsyncServe
// Bind and start to accept incoming connections.
bootstrap.setOption(backlog, backlog);
bootstrap.setOption(reuseAddress, true);
+bootstrap.setOption(child.tcpNoDelay, true);
Channel serverChannel;
if (getIP() == null) {
serverChannel = bootstrap.bind(new InetSocketAddress(port));
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Spring migration
Thanks Eric. I will get started ASAP. Kind Regards... Dhrubo On Sat, Oct 9, 2010 at 10:55 AM, Eric Charles e...@apache.org wrote: Hi, James 3 will be soon release and runs on Spring. You can check it out from http://svn.apache.org/repos/asf/james/server/trunk/. Just compile it with mvn package and use it (dist zip is in spring-deployement/target). There some open JIRA for 3.0-M1 on https://issues.apache.org/jira/secure/BrowseVersion.jspa?id=10411versionId=12314294showOpenIssuesOnly=true, but come back on mailing list to talk about. Tks, Eric On 9/10/2010 06:10, Dhrubo wrote: Hello All, I would like to contribute to the Spring port of JAMES. It will be very good if some one tells me the steps. I do not see any bug tracker for the Spring port yet on JIRA. Kind Regards... Dhrubo - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006189 - /james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageCopyOnWriteProxy.java
Author: norman
Date: Sat Oct 9 16:56:20 2010
New Revision: 1006189
URL: http://svn.apache.org/viewvc?rev=1006189view=rev
Log:
Override missing javamail method
Modified:
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageCopyOnWriteProxy.java
Modified:
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageCopyOnWriteProxy.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageCopyOnWriteProxy.java?rev=1006189r1=1006188r2=1006189view=diff
==
---
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageCopyOnWriteProxy.java
(original)
+++
james/server/trunk/core-library/src/main/java/org/apache/james/core/MimeMessageCopyOnWriteProxy.java
Sat Oct 9 16:56:20 2010
@@ -755,5 +755,14 @@ public class MimeMessageCopyOnWriteProxy
public long getMessageSize() throws MessagingException {
return MimeMessageUtil.getMessageSize(getWrappedMessage());
}
+
+
+/**
+ * Since javamail 1.4
+ */
+@Override
+public void setText(String text, String charset, String subtype) throws
MessagingException {
+getWrappedMessage().setText(text, charset, subtype);
+}
}
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006203 - /james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java
Author: norman
Date: Sat Oct 9 17:56:22 2010
New Revision: 1006203
URL: http://svn.apache.org/viewvc?rev=1006203view=rev
Log:
Use MimeMessageWrapper when create the MailImpl object with the JMS Message.
This helps to decrease the Memory usage of JavaMail (forgot to use it before).
Modified:
james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java
Modified:
james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java
URL:
http://svn.apache.org/viewvc/james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java?rev=1006203r1=1006202r2=1006203view=diff
==
---
james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java
(original)
+++
james/server/trunk/queue-activemq/src/main/java/org/apache/james/queue/activemq/ActiveMQMailQueue.java
Sat Oct 9 17:56:22 2010
@@ -50,6 +50,7 @@ import org.apache.james.core.MailImpl;
import org.apache.james.core.MimeMessageCopyOnWriteProxy;
import org.apache.james.core.MimeMessageInputStream;
import org.apache.james.core.MimeMessageInputStreamSource;
+import org.apache.james.core.MimeMessageWrapper;
import org.apache.james.queue.MailQueue;
import org.apache.mailet.Mail;
import org.apache.mailet.MailAddress;
@@ -312,7 +313,7 @@ public class ActiveMQMailQueue implement
// Ignore on error
logger.debug(Unable to get url from blobmessage for mail
+ mail.getName());
}
-mail.setMessage(new MimeMessageCopyOnWriteProxy(new
MimeMessageInputStreamSource(mail.getName(), blobMessage.getInputStream(;
+mail.setMessage(new MimeMessageWrapper(new
MimeMessageCopyOnWriteProxy(new MimeMessageInputStreamSource(mail.getName(),
blobMessage.getInputStream();
} else {
throw new MailQueueException(Not supported JMS Message
received + message);
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006207 - /james/server/trunk/mailets/src/test/java/org/apache/james/transport/remotedeliverytester/
Author: norman Date: Sat Oct 9 18:28:05 2010 New Revision: 1006207 URL: http://svn.apache.org/viewvc?rev=1006207view=rev Log: Copy remotedelivery test code.. time to enable tests again Added: james/server/trunk/mailets/src/test/java/org/apache/james/transport/remotedeliverytester/ (props changed) - copied from r1006206, james/server/tags/JAMES_TRUNK_PHOENIX/mailets-function/src/test/java/org/apache/james/transport/remotedeliverytester/ Propchange: james/server/trunk/mailets/src/test/java/org/apache/james/transport/remotedeliverytester/ -- --- svn:mergeinfo (added) +++ svn:mergeinfo Sat Oct 9 18:28:05 2010 @@ -0,0 +1 @@ +/james/server/sandbox/active/mina_experiments/mailets-function/src/test/java/org/apache/james/transport/remotedeliverytester:824613-825114 - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1006209 - in /james/server/trunk/mailets/src/test/java/org/apache/james/transport: mailets/RemoteDeliveryTest.java mailets/StandardRemoteDeliveryTestable.java remotedeliverytester/
Author: norman Date: Sat Oct 9 18:35:24 2010 New Revision: 1006209 URL: http://svn.apache.org/viewvc?rev=1006209view=rev Log: Remove remote delivery test stuff again for now.. Need some more time to fix it, so better let it compile for now Removed: james/server/trunk/mailets/src/test/java/org/apache/james/transport/mailets/RemoteDeliveryTest.java james/server/trunk/mailets/src/test/java/org/apache/james/transport/mailets/StandardRemoteDeliveryTestable.java james/server/trunk/mailets/src/test/java/org/apache/james/transport/remotedeliverytester/ - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] Commented: (JAMES-1061) NPE when connect to smtpserver with ipv6 ipaddress
[ https://issues.apache.org/jira/browse/JAMES-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12919571#action_12919571 ] Eric Charles commented on JAMES-1061: - the cause may be a null ip address or a null netmask. This may come from a code bug, or from missing guard. To further analyze, it would be good I can repoduce it. I suppose it occurs when you send an email to a specific domain for which the dns is only ipv6. Could you post a scenario to reproduce it ? Tks, NPE when connect to smtpserver with ipv6 ipaddress -- Key: JAMES-1061 URL: https://issues.apache.org/jira/browse/JAMES-1061 Project: JAMES Server Issue Type: Bug Affects Versions: 3.0, 3.0-M1, Trunk Reporter: Norman Maurer Priority: Critical Fix For: 3.0-M1 See below: java.lang.NullPointerException at org.apache.james.util.inetnetwork.model.Inet4Network.maskIP(Inet4Network.java:91) at org.apache.james.util.inetnetwork.model.Inet4Network.contains(Inet4Network.java:58) at org.apache.james.util.netmatcher.NetMatcher.matchInetNetwork(NetMatcher.java:105) at org.apache.james.util.netmatcher.NetMatcher.matchInetNetwork(NetMatcher.java:88) at org.apache.james.smtpserver.netty.NioSMTPServer$SMTPHandlerConfigurationDataImpl.isRelayingAllowed(NioSMTPServer.java:241) at org.apache.james.smtpserver.netty.SMTPNettySession.init(SMTPNettySession.java:62) at org.apache.james.smtpserver.netty.SMTPNettySession.init(SMTPNettySession.java:66) at org.apache.james.smtpserver.netty.SMTPChannelUpstreamHandler.createSession(SMTPChannelUpstreamHandler.java:67) at org.apache.james.protocols.impl.AbstractChannelUpstreamHandler.channelBound(AbstractChannelUpstreamHandler.java:56) at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:144) at org.jboss.netty.channel.Channels.fireChannelBound(Channels.java:205) at org.jboss.netty.channel.socket.nio.NioAcceptedSocketChannel.init(NioAcceptedSocketChannel.java:50) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink$Boss.registerAcceptedChannel(NioServerSocketPipelineSink.java:279) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink$Boss.run(NioServerSocketPipelineSink.java:247) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:637) DEBUG 12:12:51,117 | james.smtpserver | Unable to process request java.nio.channels.ClosedChannelException at org.jboss.netty.channel.socket.nio.NioWorker.cleanUpWriteBuffer(NioWorker.java:648) at org.jboss.netty.channel.socket.nio.NioWorker.close(NioWorker.java:604) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.handleAcceptedSocket(NioServerSocketPipelineSink.java:119) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink.eventSunk(NioServerSocketPipelineSink.java:76) at org.jboss.netty.handler.codec.oneone.OneToOneEncoder.handleDownstream(OneToOneEncoder.java:60) at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleDownstream(ChunkedWriteHandler.java:114) at org.jboss.netty.channel.Channels.close(Channels.java:720) at org.jboss.netty.channel.AbstractChannel.close(AbstractChannel.java:207) at org.apache.james.smtpserver.netty.SMTPChannelUpstreamHandler.exceptionCaught(SMTPChannelUpstreamHandler.java:90) at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:144) at org.jboss.netty.handler.codec.frame.FrameDecoder.exceptionCaught(FrameDecoder.java:238) at org.jboss.netty.channel.Channels.fireExceptionCaught(Channels.java:432) at org.jboss.netty.channel.AbstractChannelSink.exceptionCaught(AbstractChannelSink.java:52) at org.jboss.netty.handler.stream.ChunkedWriteHandler.handleUpstream(ChunkedWriteHandler.java:144) at org.jboss.netty.channel.Channels.fireChannelBound(Channels.java:205) at org.jboss.netty.channel.socket.nio.NioAcceptedSocketChannel.init(NioAcceptedSocketChannel.java:50) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink$Boss.registerAcceptedChannel(NioServerSocketPipelineSink.java:279) at org.jboss.netty.channel.socket.nio.NioServerSocketPipelineSink$Boss.run(NioServerSocketPipelineSink.java:247) at org.jboss.netty.util.internal.IoWorkerRunnable.run(IoWorkerRunnable.java:46) at
