Fwd: [ANNOUNCE] Apache Jackrabbit 2.3.0 released
so they are now on lucene 3.0 too. So we should upgrade... bye norman -- Weitergeleitete Nachricht -- Von: Jukka Zitting Datum: Montag, 3. Oktober 2011 Betreff: [ANNOUNCE] Apache Jackrabbit 2.3.0 released An: annou...@apache.org, annou...@jackrabbit.apache.org, Jackrabbit Users < us...@jackrabbit.apache.org>, Jackrabbit Developers < d...@jackrabbit.apache.org> The Apache Jackrabbit community is pleased to announce the release of Apache Jackrabbit 2.3.0. The release is available for download at: http://jackrabbit.apache.org/downloads.html See the full release notes below for details about this release. Release Notes -- Apache Jackrabbit -- Version 2.3.0 Introduction This is Apache Jackrabbit(TM) 2.3, a fully compliant implementation of the Content Repository for Java(TM) Technology API, version 2.0 (JCR 2.0) as specified in the Java Specification Request 283 (JSR 283). Apache Jackrabbit 2.3 is an unstable series of releases cut directly from Jackrabbit trunk, with a focus on new features and other improvements. For production use we recommend the latest stable 2.2 release. Changes in Jackrabbit 2.3.0 --- New features [JCR-952] Support lower and upper case functions in "order by" clause [JCR-2454] spi2dav: JSR 283 NodeType Management [JCR-2697] Add support for encrpted db password in repository.xml [JCR-2851] Authentication Mechanism Based on Login Token [JCR-2879] SQL Azure support: clustered indexes [JCR-2911] Fine-grained access control for managing node types [JCR-2961] Improve logging of Session.save() to trace back root cause ... [JCR-3037] Add getPath method to Authorizable interface [JCR-3042] jcr-commons: add cnd writer functionality [JCR-3056] jcr-commons: Add utility to translate a string to a ... [JCR-3058] BundleDumper to analyze broken bundles [JCR-3078] Add CopyMoveHanlder so that the copy/move behavior can ... [JCR-3080] Add User#changePassword(String newPw, String oldPw) [JCR-3081] Add UserManager#getAuthorizableByPath(String) for symmetry ... Improvements [JCR-1483] Move common node type functionality to jackrabbit-spi-commons [JCR-1874] Move generic locking tests from jcr2spi to jackrabbit-jcr-tests [JCR-2415] Update Lucene to 3.0 [JCR-2834] Make DefaultSecurityManager the default security manager ... [JCR-2835] Poor performance of ISDESCENDANTNODE on SQL 2 queries [JCR-2848] UserManagerImpl: typo in "compatibleJR16" config option constant [JCR-2854] Add option to make sorting in user/group query case insensitive [JCR-2856] Upgrade to latest SLF4J and Logback [JCR-2864] Use out-of-process text extraction [JCR-2873] Add a way to locate full text extraction problems [JCR-2875] Exclude the netcdf dependency [JCR-2876] org.apache.jackrabbit.server.io.IOUtil getTempFile misses ... [JCR-2877] Extend the consistency check in BundleDbPersistenceManager's ... [JCR-2885] Move tika-parsers dependency to deployment packages [JCR-2886] Add SessionImpl#isAdminOrSystem [JCR-2896] WebdavResponseImpl should cache TransformerFactory [JCR-2897] Remove jcr-commons dependency from jackrabbit-webdav [JCR-2898] [patch] remove bogus test [JCR-2916] Avoid String.intern() when indexing [JCR-2918] Avoid unnecessary index reader calls when using aggregate ... [JCR-2923] SQL2 parser: improved error message for ambiguous properties ... [JCR-2925] Various inner classes maintain references to owning class ... [JCR-2926] DefaultProtectedPropertyImporter masks several fields from ... [JCR-2929] Various places do map lookups in loop instead of using ... [JCR-2934] SQL2 queries are not logged [JCR-2942] Move privilege reader/writer to spi-commons and use ... [JCR-2943] UserManagement: membership cache default size too small [JCR-2944] Remove unnecessary NodeImpl references from LuceneQueryFactory [JCR-2946] Jcr-Server: Improve implementation of DavResource#... [JCR-2948] jcr-server: add possibility to PROPFIND the ... [JCR-2955] Use GrowingLRUMap in CachingEntryCollector [JCR-2957] Improve password hashing [JCR-2971] Revert subsequent token-node updates (tentatively introduced) [JCR-2972] Allow name to be set in PropertyInfoBuilder and NodeInfoBuilder [JCR-2975] Make ItemInfoBuilder name space aware [JCR-2976] Allow parent path to be set explicitly in NodeInfoBuilder [JCR-2977] AccessControlManager#getApplicablePolicy should check for ... [JCR-2978] Add accessor for parent to NodeInfoBuilder/PropertyInfoBuilder [JCR-2979] Deprecate RepositoryService.getNodeInfo method [JCR-2987] New JcrUtils utility methods [JCR-2993] Add method to set uuid in NodeInfoBuilder [JCR-2994] Add method to remove mappings from NamespaceMapping [JCR-2995] jcr2spi: create ChangePolling thread on demand [JCR-3002] Add read acessor for user data to SessionInfoImpl [JCR-3004] Check if a DAV-Request has a Label in the header, before ... [JCR-3011] Fix incorrect IndexingQueueTest logic [JCR-3019] RepositoryImpl.activeSessio
[jira] [Updated] (JAMES-1317) Mail spooled but not processed
[ https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Herrmann updated JAMES-1317: Attachment: Dump.txt Attachment "Dump.txt" contains a Threaddump (taken with CTRL+BREAK) when the server hangs (i.e. spools mails but does not process them). > Mail spooled but not processed > -- > > Key: JAMES-1317 > URL: https://issues.apache.org/jira/browse/JAMES-1317 > Project: JAMES Server > Issue Type: Bug > Components: SpoolManager & Processors >Affects Versions: 3.0-M1, 3.0-M2, 3.0-beta3 >Reporter: Raju Buchi >Priority: Critical > Fix For: 3.0-beta4 > > Attachments: Dump.txt, jstack.zip > > > Mails sent to James server are spooled but they are not processed and sent > out. > The issue is similar to the one faced by Zach. > The server seems to be working fine for a few hours or few days, but some > time all the mails are spooled but they will not be processed and sent out. > Restarted the server several times and some time a few of the mails will be > processed and all the others are lost. > As Norman suggested I have took a jstack trace. > Please let me how we can resolve this issue > Thanks > - Raju -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1317) Mail spooled but not processed
[
https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119271#comment-13119271
]
Michael Herrmann commented on JAMES-1317:
-
The problem also occurs in the latest snapshot release of 3.0-beta4, revision
1177179.
Maybe a little code will help. I have one non-standard mailet, AliasingMailet,
in mailetcontainer.xml:
...
X-UserIsAuth
true
...
Here is its service() method:
public void service(Mail mail) throws MessagingException {
MailAddress from = new MailAddress((InternetAddress)
mail.getMessage().getFrom()[0]);
MailAddress to = new MailAddress((InternetAddress)
mail.getMessage().getRecipients(Message.RecipientType.TO)[0]);
if (to.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
Conversation conversation =
conversationService.getConversation(mail);
InternetAddress[] recipients =
conversation.getAliasB().getRecipients();
logger.info("Rewriting recipients of mail " +
mail.getMessage().getSubject() + " to " + Arrays.asList(recipients));
mail.getMessage().setRecipients(Message.RecipientType.TO,
recipients);
String newFrom = conversation.getAliasA() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
getMailetContext().sendMail(mail.getMessage());
mail.setState(Mail.GHOST);
} else if
(!from.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
String newFrom =
conversationService.getConversation(mail).getAliasA().toString() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
}
}
The Spring bean conversationService is autowired and uses James's
JPA-infrastructure to persist/load Conversations. The problem occurs
(stochastically) when I bombard the server with 50 concurrent SMTP-requests.
We want to use James to handle email conversations of all users of our portal
for classified ads and expect about 1.500.000 mails/month. If this problem
cannot be solved we will have to downgrade to version 2.3.2 :(
> Mail spooled but not processed
> --
>
> Key: JAMES-1317
> URL: https://issues.apache.org/jira/browse/JAMES-1317
> Project: JAMES Server
> Issue Type: Bug
> Components: SpoolManager & Processors
>Affects Versions: 3.0-M1, 3.0-M2, 3.0-beta3
>Reporter: Raju Buchi
>Priority: Critical
> Fix For: 3.0-beta4
>
> Attachments: Dump.txt, jstack.zip
>
>
> Mails sent to James server are spooled but they are not processed and sent
> out.
> The issue is similar to the one faced by Zach.
> The server seems to be working fine for a few hours or few days, but some
> time all the mails are spooled but they will not be processed and sent out.
> Restarted the server several times and some time a few of the mails will be
> processed and all the others are lost.
> As Norman suggested I have took a jstack trace.
> Please let me how we can resolve this issue
> Thanks
> - Raju
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Issue Comment Edited] (JAMES-1317) Mail spooled but not processed
[
https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119271#comment-13119271
]
Michael Herrmann edited comment on JAMES-1317 at 10/3/11 12:53 PM:
---
The problem also occurs in the latest snapshot release of 3.0-beta4, revision
1177179.
Maybe a little code will help. I have one non-standard mailet, AliasingMailet,
in mailetcontainer.xml:
...
X-UserIsAuth
true
...
Here is its service() method:
public void service(Mail mail) throws MessagingException {
MailAddress from = new MailAddress((InternetAddress)
mail.getMessage().getFrom()[0]);
MailAddress to = new MailAddress((InternetAddress)
mail.getMessage().getRecipients(Message.RecipientType.TO)[0]);
if (to.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
Conversation conversation =
conversationService.getConversation(mail);
InternetAddress[] recipients =
conversation.getAliasB().getRecipients();
logger.info("Rewriting recipients of mail " +
mail.getMessage().getSubject() + " to " + Arrays.asList(recipients));
mail.getMessage().setRecipients(Message.RecipientType.TO,
recipients);
String newFrom = conversation.getAliasA() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
getMailetContext().sendMail(mail.getMessage());
mail.setState(Mail.GHOST);
} else if
(!from.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
String newFrom =
conversationService.getConversation(mail).getAliasA().toString() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
}
}
The Spring bean conversationService is autowired and uses James's
JPA-infrastructure to persist/load Conversations. The problem occurs
(stochastically) when I bombard the server with 50 concurrent SMTP-requests.
We want to use James to handle email conversations of all users of our portal
for classified ads and expect about 1.500.000 mails/month. If this problem
cannot be solved we will have to downgrade to version 2.3.2...
If it helps, I can provide you with the (little) source code and JUnit tests
that can be used to reproduce the problem. Having an automated build is very
important to us so we wrote a little Maven plugin that can be used to start
James. I could send you the code for the plugin as well as our project. All you
would then have to do is to do mvn install for the Maven plugin and then mvn
verify for our project, which then uses the installed plugin to start the
server and run the failing integration tests.
was (Author: mherrmann):
The problem also occurs in the latest snapshot release of 3.0-beta4,
revision 1177179.
Maybe a little code will help. I have one non-standard mailet, AliasingMailet,
in mailetcontainer.xml:
...
X-UserIsAuth
true
...
Here is its service() method:
public void service(Mail mail) throws MessagingException {
MailAddress from = new MailAddress((InternetAddress)
mail.getMessage().getFrom()[0]);
MailAddress to = new MailAddress((InternetAddress)
mail.getMessage().getRecipients(Message.RecipientType.TO)[0]);
if (to.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
Conversation conversation =
conversationService.getConversation(mail);
InternetAddress[] recipients =
conversation.getAliasB().getRecipients();
logger.info("Rewriting recipients of mail " +
mail.getMessage().getSubject() + " to " + Arrays.asList(recipients));
mail.getMessage().setRecipients(Message.RecipientType.TO,
recipients);
String newFrom = conversation.getAliasA() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
getMailetContext().sendMail(mail.getMessage());
mail.setState(Mail.GHOST);
} else if
(!from.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
String newFrom =
conversationService.getConversation(mail).getAliasA().toString() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.i
[jira] [Issue Comment Edited] (JAMES-1317) Mail spooled but not processed
[
https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119271#comment-13119271
]
Michael Herrmann edited comment on JAMES-1317 at 10/3/11 12:54 PM:
---
The problem also occurs in the latest snapshot release of 3.0-beta4, revision
1177179.
Maybe a little code will help. I have one non-standard mailet, AliasingMailet,
in mailetcontainer.xml:
...
X-UserIsAuth
true
...
Here is its service() method:
public void service(Mail mail) throws MessagingException {
MailAddress from = new MailAddress((InternetAddress)
mail.getMessage().getFrom()[0]);
MailAddress to = new MailAddress((InternetAddress)
mail.getMessage().getRecipients(Message.RecipientType.TO)[0]);
if (to.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
Conversation conversation = conversationService.getConversation(mail);
InternetAddress[] recipients = conversation.getAliasB().getRecipients();
logger.info("Rewriting recipients of mail " +
mail.getMessage().getSubject() + " to " + Arrays.asList(recipients));
mail.getMessage().setRecipients(Message.RecipientType.TO, recipients);
String newFrom = conversation.getAliasA() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
getMailetContext().sendMail(mail.getMessage());
mail.setState(Mail.GHOST);
} else if
(!from.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
String newFrom =
conversationService.getConversation(mail).getAliasA().toString() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
}
}
The Spring bean conversationService is autowired and uses James's
JPA-infrastructure to persist/load Conversations. The problem occurs
(stochastically) when I bombard the server with 50 concurrent SMTP-requests.
We want to use James to handle email conversations of all users of our portal
for classified ads and expect about 1.500.000 mails/month. If this problem
cannot be solved we will have to downgrade to version 2.3.2...
If it helps, I can provide you with the (little) source code and JUnit tests
that can be used to reproduce the problem. Having an automated build is very
important to us so we wrote a little Maven plugin that can be used to start
James. I could send you the code for the plugin as well as our project. All you
would then have to do is to do mvn install for the Maven plugin and then mvn
verify for our project, which then uses the installed plugin to start the
server and run the failing integration tests.
was (Author: mherrmann):
The problem also occurs in the latest snapshot release of 3.0-beta4,
revision 1177179.
Maybe a little code will help. I have one non-standard mailet, AliasingMailet,
in mailetcontainer.xml:
...
X-UserIsAuth
true
...
Here is its service() method:
public void service(Mail mail) throws MessagingException {
MailAddress from = new MailAddress((InternetAddress)
mail.getMessage().getFrom()[0]);
MailAddress to = new MailAddress((InternetAddress)
mail.getMessage().getRecipients(Message.RecipientType.TO)[0]);
if (to.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
Conversation conversation =
conversationService.getConversation(mail);
InternetAddress[] recipients =
conversation.getAliasB().getRecipients();
logger.info("Rewriting recipients of mail " +
mail.getMessage().getSubject() + " to " + Arrays.asList(recipients));
mail.getMessage().setRecipients(Message.RecipientType.TO,
recipients);
String newFrom = conversation.getAliasA() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
getMailetContext().sendMail(mail.getMessage());
mail.setState(Mail.GHOST);
} else if
(!from.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
String newFrom =
conversationService.getConversation(mail).getAliasA().toString() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
[jira] [Issue Comment Edited] (JAMES-1317) Mail spooled but not processed
[
https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119271#comment-13119271
]
Michael Herrmann edited comment on JAMES-1317 at 10/3/11 12:55 PM:
---
The problem also occurs in the latest snapshot release of 3.0-beta4, revision
1177179.
Maybe a little code will help. I have one non-standard mailet, AliasingMailet,
in mailetcontainer.xml:
...
X-UserIsAuth
true
...
Here is its service() method:
public void service(Mail mail) throws MessagingException {
MailAddress from = new MailAddress((InternetAddress)
mail.getMessage().getFrom()[0]);
MailAddress to = new MailAddress((InternetAddress)
mail.getMessage().getRecipients(Message.RecipientType.TO)[0]);
if (to.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
Conversation conversation = conversationService.getConversation(mail);
InternetAddress[] recipients = conversation.getAliasB().getRecipients();
logger.info("Rewriting recipients of mail " +
mail.getMessage().getSubject() + " to " + Arrays.asList(recipients));
mail.getMessage().setRecipients(Message.RecipientType.TO, recipients);
String newFrom = conversation.getAliasA() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
getMailetContext().sendMail(mail.getMessage());
mail.setState(Mail.GHOST);
} else if
(!from.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
String newFrom =
conversationService.getConversation(mail).getAliasA().toString() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
}
}
The Spring bean conversationService is autowired and uses James's
JPA-infrastructure to persist/load instances of Conversation, a simple DTO
class. The problem occurs (stochastically) when I bombard the server with 50
concurrent SMTP-requests.
We want to use James to handle email conversations of all users of our portal
for classified ads and expect about 1.500.000 mails/month. If this problem
cannot be solved we will have to downgrade to version 2.3.2...
If it helps, I can provide you with the (little) source code and JUnit tests
that can be used to reproduce the problem. Having an automated build is very
important to us so we wrote a little Maven plugin that can be used to start
James. I could send you the code for the plugin as well as our project. All you
would then have to do is to do mvn install for the Maven plugin and then mvn
verify for our project, which then uses the installed plugin to start the
server and run the failing integration tests.
was (Author: mherrmann):
The problem also occurs in the latest snapshot release of 3.0-beta4,
revision 1177179.
Maybe a little code will help. I have one non-standard mailet, AliasingMailet,
in mailetcontainer.xml:
...
X-UserIsAuth
true
...
Here is its service() method:
public void service(Mail mail) throws MessagingException {
MailAddress from = new MailAddress((InternetAddress)
mail.getMessage().getFrom()[0]);
MailAddress to = new MailAddress((InternetAddress)
mail.getMessage().getRecipients(Message.RecipientType.TO)[0]);
if (to.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
Conversation conversation = conversationService.getConversation(mail);
InternetAddress[] recipients = conversation.getAliasB().getRecipients();
logger.info("Rewriting recipients of mail " +
mail.getMessage().getSubject() + " to " + Arrays.asList(recipients));
mail.getMessage().setRecipients(Message.RecipientType.TO, recipients);
String newFrom = conversation.getAliasA() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
getMailetContext().sendMail(mail.getMessage());
mail.setState(Mail.GHOST);
} else if
(!from.getDomain().equals(mailserverConfiguration.getDefaultDomain())) {
String newFrom =
conversationService.getConversation(mail).getAliasA().toString() + "@" +
mailserverConfiguration.getDefaultDomain();
logger.info("Rewriting sender of mail " +
mail.getMessage().getSubject() + " from " + from + " to " + newFrom + ".");
mail.getMessage().setFrom(new InternetAddress(newFrom));
}
}
The Spri
[jira] [Updated] (JAMES-1317) Mail spooled but not processed
[ https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Herrmann updated JAMES-1317: Attachment: logs.zip The James logs of a run where it eventually hangs (a different but similar run from the one for which Dump.txt gives a thread dump) are in attachment logs.zip. The last line in james-server.log indicates where James hung. > Mail spooled but not processed > -- > > Key: JAMES-1317 > URL: https://issues.apache.org/jira/browse/JAMES-1317 > Project: JAMES Server > Issue Type: Bug > Components: SpoolManager & Processors >Affects Versions: 3.0-M1, 3.0-M2, 3.0-beta3 >Reporter: Raju Buchi >Priority: Critical > Fix For: 3.0-beta4 > > Attachments: Dump.txt, jstack.zip, logs.zip > > > Mails sent to James server are spooled but they are not processed and sent > out. > The issue is similar to the one faced by Zach. > The server seems to be working fine for a few hours or few days, but some > time all the mails are spooled but they will not be processed and sent out. > Restarted the server several times and some time a few of the mails will be > processed and all the others are lost. > As Norman suggested I have took a jstack trace. > Please let me how we can resolve this issue > Thanks > - Raju -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1317) Mail spooled but not processed
[ https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119389#comment-13119389 ] Norman Maurer commented on JAMES-1317: -- I will review the thread-dump and logs later today and come back to you > Mail spooled but not processed > -- > > Key: JAMES-1317 > URL: https://issues.apache.org/jira/browse/JAMES-1317 > Project: JAMES Server > Issue Type: Bug > Components: SpoolManager & Processors >Affects Versions: 3.0-M1, 3.0-M2, 3.0-beta3 >Reporter: Raju Buchi >Priority: Critical > Fix For: 3.0-beta4 > > Attachments: Dump.txt, jstack.zip, logs.zip > > > Mails sent to James server are spooled but they are not processed and sent > out. > The issue is similar to the one faced by Zach. > The server seems to be working fine for a few hours or few days, but some > time all the mails are spooled but they will not be processed and sent out. > Restarted the server several times and some time a few of the mails will be > processed and all the others are lost. > As Norman suggested I have took a jstack trace. > Please let me how we can resolve this issue > Thanks > - Raju -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1317) Mail spooled but not processed
[ https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119442#comment-13119442 ] Norman Maurer commented on JAMES-1317: -- Hi Michael, what OS you are running JAMES on ? > Mail spooled but not processed > -- > > Key: JAMES-1317 > URL: https://issues.apache.org/jira/browse/JAMES-1317 > Project: JAMES Server > Issue Type: Bug > Components: SpoolManager & Processors >Affects Versions: 3.0-M1, 3.0-M2, 3.0-beta3 >Reporter: Raju Buchi >Priority: Critical > Fix For: 3.0-beta4 > > Attachments: Dump.txt, jstack.zip, logs.zip > > > Mails sent to James server are spooled but they are not processed and sent > out. > The issue is similar to the one faced by Zach. > The server seems to be working fine for a few hours or few days, but some > time all the mails are spooled but they will not be processed and sent out. > Restarted the server several times and some time a few of the mails will be > processed and all the others are lost. > As Norman suggested I have took a jstack trace. > Please let me how we can resolve this issue > Thanks > - Raju -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JAMES-1324) POP3ServerTest.testKnownUserInboxWithMessages() fails
POP3ServerTest.testKnownUserInboxWithMessages() fails -- Key: JAMES-1324 URL: https://issues.apache.org/jira/browse/JAMES-1324 Project: JAMES Server Issue Type: Test Components: James Core Affects Versions: 2.3.2 Reporter: Siegfried Goeschl Fix For: 2.3.3 POP3ServerTest.setupTestMails() creates two emails * a proper one with 92 bytes length * the second one is empty The testKnownUserInboxWithMessages() deletes the first messages and checks for the size of the second message to ensure it has 92 bytes BUT we get the empty message. To make things worse * this test fails for the tagged release * I think this only went unnoticed because the Ant build was used which does not run the unit tests per default * the Ant test can't be run because there is no in "./tools/lib" * the (outdated) M2 reports the problem as expected I attach a patch which fixes the broken test and please add junit to the Ant test class path -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Updated] (JAMES-1324) POP3ServerTest.testKnownUserInboxWithMessages() fails
[ https://issues.apache.org/jira/browse/JAMES-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siegfried Goeschl updated JAMES-1324: - Attachment: POP3ServerTest.patch > POP3ServerTest.testKnownUserInboxWithMessages() fails > -- > > Key: JAMES-1324 > URL: https://issues.apache.org/jira/browse/JAMES-1324 > Project: JAMES Server > Issue Type: Test > Components: James Core >Affects Versions: 2.3.2 >Reporter: Siegfried Goeschl > Fix For: 2.3.3 > > Attachments: POP3ServerTest.patch > > > POP3ServerTest.setupTestMails() creates two emails > * a proper one with 92 bytes length > * the second one is empty > The testKnownUserInboxWithMessages() deletes the first messages and checks > for the size of the second message to ensure it has 92 bytes BUT we get the > empty message. > To make things worse > * this test fails for the tagged release > * I think this only went unnoticed because the Ant build was used which does > not run the unit tests per default > * the Ant test can't be run because there is no in "./tools/lib" > * the (outdated) M2 reports the problem as expected > I attach a patch which fixes the broken test and please add junit to the Ant > test class path -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Updated] (JAMES-1324) POP3ServerTest.testKnownUserInboxWithMessages() fails
[ https://issues.apache.org/jira/browse/JAMES-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siegfried Goeschl updated JAMES-1324: - Description: POP3ServerTest.setupTestMails() creates two emails * a proper one with 92 bytes length * the second one is empty The testKnownUserInboxWithMessages() deletes the first messages and checks for the size of the second message to ensure it has 92 bytes BUT we get the empty message. To make things worse * this test fails for the tagged release * I think this only went unnoticed because the Ant build was used which does not run the unit tests per default * the Ant test can't be run because there is no JUnit library in "./tools/lib" * the (outdated) M2 reports the problem as expected I attach a patch which fixes the broken test and please add junit to the Ant test class path was: POP3ServerTest.setupTestMails() creates two emails * a proper one with 92 bytes length * the second one is empty The testKnownUserInboxWithMessages() deletes the first messages and checks for the size of the second message to ensure it has 92 bytes BUT we get the empty message. To make things worse * this test fails for the tagged release * I think this only went unnoticed because the Ant build was used which does not run the unit tests per default * the Ant test can't be run because there is no in "./tools/lib" * the (outdated) M2 reports the problem as expected I attach a patch which fixes the broken test and please add junit to the Ant test class path > POP3ServerTest.testKnownUserInboxWithMessages() fails > -- > > Key: JAMES-1324 > URL: https://issues.apache.org/jira/browse/JAMES-1324 > Project: JAMES Server > Issue Type: Test > Components: James Core >Affects Versions: 2.3.2 >Reporter: Siegfried Goeschl > Fix For: 2.3.3 > > Attachments: POP3ServerTest.patch > > > POP3ServerTest.setupTestMails() creates two emails > * a proper one with 92 bytes length > * the second one is empty > The testKnownUserInboxWithMessages() deletes the first messages and checks > for the size of the second message to ensure it has 92 bytes BUT we get the > empty message. > To make things worse > * this test fails for the tagged release > * I think this only went unnoticed because the Ant build was used which does > not run the unit tests per default > * the Ant test can't be run because there is no JUnit library in "./tools/lib" > * the (outdated) M2 reports the problem as expected > I attach a patch which fixes the broken test and please add junit to the Ant > test class path -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Created] (JAMES-1325) Maven POM is out-of-sync with Ant buiid
Maven POM is out-of-sync with Ant buiid --- Key: JAMES-1325 URL: https://issues.apache.org/jira/browse/JAMES-1325 Project: JAMES Server Issue Type: Improvement Components: Build System Affects Versions: 2.3.2 Reporter: Siegfried Goeschl Fix For: 2.3.3 Attachments: POM_outdated.patch The M2 build is out-of-sync with the Ant build - it pulls in many more libraries and also some outdated dependencies compared to the Ant build. And having an up2date pom.xml helps since the 2.3.2 build is not hosted on Maven Central -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Updated] (JAMES-1325) Maven POM is out-of-sync with Ant buiid
[ https://issues.apache.org/jira/browse/JAMES-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siegfried Goeschl updated JAMES-1325: - Attachment: POM_outdated.patch > Maven POM is out-of-sync with Ant buiid > --- > > Key: JAMES-1325 > URL: https://issues.apache.org/jira/browse/JAMES-1325 > Project: JAMES Server > Issue Type: Improvement > Components: Build System >Affects Versions: 2.3.2 >Reporter: Siegfried Goeschl > Fix For: 2.3.3 > > Attachments: POM_outdated.patch > > > The M2 build is out-of-sync with the Ant build - it pulls in many more > libraries and also some outdated dependencies compared to the Ant build. And > having an up2date pom.xml helps since the 2.3.2 build is not hosted on Maven > Central -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1317) Mail spooled but not processed
[ https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119476#comment-13119476 ] Norman Maurer commented on JAMES-1317: -- @Michael, BTW, you need to call MimeMessage.saveChanges() after you mess with the headers (like change Mail From: and RCPT TO). This has nothing todo with the problem but I just wanted to let you know.. > Mail spooled but not processed > -- > > Key: JAMES-1317 > URL: https://issues.apache.org/jira/browse/JAMES-1317 > Project: JAMES Server > Issue Type: Bug > Components: SpoolManager & Processors >Affects Versions: 3.0-M1, 3.0-M2, 3.0-beta3 >Reporter: Raju Buchi >Priority: Critical > Fix For: 3.0-beta4 > > Attachments: Dump.txt, jstack.zip, logs.zip > > > Mails sent to James server are spooled but they are not processed and sent > out. > The issue is similar to the one faced by Zach. > The server seems to be working fine for a few hours or few days, but some > time all the mails are spooled but they will not be processed and sent out. > Restarted the server several times and some time a few of the mails will be > processed and all the others are lost. > As Norman suggested I have took a jstack trace. > Please let me how we can resolve this issue > Thanks > - Raju -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (JAMES-1317) Mail spooled but not processed
[ https://issues.apache.org/jira/browse/JAMES-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119493#comment-13119493 ] Norman Maurer commented on JAMES-1317: -- A.. sorry I think I may be wrong on the "has nothing todo with the problem". I think if you not call "mail.getMessage().saveChanges();" It will get hit by the Mailet again and again and so may end up in a infinity loop. Can you try to add the "saveChanges();" and see if it makes any difference ? > Mail spooled but not processed > -- > > Key: JAMES-1317 > URL: https://issues.apache.org/jira/browse/JAMES-1317 > Project: JAMES Server > Issue Type: Bug > Components: SpoolManager & Processors >Affects Versions: 3.0-M1, 3.0-M2, 3.0-beta3 >Reporter: Raju Buchi >Priority: Critical > Fix For: 3.0-beta4 > > Attachments: Dump.txt, jstack.zip, logs.zip > > > Mails sent to James server are spooled but they are not processed and sent > out. > The issue is similar to the one faced by Zach. > The server seems to be working fine for a few hours or few days, but some > time all the mails are spooled but they will not be processed and sent out. > Restarted the server several times and some time a few of the mails will be > processed and all the others are lost. > As Norman suggested I have took a jstack trace. > Please let me how we can resolve this issue > Thanks > - Raju -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1178555 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
Author: norman
Date: Mon Oct 3 20:28:13 2011
New Revision: 1178555
URL: http://svn.apache.org/viewvc?rev=1178555&view=rev
Log:
isClosed method needs to be synchronized
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java?rev=1178555&r1=1178554&r2=1178555&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
Mon Oct 3 20:28:13 2011
@@ -103,7 +103,7 @@ public abstract class AbstractDelegating
/**
* Check if closed
*/
-public boolean isClosed() {
+public synchronized boolean isClosed() {
return isClosed;
}
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1178558 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
Author: norman
Date: Mon Oct 3 20:30:22 2011
New Revision: 1178558
URL: http://svn.apache.org/viewvc?rev=1178558&view=rev
Log:
We don't need close and isClosed method anymore
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java?rev=1178558&r1=1178557&r2=1178558&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/AbstractDelegatingMailboxListener.java
Mon Oct 3 20:30:22 2011
@@ -29,11 +29,8 @@ import org.apache.james.mailbox.MailboxP
import org.apache.james.mailbox.MailboxSession;
public abstract class AbstractDelegatingMailboxListener implements
MailboxListener, MailboxListenerSupport{
-
-private boolean isClosed;
protected AbstractDelegatingMailboxListener() {
- isClosed = false;
}
/**
@@ -92,21 +89,7 @@ public abstract class AbstractDelegating
}
}
-
-/**
- * Close the listener
- */
-public synchronized void close() {
-isClosed = true;
-}
-/**
- * Check if closed
- */
-public synchronized boolean isClosed() {
-return isClosed;
-}
-
/*
* (non-Javadoc)
* @see
org.apache.james.mailbox.MailboxListenerSupport#addListener(org.apache.james.mailbox.MailboxPath,
org.apache.james.mailbox.MailboxListener,
org.apache.james.mailbox.MailboxSession)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1178562 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
Author: norman
Date: Mon Oct 3 20:35:37 2011
New Revision: 1178562
URL: http://svn.apache.org/viewvc?rev=1178562&view=rev
Log:
cleanup
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java?rev=1178562&r1=1178561&r2=1178562&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
Mon Oct 3 20:35:37 2011
@@ -101,14 +101,11 @@ public class MailboxEventDispatcher
* .MailboxListener.Event)
*/
public void event(Event event) {
-List closed = new ArrayList();
for (Iterator iter = listeners.iterator();
iter.hasNext();) {
MailboxListener mailboxListener = iter.next();
mailboxListener.event(event);
}
-for (int i = 0; i < closed.size(); i++)
-listeners.remove(closed.get(i));
}
/**
@@ -134,6 +131,10 @@ public class MailboxEventDispatcher
public final class AddedImpl extends MailboxListener.Added {
+/**
+ *
+ */
+private static final long serialVersionUID = 1L;
private SortedMap added;
private final Mailbox mailbox;
@@ -165,7 +166,10 @@ public class MailboxEventDispatcher
}
public final class ExpungedImpl extends MailboxListener.Expunged {
-
+/**
+ *
+ */
+private static final long serialVersionUID = 1L;
private final Map uids;
private final Mailbox mailbox;
@@ -196,7 +200,10 @@ public class MailboxEventDispatcher
}
public final class FlagsUpdatedImpl extends MailboxListener.FlagsUpdated {
-
+/**
+ *
+ */
+private static final long serialVersionUID = 1L;
private final List uids;
private final Mailbox mailbox;
@@ -233,7 +240,10 @@ public class MailboxEventDispatcher
}
public final class MailboxDeletionImpl extends MailboxDeletion {
-
+/**
+ *
+ */
+private static final long serialVersionUID = 1L;
private final Mailbox mailbox;
public MailboxDeletionImpl(MailboxSession session, Mailbox
mailbox) {
@@ -249,7 +259,11 @@ public class MailboxEventDispatcher
}
public final class MailboxAddedImpl extends MailboxAdded {
-
+/**
+ *
+ */
+private static final long serialVersionUID = 1L;
+
private final Mailbox mailbox;
public MailboxAddedImpl(MailboxSession session, Mailbox mailbox) {
@@ -288,6 +302,11 @@ public class MailboxEventDispatcher
}
public final class MailboxRenamedEventImpl extends
MailboxListener.MailboxRenamed {
+/**
+ *
+ */
+private static final long serialVersionUID = 1L;
+
private final MailboxPath newPath;
private final Mailbox newMailbox;
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1178688 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Author: norman
Date: Tue Oct 4 05:37:06 2011
New Revision: 1178688
URL: http://svn.apache.org/viewvc?rev=1178688&view=rev
Log:
Remove call of non-exsisting method
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java?rev=1178688&r1=1178687&r2=1178688&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
Tue Oct 4 05:37:06 2011
@@ -168,8 +168,6 @@ public class StoreMailboxManager imp
* @param delegatingListener
*/
public void setDelegatingMailboxListener(AbstractDelegatingMailboxListener
delegatingListener) {
-if (this.delegatingListener != null)
-this.delegatingListener.close();
this.delegatingListener = delegatingListener;
dispatcher.addMailboxListener(this.delegatingListener);
}
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1178689 - /james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/MailboxEventAnalyser.java
Author: norman
Date: Tue Oct 4 05:39:04 2011
New Revision: 1178689
URL: http://svn.apache.org/viewvc?rev=1178689&view=rev
Log:
cleanup
Modified:
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/MailboxEventAnalyser.java
Modified:
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/MailboxEventAnalyser.java
URL:
http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/MailboxEventAnalyser.java?rev=1178689&r1=1178688&r2=1178689&view=diff
==
---
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/MailboxEventAnalyser.java
(original)
+++
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/MailboxEventAnalyser.java
Tue Oct 4 05:39:04 2011
@@ -52,7 +52,6 @@ public class MailboxEventAnalyser implem
private boolean sizeChanged = false;
private boolean silentFlagChanges = false;
private MailboxPath mailboxPath;
-private boolean closed = false;
private Flags applicableFlags;
private boolean applicableFlagsChanged;
private ImapSession session;
@@ -281,7 +280,6 @@ public class MailboxEventAnalyser implem
* Mark the listener as closed and dispose all stored stuff
*/
public synchronized void close() {
-closed = true;
flagUpdateUids.clear();
uninterestingFlag = null;
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1178690 - /james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
Author: norman
Date: Tue Oct 4 05:47:02 2011
New Revision: 1178690
URL: http://svn.apache.org/viewvc?rev=1178690&view=rev
Log:
Replace tabs with spaces
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java?rev=1178690&r1=1178689&r2=1178690&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
Tue Oct 4 05:47:02 2011
@@ -632,45 +632,43 @@ public class StoreMessageManager imp
return index.search(mailboxSession, getMailboxEntity(), query);
}
-
private Iterator copy(final Iterator>
originalRows, final MailboxSession session) throws MailboxException {
- final List copiedRows = new
ArrayList();
- final MessageMapper messageMapper =
mapperFactory.getMessageMapper(session);
+final List copiedRows = new
ArrayList();
+final MessageMapper messageMapper =
mapperFactory.getMessageMapper(session);
- while(originalRows.hasNext()) {
- final Message originalMessage = originalRows.next();
- MessageMetaData data = messageMapper.execute(new
Mapper.Transaction() {
- public MessageMetaData run() throws MailboxException {
- return messageMapper.copy(getMailboxEntity(),
originalMessage);
-
- }
-
- });
- copiedRows.add(data);
- }
- return copiedRows.iterator();
+while (originalRows.hasNext()) {
+final Message originalMessage = originalRows.next();
+MessageMetaData data = messageMapper.execute(new
Mapper.Transaction() {
+public MessageMetaData run() throws MailboxException {
+return messageMapper.copy(getMailboxEntity(),
originalMessage);
+
+}
+
+});
+copiedRows.add(data);
+}
+return copiedRows.iterator();
}
-
+
/*
* (non-Javadoc)
* @see
org.apache.james.mailbox.store.AbstractStoreMessageManager#copy(org.apache.james.mailbox.MessageRange,
org.apache.james.mailbox.store.AbstractStoreMessageManager,
org.apache.james.mailbox.MailboxSession)
*/
private SortedMap copy(MessageRange set, final
StoreMessageManager to, final MailboxSession session) throws
MailboxException {
- MessageMapper messageMapper =
mapperFactory.getMessageMapper(session);
+MessageMapper messageMapper =
mapperFactory.getMessageMapper(session);
- final SortedMap copiedMessages = new
TreeMap();
- Iterator> originalRows =
messageMapper.findInMailbox(mailbox, set, FetchType.Full, -1);
- Iterator ids = to.copy(originalRows, session);
- while (ids.hasNext()) {
- MessageMetaData data = ids.next();
- copiedMessages.put(data.getUid(), data);
- }
+final SortedMap copiedMessages = new
TreeMap();
+Iterator> originalRows =
messageMapper.findInMailbox(mailbox, set, FetchType.Full, -1);
+Iterator ids = to.copy(originalRows, session);
+while (ids.hasNext()) {
+MessageMetaData data = ids.next();
+copiedMessages.put(data.getUid(), data);
+}
- return copiedMessages;
+return copiedMessages;
}
-
/**
* Return the count of unseen messages
*
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1178691 - /james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/UidToMsnConverter.java
Author: norman
Date: Tue Oct 4 05:51:44 2011
New Revision: 1178691
URL: http://svn.apache.org/viewvc?rev=1178691&view=rev
Log:
Remove unneccessary synchronized
Modified:
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/UidToMsnConverter.java
Modified:
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/UidToMsnConverter.java
URL:
http://svn.apache.org/viewvc/james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/UidToMsnConverter.java?rev=1178691&r1=1178690&r2=1178691&view=diff
==
---
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/UidToMsnConverter.java
(original)
+++
james/imap/trunk/processor/src/main/java/org/apache/james/imap/processor/base/UidToMsnConverter.java
Tue Oct 4 05:51:44 2011
@@ -128,7 +128,7 @@ public class UidToMsnConverter implement
*
* @param uid
*/
-public synchronized void add(long uid) {
+private void add(long uid) {
if (!uidToMsn.containsKey(uid)) {
highestMsn++;
add(highestMsn, uid);
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
svn commit: r1178696 - in /james/mailbox/trunk: store/src/main/java/org/apache/james/mailbox/store/ store/src/test/java/org/apache/james/mailbox/store/ tool/src/test/java/org/apache/james/mailbox/copi
Author: norman
Date: Tue Oct 4 06:37:54 2011
New Revision: 1178696
URL: http://svn.apache.org/viewvc?rev=1178696&view=rev
Log:
Refactor MailboxEventDispatcher to make contract and usage more clear
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java
james/mailbox/trunk/store/src/test/java/org/apache/james/mailbox/store/MailboxEventDispatcherFlagsTest.java
james/mailbox/trunk/tool/src/test/java/org/apache/james/mailbox/copier/MailboxCopierTest.java
Modified:
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java?rev=1178696&r1=1178695&r2=1178696&view=diff
==
---
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
(original)
+++
james/mailbox/trunk/store/src/main/java/org/apache/james/mailbox/store/MailboxEventDispatcher.java
Tue Oct 4 06:37:54 2011
@@ -20,14 +20,12 @@
package org.apache.james.mailbox.store;
import java.util.ArrayList;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
-import java.util.Set;
import java.util.SortedMap;
-import java.util.concurrent.CopyOnWriteArraySet;
-
import org.apache.james.mailbox.MailboxListener;
+import org.apache.james.mailbox.MailboxListener.MailboxAdded;
+import org.apache.james.mailbox.MailboxListener.MailboxDeletion;
import org.apache.james.mailbox.MailboxPath;
import org.apache.james.mailbox.MailboxSession;
import org.apache.james.mailbox.MessageMetaData;
@@ -37,20 +35,15 @@ import org.apache.james.mailbox.store.ma
/**
* Helper class to dispatch {@link Event}'s to registerend MailboxListener
*/
-public class MailboxEventDispatcher implements MailboxListener {
-
-private final Set listeners = new
CopyOnWriteArraySet();
+public class MailboxEventDispatcher {
+private final MailboxListener listener;
-/**
- * Add a MailboxListener to this dispatcher
- *
- * @param mailboxListener
- */
-public void addMailboxListener(MailboxListener mailboxListener) {
-listeners.add(mailboxListener);
+public MailboxEventDispatcher(MailboxListener listener) {
+this.listener = listener;
}
+
/**
* Should get called when a new message was added to a Mailbox. All
@@ -62,7 +55,7 @@ public class MailboxEventDispatcher
*/
public void added(MailboxSession session, SortedMap
uids, Mailbox mailbox) {
final AddedImpl added = new AddedImpl(session, mailbox, uids);
-event(added);
+listener.event(added);
}
/**
@@ -75,7 +68,7 @@ public class MailboxEventDispatcher
*/
public void expunged(final MailboxSession session, Map uids, Mailbox mailbox) {
final ExpungedImpl expunged = new ExpungedImpl(session, mailbox, uids);
-event(expunged);
+listener.event(expunged);
}
/**
@@ -90,32 +83,10 @@ public class MailboxEventDispatcher
*/
public void flagsUpdated(MailboxSession session, final List uids,
final Mailbox mailbox, final List uflags) {
final FlagsUpdatedImpl flags = new FlagsUpdatedImpl(session, mailbox,
uids, uflags);
-event(flags);
+listener.event(flags);
}
-/*
- * (non-Javadoc)
- *
- * @see
- * org.apache.james.mailbox.MailboxListener#event(org.apache.james.mailbox
- * .MailboxListener.Event)
- */
-public void event(Event event) {
-for (Iterator iter = listeners.iterator();
iter.hasNext();) {
-MailboxListener mailboxListener = iter.next();
-mailboxListener.event(event);
-
-}
-}
-/**
- * Return the the count of all registered MailboxListener
- *
- * @return count
- */
-public int count() {
-return listeners.size();
-}
/**
* Should get called when a Mailbox was renamed. All registered
@@ -126,7 +97,7 @@ public class MailboxEventDispatcher
* @param sessionId
*/
public void mailboxRenamed(MailboxSession session, MailboxPath from,
Mailbox to) {
-event(new MailboxRenamedEventImpl(session, from, to));
+listener.event(new MailboxRenamedEventImpl(session, from, to));
}
public final class AddedImpl extends MailboxListener.Added {
@@ -286,7 +257,7 @@ public class MailboxEventDispatcher
*/
public void mailboxDeleted(MailboxSession session, Mailbox mailbox) {
final MailboxDeletion event = new MailboxDeletionImpl(session,
mailbox);
-event(event);
+listener
svn commit: r1178697 - /james/mailbox/trunk/tool/src/test/java/org/apache/james/mailbox/copier/MailboxCopierTest.java
Author: norman
Date: Tue Oct 4 06:38:31 2011
New Revision: 1178697
URL: http://svn.apache.org/viewvc?rev=1178697&view=rev
Log:
Fix compiler warnings
Modified:
james/mailbox/trunk/tool/src/test/java/org/apache/james/mailbox/copier/MailboxCopierTest.java
Modified:
james/mailbox/trunk/tool/src/test/java/org/apache/james/mailbox/copier/MailboxCopierTest.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/tool/src/test/java/org/apache/james/mailbox/copier/MailboxCopierTest.java?rev=1178697&r1=1178696&r2=1178697&view=diff
==
---
james/mailbox/trunk/tool/src/test/java/org/apache/james/mailbox/copier/MailboxCopierTest.java
(original)
+++
james/mailbox/trunk/tool/src/test/java/org/apache/james/mailbox/copier/MailboxCopierTest.java
Tue Oct 4 06:38:31 2011
@@ -95,10 +95,10 @@ public class MailboxCopierTest {
@Test
public void testMailboxCopy() throws MailboxException, IOException {
if (srcMemMailboxManager instanceof StoreMailboxManager) {
- ((StoreMailboxManager) srcMemMailboxManager).init();
+ ((StoreMailboxManager) srcMemMailboxManager).init();
}
if (dstMemMailboxManager instanceof StoreMailboxManager) {
- ((StoreMailboxManager) dstMemMailboxManager).init();
+ ((StoreMailboxManager) dstMemMailboxManager).init();
}
srcMemMailboxManager = new
MockMailboxManager(srcMemMailboxManager).getMockMailboxManager();
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
