[jira] Commented: (JAMES-426) Make james use virtual user table domains for servernames
[ http://issues.apache.org/jira/browse/JAMES-426?page=comments#action_12365067 ] Daniel Perry commented on JAMES-426: I agree. The code i provided shouldn't affect any user of james, unless they add the extra attribute, so therefore could be added without causing any problems. I would suggest that it is put to a vote on the dev list, but as i am not a commiter, I dont really have a say. Daniel. Make james use virtual user table domains for servernames - Key: JAMES-426 URL: http://issues.apache.org/jira/browse/JAMES-426 Project: James Type: Improvement Components: James Core Environment: N/A Reporter: Daniel Perry Priority: Trivial Attachments: patch.txt Attached is a patch that makes james use the virtualusertable database for identifying local hosts. It also allows for continued use of servernames block. It is backwards compatible, and unless an extra attribute is added in the configuration, it wont affect james's behaviour. It is configured by adding the domainTable attribute to the servernames element, eg: servernames autodetect=true autodetectIP=true domainTable=db://maildb/VirtualUserTable Please note that the patch i will attach against svn trunk, but has been copied over directly from 2.2.0, and i havnt had a chance to check if it compiles or works with svn trunk. Daniel. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JAMES-426) Make james use virtual user table domains for servernames
Make james use virtual user table domains for servernames - Key: JAMES-426 URL: http://issues.apache.org/jira/browse/JAMES-426 Project: James Type: Improvement Components: James Core Environment: N/A Reporter: Daniel Perry Priority: Trivial Attached is a patch that makes james use the virtualusertable database for identifying local hosts. It also allows for continued use of servernames block. It is backwards compatible, and unless an extra attribute is added in the configuration, it wont affect james's behaviour. It is configured by adding the domainTable attribute to the servernames element, eg: servernames autodetect=true autodetectIP=true domainTable=db://maildb/VirtualUserTable Please note that the patch i will attach against svn trunk, but has been copied over directly from 2.2.0, and i havnt had a chance to check if it compiles or works with svn trunk. Daniel. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (JAMES-426) Make james use virtual user table domains for servernames
[ http://issues.apache.org/jira/browse/JAMES-426?page=all ] Daniel Perry updated JAMES-426: --- Attachment: patch.txt Patch for this functionality against trunk. Note: the code has not been compiled or tested with trunk, but has been used in a live environment with 2.2.0/2.1.3 for a long time. Make james use virtual user table domains for servernames - Key: JAMES-426 URL: http://issues.apache.org/jira/browse/JAMES-426 Project: James Type: Improvement Components: James Core Environment: N/A Reporter: Daniel Perry Priority: Trivial Attachments: patch.txt Attached is a patch that makes james use the virtualusertable database for identifying local hosts. It also allows for continued use of servernames block. It is backwards compatible, and unless an extra attribute is added in the configuration, it wont affect james's behaviour. It is configured by adding the domainTable attribute to the servernames element, eg: servernames autodetect=true autodetectIP=true domainTable=db://maildb/VirtualUserTable Please note that the patch i will attach against svn trunk, but has been copied over directly from 2.2.0, and i havnt had a chance to check if it compiles or works with svn trunk. Daniel. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-334) SHA hash incompatable with common generation methods
[ http://issues.apache.org/jira/browse/JAMES-334?page=comments#action_12318291 ] Daniel Perry commented on JAMES-334: This is an SHA hash but not in the format you'd expect. It's a base64 encoded rather than hex (reduces the size). Its then trimmed of padding. Some php code to do this is as follows: function hashPassword($in){ $pwd=base64_encode(hex2bin(sha1($in))); $pwd=substr($pwd,0,strlen($pwd)-4); return $pwd; } function hex2bin($source) { $strlen = strlen($source); for ($i=0;$istrlen($source);$i=$i+2) { $bin .= chr(hexdec(substr ($source, $i,2))); } return $bin; } SHA hash incompatable with common generation methods Key: JAMES-334 URL: http://issues.apache.org/jira/browse/JAMES-334 Project: James Type: Bug Components: UsersStore UsersRepository Versions: 2.2.0 Environment: FreeBSD, JDK 1.4.2, MySQL via. C-JDBC Reporter: Brill Pappin Priority: Minor This ticket is related to: JAMES-332 It appears the SHA password hash is not compatable with all other methods of generating an SHA hash I've tried. For example: SELECT SHA(test) in MySQL a94a8fe5ccb19ba61c4c0873d391e987982fbbd3 generates what I'd expect, however: the remote manager tool sets: CY9rzUYh03PK3k6DJie0 which doesn't even look like SHA. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-383) new posts hanging
[ http://issues.apache.org/jira/browse/JAMES-383?page=comments#action_12314394 ] Daniel Perry commented on JAMES-383: Looks like same issue as: http://issues.apache.org/jira/browse/JAMES-311 which has been fixed, but not in a release yet. Patch as follows: --- NNTPHandler_orig.java +++ NNTPHandler.java @@ -1053,7 +1053,7 @@ if (article != null) { writer.flush(); article.writeBody(new ExtraDotOutputStream(outs)); - writeLoggedFlushedResponse(.); + writeLoggedFlushedResponse(\r\n.); } } @@ -1189,7 +1189,7 @@ if (article != null) { writer.flush(); article.writeArticle(new ExtraDotOutputStream(outs)); - writeLoggedFlushedResponse(.); + writeLoggedFlushedResponse(\r\n.); } } new posts hanging - Key: JAMES-383 URL: http://issues.apache.org/jira/browse/JAMES-383 Project: James Type: Bug Components: NNTPServer Repository Versions: 2.2.0 Environment: fedora core 4, sun 1.4.2 VM Reporter: gareth lloyd Priority: Minor i have started up james as root, and disabled all the servers except the NNTP server. i'ave successfully added several newsgroups clients are able to create messages and successfully post them when you then try to read one of those messages, the client will hang ('reading message') indefintely.. clients can see the message headers.. but when they try to click on the message, the body of the message will not appear. its as if the server is 'stuck' and won't send out the message body. have tried seveal clients (thunderbird mainly) and getting same behavior. nothing of note in the logs that i can tell. please advise. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JAMES-367) Added option to CommandListServ to change the to address.
Added option to CommandListServ to change the to address. - Key: JAMES-367 URL: http://issues.apache.org/jira/browse/JAMES-367 Project: James Type: Improvement Components: Matchers/Mailets (bundled) Environment: N/A Reporter: Daniel Perry Priority: Minor Attachments: patch.txt I have added the option: changetoaddress[EMAIL PROTECTED]/changetoaddress to the CommandListServProcessor. When an email is sent to the list, it changes the to address into this. Is useful in hiding the list address, or in any other circmstances where you need to make it appear different. Note: it doesnt change the received headers, so the address is still there if people look. Daniel. --- src\java\org\apache\james\transport\mailets\CommandListservProcessor_orig.java Thu Apr 07 17:08:23 2005 +++ src\java\org\apache\james\transport\mailets\CommandListservProcessor.java Thu Apr 07 16:47:05 2005 @@ -27,10 +27,11 @@ import org.apache.mailet.GenericMailet; import org.apache.mailet.Mail; import org.apache.mailet.MailAddress; import org.apache.mailet.MailetException; +import javax.mail.Message; import javax.mail.MessagingException; import javax.mail.internet.MimeMessage; import javax.mail.internet.MimeMultipart; import javax.mail.internet.ParseException; import java.io.IOException; @@ -154,11 +155,13 @@ */ protected XMLResources xmlResources; protected boolean specificPostersOnly; protected Collection allowedPosters; - +protected boolean addFooter; +protected String changeToAddress; + /** * Initialize the mailet */ public void init() throws MessagingException { try { @@ -170,10 +173,12 @@ subjectPrefix = getString(subjectprefix, null); listName = getString(listName, null); autoBracket = getBoolean(autobracket, true); listOwner = new MailAddress(getString(listOwner, null)); specificPostersOnly = getBoolean(specifiedpostersonly, false); +addFooter = getBoolean(addfooter, true); +changeToAddress = getString(changetoaddress, null); //initialize resources initializeResources(); //init user repos initUsersRepository(); initAllowedPosters(configuration); @@ -206,17 +211,25 @@ if (!checkBeenThere(listservAddr, mail)) { return; } //addfooter -addFooter(mail); - +if (addFooter){ +addFooter(mail); +} + //prepare the new message MimeMessage message = prepareListMessage(mail, listservAddr); + + //Set the subject if set setSubject(message); + +if (changeToAddress!=null){ +message.setRecipients(Message.RecipientType.TO, changeToAddress); +} //Send the message to the list members //We set the list owner as the sender for now so bounces go to him/her getMailetContext().sendMail(listOwner, members, message); } catch (IOException ioe) { -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Updated: (JAMES-367) Added option to CommandListServ to change the to address.
[ http://issues.apache.org/jira/browse/JAMES-367?page=history ] Daniel Perry updated JAMES-367: --- Attachment: patch.txt This patch also includes the addfooter patch i submitted previously! Added option to CommandListServ to change the to address. - Key: JAMES-367 URL: http://issues.apache.org/jira/browse/JAMES-367 Project: James Type: Improvement Components: Matchers/Mailets (bundled) Environment: N/A Reporter: Daniel Perry Priority: Minor Attachments: patch.txt I have added the option: changetoaddress[EMAIL PROTECTED]/changetoaddress to the CommandListServProcessor. When an email is sent to the list, it changes the to address into this. Is useful in hiding the list address, or in any other circmstances where you need to make it appear different. Note: it doesnt change the received headers, so the address is still there if people look. Daniel. --- src\java\org\apache\james\transport\mailets\CommandListservProcessor_orig.java Thu Apr 07 17:08:23 2005 +++ src\java\org\apache\james\transport\mailets\CommandListservProcessor.java Thu Apr 07 16:47:05 2005 @@ -27,10 +27,11 @@ import org.apache.mailet.GenericMailet; import org.apache.mailet.Mail; import org.apache.mailet.MailAddress; import org.apache.mailet.MailetException; +import javax.mail.Message; import javax.mail.MessagingException; import javax.mail.internet.MimeMessage; import javax.mail.internet.MimeMultipart; import javax.mail.internet.ParseException; import java.io.IOException; @@ -154,11 +155,13 @@ */ protected XMLResources xmlResources; protected boolean specificPostersOnly; protected Collection allowedPosters; - +protected boolean addFooter; +protected String changeToAddress; + /** * Initialize the mailet */ public void init() throws MessagingException { try { @@ -170,10 +173,12 @@ subjectPrefix = getString(subjectprefix, null); listName = getString(listName, null); autoBracket = getBoolean(autobracket, true); listOwner = new MailAddress(getString(listOwner, null)); specificPostersOnly = getBoolean(specifiedpostersonly, false); +addFooter = getBoolean(addfooter, true); +changeToAddress = getString(changetoaddress, null); //initialize resources initializeResources(); //init user repos initUsersRepository(); initAllowedPosters(configuration); @@ -206,17 +211,25 @@ if (!checkBeenThere(listservAddr, mail)) { return; } //addfooter -addFooter(mail); - +if (addFooter){ +addFooter(mail); +} + //prepare the new message MimeMessage message = prepareListMessage(mail, listservAddr); + + //Set the subject if set setSubject(message); + +if (changeToAddress!=null){ +message.setRecipients(Message.RecipientType.TO, changeToAddress); +} //Send the message to the list members //We set the list owner as the sender for now so bounces go to him/her getMailetContext().sendMail(listOwner, members, message); } catch (IOException ioe) { -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JAMES-364) Made adding of footer optional with CommandListServProcessor
Made adding of footer optional with CommandListServProcessor Key: JAMES-364 URL: http://issues.apache.org/jira/browse/JAMES-364 Project: James Type: Improvement Components: Matchers/Mailets (bundled) Environment: N/A Reporter: Daniel Perry Priority: Minor Attachments: addfooterpatch.txt The CommandListServ attaches a footer. This patch makes that optional, and defaults to true. If you add: addfooterfalse/addfooter then it will not add the footer, and if you leave out that element (as in all existing installations!) then it wont effect the footer. Daniel. Patch follows: --- src\java\org\apache\james\transport\mailets\CommandListservProcessor.java_svn Tue Mar 29 17:08:45 2005 +++ src\java\org\apache\james\transport\mailets\CommandListservProcessor.java Tue Apr 05 15:02:31 2005 @@ -156,7 +156,8 @@ protected boolean specificPostersOnly; protected Collection allowedPosters; - +protected boolean addFooter; + /** * Initialize the mailet */ @@ -172,6 +173,7 @@ autoBracket = getBoolean(autobracket, true); listOwner = new MailAddress(getString(listOwner, null)); specificPostersOnly = getBoolean(specifiedpostersonly, false); +addFooter = getBoolean(addfooter, true); //initialize resources initializeResources(); //init user repos @@ -208,7 +210,9 @@ } //addfooter -addFooter(mail); +if (addFooter){ +addFooter(mail); +} //prepare the new message MimeMessage message = prepareListMessage(mail, listservAddr); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Created: (JAMES-363) Move PostmasterAlias from code to james-confix.xml
Move PostmasterAlias from code to james-confix.xml -- Key: JAMES-363 URL: http://issues.apache.org/jira/browse/JAMES-363 Project: James Type: Improvement Components: SpoolManager Processors Environment: N/A Reporter: Daniel Perry James automatically adds a PostmasterAlias mailet to the root processor. This is ok for a simple setup, but causes problems in a virtual hosting environment, as different domains may have different postmaster accounts. The fix is to remove the hard-coded mailet, and put it in the xml configuration file. A patch to do this is as follows: --- src\conf\james-config_orig.xml Mon Apr 04 12:20:31 2005 +++ src\conf\james-config.xml Mon Apr 04 12:29:52 2005 @@ -149,6 +149,12 @@ !-- This configuration is a sample configuration for the root processor. -- processor name=root + !-- This mailet redirects mail for the user 'postmaster' at any local domain to -- + !-- the postmaster address specified for the server. The postmaster address -- + !-- is required by rfc822. Do not remove this mailet unless you are meeting -- + !-- this requirement through other means (e.g. a XML/JDBCVirtualUserTable mailet) -- + mailet match=All class=PostmasterAlias/ + !-- Checks that the email Sender is associated with a valid domain. -- !-- Useful for detecting and eliminating spam. -- !-- For this block to function, the spam processor must be configured. -- --- src\java\org\apache\james\transport\JamesSpoolManager_orig.java Mon Apr 04 12:23:22 2005 +++ src\java\org\apache\james\transport\JamesSpoolManager.java Mon Apr 04 12:30:04 2005 @@ -196,16 +196,6 @@ processor.initialize(); processors.put(processorName, processor); -// If this is the root processor, add the PostmasterAlias -// mailet silently to the top -if (processorName.equals(root)) { -Matcher matcher = matchLoader.getMatcher(All, - mailetContext); -Mailet mailet = mailetLoader.getMailet(PostmasterAlias, - mailetContext, null); -processor.add(matcher, mailet); -} - final Configuration[] mailetConfs = processorConf.getChildren( mailet ); // Loop through the mailet configuration, load -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[jira] Commented: (JAMES-311) Nntp very picky with clients
[ http://issues.apache.org/jira/browse/JAMES-311?page=comments#action_61203 ] Daniel Perry commented on JAMES-311: Patch to fix this and make james rcf compliant with respect to messages not ending with \r\n. --- NNTPHandler_orig.java +++ NNTPHandler.java @@ -1053,7 +1053,7 @@ if (article != null) { writer.flush(); article.writeBody(new ExtraDotOutputStream(outs)); -writeLoggedFlushedResponse(.); +writeLoggedFlushedResponse(\r\n.); } } @@ -1189,7 +1189,7 @@ if (article != null) { writer.flush(); article.writeArticle(new ExtraDotOutputStream(outs)); -writeLoggedFlushedResponse(.); +writeLoggedFlushedResponse(\r\n.); } } Nntp very picky with clients Key: JAMES-311 URL: http://issues.apache.org/jira/browse/JAMES-311 Project: James Type: Bug Components: NNTPServer Repository Versions: 2.2.0 Environment: Tested on Windows xp Pro and Netware 6.5SP@ with Java 1.4.2_04 Reporter: Rodney Crossman Cannot read messages posted by some NNTP clients. For example, if a message is posted with Mozilla Firefox .72 or Groupwise client 6.5 and someone tries to read them, the client just hands and times out. Messages posted with Outlook express work perfectly fine. This is only an issue if there is a message body. If the message consist of only the subject, then it doesn't seem to cause any problems. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]