[jira] [Commented] (IMAP-351) ACL Support
[ https://issues.apache.org/jira/browse/IMAP-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13503156#comment-13503156 ] Eric Charles commented on IMAP-351: --- After applying the patch, the unit test were successful, however, the mailbox-integration test were failing. I fixed many of the issues for the inmemory mailbox test, but have more issue with the maildir store. Fixing the integration tests, I had to some workaround which are not in line with what we want to have as a final implementation, but which was needed if I didn't want to change to many things. Unfortunately, I was not able to got to the end and will not commit this for the time being. I also just wonder if this would have been a good thing to commit at once such huge changes. We should go more incrementally to allow everyone (developers and users) to review and comment the commits. The good think is that I have now a better view of Gazda work. ACL Support --- Key: IMAP-351 URL: https://issues.apache.org/jira/browse/IMAP-351 Project: JAMES Imap Issue Type: New Feature Components: JCR Mailbox, JPA Mailbox, Mailbox, Maildir Mailbox, Parser, Processor, Protocol Affects Versions: 0.3 Reporter: Jochen Gazda Labels: ACL, IMAP Fix For: 0.3 Attachments: ImapGetACLTest.java, IMAP-GETACL.txt, master...MAILBOX-175.diff Original Estimate: 672h Remaining Estimate: 672h Support for RFC 4314 IMAP4 Access Control List (ACL) Extension -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (IMAP-351) ACL Support
[ https://issues.apache.org/jira/browse/IMAP-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483911#comment-13483911 ] Eric Charles commented on IMAP-351: --- Hi, We talked about the attached big patch (taken from gazda github https://github.com/gazdahimself/current/compare/master...MAILBOX-175) on http://markmail.org/thread/gzzy5do5xtcnkzit I have applied the patch to the current trunk and it is roughly ok (still need to tweak some bits). I plan to commit soon. Tell me if that's ok for you. Thx, Eric ACL Support --- Key: IMAP-351 URL: https://issues.apache.org/jira/browse/IMAP-351 Project: JAMES Imap Issue Type: New Feature Components: JCR Mailbox, JPA Mailbox, Mailbox, Maildir Mailbox, Parser, Processor, Protocol Affects Versions: 0.3 Reporter: Jochen Gazda Labels: ACL, IMAP Fix For: 0.3 Attachments: ImapGetACLTest.java, IMAP-GETACL.txt Original Estimate: 672h Remaining Estimate: 672h Support for RFC 4314 IMAP4 Access Control List (ACL) Extension -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (IMAP-351) ACL Support
[ https://issues.apache.org/jira/browse/IMAP-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13208339#comment-13208339 ] Eric Charles commented on IMAP-351: --- In case you missed the commit, trunk has now ACL disabled (https://issues.apache.org/jira/browse/IMAP-357) To enable it, just put a empty set in the /META-INF/org/apache/james/spring-server.xml constructor-arg index=4 + set +valueACL/value + /set + /constructor-arg ACL Support --- Key: IMAP-351 URL: https://issues.apache.org/jira/browse/IMAP-351 Project: JAMES Imap Issue Type: New Feature Components: JCR Mailbox, JPA Mailbox, Mailbox, Maildir Mailbox, Parser, Processor, Protocol Affects Versions: 0.3 Reporter: Jochen Gazda Labels: ACL, IMAP Fix For: 0.3 Attachments: IMAP-GETACL.txt, ImapGetACLTest.java Original Estimate: 672h Remaining Estimate: 672h Support for RFC 4314 IMAP4 Access Control List (ACL) Extension -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (IMAP-351) ACL Support
[ https://issues.apache.org/jira/browse/IMAP-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13205302#comment-13205302 ] Jochen Gazda commented on IMAP-351: --- Just to sum up the state of the tasks mentioned in the original post: (1) I have put some FIXMEs and TODOs in the patch where somebody experienced should please have a look. See IMAP-354, IMAP-355, IMAP-356, MAILBOX-156, MAILBOX-157 and MAILBOX-158 (2) ACL getter and setter stubs should be filled in Mailbox implementations. New tests should be added for those getters and setters. See MAILBOX-161, MAILBOX-162, MAILBOX-163 and MAILBOX-158 (3) Mapping of ACL Rights to READ-WRITE and READ-ONLY Response Codes, see RFC 4314 section 5.2. See MAILBOX-160 (4) Enforce rights required to perform different IMAP4rev1 Commands in IMAP processors, see RFC 4314 section 4. Write tests. See IMAP-358 (5) MailboxACLUpdated event should be fired and litstened to. See MAILBOX-164 (6) A new one: IMAP-359 Implement missing ACL commands SETACL, LISTRIGHTS and MYRIGHTS ACL Support --- Key: IMAP-351 URL: https://issues.apache.org/jira/browse/IMAP-351 Project: JAMES Imap Issue Type: New Feature Components: JCR Mailbox, JPA Mailbox, Mailbox, Maildir Mailbox, Parser, Processor, Protocol Affects Versions: 0.3 Reporter: Jochen Gazda Labels: ACL, IMAP Fix For: 0.3 Attachments: IMAP-GETACL.txt, ImapGetACLTest.java Original Estimate: 672h Remaining Estimate: 672h Support for RFC 4314 IMAP4 Access Control List (ACL) Extension -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (IMAP-351) ACL Support
[ https://issues.apache.org/jira/browse/IMAP-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13201538#comment-13201538 ] Jochen Gazda commented on IMAP-351: --- Thanks for committing, Norman. I noticed there is an author tag which includes a name like Peter Who is he ? That is my real name. Should I sign up and confess under that name once again? ACL Support --- Key: IMAP-351 URL: https://issues.apache.org/jira/browse/IMAP-351 Project: JAMES Imap Issue Type: New Feature Components: JCR Mailbox, JPA Mailbox, Mailbox, Maildir Mailbox, Parser, Processor, Protocol Affects Versions: 0.3 Reporter: Jochen Gazda Labels: ACL, IMAP Fix For: 0.3 Attachments: IMAP-GETACL.txt, ImapGetACLTest.java Original Estimate: 672h Remaining Estimate: 672h Support for RFC 4314 IMAP4 Access Control List (ACL) Extension -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (IMAP-351) ACL Support
[ https://issues.apache.org/jira/browse/IMAP-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13195536#comment-13195536 ] Norman Maurer commented on IMAP-351: I merged the patch into trunk. Thanks again for this work its really a massive patch :) ACL Support --- Key: IMAP-351 URL: https://issues.apache.org/jira/browse/IMAP-351 Project: JAMES Imap Issue Type: New Feature Components: JCR Mailbox, JPA Mailbox, Mailbox, Maildir Mailbox, Parser, Processor, Protocol Affects Versions: 0.3 Reporter: Jochen Gazda Labels: ACL, IMAP Fix For: 0.3 Attachments: IMAP-GETACL.txt, ImapGetACLTest.java Original Estimate: 672h Remaining Estimate: 672h Support for RFC 4314 IMAP4 Access Control List (ACL) Extension -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
