[jira] [Commented] (JAMES-2253) addFooter mailet doesn't work for multipart mail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310640#comment-16310640
 ] 

ASF GitHub Bot commented on JAMES-2253:
---

Github user chibenwa commented on the issue:

https://github.com/apache/james-project/pull/88
  
Hi!

This contribution had been merged. Thanks again for your support to the 
James project, your help is both useful and appreciable. Might you encounter 
any additional issues or want new features please feel free to contribute it.

Futhermore, while merging this pull request I had been asked to write an 
integration test for this PR. If you are interested, you can take a look here: 
https://github.com/linagora/james-project/pull/1198/commits/c785e20a7a4a68d764d9afa8f5d142fc93a4d524

As always, wouldn't you mind closing this pull request?

Best regards,

Benoit


> addFooter mailet doesn't work for multipart mail
> 
>
> Key: JAMES-2253
> URL: https://issues.apache.org/jira/browse/JAMES-2253
> Project: James Server
>  Issue Type: Bug
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
> Attachments: AddFooter.patch
>
>
> The addFooter mailet doesn't work for multipart mail, though It works for 
> text mail. (Tested with 3.0.1.)
> The addFooterTest ends successfully but the mailet doesn't work on the real 
> James server.
> The addFooterTest uses javax.mail.internet.MimeMessage, but the real mailet 
> uses org.apache.james.server.core.MimeMessageCopyOnWriteProxy which extends 
> MimeMessage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2253) addFooter mailet doesn't work for multipart mail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294594#comment-16294594
 ] 

ASF GitHub Bot commented on JAMES-2253:
---

Github user chibenwa commented on the issue:

https://github.com/apache/james-project/pull/88
  
You are very welcome.

Might you have any question / need any support using the James server, feel 
free to ask us using the mailing list or the gitter channel.


> addFooter mailet doesn't work for multipart mail
> 
>
> Key: JAMES-2253
> URL: https://issues.apache.org/jira/browse/JAMES-2253
> Project: James Server
>  Issue Type: Bug
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
> Attachments: AddFooter.patch
>
>
> The addFooter mailet doesn't work for multipart mail, though It works for 
> text mail. (Tested with 3.0.1.)
> The addFooterTest ends successfully but the mailet doesn't work on the real 
> James server.
> The addFooterTest uses javax.mail.internet.MimeMessage, but the real mailet 
> uses org.apache.james.server.core.MimeMessageCopyOnWriteProxy which extends 
> MimeMessage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2253) addFooter mailet doesn't work for multipart mail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294591#comment-16294591
 ] 

ASF GitHub Bot commented on JAMES-2253:
---

Github user apptaro commented on the issue:

https://github.com/apache/james-project/pull/88
  
Hi, thank you for incorporating my fix!


> addFooter mailet doesn't work for multipart mail
> 
>
> Key: JAMES-2253
> URL: https://issues.apache.org/jira/browse/JAMES-2253
> Project: James Server
>  Issue Type: Bug
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
> Attachments: AddFooter.patch
>
>
> The addFooter mailet doesn't work for multipart mail, though It works for 
> text mail. (Tested with 3.0.1.)
> The addFooterTest ends successfully but the mailet doesn't work on the real 
> James server.
> The addFooterTest uses javax.mail.internet.MimeMessage, but the real mailet 
> uses org.apache.james.server.core.MimeMessageCopyOnWriteProxy which extends 
> MimeMessage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2253) addFooter mailet doesn't work for multipart mail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294590#comment-16294590
 ] 

ASF GitHub Bot commented on JAMES-2253:
---

Github user chibenwa commented on the issue:

https://github.com/apache/james-project/pull/88
  
I will duplicate the PR for unit testing, and handle further remarks. If 
interrested follow this [soon to be provided] link.

Thanks again for this contribution.

Best regard,

Benoit Tellier


> addFooter mailet doesn't work for multipart mail
> 
>
> Key: JAMES-2253
> URL: https://issues.apache.org/jira/browse/JAMES-2253
> Project: James Server
>  Issue Type: Bug
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
> Attachments: AddFooter.patch
>
>
> The addFooter mailet doesn't work for multipart mail, though It works for 
> text mail. (Tested with 3.0.1.)
> The addFooterTest ends successfully but the mailet doesn't work on the real 
> James server.
> The addFooterTest uses javax.mail.internet.MimeMessage, but the real mailet 
> uses org.apache.james.server.core.MimeMessageCopyOnWriteProxy which extends 
> MimeMessage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2253) addFooter mailet doesn't work for multipart mail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294585#comment-16294585
 ] 

ASF GitHub Bot commented on JAMES-2253:
---

Github user chibenwa commented on a diff in the pull request:

https://github.com/apache/james-project/pull/88#discussion_r157411809
  
--- Diff: 
mailet/standard/src/main/java/org/apache/james/transport/mailets/AddFooter.java 
---
@@ -94,11 +94,18 @@ private boolean attachFooter(MimePart part) throws 
MessagingException, IOExcepti
 if (part.isMimeType("multipart/mixed")
 || part.isMimeType("multipart/related")) {
 MimeMultipart multipart = (MimeMultipart) part.getContent();
-return attachFooterToFirstPart(multipart);
+boolean added = attachFooterToFirstPart(multipart);
+if (added) {
+   part.setContent(multipart);
+}
+return added;
 
 } else if (part.isMimeType("multipart/alternative")) {
 MimeMultipart multipart = (MimeMultipart) part.getContent();
-return attachFooterToAllSubparts(multipart);
+boolean added = attachFooterToAllSubparts(multipart);
+if (added) {
+   part.setContent(multipart);
+}
--- End diff --

I guess you forgot the `return added` stuff here...

That would cause `multipart/alternative` to not be well handled anymore...

By the way forgetting this return breaks tests.


> addFooter mailet doesn't work for multipart mail
> 
>
> Key: JAMES-2253
> URL: https://issues.apache.org/jira/browse/JAMES-2253
> Project: James Server
>  Issue Type: Bug
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
> Attachments: AddFooter.patch
>
>
> The addFooter mailet doesn't work for multipart mail, though It works for 
> text mail. (Tested with 3.0.1.)
> The addFooterTest ends successfully but the mailet doesn't work on the real 
> James server.
> The addFooterTest uses javax.mail.internet.MimeMessage, but the real mailet 
> uses org.apache.james.server.core.MimeMessageCopyOnWriteProxy which extends 
> MimeMessage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2253) addFooter mailet doesn't work for multipart mail

[Taro App (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294550#comment-16294550
 ] 

Taro App commented on JAMES-2253:
-

Created the PR: https://github.com/apache/james-project/pull/88

> addFooter mailet doesn't work for multipart mail
> 
>
> Key: JAMES-2253
> URL: https://issues.apache.org/jira/browse/JAMES-2253
> Project: James Server
>  Issue Type: Bug
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
> Attachments: AddFooter.patch
>
>
> The addFooter mailet doesn't work for multipart mail, though It works for 
> text mail. (Tested with 3.0.1.)
> The addFooterTest ends successfully but the mailet doesn't work on the real 
> James server.
> The addFooterTest uses javax.mail.internet.MimeMessage, but the real mailet 
> uses org.apache.james.server.core.MimeMessageCopyOnWriteProxy which extends 
> MimeMessage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2253) addFooter mailet doesn't work for multipart mail

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294549#comment-16294549
 ] 

ASF GitHub Bot commented on JAMES-2253:
---

GitHub user apptaro opened a pull request:

https://github.com/apache/james-project/pull/88

Fix for JAMES-2253



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apptaro/james-project JAMES-2253

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/james-project/pull/88.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #88


commit 8fdadb05822af91dbb0bca64ecaa3ba24ef58fc6
Author: apptaro 
Date:   2017-12-18T06:20:18Z

Fix for JAMES-2253




> addFooter mailet doesn't work for multipart mail
> 
>
> Key: JAMES-2253
> URL: https://issues.apache.org/jira/browse/JAMES-2253
> Project: James Server
>  Issue Type: Bug
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
> Attachments: AddFooter.patch
>
>
> The addFooter mailet doesn't work for multipart mail, though It works for 
> text mail. (Tested with 3.0.1.)
> The addFooterTest ends successfully but the mailet doesn't work on the real 
> James server.
> The addFooterTest uses javax.mail.internet.MimeMessage, but the real mailet 
> uses org.apache.james.server.core.MimeMessageCopyOnWriteProxy which extends 
> MimeMessage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

[jira] [Commented] (JAMES-2253) addFooter mailet doesn't work for multipart mail

[Tellier Benoit (JIRA)]

[ 
https://issues.apache.org/jira/browse/JAMES-2253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16292127#comment-16292127
 ] 

Tellier Benoit commented on JAMES-2253:
---

Hi, Sorry for the answer delay.

I first wanted to thank you for your work and the contribution to the James 
project. Your issue is well detailed and the fix looks good to me.

Would it be possible for you to open this pull request on GitHub? 
https://github.com/apache/james-project This will makes exchanging on it easier.

Thanks, and best regards,

Benoit

> addFooter mailet doesn't work for multipart mail
> 
>
> Key: JAMES-2253
> URL: https://issues.apache.org/jira/browse/JAMES-2253
> Project: James Server
>  Issue Type: Bug
>Affects Versions: 3.0.0-beta5
>Reporter: Taro App
> Attachments: AddFooter.patch
>
>
> The addFooter mailet doesn't work for multipart mail, though It works for 
> text mail. (Tested with 3.0.1.)
> The addFooterTest ends successfully but the mailet doesn't work on the real 
> James server.
> The addFooterTest uses javax.mail.internet.MimeMessage, but the real mailet 
> uses org.apache.james.server.core.MimeMessageCopyOnWriteProxy which extends 
> MimeMessage.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org