[jira] [Commented] (JAMES-2735) Add new mailet and matcher that uses the headers and the per recipients

2019-05-02 Thread Tellier Benoit (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831453#comment-16831453
 ] 

Tellier Benoit commented on JAMES-2735:
---

Hi Simon!

Many thanks for your awesome work! I'm just back from (long...) vacations and 
will get a close look at it in the coming days.

Just a quick comment: I do think the difference between Per-Recipient headers 
and "Global" headers is complex, and hard to present to the end user. 
Furthermore, I do believe we should keep things easy and avoid feature 
duplication. I do believe the behaviour you implemented should become the new 
version of *HasHeader* & *RemoveMimeHeader*.

Furthermore, I make *HasHeaderWithPrefix* also "per-recipent aware" for the 
sake of consistency.



> Add new mailet and matcher that uses the headers and the per recipients
> ---
>
> Key: JAMES-2735
> URL: https://issues.apache.org/jira/browse/JAMES-2735
> Project: James Server
>  Issue Type: New Feature
>  Components: Matchers/Mailets (bundled)
>Affects Versions: 3.3.0
>Reporter: Simon Levesque
>Priority: Minor
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the RemoveHeader and HasHeader components are only acting on the 
> global ones; not the per recipient ones.
> Need to create:
> - RemoveHeaderGlobalAndPerRecipient
> - HasHeaderGlobalAndPerRecipient



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



[jira] [Commented] (JAMES-2735) Add new mailet and matcher that uses the headers and the per recipients

2019-04-18 Thread Simon Levesque (JIRA)


[ 
https://issues.apache.org/jira/browse/JAMES-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16820968#comment-16820968
 ] 

Simon Levesque commented on JAMES-2735:
---

as discussed, I will do a pull request with these:
- 
https://github.com/foilen/james-extra-components/blob/master/src/main/java/com/foilen/james/components/mailet/RemoveHeaderGlobalAndSpecific.java
-- 
https://github.com/foilen/james-extra-components/blob/master/src/test/java/com/foilen/james/components/mailet/RemoveHeaderGlobalAndSpecificTest.java
- 
https://github.com/foilen/james-extra-components/blob/master/src/main/java/com/foilen/james/components/matcher/HasHeaderGlobalAndSpecific.java
-- 
https://github.com/foilen/james-extra-components/blob/master/src/test/java/com/foilen/james/components/matcher/HasHeaderGlobalAndSpecificTest.java


> Add new mailet and matcher that uses the headers and the per recipients
> ---
>
> Key: JAMES-2735
> URL: https://issues.apache.org/jira/browse/JAMES-2735
> Project: James Server
>  Issue Type: New Feature
>  Components: Matchers/Mailets (bundled)
>Affects Versions: 3.3.0
>Reporter: Simon Levesque
>Priority: Minor
>
> Currently, the RemoveHeader and HasHeader components are only acting on the 
> global ones; not the per recipient ones.
> Need to create:
> - RemoveHeaderGlobalAndPerRecipient
> - HasHeaderGlobalAndPerRecipient



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org