[jira] [Commented] (JAMES-3879) Use jUnit Category/Tag to exclude by default integration/long running tests

2023-02-28 Thread Wojtek (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17694772#comment-17694772
 ] 

Wojtek commented on JAMES-3879:
---

Inclusion/exclusion of the tests can (and should) be controlled via Maven 
profiles. Thus, in the CI pipeline build can be configured with "full" profile 
which would have empty list of excluded test categories thus running all of 
them no matter of further changes. Maven profile activation could be automatic 
based on certain conditions, including system environment variables (e.g. 
detecting its being run on Jenkins), though considering caveat to _not_miss_ 
test execution I would go with explicit profile declaration.

> Use jUnit Category/Tag to exclude by default integration/long running tests
> ---
>
> Key: JAMES-3879
> URL: https://issues.apache.org/jira/browse/JAMES-3879
> Project: James Server
>  Issue Type: Test
>Affects Versions: master
>Reporter: Wojtek
>Priority: Minor
>
> On the main James page 
> (https://github.com/apache/james-project#how-to-check-the-compilation) there 
> is a text:
> "Useful (maven) options includes: `-DskipTests` to skip the long to execute 
> resource consuming test suite that requires a docker daemon."
> I propose using `Tag` annotation to mark those test ("docker", "slow", 
> "integration", etc.) and by default exclude those categories.
> Main benefit, that majority of tests would be run when building James either 
> way (thus, allowing to test most of the code) and integration tests can still 
> be run (either locally or on CI)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org



[jira] [Commented] (JAMES-3879) Use jUnit Category/Tag to exclude by default integration/long running tests

2023-02-25 Thread Benoit Tellier (Jira)


[ 
https://issues.apache.org/jira/browse/JAMES-3879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17693487#comment-17693487
 ] 

Benoit Tellier commented on JAMES-3879:
---

Hi Wojtek,

Sorry for answering that late...

Ok for adding a tag/category profile for this but:

 - we do already run some smoke tests on integration tests for the distributed 
products.
 - I would be very worry that we ends up no longer running those tests without 
noticing...

Hence I'd prefer that we run all that runs today by default... (and give a 
convenient way to people to opt out those tests).

> Use jUnit Category/Tag to exclude by default integration/long running tests
> ---
>
> Key: JAMES-3879
> URL: https://issues.apache.org/jira/browse/JAMES-3879
> Project: James Server
>  Issue Type: Test
>Affects Versions: master
>Reporter: Wojtek
>Priority: Minor
>
> On the main James page 
> (https://github.com/apache/james-project#how-to-check-the-compilation) there 
> is a text:
> "Useful (maven) options includes: `-DskipTests` to skip the long to execute 
> resource consuming test suite that requires a docker daemon."
> I propose using `Tag` annotation to mark those test ("docker", "slow", 
> "integration", etc.) and by default exclude those categories.
> Main benefit, that majority of tests would be run when building James either 
> way (thus, allowing to test most of the code) and integration tests can still 
> be run (either locally or on CI)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org