[jira] [Commented] (MAILBOX-378) Refactoring: push MessageManager::expunge into IMAP layer
[ https://issues.apache.org/jira/browse/MAILBOX-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776506#comment-16776506 ] Tellier Benoit commented on MAILBOX-378: https://github.com/linagora/james-project/pull/2189 did add messages to some runtime exceptions > Refactoring: push MessageManager::expunge into IMAP layer > - > > Key: MAILBOX-378 > URL: https://issues.apache.org/jira/browse/MAILBOX-378 > Project: James Mailbox > Issue Type: Bug >Reporter: Trần Tiến Đức >Priority: Major > Fix For: 3.4.0 > > > With an expunged model, we get the deleted metadata **after** the delete > operation proceeded, which is not compatible with > PreDeletionHooks(MAILBOX-379) design. > In this ticket, we propose ourselves to implement this expunge mechanism in > the IMAP layer. > -1. Promote `List retrieveDeletedMessage(MessageRange)` as a > MessageManager method. > -2. Implement a new `void delete(List)` as a MessageManager > method. > -3. Remove `MessageManager::expunge` & > `MessageMapper::expungeMarkedForDeletionInMailbox`. > You will need to adapt MessageMapper tests and MessageManager tests > accordingly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-378) Refactoring: push MessageManager::expunge into IMAP layer
[ https://issues.apache.org/jira/browse/MAILBOX-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774694#comment-16774694 ] Rene Cordier commented on MAILBOX-378: -- PR : https://github.com/linagora/james-project/pull/2182 > Refactoring: push MessageManager::expunge into IMAP layer > - > > Key: MAILBOX-378 > URL: https://issues.apache.org/jira/browse/MAILBOX-378 > Project: James Mailbox > Issue Type: Bug >Reporter: Trần Tiến Đức >Priority: Major > > With an expunged model, we get the deleted metadata **after** the delete > operation proceeded, which is not compatible with > PreDeletionHooks(MAILBOX-379) design. > In this ticket, we propose ourselves to implement this expunge mechanism in > the IMAP layer. > -1. Promote `List retrieveDeletedMessage(MessageRange)` as a > MessageManager method. > -2. Implement a new `void delete(List)` as a MessageManager > method. > -3. Remove `MessageManager::expunge` & > `MessageMapper::expungeMarkedForDeletionInMailbox`. > You will need to adapt MessageMapper tests and MessageManager tests > accordingly. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
