[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782965#comment-16782965
]
Rene Cordier commented on MAILBOX-382:
--
Second PR on redeliver events webadmin routes :
https://github.com/linagora/james-project/pull/2208
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778801#comment-16778801
]
Rene Cordier commented on MAILBOX-382:
--
Yes exactly how I structured the routes when I started working on it. Thanks
for the insight guys !
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1662#comment-1662
]
Raphaël Ouazana commented on MAILBOX-382:
-
It seems the endpoint /events/deadLetter/groups/:group/ is not used? So in this
case yes I think you can cut the last events so that GET
/events/deadLetter/groups/:group/ returns the list of events in this group. And
/events/deadLetter/groups/:group/:eventId represent one particular event of
this group.
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1645#comment-1645
]
Rene Cordier commented on MAILBOX-382:
--
I would be alright as well with it. But if anybody else has an other idea...?
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1642#comment-1642
]
Matthieu Baechler commented on MAILBOX-382:
---
I would remove the second occurrence but we can debate that.
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1634#comment-1634
]
Rene Cordier commented on MAILBOX-382:
--
Ok I get it, but in a more specific context we can have for a specific event ID
as well... So what should be the solution here, do we keep the two occurrences
of `events` in the path, even if it's not the best practice? Or do we change
the second occurrence to an other word (like `messages`? but in the code we
call it `Event` so...). Or we just delete the second occurrence ?
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1620#comment-1620
]
Matthieu Baechler commented on MAILBOX-382:
---
deadLetter could be used in several contexts, I think it makes sense to prefix
it by events to know what context we are talking about (paths should go from
more general concepts to more specific).
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1615#comment-1615
]
Rene Cordier commented on MAILBOX-382:
--
Hmmm now that you said it... You are probably right.
However those already exist in REST webadmin :
{code:java}
GET /events/deadLetter/groups
GET /events/deadLetter/groups/:group/events
GET /events/deadLetter/groups/:group/events/:eventId
DELETE /events/deadLetter/groups/:group/events/:eventId
{code}
Might need to refactor the all REST interface for dead letters... I was
thinking, because we need events for refining some operations to some event id,
might be better to get rid of the first 'events' occurence, so that the root
base would be '/deadLetter/' instead of '/events/deadLetter', like for example :
{code:java}
curl -POST /deadLetter/events?action=reDeliver
{code}
WDYT?
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776951#comment-16776951
]
Matthieu Baechler commented on MAILBOX-382:
---
{code}
curl -POST /events/deadLetter/events?action=reDeliver
{code}
the second occurrence of events is probably a bad idea
{code}
curl -POST
/events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
curl -POST
/events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver
{code}
Same thing for these APIs too
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[jira] [Commented] (MAILBOX-382) EventDeadLetter: rechedule event delivery
[
https://issues.apache.org/jira/browse/MAILBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776751#comment-16776751
]
Rene Cordier commented on MAILBOX-382:
--
PR for event redelivery : https://github.com/linagora/james-project/pull/2192
> EventDeadLetter: rechedule event delivery
> -
>
> Key: MAILBOX-382
> URL: https://issues.apache.org/jira/browse/MAILBOX-382
> Project: James Mailbox
> Issue Type: New Feature
>Reporter: Trần Tiến Đức
>Priority: Major
>
> base on: -MAILBOX-373-
> The event bus need a method for re-delivering an event to a group.
> {code:java}
> Mono reDeliver(Group group, Event event);{code}
> In webAdmin implement the following endpoints:
> {code:java}
> curl -POST /events/deadLetter/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events?action=reDeliver
> curl -POST
> /events/deadLetter/groups/ListeningQuotaUpdaterGroup/events/UUID?action=reDeliver{code}
> And the tasks that backs it up.
> Implement tests for EventBus method addition & for WebAdmin new routes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
