[17/30] james-project git commit: JAMES-2641 Re-organize mailbox manager fields
JAMES-2641 Re-organize mailbox manager fields
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/cac26ab9
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/cac26ab9
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/cac26ab9
Branch: refs/heads/master
Commit: cac26ab9c8cb0a93d2bcb358b5ca3b34471e83fa
Parents: 9fc3e75
Author: Benoit Tellier
Authored: Tue Jan 8 10:52:48 2019 +0700
Committer: Benoit Tellier
Committed: Tue Jan 15 10:10:04 2019 +0700
--
.../mailbox/store/StoreMailboxManager.java | 23 +---
1 file changed, 5 insertions(+), 18 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/james-project/blob/cac26ab9/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
--
diff --git
a/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
b/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
index 55c0262..67bf1e3 100644
---
a/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
+++
b/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java
@@ -108,40 +108,27 @@ public class StoreMailboxManager implements
MailboxManager {
private static final Logger LOGGER =
LoggerFactory.getLogger(StoreMailboxManager.class);
public static final char SQL_WILDCARD_CHAR = '%';
public static final EnumSet
DEFAULT_NO_MESSAGE_CAPABILITIES = EnumSet.noneOf(MessageCapabilities.class);
+private static final SecureRandom RANDOM = new SecureRandom();
+private final StoreRightManager storeRightManager;
private final DelegatingMailboxListener delegatingListener;
private final MailboxSessionMapperFactory mailboxSessionMapperFactory;
-
private final Authenticator authenticator;
private final MailboxAnnotationManager annotationManager;
+private final MailboxPathLocker locker;
+private final MessageParser messageParser;
+private final Factory messageIdFactory;
private Authorizator authorizator;
-
-private final StoreRightManager storeRightManager;
-
-private static final SecureRandom RANDOM = new SecureRandom();
-
private MessageBatcher copyBatcher;
-
private MessageBatcher moveBatcher;
-
-private final MailboxPathLocker locker;
-
private MessageSearchIndex index;
-
private MailboxSessionIdGenerator idGenerator;
-
private QuotaManager quotaManager;
-
private QuotaRootResolver quotaRootResolver;
-
private QuotaUpdater quotaUpdater;
-
private BatchSizes batchSizes = BatchSizes.defaultValues();
-private final MessageParser messageParser;
-private final Factory messageIdFactory;
-
@Inject
public StoreMailboxManager(MailboxSessionMapperFactory
mailboxSessionMapperFactory, Authenticator authenticator, Authorizator
authorizator,
MailboxPathLocker locker, MessageParser
messageParser,
-
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
[05/12] james-project git commit: JAMES-2008 Remove all JUNIT contracts usages for Mailbox manager tests
http://git-wip-us.apache.org/repos/asf/james-project/blob/a9fdb1c4/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/FullUserMaildirMailboxManagerStressTest.java
--
diff --git
a/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/FullUserMaildirMailboxManagerStressTest.java
b/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/FullUserMaildirMailboxManagerStressTest.java
new file mode 100644
index 000..e2ef938
--- /dev/null
+++
b/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/FullUserMaildirMailboxManagerStressTest.java
@@ -0,0 +1,43 @@
+/
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information*
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the*
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the*
+ * specific language governing permissions and limitations *
+ * under the License. *
+ /
+
+package org.apache.james.mailbox.maildir;
+
+import org.apache.james.mailbox.MailboxManager;
+import org.apache.james.mailbox.MailboxManagerStressTest;
+import org.junit.Rule;
+import org.junit.rules.TemporaryFolder;
+
+import com.google.common.base.Throwables;
+
+public class FullUserMaildirMailboxManagerStressTest extends
MailboxManagerStressTest {
+@Rule
+public TemporaryFolder tmpFolder = new TemporaryFolder();
+
+@Override
+protected MailboxManager provideManager() {
+try {
+return
MaildirMailboxManagerProvider.createMailboxManager("/%fulluser", tmpFolder);
+} catch (Exception e) {
+throw Throwables.propagate(e);
+}
+}
+
+
+}
http://git-wip-us.apache.org/repos/asf/james-project/blob/a9fdb1c4/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/FullUserMaildirMailboxManagerTest.java
--
diff --git
a/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/FullUserMaildirMailboxManagerTest.java
b/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/FullUserMaildirMailboxManagerTest.java
new file mode 100644
index 000..d6140b8
--- /dev/null
+++
b/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/FullUserMaildirMailboxManagerTest.java
@@ -0,0 +1,51 @@
+/
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information*
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the*
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the*
+ * specific language governing permissions and limitations *
+ * under the License. *
+ /
+package org.apache.james.mailbox.maildir;
+
+import java.io.UnsupportedEncodingException;
+
+import org.apache.james.mailbox.MailboxManager;
+import org.apache.james.mailbox.MailboxManagerTest;
+import org.apache.james.mailbox.exception.MailboxException;
+import org.junit.Ignore;
+import org.junit.Rule;
+import org.junit.rules.TemporaryFolder;
+
+import com.google.common.base.Throwables;
+
+public class FullUserMaildirMailboxManagerTest extends MailboxManagerTest {
+
+@Rule
+public TemporaryFolder tmpFolder = new TemporaryFolder();
+
+
[07/12] james-project git commit: JAMES-2008 Correct Annotation JPA Mailbox Manager tests
JAMES-2008 Correct Annotation JPA Mailbox Manager tests
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/1d2d3313
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/1d2d3313
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/1d2d3313
Branch: refs/heads/master
Commit: 1d2d331377cb600ce31f7fc6c1f3e42464f26a91
Parents: 8884766
Author: benwa <btell...@linagora.com>
Authored: Fri Apr 21 16:23:05 2017 +0700
Committer: Antoine Duprat <adup...@linagora.com>
Committed: Wed Apr 26 13:50:11 2017 +0200
--
.../james/mailbox/jpa/JPAMailboxManager.java| 11 +-
.../jpa/openjpa/OpenJPAMailboxManager.java | 22
.../mailbox/jpa/JpaMailboxManagerProvider.java | 8 ++-
.../mpt/imapmailbox/jpa/host/JPAHostSystem.java | 3 ++-
.../host/LuceneSearchHostSystem.java| 3 ++-
5 files changed, 39 insertions(+), 8 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/james-project/blob/1d2d3313/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/JPAMailboxManager.java
--
diff --git
a/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/JPAMailboxManager.java
b/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/JPAMailboxManager.java
index 3754b78..d8180c7 100644
---
a/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/JPAMailboxManager.java
+++
b/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/JPAMailboxManager.java
@@ -44,7 +44,16 @@ public abstract class JPAMailboxManager extends
StoreMailboxManager {
public JPAMailboxManager(JPAMailboxSessionMapperFactory
mailboxSessionMapperFactory,
Authenticator authenticator, Authorizator authorizator,
MailboxPathLocker locker, MailboxACLResolver aclResolver,
GroupMembershipResolver groupMembershipResolver, MessageParser
messageParser, MessageId.Factory messageIdFactory) {
-super(mailboxSessionMapperFactory, authenticator, authorizator,
locker, aclResolver, groupMembershipResolver, messageParser, messageIdFactory);
+super(mailboxSessionMapperFactory, authenticator, authorizator,
locker, aclResolver, groupMembershipResolver,
+messageParser, messageIdFactory);
+}
+
+public JPAMailboxManager(JPAMailboxSessionMapperFactory
mailboxSessionMapperFactory,
+ Authenticator authenticator, Authorizator
authorizator, MailboxPathLocker locker, MailboxACLResolver aclResolver,
+ GroupMembershipResolver groupMembershipResolver,
MessageParser messageParser, MessageId.Factory messageIdFactory,
+ int limitAnnotation, int limitAnnotationSize) {
+super(mailboxSessionMapperFactory, authenticator, authorizator,
locker, aclResolver, groupMembershipResolver,
+messageParser, messageIdFactory, limitAnnotation,
limitAnnotationSize);
}
@Override
http://git-wip-us.apache.org/repos/asf/james-project/blob/1d2d3313/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
--
diff --git
a/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
b/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
index f8a2dbb..8285d9a 100644
---
a/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
+++
b/mailbox/jpa/src/main/java/org/apache/james/mailbox/jpa/openjpa/OpenJPAMailboxManager.java
@@ -31,6 +31,7 @@ import org.apache.james.mailbox.jpa.JPAMailboxManager;
import org.apache.james.mailbox.jpa.JPAMailboxSessionMapperFactory;
import org.apache.james.mailbox.jpa.mail.model.openjpa.EncryptDecryptHelper;
import
org.apache.james.mailbox.jpa.openjpa.OpenJPAMessageManager.AdvancedFeature;
+import org.apache.james.mailbox.model.MailboxConstants;
import org.apache.james.mailbox.model.MessageId;
import org.apache.james.mailbox.store.Authenticator;
import org.apache.james.mailbox.store.Authorizator;
@@ -49,8 +50,10 @@ public class OpenJPAMailboxManager extends JPAMailboxManager
{
public OpenJPAMailboxManager(JPAMailboxSessionMapperFactory mapperFactory,
Authenticator authenticator, Authorizator authorizator,
MailboxPathLocker locker, boolean useStreaming, MailboxACLResolver
aclResolver,
-GroupMembershipResolver groupMembershipResolver, MessageParser
messageParser, MessageId.Factory messageIdFactory) {
-super(mapperFactory, authenticator, authorizator, locker, aclResolver,
groupMembershipResolver, messageParser, messageIdFactory);
+GroupMembershipResolver groupMember
[06/12] james-project git commit: JAMES-2008 Remove all JUNIT contracts usages for Mailbox manager tests
JAMES-2008 Remove all JUNIT contracts usages for Mailbox manager tests
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo
Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/a9fdb1c4
Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/a9fdb1c4
Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/a9fdb1c4
Branch: refs/heads/master
Commit: a9fdb1c481a1e22b9389ee7b26043624817c5ef2
Parents: e9a73fd
Author: benwa <btell...@linagora.com>
Authored: Wed Apr 19 15:39:59 2017 +0700
Committer: Antoine Duprat <adup...@linagora.com>
Committed: Wed Apr 26 13:50:10 2017 +0200
--
mailbox/api/pom.xml | 14 +-
.../james/mailbox/MailboxManagerStressTest.java | 26 +--
.../james/mailbox/MailboxManagerTest.java | 80 +
mailbox/cassandra/pom.xml | 5 -
.../CassandraMailboxManagerProvider.java| 99 +++
.../CassandraMailboxManagerStressTest.java | 68
.../cassandra/CassandraMailboxManagerTest.java | 108 ++--
mailbox/hbase/pom.xml | 5 -
.../hbase/HBaseMailboxManagerStressTest.java| 102
.../mailbox/hbase/HBaseMailboxManagerTest.java | 80 -
mailbox/jcr/pom.xml | 5 -
.../mailbox/jcr/JCRMailboxManagerProvider.java | 79 +
.../jcr/JCRMailboxManagerStressTest.java| 64
.../mailbox/jcr/JCRMailboxManagerTest.java | 101 +++-
mailbox/jpa/pom.xml | 5 -
.../mailbox/jpa/JPAMailboxManagerTest.java | 87 ++
.../mailbox/jpa/JpaMailboxManagerProvider.java | 63 +++
.../jpa/JpaMailboxManagerStressTest.java| 52 ++
mailbox/maildir/pom.xml | 5 -
...mainUserMaildirMailboxManagerStressTest.java | 43 +
.../DomainUserMaildirMailboxManagerTest.java| 51 ++
...FullUserMaildirMailboxManagerStressTest.java | 43 +
.../FullUserMaildirMailboxManagerTest.java | 51 ++
.../maildir/MaildirMailboxManagerProvider.java | 54 ++
.../maildir/MaildirMailboxManagerTests.java | 163 ---
.../UserMaildirMailboxManagerStressTest.java| 43 +
mailbox/memory/pom.xml | 5 -
.../inmemory/InMemoryMailboxManagerTest.java| 77 -
.../inmemory/MemoryMailboxManagerProvider.java | 58 +++
.../MemoryMailboxManagerStressTest.java | 30
.../inmemory/MemoryMailboxManagerTest.java | 30
31 files changed, 1073 insertions(+), 623 deletions(-)
--
http://git-wip-us.apache.org/repos/asf/james-project/blob/a9fdb1c4/mailbox/api/pom.xml
--
diff --git a/mailbox/api/pom.xml b/mailbox/api/pom.xml
index 6917440..35471bf 100644
--- a/mailbox/api/pom.xml
+++ b/mailbox/api/pom.xml
@@ -41,12 +41,17 @@
javax.mail
+commons-codec
+commons-codec
+
+
commons-lang
commons-lang
-commons-codec
-commons-codec
+commons-io
+commons-io
+test
org.slf4j
@@ -83,11 +88,6 @@
mockito-core
test
-
-org.xenei
-junit-contracts
-test
-
http://git-wip-us.apache.org/repos/asf/james-project/blob/a9fdb1c4/mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerStressTest.java
--
diff --git
a/mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerStressTest.java
b/mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerStressTest.java
index 9221557..f92cb11 100644
---
a/mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerStressTest.java
+++
b/mailbox/api/src/test/java/org/apache/james/mailbox/MailboxManagerStressTest.java
@@ -37,34 +37,26 @@ import org.apache.james.mailbox.exception.MailboxException;
import org.apache.james.mailbox.model.ComposedMessageId;
import org.apache.james.mailbox.model.MailboxConstants;
import org.apache.james.mailbox.model.MailboxPath;
-import org.junit.After;
+import org.junit.Before;
+import org.junit.Test;
import org.slf4j.LoggerFactory;
-import org.xenei.junit.contract.Contract;
-import org.xenei.junit.contract.ContractTest;
-import org.xenei.junit.contract.IProducer;
import com.google.common.collect.ImmutableSet;
-@Contract(MailboxManager.class)
-public class MailboxManagerStressTest {
+public abstract class MailboxManagerStressTest {
private final static int APPEND_OPERATIONS = 200;
-private IProducer producer;
private Ma
svn commit: r1722812 [1/5] - in /james/project/trunk: backends-common/cassandra/ mailbox/api/src/test/java/org/apache/james/mailbox/manager/ mailbox/cassandra/ mailbox/cassandra/src/main/java/org/apac
Author: matthieu Date: Mon Jan 4 09:40:15 2016 New Revision: 1722812 URL: http://svn.apache.org/viewvc?rev=1722812=rev Log: JAMES-1651 remove a bunch of (eclipse) warnings Removed: james/project/trunk/server/data/data-library/src/test/java/org/apache/james/rrt/lib/mock/MockRecipientRewriteTableManagementImpl.java Modified: james/project/trunk/backends-common/cassandra/pom.xml james/project/trunk/mailbox/api/src/test/java/org/apache/james/mailbox/manager/QuotaMessageManagerTest.java james/project/trunk/mailbox/cassandra/pom.xml james/project/trunk/mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/modules/CassandraRegistrationModule.java james/project/trunk/mailbox/elasticsearch/pom.xml james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMailboxMapper.java james/project/trunk/mailbox/hbase/src/main/java/org/apache/james/mailbox/hbase/mail/HBaseMessageMapper.java james/project/trunk/mailbox/jcr/src/test/java/org/apache/james/mailbox/jcr/JCRMailboxIdDeserializerTest.java james/project/trunk/mailbox/kafka/src/main/java/org/apache/james/mailbox/kafka/KafkaMessageConsumer.java james/project/trunk/mailbox/maildir/src/test/java/org/apache/james/mailbox/maildir/MaildirMailboxIdDeserializerTest.java james/project/trunk/mailbox/memory/src/main/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManager.java james/project/trunk/mailbox/memory/src/test/java/org/apache/james/mailbox/inmemory/InMemoryMailboxIdDeserializerTest.java james/project/trunk/mailbox/memory/src/test/java/org/apache/james/mailbox/inmemory/manager/InMemoryIntegrationResources.java james/project/trunk/mailbox/memory/src/test/java/org/apache/james/mailbox/inmemory/quota/InMemoryCurrentQuotaManagerTest.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/MailboxSessionMapperFactory.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMailboxManager.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/StoreMessageManager.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/event/MailboxListenerRegistry.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/json/JsonEventSerializer.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/json/event/MailboxConverter.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/json/event/dto/UpdatedFlagsDataTransferObject.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/CurrentQuotaCalculator.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/DefaultQuotaRootResolver.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/quota/QuotaChecker.java james/project/trunk/mailbox/store/src/main/java/org/apache/james/mailbox/store/search/LazyMessageSearchIndex.java james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/event/DefaultDelegatingMailboxListenerTest.java james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/quota/DefaultQuotaRootResolverTest.java james/project/trunk/mailbox/store/src/test/java/org/apache/james/mailbox/store/quota/QuotaCheckerTest.java james/project/trunk/mailbox/tool/src/main/java/org/apache/james/mailbox/indexer/registrations/MailboxRegistration.java james/project/trunk/mailbox/zoo-seq-provider/src/main/java/org/apache/james/mailbox/store/mail/ZooUidProvider.java james/project/trunk/mailet/ai/pom.xml james/project/trunk/mailet/ai/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java james/project/trunk/mailet/api/pom.xml james/project/trunk/mailet/base/pom.xml james/project/trunk/mailet/base/src/main/java/org/apache/mailet/base/GenericRecipientMatcher.java james/project/trunk/mailet/base/src/test/java/org/apache/mailet/base/test/FakeMailetConfig.java james/project/trunk/mailet/crypto/pom.xml james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/KeyStoreHolder.java james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/SMIMEKeyHolder.java james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/AbstractSign.java james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMECheckSignature.java james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMEDecrypt.java james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java james/project/trunk/mailet/mailetdocs-maven-plugin/pom.xml james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james
svn commit: r1722812 [2/5] - in /james/project/trunk: backends-common/cassandra/ mailbox/api/src/test/java/org/apache/james/mailbox/manager/ mailbox/cassandra/ mailbox/cassandra/src/main/java/org/apac
Modified:
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMECheckSignature.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMECheckSignature.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMECheckSignature.java
(original)
+++
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMECheckSignature.java
Mon Jan 4 09:40:15 2016
@@ -24,7 +24,6 @@ package org.apache.james.transport.maile
import java.io.IOException;
import java.security.cert.X509Certificate;
import java.util.ArrayList;
-import java.util.Iterator;
import java.util.List;
import javax.mail.MessagingException;
Modified:
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMEDecrypt.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMEDecrypt.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMEDecrypt.java
(original)
+++
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/mailet/SMIMEDecrypt.java
Mon Jan 4 09:40:15 2016
@@ -113,6 +113,7 @@ public class SMIMEDecrypt extends Generi
if (message.isMimeType("application/x-pkcs7-mime") ||
message.isMimeType("application/pkcs7-mime")) {
try {
SMIMEEnveloped env = new SMIMEEnveloped(message);
+@SuppressWarnings("unchecked")
Collection recipients =
env.getRecipientInfos().getRecipients();
Iterator iter = recipients.iterator();
while (iter.hasNext()) {
Modified:
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java
(original)
+++
james/project/trunk/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java
Mon Jan 4 09:40:15 2016
@@ -25,14 +25,13 @@ import java.security.Principal;
import java.security.cert.X509Certificate;
import java.util.Collection;
import java.util.Collections;
-import java.util.Iterator;
import java.util.List;
import javax.mail.MessagingException;
-import org.apache.mailet.base.GenericMatcher;
import org.apache.mailet.Mail;
import org.apache.mailet.MailAddress;
+import org.apache.mailet.base.GenericMatcher;
/**
*
@@ -63,6 +62,7 @@ public class IsX509CertificateSubject ex
check = condition.substring(pos+1, condition.length());
}
+@SuppressWarnings("unchecked")
public Collection match(Mail mail) throws MessagingException {
List certificates;
Modified: james/project/trunk/mailet/mailetdocs-maven-plugin/pom.xml
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailet/mailetdocs-maven-plugin/pom.xml?rev=1722812=1722811=1722812=diff
==
--- james/project/trunk/mailet/mailetdocs-maven-plugin/pom.xml (original)
+++ james/project/trunk/mailet/mailetdocs-maven-plugin/pom.xml Mon Jan 4
09:40:15 2016
@@ -28,7 +28,6 @@
mailetdocs-maven-plugin
-2.5.1-SNAPSHOT
maven-plugin
Apache James :: Mailetdocs Maven Plugin
Modified:
james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java
(original)
+++
james/project/trunk/mailet/mailetdocs-maven-plugin/src/main/java/org/apache/james/mailet/DefaultDescriptorsExtractor.java
Mon Jan 4 09:40:15 2016
@@ -249,6 +249,7 @@ public class DefaultDescriptorsExtractor
}
+@SuppressWarnings("unchecked")
private JavaClass[] javaClasses(MavenProject project) {
JavaDocBuilder builder = new JavaDocBuilder();
for (String s : (Iterable) project.getCompileSourceRoots()) {
Modified: james/project/trunk/mailet/pom.xml
URL:
svn commit: r1722812 [5/5] - in /james/project/trunk: backends-common/cassandra/ mailbox/api/src/test/java/org/apache/james/mailbox/manager/ mailbox/cassandra/ mailbox/cassandra/src/main/java/org/apac
Modified:
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java
(original)
+++
james/project/trunk/server/protocols/jmap/src/main/java/org/apache/james/jmap/methods/JmapResponse.java
Mon Jan 4 09:40:15 2016
@@ -20,7 +20,6 @@
package org.apache.james.jmap.methods;
import org.apache.james.jmap.model.ClientId;
-import org.apache.james.jmap.model.ProtocolRequest;
import com.google.common.annotations.VisibleForTesting;
Modified:
james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapRequestParserImplTest.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapRequestParserImplTest.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapRequestParserImplTest.java
(original)
+++
james/project/trunk/server/protocols/jmap/src/test/java/org/apache/james/jmap/methods/JmapRequestParserImplTest.java
Mon Jan 4 09:40:15 2016
@@ -23,7 +23,6 @@ import org.apache.james.jmap.model.Proto
import org.junit.Test;
import com.fasterxml.jackson.databind.JsonNode;
-import com.fasterxml.jackson.databind.exc.UnrecognizedPropertyException;
import com.fasterxml.jackson.databind.node.JsonNodeFactory;
import com.fasterxml.jackson.databind.node.ObjectNode;
import com.fasterxml.jackson.datatype.jdk8.Jdk8Module;
Modified: james/project/trunk/server/protocols/protocols-imap4/pom.xml
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-imap4/pom.xml?rev=1722812=1722811=1722812=diff
==
--- james/project/trunk/server/protocols/protocols-imap4/pom.xml (original)
+++ james/project/trunk/server/protocols/protocols-imap4/pom.xml Mon Jan 4
09:40:15 2016
@@ -28,7 +28,6 @@
../../pom.xml
-org.apache.james
james-server-protocols-imap4
bundle
@@ -47,7 +46,6 @@
org.apache.james.protocols
protocols-imap
-${protocols.version}
Modified:
james/project/trunk/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/IMAPServerFactory.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/IMAPServerFactory.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/IMAPServerFactory.java
(original)
+++
james/project/trunk/server/protocols/protocols-imap4/src/main/java/org/apache/james/imapserver/netty/IMAPServerFactory.java
Mon Jan 4 09:40:15 2016
@@ -63,7 +63,6 @@ public class IMAPServerFactory extends A
return new IMAPServer();
}
-@SuppressWarnings("unchecked")
@Override
protected List createServers(Logger log,
HierarchicalConfiguration config) throws Exception {
Modified: james/project/trunk/server/protocols/protocols-library/pom.xml
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-library/pom.xml?rev=1722812=1722811=1722812=diff
==
--- james/project/trunk/server/protocols/protocols-library/pom.xml (original)
+++ james/project/trunk/server/protocols/protocols-library/pom.xml Mon Jan 4
09:40:15 2016
@@ -28,7 +28,6 @@
../../pom.xml
-org.apache.james
james-server-protocols-library
bundle
Modified:
james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/ProtocolHandlerChainImpl.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/ProtocolHandlerChainImpl.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/ProtocolHandlerChainImpl.java
(original)
+++
james/project/trunk/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/ProtocolHandlerChainImpl.java
Mon Jan 4 09:40:15 2016
@@ -50,7 +50,6 @@ public class ProtocolHandlerChainImpl im
this.jmxHandlersPackage =
svn commit: r1722812 [3/5] - in /james/project/trunk: backends-common/cassandra/ mailbox/api/src/test/java/org/apache/james/mailbox/manager/ mailbox/cassandra/ mailbox/cassandra/src/main/java/org/apac
Modified:
james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/LogProviderImpl.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/LogProviderImpl.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/LogProviderImpl.java
(original)
+++
james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/LogProviderImpl.java
Mon Jan 4 09:40:15 2016
@@ -126,7 +126,7 @@ public class LogProviderImpl implements
if (!getSupportedLogLevels().contains(loglevel)) {
throw new IllegalArgumentException("Not supported loglevel given");
} else {
-((org.apache.log4j.Logger)
logMap.get(component)).getRootLogger().setLevel(Level.toLevel(loglevel));
+((org.apache.log4j.Logger)
logMap.get(component)).setLevel(Level.toLevel(loglevel));
}
}
Modified:
james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/osgi/AbstractBundleTracker.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/osgi/AbstractBundleTracker.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/osgi/AbstractBundleTracker.java
(original)
+++
james/project/trunk/server/container/spring/src/main/java/org/apache/james/container/spring/osgi/AbstractBundleTracker.java
Mon Jan 4 09:40:15 2016
@@ -140,7 +140,7 @@ public abstract class AbstractBundleTrac
*/
private BeanFactory getBeanFactory(final BundleContext bundleContext)
throws Exception {
final String filter = "(" +
OsgiServicePropertiesResolver.BEAN_NAME_PROPERTY_KEY + "=" +
bundleContext.getBundle().getSymbolicName() + ")";
-final ServiceReference[] applicationContextRefs =
bundleContext.getServiceReferences(ApplicationContext.class.getName(), filter);
+final ServiceReference[] applicationContextRefs =
bundleContext.getServiceReferences(ApplicationContext.class.getName(), filter);
// Check if we found an ApplicationContext. If not create one
if(applicationContextRefs == null || applicationContextRefs.length !=
1) {
Modified: james/project/trunk/server/container/util-java8/pom.xml
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/container/util-java8/pom.xml?rev=1722812=1722811=1722812=diff
==
--- james/project/trunk/server/container/util-java8/pom.xml (original)
+++ james/project/trunk/server/container/util-java8/pom.xml Mon Jan 4 09:40:15
2016
@@ -28,7 +28,6 @@
../../pom.xml
-org.apache.james
james-server-util-java8
bundle
Modified: james/project/trunk/server/container/util/pom.xml
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/container/util/pom.xml?rev=1722812=1722811=1722812=diff
==
--- james/project/trunk/server/container/util/pom.xml (original)
+++ james/project/trunk/server/container/util/pom.xml Mon Jan 4 09:40:15 2016
@@ -28,7 +28,6 @@
../../pom.xml
-org.apache.james
james-server-util
bundle
@@ -40,6 +39,10 @@
${javax.mail.artifactId}
+com.google.guava
+guava
+
+
org.slf4j
slf4j-api
Modified:
james/project/trunk/server/container/util/src/main/java/org/apache/james/util/bayesian/BayesianAnalyzer.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/container/util/src/main/java/org/apache/james/util/bayesian/BayesianAnalyzer.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/container/util/src/main/java/org/apache/james/util/bayesian/BayesianAnalyzer.java
(original)
+++
james/project/trunk/server/container/util/src/main/java/org/apache/james/util/bayesian/BayesianAnalyzer.java
Mon Jan 4 09:40:15 2016
@@ -705,21 +705,6 @@ public class BayesianAnalyzer {
return (p / (p + np));
}
-private boolean allSameChar(String s) {
-if (s.length() < 2) {
-return false;
-}
-
-char c = s.charAt(0);
-
-for (int i = 1; i < s.length(); i++) {
-if (s.charAt(i) != c) {
-return false;
-}
-}
-return true;
-}
-
private boolean allDigits(String s) {
for (int i = 0; i
svn commit: r1722812 [4/5] - in /james/project/trunk: backends-common/cassandra/ mailbox/api/src/test/java/org/apache/james/mailbox/manager/ mailbox/cassandra/ mailbox/cassandra/src/main/java/org/apac
Modified:
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/matchers/Xor.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/matchers/Xor.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/matchers/Xor.java
(original)
+++
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/matchers/Xor.java
Mon Jan 4 09:40:15 2016
@@ -38,15 +38,15 @@ public class Xor extends GenericComposit
* @return Collection of Recipients from the Xor composition of the child
* matchers.
*/
-public Collection match(Mail mail) throws MessagingException {
-Collection finalResult = null;
+public Collection match(Mail mail) throws MessagingException {
+Collection finalResult = null;
Matcher matcher;
boolean first = true;
-for (Iterator matcherIter = iterator(); matcherIter.hasNext();) {
-matcher = (Matcher) (matcherIter.next());
-Collection result = matcher.match(mail);
+for (Iterator matcherIter = iterator();
matcherIter.hasNext();) {
+matcher = matcherIter.next();
+Collection result = matcher.match(mail);
if (result == null) {
-result = new ArrayList(0);
+result = new ArrayList(0);
}
// log("Matching with " +
// matcher.getMatcherConfig().getMatcherName() +
Modified:
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/lib/AbstractStateCompositeProcessor.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/lib/AbstractStateCompositeProcessor.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/lib/AbstractStateCompositeProcessor.java
(original)
+++
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/lib/AbstractStateCompositeProcessor.java
Mon Jan 4 09:40:15 2016
@@ -160,7 +160,6 @@ public abstract class AbstractStateCompo
}
}
-@SuppressWarnings("unchecked")
@PostConstruct
public void init() throws Exception {
List processorConfs =
config.configurationsAt("processor");
Modified:
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/lib/AbstractStateMailetProcessor.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/lib/AbstractStateMailetProcessor.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/lib/AbstractStateMailetProcessor.java
(original)
+++
james/project/trunk/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/lib/AbstractStateMailetProcessor.java
Mon Jan 4 09:40:15 2016
@@ -256,7 +256,6 @@ public abstract class AbstractStateMaile
* @throws MessagingException
* @throws NotCompliantMBeanException
*/
-@SuppressWarnings("unchecked")
private List loadCompositeMatchers(String state, Map compMap, List compMatcherConfs) throws
ConfigurationException, MessagingException {
List matchers = new ArrayList();
@@ -305,7 +304,6 @@ public abstract class AbstractStateMaile
return matchers;
}
-@SuppressWarnings("unchecked")
private void parseConfiguration() throws MessagingException,
ConfigurationException {
// load composite matchers if there are any
Modified:
james/project/trunk/server/mailet/mailetcontainer-camel/src/test/java/org/apache/james/mailetcontainer/impl/matchers/AndTest.java
URL:
http://svn.apache.org/viewvc/james/project/trunk/server/mailet/mailetcontainer-camel/src/test/java/org/apache/james/mailetcontainer/impl/matchers/AndTest.java?rev=1722812=1722811=1722812=diff
==
---
james/project/trunk/server/mailet/mailetcontainer-camel/src/test/java/org/apache/james/mailetcontainer/impl/matchers/AndTest.java
(original)
+++
james/project/trunk/server/mailet/mailetcontainer-camel/src/test/java/org/apache/james/mailetcontainer/impl/matchers/AndTest.java
Mon Jan 4 09:40:15 2016
@@ -43,7 +43,7 @@ public class AndTest
svn commit: r1704538 - in /james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager: ./ IntegrationResources.java ManagerTestResources.java QuotaMessageManagerTest.java
Author: btellier
Date: Tue Sep 22 10:23:38 2015
New Revision: 1704538
URL: http://svn.apache.org/viewvc?rev=1704538=rev
Log:
MAILBOX-64 Quota integration API and default tests
Added:
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/IntegrationResources.java
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/ManagerTestResources.java
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/QuotaMessageManagerTest.java
Added:
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/IntegrationResources.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/IntegrationResources.java?rev=1704538=auto
==
---
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/IntegrationResources.java
(added)
+++
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/IntegrationResources.java
Tue Sep 22 10:23:38 2015
@@ -0,0 +1,53 @@
+/
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information*
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the*
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software distributed under the License is distributed on an *
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY *
+ * KIND, either express or implied. See the License for the*
+ * specific language governing permissions and limitations *
+ * under the License. *
+ /
+
+package org.apache.james.mailbox.manager;
+
+import org.apache.james.mailbox.MailboxManager;
+import org.apache.james.mailbox.quota.MaxQuotaManager;
+import org.apache.james.mailbox.quota.QuotaManager;
+import org.apache.james.mailbox.acl.GroupMembershipResolver;
+import org.apache.james.mailbox.exception.MailboxException;
+import org.apache.james.mailbox.quota.QuotaRootResolver;
+
+/**
+ * Provides empty resources for integration tests.
+ */
+public interface IntegrationResources {
+
+MailboxManager createMailboxManager(GroupMembershipResolver
groupMembershipResolver) throws MailboxException;
+
+QuotaManager createQuotaManager(MaxQuotaManager maxQuotaManager,
MailboxManager mailboxManager) throws Exception;
+
+MaxQuotaManager createMaxQuotaManager() throws Exception;
+
+QuotaRootResolver createQuotaRootResolver(MailboxManager mailboxManager)
throws Exception;
+
+GroupMembershipResolver createGroupMembershipResolver() throws Exception;
+
+/**
+ * Init you will want to perform before tests
+ *
+ * @throws Exception
+ */
+void init() throws Exception;
+
+void clean() throws Exception;
+
+}
\ No newline at end of file
Added:
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/ManagerTestResources.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/ManagerTestResources.java?rev=1704538=auto
==
---
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/ManagerTestResources.java
(added)
+++
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/manager/ManagerTestResources.java
Tue Sep 22 10:23:38 2015
@@ -0,0 +1,146 @@
+/
+ * Licensed to the Apache Software Foundation (ASF) under one *
+ * or more contributor license agreements. See the NOTICE file *
+ * distributed with this work for additional information*
+ * regarding copyright ownership. The ASF licenses this file *
+ * to you under the Apache License, Version 2.0 (the*
+ * "License"); you may not use this file except in compliance *
+ * with the License. You may obtain a copy of the License at *
+ * *
+ * http://www.apache.org/licenses/LICENSE-2.0 *
+ * *
+ * Unless required by applicable law or agreed to in writing, *
+ * software
Re: MailBox Manager Tests performance
For hbase, we need to reduce the number of minihbasecluster start/stop. Each James independent tests suppose a clean persistent store, this is why we need to start from scratch (easy for memory and file, takes more time for other persistence technologies). btw, this is also a topic on which the hbase project works for its own tests (running a full test suite on hbase src takes hours, mainly due to those numerous minihbasecluster start/stop). Thx, Eric On 16/10/11 17:14, Manuel Carrasco Moñino wrote: Thanks Stefano I just run once each test. I know there is a overhead when running setup and teardown, what I do not know is if the test could be useful for performance, subtracting the setup/teardown times and looping it. - Manolo On Sun, Oct 16, 2011 at 5:05 PM, Stefano Bagnaraapa...@bago.org wrote: 2011/10/16 Manuel Carrasco Moñinoman...@apache.org: Hi all, Is the Manager Test useful to measure performance? Testing the the couchdb implementation Pepijn is working on, I've released that some implementations takes a long to run the tests (see attached screenshot): InMemory 0.7s MailDir 2.4s JPA 6.0s JCR 21.1s CouchDB 40.4s HBase 81.8s JPA uses a ddbb in memory, CouchDB is not optimized at all, but Is there any reason why jcr and hbase takes so long? Don't know how you test this, but if you include startup and warmup times then it is expected that more complex layers will take longer to startup. Maybe you should run the tests 1000 times or make sure you at least run them twice and only measure timings for the second time (and exclude startup times). Does this make sense? Stefano - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org -- Eric http://about.echarles.net - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: MailBox Manager Tests performance
Ok, clear enough. So I think we could use the AbstractStressTest to check performance for each implementation and realize if there is any performance issue. Maybe this test could be expanded to test more mailbox operations and not only append 200 simple messages, for instance large attachments, read, delete, folder manipulation etc. Thanks - Manolo On Mon, Oct 17, 2011 at 10:03 AM, Eric Charles eric.char...@u-mangate.com wrote: For hbase, we need to reduce the number of minihbasecluster start/stop. Each James independent tests suppose a clean persistent store, this is why we need to start from scratch (easy for memory and file, takes more time for other persistence technologies). btw, this is also a topic on which the hbase project works for its own tests (running a full test suite on hbase src takes hours, mainly due to those numerous minihbasecluster start/stop). Thx, Eric On 16/10/11 17:14, Manuel Carrasco Moñino wrote: Thanks Stefano I just run once each test. I know there is a overhead when running setup and teardown, what I do not know is if the test could be useful for performance, subtracting the setup/teardown times and looping it. - Manolo On Sun, Oct 16, 2011 at 5:05 PM, Stefano Bagnaraapa...@bago.org wrote: 2011/10/16 Manuel Carrasco Moñinoman...@apache.org: Hi all, Is the Manager Test useful to measure performance? Testing the the couchdb implementation Pepijn is working on, I've released that some implementations takes a long to run the tests (see attached screenshot): InMemory 0.7s MailDir 2.4s JPA 6.0s JCR 21.1s CouchDB 40.4s HBase 81.8s JPA uses a ddbb in memory, CouchDB is not optimized at all, but Is there any reason why jcr and hbase takes so long? Don't know how you test this, but if you include startup and warmup times then it is expected that more complex layers will take longer to startup. Maybe you should run the tests 1000 times or make sure you at least run them twice and only measure timings for the second time (and exclude startup times). Does this make sense? Stefano - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org -- Eric http://about.echarles.net - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: MailBox Manager Tests performance
On 17/10/11 13:42, Manuel Carrasco Moñino wrote: ... Maybe this test could be expanded to test more mailbox operations and not only append 200 simple messages, for instance large attachments, read, delete, folder manipulation etc. Makes sense. We just need to take care to not replicate the same kind of tests in different base tests. Eric - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
MailBox Manager Tests performance
Hi all, Is the Manager Test useful to measure performance? Testing the the couchdb implementation Pepijn is working on, I've released that some implementations takes a long to run the tests (see attached screenshot): InMemory 0.7s MailDir 2.4s JPA 6.0s JCR 21.1s CouchDB 40.4s HBase 81.8s JPA uses a ddbb in memory, CouchDB is not optimized at all, but Is there any reason why jcr and hbase takes so long? - Manolo - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: MailBox Manager Tests performance
2011/10/16 Manuel Carrasco Moñino man...@apache.org: Hi all, Is the Manager Test useful to measure performance? Testing the the couchdb implementation Pepijn is working on, I've released that some implementations takes a long to run the tests (see attached screenshot): InMemory 0.7s MailDir 2.4s JPA 6.0s JCR 21.1s CouchDB 40.4s HBase 81.8s JPA uses a ddbb in memory, CouchDB is not optimized at all, but Is there any reason why jcr and hbase takes so long? Don't know how you test this, but if you include startup and warmup times then it is expected that more complex layers will take longer to startup. Maybe you should run the tests 1000 times or make sure you at least run them twice and only measure timings for the second time (and exclude startup times). Does this make sense? Stefano - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: MailBox Manager Tests performance
Thanks Stefano I just run once each test. I know there is a overhead when running setup and teardown, what I do not know is if the test could be useful for performance, subtracting the setup/teardown times and looping it. - Manolo On Sun, Oct 16, 2011 at 5:05 PM, Stefano Bagnara apa...@bago.org wrote: 2011/10/16 Manuel Carrasco Moñino man...@apache.org: Hi all, Is the Manager Test useful to measure performance? Testing the the couchdb implementation Pepijn is working on, I've released that some implementations takes a long to run the tests (see attached screenshot): InMemory 0.7s MailDir 2.4s JPA 6.0s JCR 21.1s CouchDB 40.4s HBase 81.8s JPA uses a ddbb in memory, CouchDB is not optimized at all, but Is there any reason why jcr and hbase takes so long? Don't know how you test this, but if you include startup and warmup times then it is expected that more complex layers will take longer to startup. Maybe you should run the tests 1000 times or make sure you at least run them twice and only measure timings for the second time (and exclude startup times). Does this make sense? Stefano - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Mailbox(Manager)
Hi Tim, I agree it should get moved out of the imap namespace. I delayed that to make it not do complicated by just introduce another dependency on a mini-library. But yeah its something we should do... Bye, Norman 2010/5/29 Tim-Christian Mundt d...@tim-erwin.de: Hi, since both IMAP and POP3 use the same backend, now (https://issues.apache.org/jira/browse/JAMES-983), shouldn't the storage packages rather be moved from the IMAP library to the server module? They are not IMAP specific any more. Maybe, they could get their own mailstore library which both the IMAP library and the server depend on. Regards Tim - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Mailbox(Manager)
Hey, when doing this, we could as well unify the artifact names. We have names like apache-james-imap-* (both, apache and james) james-server-* (only james) apache-mailet-* (only apache) I'm aware that this is no particularly helpful/urgent contribution of mine, but in the long term consistency and a clear structure pay out, I think. Let me know if I can be of any help with this. Tim Am Samstag, den 29.05.2010, 09:36 +0200 schrieb Norman Maurer: Hi Tim, I agree it should get moved out of the imap namespace. I delayed that to make it not do complicated by just introduce another dependency on a mini-library. But yeah its something we should do... Bye, Norman 2010/5/29 Tim-Christian Mundt d...@tim-erwin.de: Hi, since both IMAP and POP3 use the same backend, now (https://issues.apache.org/jira/browse/JAMES-983), shouldn't the storage packages rather be moved from the IMAP library to the server module? They are not IMAP specific any more. Maybe, they could get their own mailstore library which both the IMAP library and the server depend on. Regards Tim - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Re: Mailbox(Manager)
Hi, I also personally found that the 2 mentioned goals would be fine before 3.0 release: 1.- Migrate imap projects/packages to store and protocol. 2.- Uniform the current apache-... james-... namings. And, yes, in the middle-term, it would be much cleaner. Now, when you talk about apache-james-imap-store, you need to translate the project responsible to access the different mail stores. During some time, I was really confused about this. On the other hand, mailet and jsieve projects are just released with current naming and the amount of work to migrate/rename is really huge without any user functionality counterpart. As Tim, I was also asking-party for a migration and uniform naming. But I just feel now that we should concentrate on releasing 3.0, trying to find and solve bugs in trunk. If we release, we should have more users, helping us to solve issues. The migration and renaming could be strong goals for 3.1 in a near future. Maybe we should in priority have a list of JIRA still to solve before releasing. I also find that the website documentation needs some urgent updates (how to setup and use james 3.0). Tks, Eric On 05/29/2010 12:08 PM, Tim-Christian Mundt wrote: Hey, when doing this, we could as well unify the artifact names. We have names like apache-james-imap-* (both, apache and james) james-server-* (only james) apache-mailet-* (only apache) I'm aware that this is no particularly helpful/urgent contribution of mine, but in the long term consistency and a clear structure pay out, I think. Let me know if I can be of any help with this. Tim Am Samstag, den 29.05.2010, 09:36 +0200 schrieb Norman Maurer: Hi Tim, I agree it should get moved out of the imap namespace. I delayed that to make it not do complicated by just introduce another dependency on a mini-library. But yeah its something we should do... Bye, Norman 2010/5/29 Tim-Christian Mundtd...@tim-erwin.de: Hi, since both IMAP and POP3 use the same backend, now (https://issues.apache.org/jira/browse/JAMES-983), shouldn't the storage packages rather be moved from the IMAP library to the server module? They are not IMAP specific any more. Maybe, they could get their own mailstore library which both the IMAP library and the server depend on. Regards Tim - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
Mailbox(Manager)
Hi, since both IMAP and POP3 use the same backend, now (https://issues.apache.org/jira/browse/JAMES-983), shouldn't the storage packages rather be moved from the IMAP library to the server module? They are not IMAP specific any more. Maybe, they could get their own mailstore library which both the IMAP library and the server depend on. Regards Tim - To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
