Re: [Server-devel] [Sugar-devel] Backup and Restore for Sugar on a Stick
On Thu, Aug 6, 2009 at 3:29 PM, Caroline Meeks wrote: > This email is especially for Miguel Salazar and the Chiapas deployment. > The code for backup and restore of Sugar Sticks using the XS is awaiting > code review, if you can please test it. > http://dev.sugarlabs.org/ticket/916 > http://dev.sugarlabs.org/ticket/1124 Right - reviewed, sorry about the latency. In general, the patches are good. There is a little list of minor things. None major but I think they're worth addressing. cheers, m -- martin.langh...@gmail.com mar...@laptop.org -- School Server Architect - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff ___ Server-devel mailing list Server-devel@lists.laptop.org http://lists.laptop.org/listinfo/server-devel
Re: [Server-devel] [Sugar-devel] Backup and Restore for Sugar on a Stick
> > but I'm programming them in > > such a way that they should not break if Sugar is running on SoaS. > > I'm confused, did you meant to say not break if _not_ running on SoaS? Haha, yes sorry. I meant that it should not break when running in an OLPC Laptop :-) ___ Server-devel mailing list Server-devel@lists.laptop.org http://lists.laptop.org/listinfo/server-devel
Re: [Server-devel] [Sugar-devel] Backup and Restore for Sugar on a Stick
On Sat, Aug 8, 2009 at 6:07 AM, Tomeu Vizoso wrote: > I'm confused, did you meant to say not break if _not_ running on SoaS? I've asked for a rework on the patch so that it works on the olpc os (w sugar 0.82) as well as on SoaS. The compat needs are easy so I rather have an if() clause here and there than 2 packages, one for each. cheers, m -- martin.langh...@gmail.com mar...@laptop.org -- School Server Architect - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff ___ Server-devel mailing list Server-devel@lists.laptop.org http://lists.laptop.org/listinfo/server-devel
Re: [Server-devel] [Sugar-devel] Backup and Restore for Sugar on a Stick
On Sat, Aug 8, 2009 at 12:01, Hamilton Chua wrote: > Hello Tomeu, > > The modifications are intended for SoaS only So you don't want the patches to be applied to upstream Sugar? Only to be in SoaS images? > but I'm programming them in > such a way that they should not break if Sugar is running on SoaS. I'm confused, did you meant to say not break if _not_ running on SoaS? > Although I already have patches in the form of diffs, they were not > created using 'git format-patch. I've read the code review procedures > and will get to work making the preparations. Thanks, feedback about the process and its documentation is much appreciated. Tomeu > Thanks, > > Ham > > On Fri, 2009-08-07 at 10:39 +0200, Tomeu Vizoso wrote: >> On Thu, Aug 6, 2009 at 15:29, Caroline Meeks >> wrote: >> > This email is especially for Miguel Salazar and the Chiapas deployment. >> > The code for backup and restore of Sugar Sticks using the XS is awaiting >> > code review, if you can please test it. >> > http://dev.sugarlabs.org/ticket/916 >> > http://dev.sugarlabs.org/ticket/1124 >> >> Is it intended to be integrated in Sugar? Or only for SoaS? >> >> If it's for Sugar, then please follow the review process outlined here: >> >> http://wiki.sugarlabs.org/go/Development_Team/CodeReview >> >> Thanks, >> >> Tomeu >> >> > Thanks, >> > Caroline >> > >> > -- >> > Caroline Meeks >> > Solution Grove >> > carol...@solutiongrove.com >> > >> > 617-500-3488 - Office >> > 505-213-3268 - Fax >> > >> > ___ >> > Sugar-devel mailing list >> > sugar-de...@lists.sugarlabs.org >> > http://lists.sugarlabs.org/listinfo/sugar-devel >> > >> > > > ___ Server-devel mailing list Server-devel@lists.laptop.org http://lists.laptop.org/listinfo/server-devel
Re: [Server-devel] [Sugar-devel] Backup and Restore for Sugar on a Stick
Hello Tomeu, The modifications are intended for SoaS only but I'm programming them in such a way that they should not break if Sugar is running on SoaS. Although I already have patches in the form of diffs, they were not created using 'git format-patch. I've read the code review procedures and will get to work making the preparations. Thanks, Ham On Fri, 2009-08-07 at 10:39 +0200, Tomeu Vizoso wrote: > On Thu, Aug 6, 2009 at 15:29, Caroline Meeks > wrote: > > This email is especially for Miguel Salazar and the Chiapas deployment. > > The code for backup and restore of Sugar Sticks using the XS is awaiting > > code review, if you can please test it. > > http://dev.sugarlabs.org/ticket/916 > > http://dev.sugarlabs.org/ticket/1124 > > Is it intended to be integrated in Sugar? Or only for SoaS? > > If it's for Sugar, then please follow the review process outlined here: > > http://wiki.sugarlabs.org/go/Development_Team/CodeReview > > Thanks, > > Tomeu > > > Thanks, > > Caroline > > > > -- > > Caroline Meeks > > Solution Grove > > carol...@solutiongrove.com > > > > 617-500-3488 - Office > > 505-213-3268 - Fax > > > > ___ > > Sugar-devel mailing list > > sugar-de...@lists.sugarlabs.org > > http://lists.sugarlabs.org/listinfo/sugar-devel > > > > ___ Server-devel mailing list Server-devel@lists.laptop.org http://lists.laptop.org/listinfo/server-devel
Re: [Server-devel] [Sugar-devel] Backup and Restore for Sugar on a Stick
On Thu, Aug 6, 2009 at 15:29, Caroline Meeks wrote: > This email is especially for Miguel Salazar and the Chiapas deployment. > The code for backup and restore of Sugar Sticks using the XS is awaiting > code review, if you can please test it. > http://dev.sugarlabs.org/ticket/916 > http://dev.sugarlabs.org/ticket/1124 Is it intended to be integrated in Sugar? Or only for SoaS? If it's for Sugar, then please follow the review process outlined here: http://wiki.sugarlabs.org/go/Development_Team/CodeReview Thanks, Tomeu > Thanks, > Caroline > > -- > Caroline Meeks > Solution Grove > carol...@solutiongrove.com > > 617-500-3488 - Office > 505-213-3268 - Fax > > ___ > Sugar-devel mailing list > sugar-de...@lists.sugarlabs.org > http://lists.sugarlabs.org/listinfo/sugar-devel > > ___ Server-devel mailing list Server-devel@lists.laptop.org http://lists.laptop.org/listinfo/server-devel
