hg: jdk8/tl/nashorn: 4 new changesets
Changeset: 6fc7b51e83d6 Author:lagergren Date: 2013-05-23 15:51 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6fc7b51e83d6 8012522: Clean up lexical contexts - split out stack based functionality in CodeGenerator and generify NodeVisitors based on their LexicalContext type to avoid casts Reviewed-by: attila, jlaskey ! src/jdk/nashorn/internal/codegen/Attr.java ! src/jdk/nashorn/internal/codegen/CodeGenerator.java + src/jdk/nashorn/internal/codegen/CodeGeneratorLexicalContext.java ! src/jdk/nashorn/internal/codegen/CompilationPhase.java ! src/jdk/nashorn/internal/codegen/FinalizeTypes.java ! src/jdk/nashorn/internal/codegen/FoldConstants.java ! src/jdk/nashorn/internal/codegen/Lower.java ! src/jdk/nashorn/internal/codegen/RangeAnalyzer.java ! src/jdk/nashorn/internal/codegen/SharedScopeCall.java ! src/jdk/nashorn/internal/codegen/Splitter.java ! src/jdk/nashorn/internal/codegen/WeighNodes.java ! src/jdk/nashorn/internal/ir/AccessNode.java ! src/jdk/nashorn/internal/ir/BinaryNode.java ! src/jdk/nashorn/internal/ir/Block.java ! src/jdk/nashorn/internal/ir/BreakNode.java ! src/jdk/nashorn/internal/ir/CallNode.java ! src/jdk/nashorn/internal/ir/CaseNode.java ! src/jdk/nashorn/internal/ir/CatchNode.java ! src/jdk/nashorn/internal/ir/ContinueNode.java ! src/jdk/nashorn/internal/ir/EmptyNode.java ! src/jdk/nashorn/internal/ir/ExecuteNode.java ! src/jdk/nashorn/internal/ir/ForNode.java ! src/jdk/nashorn/internal/ir/FunctionNode.java ! src/jdk/nashorn/internal/ir/IdentNode.java ! src/jdk/nashorn/internal/ir/IfNode.java ! src/jdk/nashorn/internal/ir/IndexNode.java ! src/jdk/nashorn/internal/ir/LabelNode.java ! src/jdk/nashorn/internal/ir/LexicalContextNode.java ! src/jdk/nashorn/internal/ir/LiteralNode.java ! src/jdk/nashorn/internal/ir/Node.java ! src/jdk/nashorn/internal/ir/ObjectNode.java ! src/jdk/nashorn/internal/ir/PropertyNode.java ! src/jdk/nashorn/internal/ir/ReturnNode.java ! src/jdk/nashorn/internal/ir/RuntimeNode.java ! src/jdk/nashorn/internal/ir/SplitNode.java ! src/jdk/nashorn/internal/ir/SwitchNode.java ! src/jdk/nashorn/internal/ir/TernaryNode.java ! src/jdk/nashorn/internal/ir/ThrowNode.java ! src/jdk/nashorn/internal/ir/TryNode.java ! src/jdk/nashorn/internal/ir/UnaryNode.java ! src/jdk/nashorn/internal/ir/VarNode.java ! src/jdk/nashorn/internal/ir/WhileNode.java ! src/jdk/nashorn/internal/ir/WithNode.java ! src/jdk/nashorn/internal/ir/debug/JSONWriter.java ! src/jdk/nashorn/internal/ir/debug/PrintVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeOperatorVisitor.java ! src/jdk/nashorn/internal/ir/visitor/NodeVisitor.java ! src/jdk/nashorn/internal/objects/ArrayBufferView.java ! src/jdk/nashorn/internal/runtime/DebugLogger.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterClassLoader.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterFactory.java ! src/jdk/nashorn/internal/runtime/linker/JavaAdapterGeneratorBase.java Changeset: fdfb4edd78d6 Author:hannesw Date: 2013-05-24 13:54 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/fdfb4edd78d6 8011630: JSON parsing performance issue Reviewed-by: lagergren, sundar ! src/jdk/nashorn/internal/objects/NativeArguments.java ! src/jdk/nashorn/internal/runtime/AccessorProperty.java ! src/jdk/nashorn/internal/runtime/FindProperty.java ! src/jdk/nashorn/internal/runtime/Property.java ! src/jdk/nashorn/internal/runtime/ScriptObject.java ! src/jdk/nashorn/internal/runtime/SetMethodCreator.java ! src/jdk/nashorn/internal/runtime/UserAccessorProperty.java Changeset: 4d2eca4d4d66 Author:sundar Date: 2013-05-24 18:39 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/4d2eca4d4d66 8015354: JSON.parse should not use [[Put]] but use [[DefineOwnProperty]] instead Reviewed-by: lagergren, hannesw ! src/jdk/nashorn/internal/objects/NativeFloat32Array.java ! src/jdk/nashorn/internal/objects/NativeFloat64Array.java ! src/jdk/nashorn/internal/objects/NativeInt16Array.java ! src/jdk/nashorn/internal/objects/NativeInt32Array.java ! src/jdk/nashorn/internal/objects/NativeInt8Array.java ! src/jdk/nashorn/internal/objects/NativeUint16Array.java ! src/jdk/nashorn/internal/objects/NativeUint32Array.java ! src/jdk/nashorn/internal/objects/NativeUint8Array.java ! src/jdk/nashorn/internal/objects/NativeUint8ClampedArray.java ! src/jdk/nashorn/internal/runtime/JSONFunctions.java ! src/jdk/nashorn/internal/runtime/Property.java + test/script/basic/JDK-8015354.js Changeset: 751cfefff5eb Author:sundar Date: 2013-05-24 23:27 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/751cfefff5eb 8015351: Nashorn shell does not start with Turkish locale Reviewed-by: jlaskey ! make/project.properties ! src/jdk/nashorn/internal/runtime/options/OptionTemplate.java
RFR 8014506: Test for Jdp (Java Discovery Protocol) feature
Please review these tests for the Jdp protocol. There are three cases: 1) Jdp is off. 2) Jdp is on and using default address and port. 3) Jdp is on using custom address and port. Tests: http://cr.openjdk.java.net/~nloodin/8014506/webrev.00/ http://cr.openjdk.java.net/%7Enloodin/8014506/webrev.00/ Jdp feature enhancement: https://jbs.oracle.com/bugs/browse/JDK-8002048 JDK CCC: http://ccc.us.oracle.com/8002048 Thanks in advance! -- Alex Schenkman Java VM SQE Stockholm
Re: jmx-dev [PATCH] JDK-8005472: com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.sh failed on windows
On 18/05/2013 01:09, Stuart Marks wrote: On 5/15/13 1:12 PM, Jaroslav Bachorik wrote: Ok. I've changed it to use AtomicBoolean Thanks for pointing this out. Even though it's rather obvious I got so used to using the final array in anonymous inner classes that I didn't even stop and think. BTW, there are a lot of places in the tests using this idiom in potentially multithreaded environment :( Hrrm. OK, well, let's fix one test at a time. :-) Updated webrev - http://cr.openjdk.java.net/~jbachorik/8005472/webrev.10 Thanks for the update. I took a quick look at it seems fine now. I think Chris may need to be the OpenJDK Reviewer on this one. I've been over the archives to re-read the complete review thread on this. All in all, it is a thumbs up from me too. -Chris. s'marks
hg: jdk8/tl/jdk: 7038914: VM could throw uncaught OOME in ReferenceHandler thread
Changeset: 0b8dab7fec54 Author:plevart Date: 2013-05-27 09:41 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0b8dab7fec54 7038914: VM could throw uncaught OOME in ReferenceHandler thread Summary: Catch OutOfMemoryError in reference handler thread if caused by allocation of an InterruptedException Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/ref/Reference.java + test/java/lang/ref/OOMEInReferenceHandler.java
hg: jdk8/tl/jdk: 8014394: (fs) WatchService failing when watching \\server\$d
Changeset: d78f91ab0e96 Author:uta Date: 2013-05-27 15:18 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d78f91ab0e96 8014394: (fs) WatchService failing when watching \\server\$d Reviewed-by: alanb ! src/windows/classes/sun/nio/fs/WindowsConstants.java ! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java ! src/windows/classes/sun/nio/fs/WindowsWatchService.java ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c
hg: jdk8/tl/langtools: 7030476: Fix conflicting use of JCTree/JCExpression
Changeset: b391ecea538e Author:vromero Date: 2013-05-27 13:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b391ecea538e 7030476: Fix conflicting use of JCTree/JCExpression Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java
Re: RFR: 8009681: TEST_BUG: MethodExitReturnValuesTest.java fails with when there are unexpected background threads
I think this looks excellent. I can sponsor the change. Regards, Nils Loodin On 04/17/2013 03:03 PM, Mikael Auno wrote: Hi, I'd like some reviews on http://cr.openjdk.java.net/~nloodin/8009681/webrev.01/ for JDK-8009681 (http://bugs.sun.com/view_bug.do?bug_id=8009681). The issue here is that when MethodExitReturnValuesTest hooks into MethodExit events through JDI it uses an exclude list to filter out classes from which it is not interested in these events. This is bound to break over and over again as new features are added to the JDK. I've changed the test to use an include list instead, containing only the handful of classes the test is actually interested in. Thanks, Mikael
hg: jdk8/tl/jdk: 2 new changesets
Changeset: a2dc42667df3 Author:chegar Date: 2013-05-27 14:00 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a2dc42667df3 8015439: Minor/sync/cleanup of ConcurrentHashMap Reviewed-by: chegar Contributed-by: Doug Lea d...@cs.oswego.edu, Chris Hegarty chris.hega...@oracle.com ! src/share/classes/java/util/concurrent/ConcurrentHashMap.java Changeset: 9bbf2237071e Author:chegar Date: 2013-05-27 15:24 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9bbf2237071e Merge
Re: RFR 6470730: Disconnect button leads to wrong popup message
Could you please chime in? :) /Nisse On 05/24/2013 06:33 PM, Staffan Larsen wrote: Looks good, but the indentation is wrong in one place. /Staffan On 24 maj 2013, at 16:13, Nils Loodin nils.loo...@oracle.com wrote: Simple fix not to add a confusing dialog. Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 Webrev: http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ Regards, Nils Loodin
Re: RFR 6470730: Disconnect button leads to wrong popup message
Sure! Chime!!! http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ src/share/classes/sun/tools/jconsole/VMPanel.java No comments (presuming you fix the indentation on lines 458-459) Thumbs up! FYI: Mandy Chung is the person to ping if/when you have a more complicated jconsole fix... Dan On 5/27/13 8:34 AM, Nils Loodin wrote: Could you please chime in? :) /Nisse On 05/24/2013 06:33 PM, Staffan Larsen wrote: Looks good, but the indentation is wrong in one place. /Staffan On 24 maj 2013, at 16:13, Nils Loodin nils.loo...@oracle.com wrote: Simple fix not to add a confusing dialog. Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 Webrev: http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ Regards, Nils Loodin
hg: jdk8/tl/jdk: 6470730: Disconnect button leads to wrong popup message
Changeset: bbf6e6222726 Author:nloodin Date: 2013-05-27 17:10 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bbf6e6222726 6470730: Disconnect button leads to wrong popup message Reviewed-by: dcubed, sla, egahlin ! src/share/classes/sun/tools/jconsole/VMPanel.java
hg: hsx/hotspot-rt/hotspot: 8015270: @Contended: fix multiple issues in the layout code
Changeset: 3970971c91e0 Author:shade Date: 2013-05-27 12:49 -0700 URL: http://hg.openjdk.java.net/hsx/hotspot-rt/hotspot/rev/3970971c91e0 8015270: @Contended: fix multiple issues in the layout code Summary: field count handling fixed, has_nonstatic_fields invariant fixed, oop map overrun fixed; new asserts Reviewed-by: kvn, dcubed, coleenp ! src/share/vm/classfile/classFileParser.cpp + test/runtime/contended/HasNonStatic.java + test/runtime/contended/OopMaps.java
Re: RFR 6470730: Disconnect button leads to wrong popup message
Looks good to me too except the indentation as Staffan pointed out (line 458-459) Mandy On 5/27/2013 7:47 AM, Daniel D. Daugherty wrote: Sure! Chime!!! http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ src/share/classes/sun/tools/jconsole/VMPanel.java No comments (presuming you fix the indentation on lines 458-459) Thumbs up! FYI: Mandy Chung is the person to ping if/when you have a more complicated jconsole fix... Dan On 5/27/13 8:34 AM, Nils Loodin wrote: Could you please chime in? :) /Nisse On 05/24/2013 06:33 PM, Staffan Larsen wrote: Looks good, but the indentation is wrong in one place. /Staffan On 24 maj 2013, at 16:13, Nils Loodin nils.loo...@oracle.com wrote: Simple fix not to add a confusing dialog. Bug: https://jbs.oracle.com/bugs/browse/JDK-6470730 Webrev: http://cr.openjdk.java.net/~nloodin/6470730/webrev.00/ Regards, Nils Loodin
