Re: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public
On 2013-11-08 00:40, Mandy Chung wrote: com.sun.management API is an exported API [1] except com.sun.management.OSMBeanFactory class which is an implementation-specific class and it's currently annotated as @jdk.Exported(false) [2]. This patch will eliminate one use of @jdk.Exported(false). This is simply refactoring of the existing implementation: o remove com.sun.management.OSMBeanFactory o move the implementation classes to sun.management including - rename com.sun.management.UnixOperatingSystemImpl (or OperatingSystem windows version) to sun.management.OperatingSystemImpl along with its native implementation - sun.management.ManagementFactoryHelper creates the sun.management.OperatingSystemImpl instance directly (no need of the factory OSMBeanFactory method) I'm including build-dev as there are changes in the makefiles. Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8025985/webrev.00/ The makefile changes look good. /Magnus
Re: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public
On 08/11/2013 08:40, Jaroslav Bachorik wrote: AbstractOperatingSystemImpl should be an abstract class as its name already indicates. Right, it probably should be something like BaseOperatingSystemImpl. Otherwise it looks good to me too. -Alan.
RFR (XS): 8023138: [TEST_BUG] java/lang/instrument/PremainClass/NoPremainAgent.sh fails intermittently
Hi, Could you please review this fix. The tests for java/lang/instrument/PremainClass/PremainAgent has been ported from script to java. The purpose is to make the tests more stable and easier to maintain. Thanks, Mattias Webrev: http://cr.openjdk.java.net/~ykantser/8023138/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8023138
Removal of sample code from tools.jar
Regarding bug JDK-8008602: Sample code in tools.jar. Does anyone have any insight in whether or not the JPDA example code in com.sun.tools.example.** should be kept, or if should be removed altogether? AFAIK no code outside of the example package depends upon it. The build does however fail with make[2]: *** No rule to make target `.../tl/jdk/src/share/classes/com/sun/tools/example/README', needed by `.../tl/build/linux-x86_64-normal-server-release/jdk/demo/jpda/com/sun/tools/example/README'. Stop. and I can't find the reason while browsing / grepping in the make files. Any input on the matter would be greately appreciated. best regardrs, Andreas Lundblad
Re: Review request for 8025985: com.sun.management.OSMBeanFactory should not be public
Thanks you all for the review. I'll rename AbstractOperatingSystemImpl before I push. Mandy On 11/8/2013 5:22 AM, Alan Bateman wrote: On 08/11/2013 08:40, Jaroslav Bachorik wrote: AbstractOperatingSystemImpl should be an abstract class as its name already indicates. Right, it probably should be something like BaseOperatingSystemImpl. Otherwise it looks good to me too. -Alan.
hg: jdk8/tl/jdk: 8027351: (ref) Private finalize method invoked in preference to protected superclass method
Changeset: 41d7ce111bd8 Author:mchung Date: 2013-11-08 07:53 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d7ce111bd8 8027351: (ref) Private finalize method invoked in preference to protected superclass method Reviewed-by: alanb, dholmes, mr, plevart, psandoz ! makefiles/lib/CoreLibraries.gmk ! makefiles/mapfiles/libjava/mapfile-vers ! makefiles/mapfiles/libjava/reorder-sparc ! makefiles/mapfiles/libjava/reorder-sparcv9 ! makefiles/mapfiles/libjava/reorder-x86 ! src/share/classes/java/lang/System.java ! src/share/classes/java/lang/ref/Finalizer.java ! src/share/classes/sun/misc/JavaLangAccess.java ! src/share/classes/sun/misc/VM.java + test/java/lang/ref/FinalizeOverride.java
RFR, fix for 8027914, compact1/2 VM exits silently with -Dcom.sun.management argument
If you are running a non-minimal VM build with compact 1 or 2 JRE and you pass in -Dcom.sun.management argument, VM will exit silently with exit code 1. Fix adds an error check when attempting to load the class sun.management.Agent (missing from compact 1 and 2) and will print a message before exiting. http://cr.openjdk.java.net/~bpittore/8027914/webrev.00/ thanks, bill
Re: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature
Hi list, Latest version is up for review here [1]. It fixes Staffan's latest comments (see below), as well as some indentation and tab/spaces nits. Thanks! [1] http://cr.openjdk.java.net/~miauno/8014506/ http://cr.openjdk.java.net/%7Emiauno/8014506/ On 2013-10-30 16:03, Staffan Larsen wrote: Alex, This looks much better! Thanks for spending the time. README: nit: contribuited - contributed JdpTestUtilTest.java: Can you add a comment saying this is a test for the tests - just like PacketTest.java and PortAlreadyInUseTest.java? PortFinder.java: Please remove this and use Utils.getFreePort() since ykantser's fix is now pushed. Thanks, /Staffan On 29 okt 2013, at 15:53, Alex Schenkman alex.schenk...@oracle.com mailto:alex.schenk...@oracle.com wrote: Hi Staffan, There is a new webrev here [1], addressing your comments. The Jdp specs have changed a bit, adding three optional fields to the Jdp packet [2]. The JEP-168 [3] is not updated yet, but Dmitry will do it soon. This enhancement request is tracking the changes needed for SQE [4]. See inlined answers for details on your previos comments, please. Thanks! [1] http://cr.openjdk.java.net/~dsamersoff/sponsorship/aschenkman/8014506/webrev.04/ http://cr.openjdk.java.net/%7Edsamersoff/sponsorship/aschenkman/8014506/webrev.04/ [2] https://bugs.openjdk.java.net/browse/JDK-8004213 [3] http://openjdk.java.net/jeps/168 [4] https://bugs.openjdk.java.net/browse/JDK-8027436 On 2013-10-24 10:54, Staffan Larsen wrote: Alex, test/sun/management/jdp/README Thanks for providing a README! References to JDK-7169888 seem incorrect to me. L8: written by appears twice. L11: defautl - default Fixed. test/lib/testlibrary/jdk/testlibrary/PortFinder.java This should be coordinated with the review for 809 which contains the same code in a different testlibrary class: http://cr.openjdk.java.net/~ykantser/809/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html http://cr.openjdk.java.net/%7Eykantser/809/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html I made a private copy of this function, and have marked it as deprecated. As soon as ykanster's code is merged I can delete my private function and use the library. The reason for this is to get this patch pushed without further delay. test/sun/management/jdp/7169888/JdpClient.java test/sun/management/jdp/7169888/JdpDoSomething.java test/sun/management/jdp/7169888/JdpTest.sh test/sun/management/jdp/7169888/JdpUnitTest.java These were moved to a subdirectory, but these tests have nothing to do with bug 7169888, so why that name? In any case we should avoid naming test directories after bug ids, and instead use a descriptive name. This bug number was wrong. These tests were now moved back to the jdp folder. I have expanded the README file with some details about these tests. Dmitry's shell-based are as follows: test_01 - basic test, check if JDP packet assembler and other parts of JDP is not broken test_02 - test if JDP starts with custom parameters. test_03 - test if jcmd is able to start jdp with custom parameters (disabled) test_04 - test if JDP starts with default parameters test_05 - test if jcmd is able to start jdp with default parameters (disabled) test_03 and test_05 are diabled becuase there is a mismatch between hotsport and jdk repos, according to Dmitry. These cases (jcmd) are not covered by this patch, and are part of the test enhacements [4]. test_01 does partly overlap with the Java-based tests, but we should keep it until we implement the latest enhacements [4]. test/sun/management/jdp/ClientConnection.java No comments. test/sun/management/jdp/DefaultLauncher.java Can @library ../../../lib/testlibrary be replaced by @library /lib/testlibrary ? Fixed. test/sun/management/jdp/OffLauncher.java Can @library ../../../lib/testlibrary be replaced by @library /lib/testlibrary ? Fixed. test/sun/management/jdp/SpecificJdpAddressLauncher.java Can @library ../../../lib/testlibrary be replaced by @library /lib/testlibrary ? Fixed. test/sun/management/jdp/DynamicLauncher.java No comments. Fixed. test/sun/management/jdp/JdpOffTest.java For the future: it is customary that the file containing the jtreg directives be named xxxTest.java, and supporting files not ending in Test. I have renamed the tests following your recomendation. Jtreg tests have now the test suffix. test/sun/management/jdp/JdpOnTest.java For the future: it is customary that the file containing the jtreg directives be named xxxTest.java, and supporting files not ending in Test. Same as above. test/sun/management/jdp/JdpTest.java No comments. test/sun/management/jdp/JdpTestUtil.java No comments. test/sun/management/jdp/JdpTestUtilTest.java test/sun/management/jdp/PacketTest.java test/sun/management/jdp/PortAlreadyInUseTest.java These are tests for the tests. But where
hg: jdk8/tl/jdk: 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface
Changeset: 3112729d6b74 Author:tyan Date: 2013-11-08 15:12 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3112729d6b74 8022963: java/net/NetworkInterface/Equals.java fails equality for Windows Teredo Interface Reviewed-by: chegar ! test/java/net/MulticastSocket/TestInterfaces.java ! test/java/net/NetworkInterface/Equals.java
hg: jdk8/tl/jdk: 8019834: InetAddress.getByName hangs for bad IPv6 literals
Changeset: 771c77b49bb6 Author:chegar Date: 2013-11-08 15:15 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/771c77b49bb6 8019834: InetAddress.getByName hangs for bad IPv6 literals Reviewed-by: alanb ! src/share/classes/java/net/InetAddress.java ! test/java/net/ipv6tests/BadIPv6Addresses.java
Re: RFR 8014506: Test for Jdp (Java Discovery Protocol) feature
There was some unintended whitespace changes in webrev.05 that Alex had missed. I removed them and uploaded webrev.06 for him. http://cr.openjdk.java.net/~miauno/8014506/webrev.06/ Mikael On 2013-11-08 17:02, Alex Schenkman wrote: Hi list, Latest version is up for review here [1]. It fixes Staffan's latest comments (see below), as well as some indentation and tab/spaces nits. Thanks! [1] http://cr.openjdk.java.net/~miauno/8014506/ http://cr.openjdk.java.net/%7Emiauno/8014506/ On 2013-10-30 16:03, Staffan Larsen wrote: Alex, This looks much better! Thanks for spending the time. README: nit: contribuited - contributed JdpTestUtilTest.java: Can you add a comment saying this is a test for the tests - just like PacketTest.java and PortAlreadyInUseTest.java? PortFinder.java: Please remove this and use Utils.getFreePort() since ykantser's fix is now pushed. Thanks, /Staffan On 29 okt 2013, at 15:53, Alex Schenkman alex.schenk...@oracle.com mailto:alex.schenk...@oracle.com wrote: Hi Staffan, There is a new webrev here [1], addressing your comments. The Jdp specs have changed a bit, adding three optional fields to the Jdp packet [2]. The JEP-168 [3] is not updated yet, but Dmitry will do it soon. This enhancement request is tracking the changes needed for SQE [4]. See inlined answers for details on your previos comments, please. Thanks! [1] http://cr.openjdk.java.net/~dsamersoff/sponsorship/aschenkman/8014506/webrev.04/ http://cr.openjdk.java.net/%7Edsamersoff/sponsorship/aschenkman/8014506/webrev.04/ [2] https://bugs.openjdk.java.net/browse/JDK-8004213 [3] http://openjdk.java.net/jeps/168 [4] https://bugs.openjdk.java.net/browse/JDK-8027436 On 2013-10-24 10:54, Staffan Larsen wrote: Alex, test/sun/management/jdp/README Thanks for providing a README! References to JDK-7169888 seem incorrect to me. L8: written by appears twice. L11: defautl - default Fixed. test/lib/testlibrary/jdk/testlibrary/PortFinder.java This should be coordinated with the review for 809 which contains the same code in a different testlibrary class: http://cr.openjdk.java.net/~ykantser/809/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html http://cr.openjdk.java.net/%7Eykantser/809/webrev.01/test/lib/testlibrary/jdk/testlibrary/Utils.java.html I made a private copy of this function, and have marked it as deprecated. As soon as ykanster's code is merged I can delete my private function and use the library. The reason for this is to get this patch pushed without further delay. test/sun/management/jdp/7169888/JdpClient.java test/sun/management/jdp/7169888/JdpDoSomething.java test/sun/management/jdp/7169888/JdpTest.sh test/sun/management/jdp/7169888/JdpUnitTest.java These were moved to a subdirectory, but these tests have nothing to do with bug 7169888, so why that name? In any case we should avoid naming test directories after bug ids, and instead use a descriptive name. This bug number was wrong. These tests were now moved back to the jdp folder. I have expanded the README file with some details about these tests. Dmitry's shell-based are as follows: test_01 - basic test, check if JDP packet assembler and other parts of JDP is not broken test_02 - test if JDP starts with custom parameters. test_03 - test if jcmd is able to start jdp with custom parameters (disabled) test_04 - test if JDP starts with default parameters test_05 - test if jcmd is able to start jdp with default parameters (disabled) test_03 and test_05 are diabled becuase there is a mismatch between hotsport and jdk repos, according to Dmitry. These cases (jcmd) are not covered by this patch, and are part of the test enhacements [4]. test_01 does partly overlap with the Java-based tests, but we should keep it until we implement the latest enhacements [4]. test/sun/management/jdp/ClientConnection.java No comments. test/sun/management/jdp/DefaultLauncher.java Can @library ../../../lib/testlibrary be replaced by @library /lib/testlibrary ? Fixed. test/sun/management/jdp/OffLauncher.java Can @library ../../../lib/testlibrary be replaced by @library /lib/testlibrary ? Fixed. test/sun/management/jdp/SpecificJdpAddressLauncher.java Can @library ../../../lib/testlibrary be replaced by @library /lib/testlibrary ? Fixed. test/sun/management/jdp/DynamicLauncher.java No comments. Fixed. test/sun/management/jdp/JdpOffTest.java For the future: it is customary that the file containing the jtreg directives be named xxxTest.java, and supporting files not ending in Test. I have renamed the tests following your recomendation. Jtreg tests have now the test suffix. test/sun/management/jdp/JdpOnTest.java For the future: it is customary that the file containing the jtreg directives be named xxxTest.java, and supporting files not ending in Test. Same as above. test/sun/management/jdp/JdpTest.java No comments.
hg: jdk8/tl/jdk: 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351
Changeset: 1c9ba18198d5 Author:mchung Date: 2013-11-08 09:43 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c9ba18198d5 8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351 Reviewed-by: alanb - src/share/native/java/lang/ref/Finalizer.c
hg: jdk8/tl/jdk: 8025985: com.sun.management.OSMBeanFactory should not be public
Changeset: 40ca9e4866de Author:mchung Date: 2013-11-08 12:13 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40ca9e4866de 8025985: com.sun.management.OSMBeanFactory should not be public Reviewed-by: alanb, erikj, ihse, jbachorik ! makefiles/lib/ServiceabilityLibraries.gmk ! makefiles/mapfiles/libmanagement/mapfile-vers + src/share/classes/sun/management/BaseOperatingSystemImpl.java ! src/share/classes/sun/management/ManagementFactoryHelper.java - src/share/classes/sun/management/OperatingSystemImpl.java - src/solaris/classes/com/sun/management/OSMBeanFactory.java - src/solaris/classes/com/sun/management/UnixOperatingSystem.java + src/solaris/classes/sun/management/OperatingSystemImpl.java - src/solaris/native/com/sun/management/LinuxOperatingSystem.c - src/solaris/native/com/sun/management/MacosxOperatingSystem.c - src/solaris/native/com/sun/management/SolarisOperatingSystem.c - src/solaris/native/com/sun/management/UnixOperatingSystem_md.c + src/solaris/native/sun/management/LinuxOperatingSystem.c + src/solaris/native/sun/management/MacosxOperatingSystem.c + src/solaris/native/sun/management/OperatingSystemImpl.c + src/solaris/native/sun/management/SolarisOperatingSystem.c - src/windows/classes/com/sun/management/OSMBeanFactory.java - src/windows/classes/com/sun/management/OperatingSystem.java + src/windows/classes/sun/management/OperatingSystemImpl.java - src/windows/native/com/sun/management/OperatingSystem_md.c + src/windows/native/sun/management/OperatingSystemImpl.c
hg: jdk8/tl/jdk: 8028076: Correct raw type lint warnings in core reflection implementation classes
Changeset: 11376ad23e21 Author:darcy Date: 2013-11-08 12:19 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21 8028076: Correct raw type lint warnings in core reflection implementation classes Reviewed-by: lancea, alanb ! src/share/classes/sun/reflect/generics/reflectiveObjects/ParameterizedTypeImpl.java ! src/share/classes/sun/reflect/generics/repository/GenericDeclRepository.java
hg: jdk8/tl/jdk: 8028074: InetAddress.getByName fails with UHE invalid IPv6 address if host name starts with a-f
Changeset: 50df04934e86 Author:alanb Date: 2013-11-08 21:07 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50df04934e86 8028074: InetAddress.getByName fails with UHE invalid IPv6 address if host name starts with a-f Reviewed-by: chegar ! src/share/classes/java/net/InetAddress.java
hg: jdk8/tl/jdk: 8028041: Serialized Form description of j.l.String is not consistent with the implementation
Changeset: df2f7f288353 Author:rriggs Date: 2013-11-08 17:50 -0500 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df2f7f288353 8028041: Serialized Form description of j.l.String is not consistent with the implementation Summary: Replaced incorrect description with reference to the serialization specification Reviewed-by: alanb, smarks ! src/share/classes/java/lang/String.java
hg: jdk8/tl/hotspot: 37 new changesets
Changeset: ddc3758f68db Author:cl Date: 2013-10-31 12:36 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ddc3758f68db Added tag jdk8-b114 for changeset 7fd913010dbb ! .hgtags Changeset: 205834867346 Author:lana Date: 2013-10-31 16:31 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/205834867346 Merge Changeset: f94a9f0746d8 Author:amurillo Date: 2013-10-25 13:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/f94a9f0746d8 8027173: new hotspot build - hs25-b57 Reviewed-by: jcoomes ! make/hotspot_version Changeset: e64f1fe9756b Author:farvidsson Date: 2013-10-24 10:02 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e64f1fe9756b 8024423: JVMTI: GetLoadedClasses doesn't enumerate anonymous classes Summary: Rewrite of the getLoadedClasses() method implementation to include anonymous classes. Reviewed-by: coleenp, sspitsyn ! src/share/vm/classfile/classLoaderData.cpp ! src/share/vm/classfile/classLoaderData.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/prims/jvmtiGetLoadedClasses.cpp Changeset: d70a665e25d7 Author:iklam Date: 2013-10-24 22:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/d70a665e25d7 8020753: JNI_CreateJavaVM on Mac OSX 10.9 Mavericks corrupts the callers stack size Summary: Use hard-coded DEFAULT_MAIN_THREAD_STACK_PAGES = 2048 for 10.9 Reviewed-by: dcubed, iveresov Contributed-by: gerard.ziem...@oracle.com ! src/os_cpu/bsd_x86/vm/os_bsd_x86.cpp Changeset: e4f478e7781b Author:jbachorik Date: 2013-10-25 09:07 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/e4f478e7781b 8027294: Prepare hotspot for non TOD based uptime counter Summary: Use HR timer when available for os::elapsed_counter() on linux/bsd. Add a new counter for the JVM uptime. Reviewed-by: dholmes, sla ! src/os/bsd/vm/os_bsd.cpp ! src/os/linux/vm/os_linux.cpp ! src/share/vm/services/jmm.h ! src/share/vm/services/management.cpp Changeset: a6177f601c64 Author:hseigel Date: 2013-10-25 11:05 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/a6177f601c64 8026822: metaspace/flags/maxMetaspaceSize throws OOM of unexpected type.java.lang.OutOfMemoryError: Compressed class space Summary: Incorporate chunk size when seeing if OutOfMemoryError was caused by Metaspace or Compressed class space. Reviewed-by: stefank, coleenp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp Changeset: 634715d59d9e Author:hseigel Date: 2013-10-25 11:13 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/634715d59d9e Merge Changeset: 209aa13ab8c0 Author:coleenp Date: 2013-10-25 15:19 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/209aa13ab8c0 8024927: Nashorn performance regression with CompressedOops Summary: Allocate compressed class space at end of Java heap. For small heap sizes, without CDS, save some space so compressed classes can have the same favorable compression as oops Reviewed-by: stefank, hseigel, goetz ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/macroAssembler_x86.cpp ! src/share/vm/memory/metaspace.cpp ! src/share/vm/memory/metaspace.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/utilities/globalDefinitions.hpp + test/runtime/CompressedOops/CompressedClassPointers.java Changeset: b4aa8fc5d0d5 Author:ccheung Date: 2013-10-25 22:06 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b4aa8fc5d0d5 Merge ! src/cpu/sparc/vm/macroAssembler_sparc.cpp ! src/cpu/sparc/vm/sparc.ad ! src/share/vm/memory/metaspace.cpp - test/compiler/intrinsics/mathexact/CondTest.java - test/compiler/intrinsics/mathexact/ConstantTest.java - test/compiler/intrinsics/mathexact/LoadTest.java - test/compiler/intrinsics/mathexact/LoopDependentTest.java - test/compiler/intrinsics/mathexact/NonConstantTest.java - test/compiler/intrinsics/mathexact/RepeatTest.java Changeset: 1a04de1aaedb Author:dsamersoff Date: 2013-10-28 21:41 +0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/1a04de1aaedb 8026950: Nits in agent ps_proc.c file breaks compilation of open hotspot Summary: Fixed two compilation-breaking nits Reviewed-by: sla, dholmes ! agent/src/os/bsd/ps_proc.c Changeset: 85730a185147 Author:ccheung Date: 2013-10-30 14:02 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/85730a185147 Merge Changeset: 292050e5d5ea Author:dholmes Date: 2013-10-24 00:33 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/292050e5d5ea 8026877: Error in opening JAR file when invalid jar specified with -Xbootclasspath/a on OpenJDK build Reviewed-by: coleenp, twisti ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/runtime/thread.cpp Changeset: 066778844ed9 Author:jprovino Date: 2013-10-27 14:11 -0400 URL: