Re: Question about DiagnosticCommand.jfrCheck

2017-12-28 Thread Erik Gahlin 

Hi Martin,

There will be a JEP outlining how things will work in OpenJDK.

When it comes to Oracle JDK, it is too early to say and should not be 
discussed on this mailing list, but feel free to mail me when there is a 
JEP.


Cheers!
Erik


Hi

I have a question about plans for 
com.sun.management.DiagnosticCommand.jfrCheck :


If I run this command in JRE 9+181 i get this output:

"Java Flight Recorder not enabled.

Use VM.unlock_commercial_features to enable."

Will the output change in future versions when the flight recorder 
goes open source?

Will it work differently in Oracle and OpenJDK JRE ?

My background for asking this question: I do some work on flight 
recorder support in hawt.io  and would like to give 
the user proper warning before attempting to unlock commercial 
features at runtime.


Cheers!

Martin Skarsaune

Re: RFR: JDK-8193506 - serviceability/sa/TestClassDump.java fails in OpenJDK build

2017-12-28 Thread David Holmes 

Looks good.

Thanks,
David

On 28/12/2017 2:24 PM, Sharath Ballal wrote:

Hello,

Requesting reviews for:

JBS Id: https://bugs.openjdk.java.net/browse/JDK-8193506

Webrev: http://cr.openjdk.java.net/~sballal/8193506/webrev.00/

I tested the changes in an open only workspace.  Also the test ran 
successfully in JPRT and Mach5.


Thanks,

Sharath

Re: RFR: JDK-8194058 - [TESTBUG] serviceability/sa/ClhsdbWhere.java fails to find method 'sleep' in output

2017-12-28 Thread David Holmes 

Seems reasonable.

Thanks,
David

On 28/12/2017 3:09 PM, Sharath Ballal wrote:

(Resending as I got a failure notice)

Hello,

Requesting reviews for:

JBS Id: https://bugs.openjdk.java.net/browse/JDK-8194058

Webrev: http://cr.openjdk.java.net/~sballal/8194058/webrev.00/

Test ran successfully in JPRT and Mach5.

Thanks,

Sharath

Re: RFR: JDK-8194067 - [Testbug] serviceability/sa/Jhsdb* tests can't tolerate unrelated warnings

2017-12-28 Thread David Holmes 
When I reported this one I thought about how to best fix it. What you 
propose is a simple fix, but may potentially allow other errors to go 
unnoticed. I was wondering whether there was a simple way to filter the 
stderr content to exclude VM Warnings, but still check for other 
unexpected content?


Thanks,
David

On 28/12/2017 3:29 PM, Sharath Ballal wrote:

Hello,

Requesting reviews for:

JBS Id: https://bugs.openjdk.java.net/browse/JDK-8194067

Webrev: http://cr.openjdk.java.net/~sballal/8194067/webrev.00/

The tests ran successfully in JPRT and Mach5.

Thanks,

Sharath