[jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
Please review this semi-automatic update for the nroff man pages for JDK 18. The changes update the version number, copyright year, and incorporate the changes from the latest upstream files. - Commit messages: - JDK-8273179: Update nroff pages in JDK 18 before RC Changes: https://git.openjdk.java.net/jdk18/pull/5/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk18&pr=5&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8273179 Stats: 858 lines in 28 files changed: 448 ins; 146 del; 264 mod Patch: https://git.openjdk.java.net/jdk18/pull/5.diff Fetch: git fetch https://git.openjdk.java.net/jdk18 pull/5/head:pull/5 PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi Jon, This all looks good - I'm familiar with many of the changes made to the sources but not yet generated. We will have to be careful not to regress the copyright year or version if any subsequent updates are made before next year, or before the version loses the EA designator. Thanks, David - Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Hi David, The copyright year will naturally sort itself out in a few weeks time ;-) When these changes make their way down from 18 to 19, we will probably want to regenerate these files with 19-EA. -- Jon We will also want to regenerate any appropriate files if any more updates to the man pages are made during the ramp down period. - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 02:48:43 GMT, Jonathan Gibbons wrote: >> Please review this semi-automatic update for the nroff man pages for JDK 18. >> The changes update the version number, copyright year, and incorporate the >> changes from the latest upstream files. > > We will also want to regenerate any appropriate files if any more updates to > the man pages are made during the ramp down period. Hi @jonathan-gibbons , I have a couple of manpage related tasks for early in the 19 release cycle that will take care of updating the version number. Unfortunately for this change it looks like whomever did the source uodate to the javadoc manpage did not know about the test: test/langtools/jdk/javadoc/tool/CheckManPageOptions.java which is now failing on all platforms. :( I will file a bug. David - PR: https://git.openjdk.java.net/jdk18/pull/5
Re: [jdk18] RFR: JDK-8273179: Update nroff pages in JDK 18 before RC
On Fri, 10 Dec 2021 01:46:03 GMT, Jonathan Gibbons wrote: > Please review this semi-automatic update for the nroff man pages for JDK 18. > The changes update the version number, copyright year, and incorporate the > changes from the latest upstream files. hmmm, I thought we had taken care of that test. I will investigate - PR: https://git.openjdk.java.net/jdk18/pull/5
