Re: RFR(L) : 8199382 : [TESTBUG] Open source VM testbase JDI tests

2018-05-04 Thread serguei.spit...@oracle.com

  
  
Hi Igor,
  
  The two definitions below look almost the same! :)
  +NSK_SHARE_JDI_INCLUDES := \
+-I$(VM_TESTBASE_DIR)/nsk/share/native \
+-I$(VM_TESTBASE_DIR)/nsk/share/jdi
+
+NSK_SHARE_JNI_INCLUDES := \
+-I$(VM_TESTBASE_DIR)/nsk/share/native \
+-I$(VM_TESTBASE_DIR)/nsk/share/jni
  
  It looks good.
  
  Thank you a lot for taking care about it!
  Serguei
  
  
  
  On 5/3/18 21:14, Igor Ignatyev wrote:


  http://cr.openjdk.java.net/~iignatyev/8199382/webrev.00/index.html

  
577169 lines changed: 577169 ins; 0 del; 0 mod; 

  
  
Hi all,

could you please review the patch which open sources JDI tests from vm testbase? These tests cover different aspects of JDI implementation.

As usually w/ VM testbase code, these tests are old, they have been run in hotspot testing for a long period of time. Originally, these tests were run by a test harness different from jtreg and had different build and execution schemes, some parts couldn't be easily translated to jtreg, so tests might have actions or pieces of code which look weird. In a long term, we are planning to rework them.

JBS: https://bugs.openjdk.java.net/browse/JDK-8199382
webrev:  http://cr.openjdk.java.net/~iignatyev/8199382/webrev.00/index.html
testing: vmTestbase_nsk_jdi test group

Thanks,
-- Igor


  



Re: RFR(L) : 8199382 : [TESTBUG] Open source VM testbase JDI tests

2018-05-04 Thread Erik Joelsson

Build change looks good.

/Erik


On 2018-05-03 21:14, Igor Ignatyev wrote:

http://cr.openjdk.java.net/~iignatyev/8199382/webrev.00/index.html

577169 lines changed: 577169 ins; 0 del; 0 mod;

Hi all,

could you please review the patch which open sources JDI tests from vm 
testbase? These tests cover different aspects of JDI implementation.

As usually w/ VM testbase code, these tests are old, they have been run in 
hotspot testing for a long period of time. Originally, these tests were run by 
a test harness different from jtreg and had different build and execution 
schemes, some parts couldn't be easily translated to jtreg, so tests might have 
actions or pieces of code which look weird. In a long term, we are planning to 
rework them.

JBS: https://bugs.openjdk.java.net/browse/JDK-8199382
webrev:  http://cr.openjdk.java.net/~iignatyev/8199382/webrev.00/index.html
testing: vmTestbase_nsk_jdi test group

Thanks,
-- Igor




RFR(L) : 8199382 : [TESTBUG] Open source VM testbase JDI tests

2018-05-03 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev/8199382/webrev.00/index.html
> 577169 lines changed: 577169 ins; 0 del; 0 mod; 

Hi all,

could you please review the patch which open sources JDI tests from vm 
testbase? These tests cover different aspects of JDI implementation.

As usually w/ VM testbase code, these tests are old, they have been run in 
hotspot testing for a long period of time. Originally, these tests were run by 
a test harness different from jtreg and had different build and execution 
schemes, some parts couldn't be easily translated to jtreg, so tests might have 
actions or pieces of code which look weird. In a long term, we are planning to 
rework them.

JBS: https://bugs.openjdk.java.net/browse/JDK-8199382
webrev:  http://cr.openjdk.java.net/~iignatyev/8199382/webrev.00/index.html
testing: vmTestbase_nsk_jdi test group

Thanks,
-- Igor