RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

2016-09-06 Thread Dmitry Dmitriev 

Hello,

Please review fix for jdk/test/sun/tools/jps tests. 
sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: 
jdk.testlibrary.ProcessTools. The problem is that TestJpsJar not add 
class path to the process builder and fails to find test library classes 
if these classes were compiled before with @build directive.


In this fix I also removed unnecessary build directives from 
sun/tools/jps/ tests.


JBS: https://bugs.openjdk.java.net/browse/JDK-8165490
webrev.00: http://cr.openjdk.java.net/~ddmitriev/8165490/webrev.00/ 


Testing: locally, RBT(in progress)

Thanks,
Dmitry

Re: RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

2016-09-06 Thread Dmitry Dmitriev 

Hello, I withdraw this patch because it's wrong. Thanks!

On 06.09.2016 14:43, Dmitry Dmitriev wrote:

Hello,

Please review fix for jdk/test/sun/tools/jps tests. 
sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: 
jdk.testlibrary.ProcessTools. The problem is that TestJpsJar not add 
class path to the process builder and fails to find test library 
classes if these classes were compiled before with @build directive.


In this fix I also removed unnecessary build directives from 
sun/tools/jps/ tests.


JBS: https://bugs.openjdk.java.net/browse/JDK-8165490
webrev.00: http://cr.openjdk.java.net/~ddmitriev/8165490/webrev.00/ 


Testing: locally, RBT(in progress)

Thanks,
Dmitry

Re: RFR(S): 8165490: [TESTBUG] sun/tools/jps/TestJpsJar.java still fails with ClassNotFoundException: jdk.testlibrary.ProcessTools

2016-09-06 Thread Dmitry Dmitriev 
FYI: the problem is with new JDK 9 multi-release jar tool which ignores 
second(and others) '-C  .' arguments. Bug: JDK-8165500 "jar not 
proceed second(and others) -C  . arguments" 



Dmitry

On 06.09.2016 15:35, Dmitry Dmitriev wrote:

Hello, I withdraw this patch because it's wrong. Thanks!

On 06.09.2016 14:43, Dmitry Dmitriev wrote:

Hello,

Please review fix for jdk/test/sun/tools/jps tests. 
sun/tools/jps/TestJpsJar.java still fails with 
ClassNotFoundException: jdk.testlibrary.ProcessTools. The problem is 
that TestJpsJar not add class path to the process builder and fails 
to find test library classes if these classes were compiled before 
with @build directive.


In this fix I also removed unnecessary build directives from 
sun/tools/jps/ tests.


JBS: https://bugs.openjdk.java.net/browse/JDK-8165490
webrev.00: http://cr.openjdk.java.net/~ddmitriev/8165490/webrev.00/ 


Testing: locally, RBT(in progress)

Thanks,
Dmitry