Re: RFR(XS): 8058647, 8058649, 8058651, 8058652: ProblemList additions

2014-09-22 Thread Jaroslav Bachorik

Reviewed

-JB-

On 09/18/2014 02:32 PM, Mikael Auno wrote:

Hi,

Could I please have a review for these small additions to
ProblemList.txt in jdk9? They are separate changes (jcheck didn't agree
with the guidelines[1] about multiple fixes in a single changeset) with
separate bug numbers, but it seems easier to have one review for them all.

bug: https://bugs.openjdk.java.net/browse/JDK-8058647
bug: https://bugs.openjdk.java.net/browse/JDK-8058649
bug: https://bugs.openjdk.java.net/browse/JDK-8058651
bug: https://bugs.openjdk.java.net/browse/JDK-8058652
webrev:
http://cr.openjdk.java.net/~miauno/8058647_8058649_8058651_8058652/webrev.00/

Thanks,
Mikael

  [1] http://openjdk.java.net/guide/producingChangeset.html#changesetComment





Re: RFR(XS): 8058647, 8058649, 8058651, 8058652: ProblemList additions

2014-09-22 Thread Mikael Auno
Thanks for the review Jaroslav. Could you also help me push this
(exported changesets attached)?

Thanks,
Mikael

On 2014-09-22 10:30, Jaroslav Bachorik wrote:
 Reviewed
 
 -JB-
 
 On 09/18/2014 02:32 PM, Mikael Auno wrote:
 Hi,

 Could I please have a review for these small additions to
 ProblemList.txt in jdk9? They are separate changes (jcheck didn't agree
 with the guidelines[1] about multiple fixes in a single changeset) with
 separate bug numbers, but it seems easier to have one review for them
 all.

 bug: https://bugs.openjdk.java.net/browse/JDK-8058647
 bug: https://bugs.openjdk.java.net/browse/JDK-8058649
 bug: https://bugs.openjdk.java.net/browse/JDK-8058651
 bug: https://bugs.openjdk.java.net/browse/JDK-8058652
 webrev:
 http://cr.openjdk.java.net/~miauno/8058647_8058649_8058651_8058652/webrev.00/


 Thanks,
 Mikael

   [1]
 http://openjdk.java.net/guide/producingChangeset.html#changesetComment

 

# HG changeset patch
# User miauno
# Date 1411032854 -7200
# Node ID 80c2675985834df64dc385eb914776f089261bf8
# Parent  71c9aa685da57a3a700a067163d9817a35143494
8058647: sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.java should be quarantined
Reviewed-by: jbachorik

diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -298,4 +298,7 @@
 # 6456333
 sun/tools/jps/TestJpsJarRelative.javageneric-all
 
+# 8057732
+sun/jvmstat/monitor/MonitoredVm/MonitorVmStartTerminate.javageneric-all
+
 
# HG changeset patch
# User miauno
# Date 1411032854 -7200
# Node ID 89b3cbfdf0e8684c6772fb1095b9b07fd1c1bd37
# Parent  80c2675985834df64dc385eb914776f089261bf8
8058649: java/lang/management/ThreadMXBean/FindDeadlocks.java should be quarantined
Reviewed-by: jbachorik

diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -130,6 +130,9 @@
 # 8056143
 java/lang/management/MemoryMXBean/LowMemoryTest.java  generic-all
 
+# 8058492
+java/lang/management/ThreadMXBean/FindDeadlocks.java  generic-all
+
 
 
 # jdk_jmx
# HG changeset patch
# User miauno
# Date 1411032854 -7200
# Node ID 19d857cb4b9d0ce001c732f676e8c98e9e048625
# Parent  89b3cbfdf0e8684c6772fb1095b9b07fd1c1bd37
8058651: com/sun/jdi/RedefinePop.sh should be quarantined
Reviewed-by: jbachorik

diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -271,6 +271,9 @@
 # 8044419
 com/sun/jdi/JdbReadTwiceTest.sh generic-all
 
+# 8058616
+com/sun/jdi/RedefinePop.sh  generic-all
+
 
 
 # jdk_util
# HG changeset patch
# User miauno
# Date 1411032854 -7200
# Node ID 3f92ca54cd2c87617e345cc7fad26c6a8908e46c
# Parent  19d857cb4b9d0ce001c732f676e8c98e9e048625
8058652: java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java should be quarantined
Reviewed-by: jbachorik

diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -133,6 +133,9 @@
 # 8058492
 java/lang/management/ThreadMXBean/FindDeadlocks.java  generic-all
 
+# 8058506
+java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java  generic-all
+
 
 
 # jdk_jmx


Re: RFR(XS): 8058647, 8058649, 8058651, 8058652: ProblemList additions

2014-09-22 Thread Jaroslav Bachorik

On 09/22/2014 04:20 PM, Mikael Auno wrote:

Thanks for the review Jaroslav. Could you also help me push this
(exported changesets attached)?


Will do.

-JB-



Thanks,
Mikael

On 2014-09-22 10:30, Jaroslav Bachorik wrote:

Reviewed

-JB-

On 09/18/2014 02:32 PM, Mikael Auno wrote:

Hi,

Could I please have a review for these small additions to
ProblemList.txt in jdk9? They are separate changes (jcheck didn't agree
with the guidelines[1] about multiple fixes in a single changeset) with
separate bug numbers, but it seems easier to have one review for them
all.

bug: https://bugs.openjdk.java.net/browse/JDK-8058647
bug: https://bugs.openjdk.java.net/browse/JDK-8058649
bug: https://bugs.openjdk.java.net/browse/JDK-8058651
bug: https://bugs.openjdk.java.net/browse/JDK-8058652
webrev:
http://cr.openjdk.java.net/~miauno/8058647_8058649_8058651_8058652/webrev.00/


Thanks,
Mikael

   [1]
http://openjdk.java.net/guide/producingChangeset.html#changesetComment









RFR(XS): 8058647, 8058649, 8058651, 8058652: ProblemList additions

2014-09-18 Thread Mikael Auno
Hi,

Could I please have a review for these small additions to
ProblemList.txt in jdk9? They are separate changes (jcheck didn't agree
with the guidelines[1] about multiple fixes in a single changeset) with
separate bug numbers, but it seems easier to have one review for them all.

bug: https://bugs.openjdk.java.net/browse/JDK-8058647
bug: https://bugs.openjdk.java.net/browse/JDK-8058649
bug: https://bugs.openjdk.java.net/browse/JDK-8058651
bug: https://bugs.openjdk.java.net/browse/JDK-8058652
webrev:
http://cr.openjdk.java.net/~miauno/8058647_8058649_8058651_8058652/webrev.00/

Thanks,
Mikael

 [1] http://openjdk.java.net/guide/producingChangeset.html#changesetComment