Re: RFR(XS): 8066814: Reduce accessibility in TraceEvent

2015-11-19 Thread Erik Gahlin 

Looks good, not a reviewer.

Erik

On 2014-12-17 15:45, Markus Grönlund wrote:


Greetings,

Kindly asking for reviews for the following changeset:

Bug: https://bugs.openjdk.java.net/browse/JDK-8066814

Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/ 



Description:

TraceEvent currently exposes internals unnecessarily.

Therefore:

Remove unnecessarily exposed methods.
Add assert for not committing a cancelled event.
Add method stubs for !INCLUDE_TRACE

Thanks in advance

Markus

Re: RFR(XS): 8066814: Reduce accessibility in TraceEvent

2014-12-18 Thread Staffan Larsen 
Looks good!

Thanks,
/Staffan

 On 17 dec 2014, at 15:45, Markus Grönlund markus.gronl...@oracle.com wrote:
 
 Greetings,
  
 Kindly asking for reviews for the following changeset:
  
 Bug: https://bugs.openjdk.java.net/browse/JDK-8066814 
 https://bugs.openjdk.java.net/browse/JDK-8066814
 Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/ 
 http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/
  
 Description:
 TraceEvent currently exposes internals unnecessarily.
  
 Therefore:
  
 Remove unnecessarily exposed methods. 
 Add assert for not committing a cancelled event. 
 Add method stubs for !INCLUDE_TRACE
  
 Thanks in advance
 Markus

RFR(XS): 8066814: Reduce accessibility in TraceEvent

2014-12-17 Thread Markus Grönlund 
Greetings,

 

Kindly asking for reviews for the following changeset:

 

Bug: https://bugs.openjdk.java.net/browse/JDK-8066814 

Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/ 

 

Description:

TraceEvent currently exposes internals unnecessarily.

 

Therefore:

 

Remove unnecessarily exposed methods. 
Add assert for not committing a cancelled event. 
Add method stubs for !INCLUDE_TRACE

 

Thanks in advance

Markus

Re: RFR(XS): 8066814: Reduce accessibility in TraceEvent

2014-12-17 Thread Erik Gahlin 

Looks good

Erik

Markus Grönlund skrev 2014-12-17 15:45:

Greetings,

  


Kindly asking for reviews for the following changeset:

  


Bug: https://bugs.openjdk.java.net/browse/JDK-8066814

Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/

  


Description:

TraceEvent currently exposes internals unnecessarily.

  


Therefore:

  


Remove unnecessarily exposed methods.
Add assert for not committing a cancelled event.
Add method stubs for !INCLUDE_TRACE

  


Thanks in advance

Markus