Re: RFR(XXS): 8044540: serviceability/sa/jmap-hashcode/Test8028623.java should be quarantined
Hi - I think this is too late, but just a note that I'd started a review request on a version of that test which would fail gracefully (pass) if it wasn't able to use jmap to attach. But I left that change (bug 8039995, on this alias) pending, waiting to find out if it was irrelevant - i.e. whether we're just making a mistake in the way we do these tests - shouldn't we be running SA tests in an environment where SA features are able to work: either running as root as required on some systems, or at least with the kernel.yama.ptrace_scope = 0 on some Linux systems. Just wanted to make sure these threads are joined up... Thanks Kevin On 02/06/14 18:28, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 2 jun 2014, at 17:29, Mikael Auno mikael.a...@oracle.com wrote: Hi, Could I please have a review of this very small fix. webrev: http://cr.openjdk.java.net/~miauno/8044540/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8044540 Verified locally. Thanks, Mikael
Re: RFR(XXS): 8044540: serviceability/sa/jmap-hashcode/Test8028623.java should be quarantined
Thanks for the review. Could you also help me push this to hs-rt? The exported changeset is attached. Mikael On 2014-06-02 19:28, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 2 jun 2014, at 17:29, Mikael Auno mikael.a...@oracle.com wrote: Hi, Could I please have a review of this very small fix. webrev: http://cr.openjdk.java.net/~miauno/8044540/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8044540 Verified locally. Thanks, Mikael # HG changeset patch # User miauno # Date 1401722475 -7200 # Node ID aa696854a732ed5bd49bd310cfc0d96a86d1d151 # Parent 1ffd0bb18df9e28230c1a5dbb1124ad5b3869863 8044540: serviceability/sa/jmap-hashcode/Test8028623.java should be quarantined Reviewed-by: sla diff --git a/test/serviceability/sa/jmap-hashcode/Test8028623.java b/test/serviceability/sa/jmap-hashcode/Test8028623.java --- a/test/serviceability/sa/jmap-hashcode/Test8028623.java +++ b/test/serviceability/sa/jmap-hashcode/Test8028623.java @@ -26,6 +26,7 @@ * @bug 8028623 * @summary Test hashing of extended characters in Serviceability Agent. * @library /testlibrary + * @ignore 8044416 * @build com.oracle.java.testlibrary.* * @compile -encoding utf8 Test8028623.java * @run main Test8028623
RFR(XXS): 8044540: serviceability/sa/jmap-hashcode/Test8028623.java should be quarantined
Hi, Could I please have a review of this very small fix. webrev: http://cr.openjdk.java.net/~miauno/8044540/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8044540 Verified locally. Thanks, Mikael
Re: RFR(XXS): 8044540: serviceability/sa/jmap-hashcode/Test8028623.java should be quarantined
Looks good! Thanks, /Staffan On 2 jun 2014, at 17:29, Mikael Auno mikael.a...@oracle.com wrote: Hi, Could I please have a review of this very small fix. webrev: http://cr.openjdk.java.net/~miauno/8044540/webrev.00/ bug: https://bugs.openjdk.java.net/browse/JDK-8044540 Verified locally. Thanks, Mikael
