Re: RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

2016-06-23 Thread Dmitry Dmitriev 

Robbin, thank you for the review!

Dmitry

On 23.06.2016 12:54, Robbin Ehn wrote:

Hi Dmitry,

Looks good, thanks!

/Robbin

On 06/22/2016 10:57 PM, Dmitry Dmitriev wrote:

Hello,

Please review small patch which fixes error message for NULL memory 
size arguments. Currently message for nanotime arguments is printed. 
I change it to make it consistent

with other error messages for memory size arguments.

JBS: https://bugs.openjdk.java.net/browse/JDK-8160102
webrev.00: http://cr.openjdk.java.net/~ddmitriev/8160102/webrev.00/ 


Testing: jprt

Thanks,
Dmitry

Re: RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

2016-06-23 Thread Dmitry Dmitriev 

David, thank you for the review!

Dmitry

On 23.06.2016 3:08, David Holmes wrote:

Looks good.

Thanks,
David

On 23/06/2016 6:57 AM, Dmitry Dmitriev wrote:

Hello,

Please review small patch which fixes error message for NULL memory size
arguments. Currently message for nanotime arguments is printed. I change
it to make it consistent with other error messages for memory size
arguments.

JBS: https://bugs.openjdk.java.net/browse/JDK-8160102
webrev.00: http://cr.openjdk.java.net/~ddmitriev/8160102/webrev.00/

Testing: jprt

Thanks,
Dmitry

Re: RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

2016-06-23 Thread Robbin Ehn 

Hi Dmitry,

Looks good, thanks!

/Robbin

On 06/22/2016 10:57 PM, Dmitry Dmitriev wrote:

Hello,

Please review small patch which fixes error message for NULL memory size 
arguments. Currently message for nanotime arguments is printed. I change it to 
make it consistent
with other error messages for memory size arguments.

JBS: https://bugs.openjdk.java.net/browse/JDK-8160102
webrev.00: http://cr.openjdk.java.net/~ddmitriev/8160102/webrev.00/ 

Testing: jprt

Thanks,
Dmitry

Re: RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

2016-06-22 Thread David Holmes 

Looks good.

Thanks,
David

On 23/06/2016 6:57 AM, Dmitry Dmitriev wrote:

Hello,

Please review small patch which fixes error message for NULL memory size
arguments. Currently message for nanotime arguments is printed. I change
it to make it consistent with other error messages for memory size
arguments.

JBS: https://bugs.openjdk.java.net/browse/JDK-8160102
webrev.00: http://cr.openjdk.java.net/~ddmitriev/8160102/webrev.00/

Testing: jprt

Thanks,
Dmitry

RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

2016-06-22 Thread Dmitry Dmitriev 

Hello,

Please review small patch which fixes error message for NULL memory size 
arguments. Currently message for nanotime arguments is printed. I change 
it to make it consistent with other error messages for memory size 
arguments.


JBS: https://bugs.openjdk.java.net/browse/JDK-8160102
webrev.00: http://cr.openjdk.java.net/~ddmitriev/8160102/webrev.00/ 


Testing: jprt

Thanks,
Dmitry