Re: RFR: 8035939: java/lang/management/MemoryMXBean/MemoryManagement.java timed out on Linux-amd64

2014-08-19 Thread Staffan Larsen 
Looks good!

Thanks,
/Staffan

On 19 aug 2014, at 12:25, Stefan Karlsson stefan.karls...@oracle.com wrote:

 Hi all,
 
 Please review this patch harden two MemoryMXBean tests. These tests cause 
 intermittent test failures when the allocated objects are put in the young 
 gen instead of the old gen. The proposed fix/workaround is to lower the young 
 gen size and assert that the allocated objects are large enough to not fit in 
 the young gen.
 
 http://cr.openjdk.java.net/~stefank/8035939/webrev.00/
 https://bugs.openjdk.java.net/browse/JDK-8035939
 
 thanks,
 StefanK

Re: RFR: 8035939: java/lang/management/MemoryMXBean/MemoryManagement.java timed out on Linux-amd64

2014-08-19 Thread Bengt Rutisson 


Hi Stefank,

Seems reasonable. Reviewed.

Bengt


On 2014-08-19 12:25, Stefan Karlsson wrote:

Hi all,

Please review this patch harden two MemoryMXBean tests. These tests 
cause intermittent test failures when the allocated objects are put in 
the young gen instead of the old gen. The proposed fix/workaround is 
to lower the young gen size and assert that the allocated objects are 
large enough to not fit in the young gen.


http://cr.openjdk.java.net/~stefank/8035939/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8035939

thanks,
StefanK

Re: RFR: 8035939: java/lang/management/MemoryMXBean/MemoryManagement.java timed out on Linux-amd64

2014-08-19 Thread Stefan Karlsson 

On 2014-08-19 12:51, Staffan Larsen wrote:

Looks good!


Thanks!

StefanK



Thanks,
/Staffan

On 19 aug 2014, at 12:25, Stefan Karlsson stefan.karls...@oracle.com wrote:


Hi all,

Please review this patch harden two MemoryMXBean tests. These tests cause 
intermittent test failures when the allocated objects are put in the young gen 
instead of the old gen. The proposed fix/workaround is to lower the young gen 
size and assert that the allocated objects are large enough to not fit in the 
young gen.

http://cr.openjdk.java.net/~stefank/8035939/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8035939

thanks,
StefanK

Re: RFR: 8035939: java/lang/management/MemoryMXBean/MemoryManagement.java timed out on Linux-amd64

2014-08-19 Thread Mikael Gerdin 

Hi Stefan,

On 2014-08-19 12:25, Stefan Karlsson wrote:

Hi all,

Please review this patch harden two MemoryMXBean tests. These tests
cause intermittent test failures when the allocated objects are put in
the young gen instead of the old gen. The proposed fix/workaround is to
lower the young gen size and assert that the allocated objects are large
enough to not fit in the young gen.

http://cr.openjdk.java.net/~stefank/8035939/webrev.00/


Looks good.

/Mikael


https://bugs.openjdk.java.net/browse/JDK-8035939

thanks,
StefanK