Re: RFR: 8243450: Reomve VMOps from jdk.hotspot.agent

2020-04-22 Thread Yasumasa Suenaga 

Thanks Chris and David for quick review!

Yasumasa


On 2020/04/23 11:22, Yasumasa Suenaga wrote:

Hi all,

Please review removing file from jdk.hotspot.agent:

   JBS: https://bugs.openjdk.java.net/browse/JDK-8243450
   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8243450/webrev.00/

VMOps is enum class which lists all of VM Operation, but it has not been synced 
with HotSpot source.
In addition, it is not used in src/ and test/.

This change has passed tests on submit repo 
(mach5-one-ysuenaga-JDK-8243450-20200423-0039-10418768).


Thanks,

Yasumasa

Re: RFR: 8243450: Reomve VMOps from jdk.hotspot.agent

2020-04-22 Thread David Holmes 

Hi Yasumasa,

On 23/04/2020 12:22 pm, Yasumasa Suenaga wrote:

Hi all,

Please review removing file from jdk.hotspot.agent:

   JBS: https://bugs.openjdk.java.net/browse/JDK-8243450
   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8243450/webrev.00/

VMOps is enum class which lists all of VM Operation, but it has not been 
synced with HotSpot source.

In addition, it is not used in src/ and test/.


Strange. It was added by:

https://bugs.openjdk.java.net/browse/JDK-8046282

http://hg.openjdk.java.net/jdk9/jdk9/hotspot/rev/74ab5b554535

but appears to be unused even then.

So I guess it is okay to remove it.

Thanks,
David

This change has passed tests on submit repo 
(mach5-one-ysuenaga-JDK-8243450-20200423-0039-10418768).



Thanks,

Yasumasa

Re: RFR: 8243450: Reomve VMOps from jdk.hotspot.agent

2020-04-22 Thread Chris Plummer 

Looks good.

Chris

On 4/22/20 7:22 PM, Yasumasa Suenaga wrote:

Hi all,

Please review removing file from jdk.hotspot.agent:

  JBS: https://bugs.openjdk.java.net/browse/JDK-8243450
  webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8243450/webrev.00/

VMOps is enum class which lists all of VM Operation, but it has not 
been synced with HotSpot source.

In addition, it is not used in src/ and test/.

This change has passed tests on submit repo 
(mach5-one-ysuenaga-JDK-8243450-20200423-0039-10418768).



Thanks,

Yasumasa

RFR: 8243450: Reomve VMOps from jdk.hotspot.agent

2020-04-22 Thread Yasumasa Suenaga 

Hi all,

Please review removing file from jdk.hotspot.agent:

  JBS: https://bugs.openjdk.java.net/browse/JDK-8243450
  webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8243450/webrev.00/

VMOps is enum class which lists all of VM Operation, but it has not been synced 
with HotSpot source.
In addition, it is not used in src/ and test/.

This change has passed tests on submit repo 
(mach5-one-ysuenaga-JDK-8243450-20200423-0039-10418768).


Thanks,

Yasumasa