Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v7]

2022-03-03 Thread Yi Yang 
On Fri, 4 Mar 2022 03:29:51 GMT, David Holmes  wrote:

>> Yi Yang has updated the pull request with a new target base due to a merge 
>> or a rebase. The pull request now contains eight commits:
>> 
>>  - Merge branch 'master' into jcmd_classes
>>  - typo
>>  - fix
>>  - fix test
>>  - -verbose and help doc
>>  - -verbose
>>  - review
>>  - 8275775 Add VM.classes to print details of all classes
>
> src/hotspot/share/services/diagnosticCommand.cpp line 964:
> 
>> 962:"Dump the detailed content of a Java class. "
>> 963:"Some classes are annotated with flags: "
>> 964:"F = has finialize method, "
> 
> This is still spelt incorrectly: finalize

Sorry... changed.

-

PR: https://git.openjdk.java.net/jdk/pull/7105

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v7]

2022-03-03 Thread David Holmes 
On Fri, 4 Mar 2022 03:07:26 GMT, Yi Yang  wrote:

>> Add VM.classes to print details of all classes, output looks like:
>> 
>> 1. jcmd VM.classes
>> 
>> KlassAddr Size State Flags LoaderName ClassName
>> 0x000800c0b400 62 inited W bootstrap 
>> java.lang.invoke.LambdaForm$MH/0x000800c0b400
>> 0x000800c0b000 62 inited W bootstrap 
>> java.lang.invoke.LambdaForm$DMH/0x000800c0b000
>> 0x000800c0ac00 62 inited W bootstrap 
>> java.lang.invoke.LambdaForm$MH/0x000800c0ac00
>> ...
>> 
>> 2. jcmd VM.classes verbose
>> 
>> KlassAddr Size State Flags LoaderName ClassName
>> 0x000800c0b400 62 inited W bootstrap 
>> java.lang.invoke.LambdaForm$MH/0x000800c0b400
>> java.lang.invoke.LambdaForm$MH/0x000800c0b400 {0x000800c0b400}
>>  - instance size: 2
>>  - klass size: 62
>>  - access: final synchronized
>>  - state: inited
>>  - name: 'java/lang/invoke/LambdaForm$MH+0x000800c0b400'
>>  - super: 'java/lang/Object'
>>  - sub:
>>  - arrays: NULL
>>  - methods: Array(0x7f620841f210)
>>  - method ordering: Array(0x000800a7e5a8)
>>  - default_methods: Array(0x)
>>  - local interfaces: Array(0x0008005af748)
>>  - trans. interfaces: Array(0x0008005af748)
>>  - constants: constant pool [41] {0x7f620841f030} for 
>> 'java/lang/invoke/LambdaForm$MH+0x000800c0b400' cache=0x7f620841f380
>>  - class loader data: loader data: 0x7f61c804a690 of 'bootstrap' has a 
>> class holder
>>  - source file: 'LambdaForm$MH'
>>  - class annotations: Array(0x)
>>  - class type annotations: Array(0x)
>>  - field annotations: Array(0x)
>>  - field type annotations: Array(0x)
>>  - inner classes: Array(0x0008005af6d8)
>>  - nest members: Array(0x0008005af6d8)
>>  - permitted subclasses: Array(0x0008005af6d8)
>>  - java mirror: a 'java/lang/Class'{0x00011f4b3968} = 
>> 'java/lang/invoke/LambdaForm$MH+0x000800c0b400'
>>  - vtable length 5 (start addr: 0x000800c0b5b8)
>>  - itable length 2 (start addr: 0x000800c0b5e0)
>>  -  static fields (1 words):
>>  - static final '_D_0' 'Ljava/lang/invoke/LambdaForm;' @112
>>  -  non-static fields (0 words):
>>  - non-static oop maps:
>> 0x000800c0b000 62 inited W bootstrap 
>> java.lang.invoke.LambdaForm$DMH/0x000800c0b000
>> java.lang.invoke.LambdaForm$DMH/0x000800c0b000 {0x000800c0b000}
>>  - instance size: 2
>>  - klass size: 62
>>  - access: final synchronized
>>  - state: inited
>>  - name: 'java/lang/invoke/LambdaForm$DMH+0x000800c0b000'
>>  - super: 'java/lang/Object'
>>  - sub:
>>  - arrays: NULL
>>  - methods: Array(0x7f620841ea68)
>>  - method ordering: Array(0x000800a7e5a8)
>>  - default_methods: Array(0x)
>>  - local interfaces: Array(0x0008005af748)
>>  - trans. interfaces: Array(0x0008005af748)
>>  - constants: constant pool [49] {0x7f620841e838} for 
>> 'java/lang/invoke/LambdaForm$DMH+0x000800c0b000' cache=0x7f620841ebe0
>>  - class loader data: loader data: 0x7f61c804a750 of 'bootstrap' has a 
>> class holder
>>  - source file: 'LambdaForm$DMH'
>>  - class annotations: Array(0x)
>>  - class type annotations: Array(0x)
>>  - field annotations: Array(0x)
>>  - field type annotations: Array(0x)
>>  - inner classes: Array(0x0008005af6d8)
>>  - nest members: Array(0x0008005af6d8)
>>  - permitted subclasses: Array(0x0008005af6d8)
>>  - java mirror: a 'java/lang/Class'{0x00011f4b0968} = 
>> 'java/lang/invoke/LambdaForm$DMH+0x000800c0b000'
>>  - vtable length 5 (start addr: 0x000800c0b1b8)
>>  - itable length 2 (start addr: 0x000800c0b1e0)
>>  -  static fields (1 words):
>>  - static final '_D_0' 'Ljava/lang/invoke/LambdaForm;' @112
>>  -  non-static fields (0 words):
>> ...
>
> Yi Yang has updated the pull request with a new target base due to a merge or 
> a rebase. The pull request now contains eight commits:
> 
>  - Merge branch 'master' into jcmd_classes
>  - typo
>  - fix
>  - fix test
>  - -verbose and help doc
>  - -verbose
>  - review
>  - 8275775 Add VM.classes to print details of all classes

Changes requested by dholmes (Reviewer).

src/hotspot/share/services/diagnosticCommand.cpp line 964:

> 962:"Dump the detailed content of a Java class. "
> 963:"Some classes are annotated with flags: "
> 964:"F = has finialize method, "

This is still spelt incorrectly: finalize

-

PR: https://git.openjdk.java.net/jdk/pull/7105

Re: RFR: 8275775: Add jcmd VM.classes to print details of all classes [v7]

2022-03-03 Thread Yi Yang 
> Add VM.classes to print details of all classes, output looks like:
> 
> 1. jcmd VM.classes
> 
> KlassAddr Size State Flags LoaderName ClassName
> 0x000800c0b400 62 inited W bootstrap 
> java.lang.invoke.LambdaForm$MH/0x000800c0b400
> 0x000800c0b000 62 inited W bootstrap 
> java.lang.invoke.LambdaForm$DMH/0x000800c0b000
> 0x000800c0ac00 62 inited W bootstrap 
> java.lang.invoke.LambdaForm$MH/0x000800c0ac00
> ...
> 
> 2. jcmd VM.classes verbose
> 
> KlassAddr Size State Flags LoaderName ClassName
> 0x000800c0b400 62 inited W bootstrap 
> java.lang.invoke.LambdaForm$MH/0x000800c0b400
> java.lang.invoke.LambdaForm$MH/0x000800c0b400 {0x000800c0b400}
>  - instance size: 2
>  - klass size: 62
>  - access: final synchronized
>  - state: inited
>  - name: 'java/lang/invoke/LambdaForm$MH+0x000800c0b400'
>  - super: 'java/lang/Object'
>  - sub:
>  - arrays: NULL
>  - methods: Array(0x7f620841f210)
>  - method ordering: Array(0x000800a7e5a8)
>  - default_methods: Array(0x)
>  - local interfaces: Array(0x0008005af748)
>  - trans. interfaces: Array(0x0008005af748)
>  - constants: constant pool [41] {0x7f620841f030} for 
> 'java/lang/invoke/LambdaForm$MH+0x000800c0b400' cache=0x7f620841f380
>  - class loader data: loader data: 0x7f61c804a690 of 'bootstrap' has a 
> class holder
>  - source file: 'LambdaForm$MH'
>  - class annotations: Array(0x)
>  - class type annotations: Array(0x)
>  - field annotations: Array(0x)
>  - field type annotations: Array(0x)
>  - inner classes: Array(0x0008005af6d8)
>  - nest members: Array(0x0008005af6d8)
>  - permitted subclasses: Array(0x0008005af6d8)
>  - java mirror: a 'java/lang/Class'{0x00011f4b3968} = 
> 'java/lang/invoke/LambdaForm$MH+0x000800c0b400'
>  - vtable length 5 (start addr: 0x000800c0b5b8)
>  - itable length 2 (start addr: 0x000800c0b5e0)
>  -  static fields (1 words):
>  - static final '_D_0' 'Ljava/lang/invoke/LambdaForm;' @112
>  -  non-static fields (0 words):
>  - non-static oop maps:
> 0x000800c0b000 62 inited W bootstrap 
> java.lang.invoke.LambdaForm$DMH/0x000800c0b000
> java.lang.invoke.LambdaForm$DMH/0x000800c0b000 {0x000800c0b000}
>  - instance size: 2
>  - klass size: 62
>  - access: final synchronized
>  - state: inited
>  - name: 'java/lang/invoke/LambdaForm$DMH+0x000800c0b000'
>  - super: 'java/lang/Object'
>  - sub:
>  - arrays: NULL
>  - methods: Array(0x7f620841ea68)
>  - method ordering: Array(0x000800a7e5a8)
>  - default_methods: Array(0x)
>  - local interfaces: Array(0x0008005af748)
>  - trans. interfaces: Array(0x0008005af748)
>  - constants: constant pool [49] {0x7f620841e838} for 
> 'java/lang/invoke/LambdaForm$DMH+0x000800c0b000' cache=0x7f620841ebe0
>  - class loader data: loader data: 0x7f61c804a750 of 'bootstrap' has a 
> class holder
>  - source file: 'LambdaForm$DMH'
>  - class annotations: Array(0x)
>  - class type annotations: Array(0x)
>  - field annotations: Array(0x)
>  - field type annotations: Array(0x)
>  - inner classes: Array(0x0008005af6d8)
>  - nest members: Array(0x0008005af6d8)
>  - permitted subclasses: Array(0x0008005af6d8)
>  - java mirror: a 'java/lang/Class'{0x00011f4b0968} = 
> 'java/lang/invoke/LambdaForm$DMH+0x000800c0b000'
>  - vtable length 5 (start addr: 0x000800c0b1b8)
>  - itable length 2 (start addr: 0x000800c0b1e0)
>  -  static fields (1 words):
>  - static final '_D_0' 'Ljava/lang/invoke/LambdaForm;' @112
>  -  non-static fields (0 words):
> ...

Yi Yang has updated the pull request with a new target base due to a merge or a 
rebase. The pull request now contains eight commits:

 - Merge branch 'master' into jcmd_classes
 - typo
 - fix
 - fix test
 - -verbose and help doc
 - -verbose
 - review
 - 8275775 Add VM.classes to print details of all classes

-

Changes: https://git.openjdk.java.net/jdk/pull/7105/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk=7105=06
  Stats: 172 lines in 6 files changed: 171 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/7105.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/7105/head:pull/7105

PR: https://git.openjdk.java.net/jdk/pull/7105