Re: RFR: 8277481: Obsolete seldom used CDS flags [v2]
On Fri, 10 Dec 2021 19:49:48 GMT, Harold Seigel wrote: >> Please review this change to obsolete deprecated CDS options >> UseSharedSpaces, RequireSharedSpaces, DynamicDumpSharedSpaces, and >> DumpSharedSpaces. The change was tested by running Mach5 tiers 1-2 on >> Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64 and Windows x64. >> >> The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by >> temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem >> list. >> >> Thanks! Harold > > Harold Seigel has updated the pull request incrementally with one additional > commit since the last revision: > > fix print_debug() message Thanks Ioi, Calvin, and David for the reviews! - PR: https://git.openjdk.java.net/jdk/pull/6800
Re: RFR: 8277481: Obsolete seldom used CDS flags [v2]
On Fri, 10 Dec 2021 19:49:48 GMT, Harold Seigel wrote: >> Please review this change to obsolete deprecated CDS options >> UseSharedSpaces, RequireSharedSpaces, DynamicDumpSharedSpaces, and >> DumpSharedSpaces. The change was tested by running Mach5 tiers 1-2 on >> Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64 and Windows x64. >> >> The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by >> temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem >> list. >> >> Thanks! Harold > > Harold Seigel has updated the pull request incrementally with one additional > commit since the last revision: > > fix print_debug() message LGTM! Thanks, David - Marked as reviewed by dholmes (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6800
Re: RFR: 8277481: Obsolete seldom used CDS flags [v2]
On Fri, 10 Dec 2021 19:37:31 GMT, Calvin Cheung wrote:
>> Harold Seigel has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix print_debug() message
>
> src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c line 303:
>
>> 301: useSharedSpacesAddr = lookup_symbol(ph, jvm_name,
>> USE_SHARED_SPACES_SYM);
>> 302: if (useSharedSpacesAddr == 0) {
>> 303: print_debug("can't lookup 'UseSharedSpaces' symbol\n");
>
> Maybe the `print_debug` at line 311 should also be updated from "flag" to
> "symbol"?
fixed. Thanks for pointing it out.
-
PR: https://git.openjdk.java.net/jdk/pull/6800
Re: RFR: 8277481: Obsolete seldom used CDS flags [v2]
> Please review this change to obsolete deprecated CDS options UseSharedSpaces, > RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The > change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows > and Mach5 tiers 3-5 on Linux x64 and Windows x64. > > The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by > temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem > list. > > Thanks! Harold Harold Seigel has updated the pull request incrementally with one additional commit since the last revision: fix print_debug() message - Changes: - all: https://git.openjdk.java.net/jdk/pull/6800/files - new: https://git.openjdk.java.net/jdk/pull/6800/files/3f6c6dee..601a678f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=6800=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=6800=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jdk/pull/6800.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6800/head:pull/6800 PR: https://git.openjdk.java.net/jdk/pull/6800
Re: RFR: 8277481: Obsolete seldom used CDS flags
On Fri, 10 Dec 2021 15:01:29 GMT, Harold Seigel wrote:
> Please review this change to obsolete deprecated CDS options UseSharedSpaces,
> RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The
> change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows
> and Mach5 tiers 3-5 on Linux x64 and Windows x64.
>
> The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by
> temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem
> list.
>
> Thanks! Harold
Looks good. Just one nit.
src/jdk.hotspot.agent/share/native/libsaproc/ps_core_common.c line 303:
> 301: useSharedSpacesAddr = lookup_symbol(ph, jvm_name,
> USE_SHARED_SPACES_SYM);
> 302: if (useSharedSpacesAddr == 0) {
> 303: print_debug("can't lookup 'UseSharedSpaces' symbol\n");
Maybe the `print_debug` at line 311 should also be updated from "flag" to
"symbol"?
-
Marked as reviewed by ccheung (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/6800
Re: RFR: 8277481: Obsolete seldom used CDS flags
On Fri, 10 Dec 2021 15:01:29 GMT, Harold Seigel wrote: > Please review this change to obsolete deprecated CDS options UseSharedSpaces, > RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The > change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows > and Mach5 tiers 3-5 on Linux x64 and Windows x64. > > The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by > temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem > list. > > Thanks! Harold Looks good to me. Thanks for fixing this! - Marked as reviewed by iklam (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6800
RFR: 8277481: Obsolete seldom used CDS flags
Please review this change to obsolete deprecated CDS options UseSharedSpaces, RequireSharedSpaces, DynamicDumpSharedSpaces, and DumpSharedSpaces. The change was tested by running Mach5 tiers 1-2 on Linux, Mac OS, and Windows and Mach5 tiers 3-5 on Linux x64 and Windows x64. The use of UseSharedSpaces in ps_core_common.c was tested on Mac OS x64 by temporarily removing serviceability/sa/ClhsdbPmap.java#core from the problem list. Thanks! Harold - Commit messages: - fix typo - 8277481: Obsolete seldom used CDS flags Changes: https://git.openjdk.java.net/jdk/pull/6800/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6800=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277481 Stats: 151 lines in 13 files changed: 22 ins; 94 del; 35 mod Patch: https://git.openjdk.java.net/jdk/pull/6800.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6800/head:pull/6800 PR: https://git.openjdk.java.net/jdk/pull/6800
