Re: RFR (XS): 8196450: Deprecate JDWP/JDI canUnrestrictedlyRedefineClasses to match JVM TI capabilities
Thank you for review, Chris! Serguei On 6/5/20 16:11, Chris Plummer wrote: Hi Serguei, Looks good. thanks, Chris On 6/5/20 6:05 AM, David Holmes wrote: Sorry Serguei I got distracted and forgot about the RFR part of this. Reviewed :) Thanks, David On 5/06/2020 3:19 pm, serguei.spit...@oracle.com wrote: Hi David, You have already approved the CSR below. May I count it as a review as there is no difference between CSR and webrev - both have the same spec update? Thanks, Serguei On 6/3/20 20:57, serguei.spit...@oracle.com wrote: Please, review a fix for: https://bugs.openjdk.java.net/browse/JDK-8196450 CSR draft (one CSR reviewer is needed before finalizing it): https://bugs.openjdk.java.net/browse/JDK-8246540 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/src/ Updated JDWP VirtualMachine::capabilitiesNew spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_CapabilitiesNew Updated JDI com.sun.jdi.VirtualMachine spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canAddMethod() http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canUnrestrictedlyRedefineClasses() Summary: The fix adds annotations and deprecation comments to the capabilities canUnrestrictedlyRedefineClasses and canAddMethod. It impacts the JDWP capabilitiesNew command and the JDI VirtualMachine interface. Testing: Built docs and checked the doc has been generated as expected. Will run the JDI/JDWP tests locally Thanks, Serguei
Re: RFR (XS): 8196450: Deprecate JDWP/JDI canUnrestrictedlyRedefineClasses to match JVM TI capabilities
Hi Serguei, Looks good. thanks, Chris On 6/5/20 6:05 AM, David Holmes wrote: Sorry Serguei I got distracted and forgot about the RFR part of this. Reviewed :) Thanks, David On 5/06/2020 3:19 pm, serguei.spit...@oracle.com wrote: Hi David, You have already approved the CSR below. May I count it as a review as there is no difference between CSR and webrev - both have the same spec update? Thanks, Serguei On 6/3/20 20:57, serguei.spit...@oracle.com wrote: Please, review a fix for: https://bugs.openjdk.java.net/browse/JDK-8196450 CSR draft (one CSR reviewer is needed before finalizing it): https://bugs.openjdk.java.net/browse/JDK-8246540 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/src/ Updated JDWP VirtualMachine::capabilitiesNew spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_CapabilitiesNew Updated JDI com.sun.jdi.VirtualMachine spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canAddMethod() http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canUnrestrictedlyRedefineClasses() Summary: The fix adds annotations and deprecation comments to the capabilities canUnrestrictedlyRedefineClasses and canAddMethod. It impacts the JDWP capabilitiesNew command and the JDI VirtualMachine interface. Testing: Built docs and checked the doc has been generated as expected. Will run the JDI/JDWP tests locally Thanks, Serguei
Re: RFR (XS): 8196450: Deprecate JDWP/JDI canUnrestrictedlyRedefineClasses to match JVM TI capabilities
Thank you, David! Sorry for late reply. I did not see you message until restarted my Zunderbird email client. Thanks, Serguei On 6/5/20 06:05, David Holmes wrote: Sorry Serguei I got distracted and forgot about the RFR part of this. Reviewed :) Thanks, David On 5/06/2020 3:19 pm, serguei.spit...@oracle.com wrote: Hi David, You have already approved the CSR below. May I count it as a review as there is no difference between CSR and webrev - both have the same spec update? Thanks, Serguei On 6/3/20 20:57, serguei.spit...@oracle.com wrote: Please, review a fix for: https://bugs.openjdk.java.net/browse/JDK-8196450 CSR draft (one CSR reviewer is needed before finalizing it): https://bugs.openjdk.java.net/browse/JDK-8246540 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/src/ Updated JDWP VirtualMachine::capabilitiesNew spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_CapabilitiesNew Updated JDI com.sun.jdi.VirtualMachine spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canAddMethod() http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canUnrestrictedlyRedefineClasses() Summary: The fix adds annotations and deprecation comments to the capabilities canUnrestrictedlyRedefineClasses and canAddMethod. It impacts the JDWP capabilitiesNew command and the JDI VirtualMachine interface. Testing: Built docs and checked the doc has been generated as expected. Will run the JDI/JDWP tests locally Thanks, Serguei
Re: RFR (XS): 8196450: Deprecate JDWP/JDI canUnrestrictedlyRedefineClasses to match JVM TI capabilities
Sorry Serguei I got distracted and forgot about the RFR part of this. Reviewed :) Thanks, David On 5/06/2020 3:19 pm, serguei.spit...@oracle.com wrote: Hi David, You have already approved the CSR below. May I count it as a review as there is no difference between CSR and webrev - both have the same spec update? Thanks, Serguei On 6/3/20 20:57, serguei.spit...@oracle.com wrote: Please, review a fix for: https://bugs.openjdk.java.net/browse/JDK-8196450 CSR draft (one CSR reviewer is needed before finalizing it): https://bugs.openjdk.java.net/browse/JDK-8246540 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/src/ Updated JDWP VirtualMachine::capabilitiesNew spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_CapabilitiesNew Updated JDI com.sun.jdi.VirtualMachine spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canAddMethod() http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canUnrestrictedlyRedefineClasses() Summary: The fix adds annotations and deprecation comments to the capabilities canUnrestrictedlyRedefineClasses and canAddMethod. It impacts the JDWP capabilitiesNew command and the JDI VirtualMachine interface. Testing: Built docs and checked the doc has been generated as expected. Will run the JDI/JDWP tests locally Thanks, Serguei
Re: RFR (XS): 8196450: Deprecate JDWP/JDI canUnrestrictedlyRedefineClasses to match JVM TI capabilities
Hi David, You have already approved the CSR below. May I count it as a review as there is no difference between CSR and webrev - both have the same spec update? Thanks, Serguei On 6/3/20 20:57, serguei.spit...@oracle.com wrote: Please, review a fix for: https://bugs.openjdk.java.net/browse/JDK-8196450 CSR draft (one CSR reviewer is needed before finalizing it): https://bugs.openjdk.java.net/browse/JDK-8246540 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/src/ Updated JDWP VirtualMachine::capabilitiesNew spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_CapabilitiesNew Updated JDI com.sun.jdi.VirtualMachine spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canAddMethod() http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canUnrestrictedlyRedefineClasses() Summary: The fix adds annotations and deprecation comments to the capabilities canUnrestrictedlyRedefineClasses and canAddMethod. It impacts the JDWP capabilitiesNew command and the JDI VirtualMachine interface. Testing: Built docs and checked the doc has been generated as expected. Will run the JDI/JDWP tests locally Thanks, Serguei
RFR (XS): 8196450: Deprecate JDWP/JDI canUnrestrictedlyRedefineClasses to match JVM TI capabilities
Please, review a fix for: https://bugs.openjdk.java.net/browse/JDK-8196450 CSR draft (one CSR reviewer is needed before finalizing it): https://bugs.openjdk.java.net/browse/JDK-8246540 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/src/ Updated JDWP VirtualMachine::capabilitiesNew spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/specs/jdwp/jdwp-protocol.html#JDWP_VirtualMachine_CapabilitiesNew Updated JDI com.sun.jdi.VirtualMachine spec: http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canAddMethod() http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jdwp-depr.1/docs/api/jdk.jdi/com/sun/jdi/VirtualMachine.html#canUnrestrictedlyRedefineClasses() Summary: The fix adds annotations and deprecation comments to the capabilities canUnrestrictedlyRedefineClasses and canAddMethod. It impacts the JDWP capabilitiesNew command and the JDI VirtualMachine interface. Testing: Built docs and checked the doc has been generated as expected. Will run the JDI/JDWP tests locally Thanks, Serguei
