RFR (XXS): JDK-8059105 : Add better failure reporting to com/sun/jdi/RunToExit.java test
Hi Please help me review this tiny change to make a test produce better information when it fails. This fix is about adding some instrumentation to be able to understand an intermittent failure in a test. The test fails and this bug: https://bugs.openjdk.java.net/browse/JDK-8058734 is probably a duplicate of another bug: https://bugs.openjdk.java.net/browse/JDK-6573254, but to be sure we need more data when test fails. Webrev: http://cr.openjdk.java.net/~farvidsson/8059105/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8059105 Cheers /Fredrik
Re: RFR (XXS): JDK-8059105 : Add better failure reporting to com/sun/jdi/RunToExit.java test
Looks good. /Erik Fredrik Arvidsson skrev 2014-09-25 14:24: Hi Please help me review this tiny change to make a test produce better information when it fails. This fix is about adding some instrumentation to be able to understand an intermittent failure in a test. The test fails and this bug: https://bugs.openjdk.java.net/browse/JDK-8058734 is probably a duplicate of another bug: https://bugs.openjdk.java.net/browse/JDK-6573254, but to be sure we need more data when test fails. Webrev: http://cr.openjdk.java.net/~farvidsson/8059105/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8059105 Cheers /Fredrik
Re: RFR (XXS): JDK-8059105 : Add better failure reporting to com/sun/jdi/RunToExit.java test
Looks good! Thanks, /Staffan On 25 sep 2014, at 14:24, Fredrik Arvidsson fredrik.arvids...@oracle.com wrote: Hi Please help me review this tiny change to make a test produce better information when it fails. This fix is about adding some instrumentation to be able to understand an intermittent failure in a test. The test fails and this bug: https://bugs.openjdk.java.net/browse/JDK-8058734 is probably a duplicate of another bug: https://bugs.openjdk.java.net/browse/JDK-6573254, but to be sure we need more data when test fails. Webrev: http://cr.openjdk.java.net/~farvidsson/8059105/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8059105 Cheers /Fredrik
Re: RFR (XXS): JDK-8059105 : Add better failure reporting to com/sun/jdi/RunToExit.java test
Thumbs up! -JB- On 09/25/2014 02:24 PM, Fredrik Arvidsson wrote: Hi Please help me review this tiny change to make a test produce better information when it fails. This fix is about adding some instrumentation to be able to understand an intermittent failure in a test. The test fails and this bug: https://bugs.openjdk.java.net/browse/JDK-8058734 is probably a duplicate of another bug: https://bugs.openjdk.java.net/browse/JDK-6573254, but to be sure we need more data when test fails. Webrev: http://cr.openjdk.java.net/~farvidsson/8059105/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8059105 Cheers /Fredrik
