Re: RFR(XS) 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace

2020-04-22 Thread Chris Plummer

Thanks Ioi and Serguei!

Chris

On 4/22/20 11:42 AM, Ioi Lam wrote:

Hi Chris, the change looks good to me, too.

Thanks
- Ioi

On 4/21/20 6:35 PM, serguei.spit...@oracle.com wrote:

Hi Chris,

It looks reasonable.

Thanks,
Serguei


On 4/21/20 16:07, Chris Plummer wrote:

Hello,

Please review the following:

https://bugs.openjdk.java.net/browse/JDK-8243210
http://cr.openjdk.java.net/~cjplummer/8243210/webrev.01/index.html

Description is in the bug. Hopefully this is the last in a series of 
about 6 bugs being addressed that finally lets us get this test off 
the problem list for all platforms.


thanks,

Chris








Re: RFR(XS) 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace

2020-04-22 Thread Ioi Lam

Hi Chris, the change looks good to me, too.

Thanks
- Ioi

On 4/21/20 6:35 PM, serguei.spit...@oracle.com wrote:

Hi Chris,

It looks reasonable.

Thanks,
Serguei


On 4/21/20 16:07, Chris Plummer wrote:

Hello,

Please review the following:

https://bugs.openjdk.java.net/browse/JDK-8243210
http://cr.openjdk.java.net/~cjplummer/8243210/webrev.01/index.html

Description is in the bug. Hopefully this is the last in a series of 
about 6 bugs being addressed that finally lets us get this test off 
the problem list for all platforms.


thanks,

Chris






Re: RFR(XS) 8243210: ClhsdbScanOops fails with NullPointerException in FileMapHeader.inCopiedVtableSpace

2020-04-21 Thread serguei.spit...@oracle.com

Hi Chris,

It looks reasonable.

Thanks,
Serguei


On 4/21/20 16:07, Chris Plummer wrote:

Hello,

Please review the following:

https://bugs.openjdk.java.net/browse/JDK-8243210
http://cr.openjdk.java.net/~cjplummer/8243210/webrev.01/index.html

Description is in the bug. Hopefully this is the last in a series of 
about 6 bugs being addressed that finally lets us get this test off 
the problem list for all platforms.


thanks,

Chris