Re: RFR : JDK-8174196 : sun/management/jdp tests are not running properly

2017-02-14 Thread Daniel Fuchs 

Looks good to me Amit.

best regards,

-- daniel

On 14/02/17 11:52, Amit Sapre wrote:

Hello,



Please review following test case fix



Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174196

Webrev :
http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174196/webrev.00/



Thanks,

Amit

Re: RFR : JDK-8174196 : sun/management/jdp tests are not running properly

2017-02-14 Thread Erik Gahlin 

Looks good.

Erik


Hello,

Please review following test case fix

Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174196

Webrev : 
http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174196/webrev.00/ 



Thanks,

Amit

RE: RFR : JDK-8174196 : sun/management/jdp tests are not running properly

2017-02-14 Thread Amit Sapre 
Thanks Daniel & Erik for the review

 

From: Erik Gahlin 
Sent: Tuesday, February 14, 2017 5:52 PM
To: serviceability-dev@openjdk.java.net
Subject: Re: RFR : JDK-8174196 : sun/management/jdp tests are not running 
properly

 

Looks good.

Erik 

Hello,

 

Please review following test case fix 

 

Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174196 

Webrev : http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174196/webrev.00/

 

Thanks,

Amit

Re: RFR : JDK-8174196 : sun/management/jdp tests are not running properly

2017-02-14 Thread David Holmes 

Hi Amit,

On 14/02/2017 9:52 PM, Amit Sapre wrote:

Hello,

Please review following test case fix

Bug ID : https://bugs.openjdk.java.net/browse/JDK-8174196

Webrev :
http://cr.openjdk.java.net/~asapre/webrev/2017/JDK-8174196/webrev.00/


The change to use othervm seems fine, but I'm unclear how useful this is 
by itself without the changes now being tracked in JDK-8174915?


Thanks,
David




Thanks,

Amit