Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v5]

2023-10-16 Thread Chris Plummer 
On Mon, 16 Oct 2023 21:05:58 GMT, Johannes Bechberger  
wrote:

>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>> 
>> This prevents `jdb` from receiving a broken exception event and throwing an 
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Johannes Bechberger has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Update test/jdk/com/sun/jdi/JdwpOnThrowTest.java
>   
>   Co-authored-by: Chris Plummer 

I think I know the problem with virtual threads. It has to do with the fact 
that the debug agent tracks and registers virtual threads differently than 
platform threads, and the event handling code that normally does this is not 
executed when processing an event in this manner. I'll work on a fix. Shouldn't 
be too hard but probably has to wait until tomorrow.

-

PR Comment: https://git.openjdk.org/jdk/pull/16145#issuecomment-1765518955

Re: RFR: 8318126: Refresh manpages

2023-10-16 Thread Iris Clark 
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes  wrote:

> The open nroff manpage files are out of sync with their closed markdown 
> sources and need to be refreshed.
> 
> The changes to apply are coming from:
> 
> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor 
> to each subcommand option on jfr html page
> - [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java 
> manpage markdown source for JFR filename expansion
> - [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): 
> StartFlightRecording: consider moving mention of multiple comma-separated 
> parameters to the front
> - [JDK-8308662](https://bugs.openjdk.org/browse/JDK-8308662): Update the 
> "java" tool specification for CompileOnly
> - [JDK-8317565](https://bugs.openjdk.org/browse/JDK-8317565): Update Manpage 
> for obsoletion of UseSHM
> - [JDK-8310460](https://bugs.openjdk.org/browse/JDK-8310460): Remove jdeps 
> -profile option
> 
> There are also some simple line break changes, likely due to using different 
> versions of the pandoc tool.
> 
> Thanks

Marked as reviewed by iris (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/16196#pullrequestreview-1681114738

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v5]

2023-10-16 Thread Chris Plummer 
On Mon, 16 Oct 2023 21:05:58 GMT, Johannes Bechberger  
wrote:

>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>> 
>> This prevents `jdb` from receiving a broken exception event and throwing an 
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Johannes Bechberger has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Update test/jdk/com/sun/jdi/JdwpOnThrowTest.java
>   
>   Co-authored-by: Chris Plummer 

When running with `JTREG_TEST_THREAD_FACTORY=Virtual`, I see the following 
fatal error:

`[debuggee] FATAL ERROR in native method: JDWP getting thread invoke request, 
jvmtiError=AGENT_ERROR_INVALID_THREAD(203)`

This happens while attaching. The debuggee then core dumps (on purpose) and the 
debugger side of the test throws an exception because it fails to attach.

I'm not yet sure why this is happening. The main debuggee thread is being run 
as a virtual thread, so that seems to have something to do with it, but I'm not 
sure what.

-

PR Comment: https://git.openjdk.org/jdk/pull/16145#issuecomment-1765368352

Re: RFR: 8318126: Refresh manpages

2023-10-16 Thread David Holmes 
On Mon, 16 Oct 2023 06:02:02 GMT, Alan Bateman  wrote:

>> The open nroff manpage files are out of sync with their closed markdown 
>> sources and need to be refreshed.
>> 
>> The changes to apply are coming from:
>> 
>> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor 
>> to each subcommand option on jfr html page
>> - [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the 
>> java manpage markdown source for JFR filename expansion
>> - [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): 
>> StartFlightRecording: consider moving mention of multiple comma-separated 
>> parameters to the front
>> - [JDK-8308662](https://bugs.openjdk.org/browse/JDK-8308662): Update the 
>> "java" tool specification for CompileOnly
>> - [JDK-8317565](https://bugs.openjdk.org/browse/JDK-8317565): Update Manpage 
>> for obsoletion of UseSHM
>> - [JDK-8310460](https://bugs.openjdk.org/browse/JDK-8310460): Remove jdeps 
>> -profile option
>> 
>> There are also some simple line break changes, likely due to using different 
>> versions of the pandoc tool.
>> 
>> Thanks
>
> Marked as reviewed by alanb (Reviewer).

Thanks for the reviews @AlanBateman and @Hamlin-Li

-

PR Comment: https://git.openjdk.org/jdk/pull/16196#issuecomment-1765289558

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v5]

2023-10-16 Thread Johannes Bechberger 
> Fix `onthrow` issue by passing the event info to the `initialize` method.
> 
> This prevents `jdb` from receiving a broken exception event and throwing an 
> internal NullPointerException, upon attaching to the JDWP-agent.

Johannes Bechberger has updated the pull request incrementally with one 
additional commit since the last revision:

  Update test/jdk/com/sun/jdi/JdwpOnThrowTest.java
  
  Co-authored-by: Chris Plummer 

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/16145/files
  - new: https://git.openjdk.org/jdk/pull/16145/files/f1f75482..1371459d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16145&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16145&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/16145.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16145/head:pull/16145

PR: https://git.openjdk.org/jdk/pull/16145

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-16 Thread Chris Plummer 
On Mon, 16 Oct 2023 19:07:37 GMT, Johannes Bechberger  
wrote:

>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>> 
>> This prevents `jdb` from receiving a broken exception event and throwing an 
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Johannes Bechberger has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Fixed event location

Overall the changes look good except one minor comment typo I noted. I'd like 
to first run this through our CI testing to make sure there are no issues.

test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 91:

> 89: if 
> (!ex.location().equals(ex.thread().frame(0).location())) {
> 90: throw new RuntimeException(
> 91: String.format("Throw location %s and 
> location if first frame %s are not equal",

Suggestion:

String.format("Throw location %s and 
location of first frame %s are not equal",

-

PR Review: https://git.openjdk.org/jdk/pull/16145#pullrequestreview-1680940159
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1361253082

Integrated: JDK-8317285: Misspellings in hprof test lib

2023-10-16 Thread Alex Menkov 
On Fri, 13 Oct 2023 01:15:58 GMT, Alex Menkov  wrote:

> The change fixes misspelled "referer" in test/lib/jdk/test/lib/hprof library
> The only caller of changed public API is VThreadInHeapDump.java

This pull request has now been integrated.

Changeset: aed1e810
Author:Alex Menkov 
URL:   
https://git.openjdk.org/jdk/commit/aed1e810e638681dbfd7767fbfdcdc22a29a
Stats: 50 lines in 4 files changed: 0 ins; 0 del; 50 mod

8317285: Misspellings in hprof test lib

Reviewed-by: sspitsyn, cjplummer

-

PR: https://git.openjdk.org/jdk/pull/16174

Re: RFR: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818 [v4]

2023-10-16 Thread Alex Menkov 
On Sat, 14 Oct 2023 20:17:31 GMT, Hannes Greule  wrote:

>> See the bug description for more information.
>> 
>> This implementation brings down the time to take a heap dump on the example 
>> application in the bug report to <2 seconds on my machine.
>
> Hannes Greule has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   reword -> initial klass

Marked as reviewed by amenkov (Reviewer).

test/hotspot/jtreg/serviceability/HeapDump/FieldsInInstanceTest.java line 66:

> 64: 
> 65: interface I {
> 66: int i = -10;

wrong indent

-

PR Review: https://git.openjdk.org/jdk/pull/16083#pullrequestreview-1680863228
PR Review Comment: https://git.openjdk.org/jdk/pull/16083#discussion_r1361204991

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger 
On Mon, 16 Oct 2023 18:16:59 GMT, Johannes Bechberger  
wrote:

>> `ex.catchLocation())` and `ex.thread().frame(0).location()` are valid.
>
> The problem is that the properties of the `ex.location()` are broken:
> 
> ``
> LocationImpl(VirtualMachine vm, 
>  ReferenceTypeImpl declaringType, // -> Ex
>  long methodRef, // -> main method where it has been caught 
>  long codeIndex // -> index in main method
> ) {
> 
> 
> Resolving is therefore not possible. I'm on it.

Fixed it and added the check.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1361152808

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v4]

2023-10-16 Thread Johannes Bechberger 
> Fix `onthrow` issue by passing the event info to the `initialize` method.
> 
> This prevents `jdb` from receiving a broken exception event and throwing an 
> internal NullPointerException, upon attaching to the JDWP-agent.

Johannes Bechberger has updated the pull request incrementally with one 
additional commit since the last revision:

  Fixed event location

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/16145/files
  - new: https://git.openjdk.org/jdk/pull/16145/files/1f72b743..f1f75482

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16145&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16145&range=02-03

  Stats: 11 lines in 2 files changed: 7 ins; 0 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/16145.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16145/head:pull/16145

PR: https://git.openjdk.org/jdk/pull/16145

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger 
On Mon, 16 Oct 2023 17:51:31 GMT, Johannes Bechberger  
wrote:

>> Ok. It should work so there is a bug somewhere. I'll look into it. In the 
>> meantime can you verify that ex.catchLocation().method() is valid?
>
> `ex.catchLocation())` and `ex.thread().frame(0).location()` are valid.

The problem is that the properties of the `ex.location()` are broken:

``
LocationImpl(VirtualMachine vm, 
 ReferenceTypeImpl declaringType, // -> Ex
 long methodRef, // -> main method where it has been caught 
 long codeIndex // -> index in main method
) {


Resolving is therefore not possible. I'm on it.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1361102934

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger 
On Mon, 16 Oct 2023 17:20:57 GMT, Chris Plummer  wrote:

>> I resolved all the other things you pointed out, but this issue is sticky.
>
> Ok. It should work so there is a bug somewhere. I'll look into it. In the 
> meantime can you verify that ex.catchLocation().method() is valid?

`ex.catchLocation())` and `ex.thread().frame(0).location()` are valid.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1361053893

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Chris Plummer 
On Mon, 16 Oct 2023 16:34:40 GMT, Johannes Bechberger  
wrote:

>> `if (!ex.thread().frame(0).location().equals(ex.location())) {` causes an 
>> exception:
>> 
>> 
>> java.lang.IllegalArgumentException: Invalid method id: 139869509179824
>> at 
>> jdk.jdi/com.sun.tools.jdi.ReferenceTypeImpl.getMethodMirror(ReferenceTypeImpl.java:127)
>> at 
>> jdk.jdi/com.sun.tools.jdi.LocationImpl.method(LocationImpl.java:101)
>> at 
>> jdk.jdi/com.sun.tools.jdi.LocationImpl.equals(LocationImpl.java:66)
>> at JdwpOnThrowTest.main(JdwpOnThrowTest.java:92)
>> at 
>> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
>> at 
>> com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
>> at java.base/java.lang.Thread.run(Thread.java:1570)
>
> I resolved all the other things you pointed out, but this issue is sticky.

Ok. It should work so there is a bug somewhere. I'll look into it. In the 
meantime can you verify that ex.catchLocation().method() is valid?

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1361014472

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger 
On Mon, 16 Oct 2023 16:22:29 GMT, Johannes Bechberger  
wrote:

>> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 86:
>> 
>>> 84: if (ex.catchLocation() == null) {
>>> 85: throw new RuntimeException("Exception 
>>> catch location is null");
>>> 86: }
>> 
>> One more thing you can check here. ExceptionEvent implements Locatable, 
>> which has a location() API. That should return the same location as 
>> ex.thread().frame(0).location().
>
> `if (!ex.thread().frame(0).location().equals(ex.location())) {` causes an 
> exception:
> 
> 
> java.lang.IllegalArgumentException: Invalid method id: 139869509179824
> at 
> jdk.jdi/com.sun.tools.jdi.ReferenceTypeImpl.getMethodMirror(ReferenceTypeImpl.java:127)
> at 
> jdk.jdi/com.sun.tools.jdi.LocationImpl.method(LocationImpl.java:101)
> at jdk.jdi/com.sun.tools.jdi.LocationImpl.equals(LocationImpl.java:66)
> at JdwpOnThrowTest.main(JdwpOnThrowTest.java:92)
> at 
> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
> at java.base/java.lang.reflect.Method.invoke(Method.java:580)
> at 
> com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
> at java.base/java.lang.Thread.run(Thread.java:1570)

I resolved all the other things you pointed out, but this issue is sticky.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1360942831

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v3]

2023-10-16 Thread Johannes Bechberger 
> Fix `onthrow` issue by passing the event info to the `initialize` method.
> 
> This prevents `jdb` from receiving a broken exception event and throwing an 
> internal NullPointerException, upon attaching to the JDWP-agent.

Johannes Bechberger has updated the pull request incrementally with one 
additional commit since the last revision:

  Copyright and timeout

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/16145/files
  - new: https://git.openjdk.org/jdk/pull/16145/files/3badd197..1f72b743

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16145&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16145&range=01-02

  Stats: 31 lines in 3 files changed: 26 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/16145.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16145/head:pull/16145

PR: https://git.openjdk.org/jdk/pull/16145

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger 
On Mon, 16 Oct 2023 15:50:05 GMT, Chris Plummer  wrote:

>> Johannes Bechberger has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add test case
>
> test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 86:
> 
>> 84: if (ex.catchLocation() == null) {
>> 85: throw new RuntimeException("Exception 
>> catch location is null");
>> 86: }
> 
> One more thing you can check here. ExceptionEvent implements Locatable, which 
> has a location() API. That should return the same location as 
> ex.thread().frame(0).location().

`if (!ex.thread().frame(0).location().equals(ex.location())) {` causes an 
exception:


java.lang.IllegalArgumentException: Invalid method id: 139869509179824
at 
jdk.jdi/com.sun.tools.jdi.ReferenceTypeImpl.getMethodMirror(ReferenceTypeImpl.java:127)
at jdk.jdi/com.sun.tools.jdi.LocationImpl.method(LocationImpl.java:101)
at jdk.jdi/com.sun.tools.jdi.LocationImpl.equals(LocationImpl.java:66)
at JdwpOnThrowTest.main(JdwpOnThrowTest.java:92)
at 
java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at 
com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
at java.base/java.lang.Thread.run(Thread.java:1570)

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1360927364

Re: Serviceability Meetup

2023-10-16 Thread Laurence Cable 

Thanks Marcus!!!

looking forward to it!

- Larry

On 10/15/23 1:28 PM, Marcus Hirt wrote:

Hi all,

Roughly 19 months ago I held an OpenJDK Serviceability Meetup, where a 
few people (35 in total) from various companies (Oracle, SAP, Red Hat, 
Datadog, Azul, VMware and more) interested in OpenJDK serviceability 
topics, met to discuss various problems and potential solutions 
related to OpenJDK serviceability.


After the meeting I did a poll, revealing that people had fun at the 
meetup, and that they on average wanted me to do them every 6 months. 
In the spirit of "better late than never", I have decided to try to do 
one again. :)


I tweeted (um, Xed?) about this 
 a while back, 
which prompted Larry Cable to reach out and wanting to participate. He 
also suggested that I post here about the meetup - so here I am, 
posting. I feel silly for not doing so in the first place.


Anyways, here's a link to the invite form, should you be interested in 
participating:

https://forms.gle/nHcAGACBRBydTvbH8

Kind regards,
Marcus

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Chris Plummer 
On Mon, 16 Oct 2023 16:01:39 GMT, Johannes Bechberger  
wrote:

>> Fix `onthrow` issue by passing the event info to the `initialize` method.
>> 
>> This prevents `jdb` from receiving a broken exception event and throwing an 
>> internal NullPointerException, upon attaching to the JDWP-agent.
>
> Johannes Bechberger has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Add test case

test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 70:

> 68: long start = System.currentTimeMillis();
> 69: while (start + 1000 > System.currentTimeMillis()) {
> 70: EventSet eventSet = queue.remove(1000);

One second is not always enough in some test situations such as with -Xcomp on 
a slower machine. I'd suggest giving it 10 seconds.

test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 74:

> 72: while(eventIterator.hasNext() && start + 1000 > 
> System.currentTimeMillis()) {
> 73: Event event = eventIterator.next();
> 74: if (event instanceof ExceptionEvent ex) {

It would be useful for future debugging to log every event. However, logging 
the invalid ExceptionEvent might itself throw an exception and you would never 
get to your checks below, so perhaps log after all the checks below.

test/jdk/com/sun/jdi/JdwpOnThrowTest.java line 86:

> 84: if (ex.catchLocation() == null) {
> 85: throw new RuntimeException("Exception 
> catch location is null");
> 86: }

One more thing you can check here. ExceptionEvent implements Locatable, which 
has a location() API. That should return the same location as 
ex.thread().frame(0).location().

test/jdk/com/sun/jdi/ThrowCaughtException.java line 1:

> 1: /* /nodynamiccopyright/ */ public class ThrowCaughtException {  // hard 
> coded linenumbers - DO NOT CHANGE

I think you should still do a copyright. We have plenty of cases of files with 
hard coded line numbers and copyrights. Also, I don't see that you are actually 
hard coding the line numbers in the test. There is no check that the exception 
was thrown or caught at the proper location.

-

PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1360902294
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1360892174
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1360889149
PR Review Comment: https://git.openjdk.org/jdk/pull/16145#discussion_r1360898071

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-16 Thread Johannes Bechberger 
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger  
wrote:

> Fix `onthrow` issue by passing the event info to the `initialize` method.
> 
> This prevents `jdb` from receiving a broken exception event and throwing an 
> internal NullPointerException, upon attaching to the JDWP-agent.

I added a minimal test case which starts a debugging session for a basic 
program and attaches to it via JDI to check that the JDWP-agent throws an 
exception event with non-null properties. The case fails for the current master 
and succeeds with this PR.

-

PR Comment: https://git.openjdk.org/jdk/pull/16145#issuecomment-1764622093

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option [v2]

2023-10-16 Thread Johannes Bechberger 
> Fix `onthrow` issue by passing the event info to the `initialize` method.
> 
> This prevents `jdb` from receiving a broken exception event and throwing an 
> internal NullPointerException, upon attaching to the JDWP-agent.

Johannes Bechberger has updated the pull request incrementally with one 
additional commit since the last revision:

  Add test case

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/16145/files
  - new: https://git.openjdk.org/jdk/pull/16145/files/3bcb66dc..3badd197

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=16145&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16145&range=00-01

  Stats: 199 lines in 3 files changed: 196 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk/pull/16145.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/16145/head:pull/16145

PR: https://git.openjdk.org/jdk/pull/16145

Serviceability Meetup

2023-10-16 Thread Marcus Hirt 
Hi all,

Roughly 19 months ago I held an OpenJDK Serviceability Meetup, where a few
people (35 in total) from various companies (Oracle, SAP, Red Hat, Datadog,
Azul, VMware and more) interested in OpenJDK serviceability topics, met to
discuss various problems and potential solutions related to OpenJDK
serviceability.

After the meeting I did a poll, revealing that people had fun at the
meetup, and that they on average wanted me to do them every 6 months. In
the spirit of "better late than never", I have decided to try to do one
again. :)

I tweeted (um, Xed?) about this
 a while back, which
prompted Larry Cable to reach out and wanting to participate. He also
suggested that I post here about the meetup - so here I am, posting. I feel
silly for not doing so in the first place.

Anyways, here's a link to the invite form, should you be interested in
participating:
https://forms.gle/nHcAGACBRBydTvbH8

Kind regards,
Marcus

Re: RFR: 8318126: Refresh manpages

2023-10-16 Thread Hamlin Li 
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes  wrote:

> The open nroff manpage files are out of sync with their closed markdown 
> sources and need to be refreshed.
> 
> The changes to apply are coming from:
> 
> - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor 
> to each subcommand option on jfr html page
> - [JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java 
> manpage markdown source for JFR filename expansion
> - [JDK-8221633](https://bugs.openjdk.org/browse/JDK-8221633): 
> StartFlightRecording: consider moving mention of multiple comma-separated 
> parameters to the front
> - [JDK-8308662](https://bugs.openjdk.org/browse/JDK-8308662): Update the 
> "java" tool specification for CompileOnly
> - [JDK-8317565](https://bugs.openjdk.org/browse/JDK-8317565): Update Manpage 
> for obsoletion of UseSHM
> - [JDK-8310460](https://bugs.openjdk.org/browse/JDK-8310460): Remove jdeps 
> -profile option
> 
> There are also some simple line break changes, likely due to using different 
> versions of the pandoc tool.
> 
> Thanks

Marked as reviewed by mli (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/16196#pullrequestreview-1679368261

Re: RFR: JDK-8317920: JDWP-agent sends broken exception event with onthrow option

2023-10-16 Thread Johannes Bechberger 
On Wed, 11 Oct 2023 10:44:53 GMT, Johannes Bechberger  
wrote:

> Fix `onthrow` issue by passing the event info to the `initialize` method.
> 
> This prevents `jdb` from receiving a broken exception event and throwing an 
> internal NullPointerException, upon attaching to the JDWP-agent.

After the fix (see 
https://mostlynerdless.de/blog/2023/10/11/jdwp-onthrow-and-a-mysterious-error/):

➜ jdb -attach 5005
Set uncaught java.lang.Throwable
Set deferred uncaught java.lang.Throwable
Initializing jdb ...
> 
Exception occurred: Ex (to be caught at: OnThrowAndJCmd.main(), line=7 
bci=18)"thread=main", OnThrowAndJCmd.main(), line=6 bci=17
main[1]

-

PR Comment: https://git.openjdk.org/jdk/pull/16145#issuecomment-1763866646