Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information
On Wed, 31 Jan 2024 14:22:44 GMT, Kevin Walls wrote: > Introduce the jcmd "VM.debug" to implement access to a useful set of the > established debug.cpp utilities, with "jcmd PID VM.debug subcommand ...". > > Not recommended for live production use. Calling these "debug" utilities, > and not including them in the jcmd help output, is to remind us they are not > general customer-facing tools. This proposal effectively opens a new side channel for debugging with several commands ("events", "find", "findclass", ...). This will surely end up in troubleshooting recipes and other documentation. For now, the commands look benign but it may be tempting for people to show up with changes that extend this for other things. So I think this feature needs wider review and a CSR should be submitted for this. - PR Comment: https://git.openjdk.org/jdk/pull/17655#issuecomment-1926365013
Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information
On Wed, 31 Jan 2024 14:22:44 GMT, Kevin Walls wrote: > not including them in the jcmd help output, is to remind us they are not > general customer-facing tools. Then who are they for? and do they really belong in the `jcmd` tool, or is that just convenient? Without help information who will know what can be done with this tool? - PR Comment: https://git.openjdk.org/jdk/pull/17655#issuecomment-1925959472
[jdk22] RFR: 8322066: Update troff manpages in JDK 22 before RC
This update drops the "ea" from the version string. We also propagate the following fixes from the markdown sources to the troff manpage file: JDK-8322478: Update java manpage for multi-file source-code launcher JDK-8302233: HSS/LMS: keytool and jarsigner changes JDK-8318971: Better Error Handling for Jar Tool When Processing Non-existent Files Thanks. - Commit messages: - 8322066: Update troff pages in JDK 22 before RC Changes: https://git.openjdk.org/jdk22/pull/104/files Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8322066 Stats: 160 lines in 28 files changed: 63 ins; 15 del; 82 mod Patch: https://git.openjdk.org/jdk22/pull/104.diff Fetch: git fetch https://git.openjdk.org/jdk22.git pull/104/head:pull/104 PR: https://git.openjdk.org/jdk22/pull/104
Re: RFR: 8325180: Rename jvmti_FollowRefObjects.h
On Fri, 2 Feb 2024 16:34:19 GMT, Kim Barrett wrote: > Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_FollowRefObjects.h > to jvmti_FollowRefObjects.hpp, and replaces uses of NULL in the file. > > Testing: mach5 tier1 Marked as reviewed by jwaters (Committer). - PR Review: https://git.openjdk.org/jdk/pull/17689#pullrequestreview-1861434363