Withdrawn: 8333566: Remove unused methods
On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas wrote: > Please, consider this patch to remove unused methods from the code base. To > the best of my knowledge, these methods are only defined but never used. > > Here is a list with names of delete methods: > https://gist.github.com/JohnTortugo/fccc29781a1b584c03162aa4e160e874 > > Tested with Linux x86_64 tier1-4, GHA, and only cross building to other > platforms. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/19550
Re: RFR: 8333566: Remove unused methods
On Tue, 4 Jun 2024 20:51:52 GMT, Cesar Soares Lucas wrote: > Please, consider this patch to remove unused methods from the code base. To > the best of my knowledge, these methods are only defined but never used. > > Here is a list with names of delete methods: > https://gist.github.com/JohnTortugo/fccc29781a1b584c03162aa4e160e874 > > Tested with Linux x86_64 tier1-4, GHA, and only cross building to other > platforms. Closing this as not relevant. Thank you for the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/19550#issuecomment-2155383826
Re: RFR: 8333566: Remove unused methods
On Thu, 6 Jun 2024 01:28:00 GMT, Amit Kumar wrote:
>> Please, consider this patch to remove unused methods from the code base. To
>> the best of my knowledge, these methods are only defined but never used.
>>
>> Here is a list with names of delete methods:
>> https://gist.github.com/JohnTortugo/fccc29781a1b584c03162aa4e160e874
>>
>> Tested with Linux x86_64 tier1-4, GHA, and only cross building to other
>> platforms.
>
> src/hotspot/cpu/s390/vm_version_s390.hpp line 516:
>
>> 514: static void set_has_CompareTrap() { _features[0] |=
>> GnrlInstrExtFacilityMask; }
>> 515: static void set_has_RelativeLoadStore() { _features[0] |=
>> GnrlInstrExtFacilityMask; }
>> 516: static void set_has_GnrlInstrExtensions() { _features[0] |=
>> GnrlInstrExtFacilityMask; }
>
> I know this PR is still in draft state. Just a thought: I would like to keep
> the methods in `vm_version_s390.hpp` file for now. I'm planning to remove the
> checks applicable to older hardware. So it would be better, If I clean these
> methods as a part of that PR :-)
Sounds good to me!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19550#discussion_r1629762442
RFR: 8333566: Remove unused methods
Please, consider this patch to remove unused methods from the code base. To the best of my knowledge, these methods are only defined but never used. Here is a list with names of delete methods: https://gist.github.com/JohnTortugo/fccc29781a1b584c03162aa4e160e874 Tested with Linux x86_64 tier1-4, GHA, and only cross building to other platforms. - Commit messages: - Temove trailing whitespace. - Removing unused methods in aarch64 - Merge remote-tracking branch 'origin/main' into unused-methods - Merge remote-tracking branch 'origin/main' into unused-methods - Remove defined but unused methods. Changes: https://git.openjdk.org/jdk/pull/19550/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19550&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8333566 Stats: 1398 lines in 139 files changed: 1 ins; 1290 del; 107 mod Patch: https://git.openjdk.org/jdk/pull/19550.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/19550/head:pull/19550 PR: https://git.openjdk.org/jdk/pull/19550
Re: RFR: 8329433: Reduce nmethod header size [v6]
On Wed, 17 Apr 2024 00:56:33 GMT, Vladimir Kozlov wrote: >> This is part of changes which try to reduce size of `nmethod` and `codeblob` >> data vs code in CodeCache. >> These changes reduced size of `nmethod` header from 288 to 232 bytes. From >> 304 to 248 in optimized VM: >> >> Statistics for 1282 bytecoded nmethods for C2: >> total in heap = 5560352 (100%) >> header = 389728 (7.009053%) >> >> vs >> >> Statistics for 1322 bytecoded nmethods for C2: >> total in heap = 8307120 (100%) >> header = 327856 (3.946687%) >> >> >> Several unneeded fields in `nmethod` and `CodeBlob` were removed. Some >> fields were changed from `int` to `int16_t` with added corresponding asserts >> to make sure their values are fit into 16 bits. >> >> I did additional cleanup after recent `CompiledMethod` removal. >> >> Tested tier1-7,stress,xcomp and performance testing. > > Vladimir Kozlov has updated the pull request incrementally with two > additional commits since the last revision: > > - remove trailing space > - Shuffle fields initialization src/hotspot/share/code/nmethod.hpp line 259: > 257: int _orig_pc_offset; > 258: > 259: int _compile_id;// which compilation made this > nmethod NIT: are these fields always needed? - PR Review Comment: https://git.openjdk.org/jdk/pull/18768#discussion_r1569185473
Re: RFR: 8318682: SA decoding of scalar replaced objects is broken [v6]
On Wed, 17 Jan 2024 19:52:32 GMT, Tom Rodriguez wrote: >> The changes for JDK-8287061 didn't update the SA decoding logic and there >> are other places where the decoding has gotten out of sync with HotSpot. >> Some of them can't be tested because they are part of JVMCI but I've added a >> directed test for the JDK-8287061 code and a more brute force test that >> tries to decode everything. > > Tom Rodriguez has updated the pull request incrementally with one additional > commit since the last revision: > > Review comments Marked as reviewed by cslucas (Author). - PR Review: https://git.openjdk.org/jdk/pull/17407#pullrequestreview-1828474714
