Re: RFR: 8333130: MakeJAR2.sh uses hard-coded JDK version [v2]
On Fri, 31 May 2024 12:01:14 GMT, Jaikiran Pai wrote: >> Can I please get a review of this test-only change which addresses >> https://bugs.openjdk.org/browse/JDK-8333130? >> >> There are a couple of tests `NativeMethodPrefixApp` and `RetransformApp` >> under `test/jdk/java/lang/instrument/` which launch the app/test with a >> `-javaagent:` pointing to a test specific jar. The test, launched with >> that `javaagent`, then verifies the test specific details. >> >> In their current form, in order to construct the agent `.jar` and make it >> available to the jtreg test that's launched, they `@run` a jtreg `shell` >> test. This `shell` test uses the `MakeJAR2.sh` script to generate the jar >> file. The contents of the script is relatively straightforward - it compiles >> (using `javac`) some boot classpath classes, some agent specific classes and >> then generates a jar file with the agent classes and a `MANIFEST.MF` which >> points to the boot classpath classes along with test specific manifest >> attributes. In a recent PR the `MakeJAR2.sh` script was updated to pass >> `--enable-preview --release 23` since one of the existing agent class was >> updated to use the ClassFile API PreviewFeature >> (https://github.com/openjdk/jdk/pull/13009). >> >> This generated agent jar then is passed as `-javaagent:` to the subsequent >> `@run main` test which does the actual testing. >> >> So essentially the `shell` test which uses the `MakeJAR2.sh` is merely there >> to create a jar file that's needed by the actual test. Within the JDK we >> have several tests which compile other classes and generate jar files using >> in-process test libraries and the `java.util.spi.ToolProvider` >> implementations. These 2 tests too can be updated to use a similar >> technique, to completely get rid of the `MakeJAR2.sh`. Removing the >> `MakeJAR2.sh` will simplify the ability to pass around value for `--release` >> when using `--enable-preview`. >> >> The commit in this PR updates these 2 tests to use `@run driver` which then >> compiles relevant classes (maintaining the semantics of `MakeJAR2.sh`) and >> generates the agent jar file and then finally launching the test process. As >> part of the update, I did not retain the `@author` tag from the 2 test >> definitions, since it's my understanding that we no longer use those. I will >> add them back if we should retain them. >> >> The tests continue to pass locally with this change. I've also triggered >> tier testing in our CI for this change. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > fix Boot-Class-Path value for Windows Marked as reviewed by darcy (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/19495#pullrequestreview-2091336086
Re: RFR: 8330205: Initial troff manpage generation for JDK 24
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote: > Please review this mechanical change to man pages. This PR should be > integrated after https://github.com/openjdk/jdk/pull/18787. Marked as reviewed by darcy (Reviewer). > This PR is standalone as opposed to dependent because the #18787 dependency > currently has a merge conflict, which complicates the required workflow. > > This comment serves as a reminder to merge master into this PR once #18787 > has been integrated. If we don't do that, Skara will likely create a backport > issue: > > > (⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf > > is 23, a new backport will be created when this pr is integrated.) Thanks @pavelrappo. For as a small risk-reduction exercise, the fixVersion on the bug could also be changed to tbd, but if it is integrated after the main start-of-release PR it should be fine. - PR Review: https://git.openjdk.org/jdk/pull/19119#pullrequestreview-2044060259 PR Comment: https://git.openjdk.org/jdk/pull/19119#issuecomment-2099210018
Re: [jdk22] RFR: 8322066: Update troff manpages in JDK 22 before RC
On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote: > This update drops the "ea" from the version string. > > We also propagate the following fixes from the markdown sources to the troff > manpage file: > > JDK-8322478: Update java manpage for multi-file source-code launcher > JDK-8302233: HSS/LMS: keytool and jarsigner changes > JDK-8318971: Better Error Handling for Jar Tool When Processing Non-existent > Files > > > Thanks. Marked as reviewed by darcy (Reviewer). - PR Review: https://git.openjdk.org/jdk22/pull/104#pullrequestreview-1863882694
Re: RFR: 8325109: Sort method modifiers in canonical order
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote: > This is a follow-up on > [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the > bin/blessed-modifier-order.sh on the entire code base, and manually checked > the result. I have reverted all but these trivial and uncontroversial changes. > > Almost all of these are about moving `static` to its proper position; a few > do not involve `static` but instead puts `final` or `abstract` in the correct > place. > > I have deliberately stayed away from `default` in this PR, since they should > probably get a more thorough treatment, see > https://github.com/openjdk/jdk/pull/17468#pullrequestreview-1829238473. Looks fine; I just suggest double-checking on the current maintenance procedures for the java.util.concurrent code. - Marked as reviewed by darcy (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17670#pullrequestreview-1857088376
Re: Integrated: 8309230: ProblemList jdk/incubator/vector/Float64VectorTests.java on aarch64
On Wed, 31 May 2023 16:40:54 GMT, Daniel D. Daugherty wrote: > A couple of trivial ProblemListings: > [JDK-8309230](https://bugs.openjdk.org/browse/JDK-8309230) ProblemList > jdk/incubator/vector/Float64VectorTests.java on aarch64 > [JDK-8309231](https://bugs.openjdk.org/browse/JDK-8309231) ProblemList > vmTestbase/nsk/jvmti/scenarios/jni_interception/JI05/ji05t001/TestDescription.java Marked as reviewed by darcy (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14250#pullrequestreview-1453713285
Re: RFR: 8290918: Initial nroff manpage generation for JDK 21
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote: > Please review this simple update to the manpage to set the version to 21-ea. > > This change also corrects a typo in javac.1 that was manually introduced by > JDK-8300591 > > Thanks. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12154
Integrated: JDK-8300357: Use generalized see and link tags in java.management
On Wed, 18 Jan 2023 00:37:05 GMT, Joe Darcy wrote: > Use new javadoc capabilities courtesy JDK-8200337 to have > more-readable-in-javadoc-source links to anchors in several management types. > Analogous change is out for review in core libs, JDK-8300133. This pull request has now been integrated. Changeset: 5473e8a1 Author:Joe Darcy URL: https://git.openjdk.org/jdk/commit/5473e8a1c616a7004f4a154e235c5344b559104c Stats: 13 lines in 3 files changed: 0 ins; 1 del; 12 mod 8300357: Use generalized see and link tags in java.management Reviewed-by: alanb, dfuchs - PR: https://git.openjdk.org/jdk/pull/12058
Re: RFR: JDK-8300357: Use generalized see and link tags in java.management [v3]
On Wed, 18 Jan 2023 12:22:01 GMT, Daniel Fuchs wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve link target per code review comments.
>
> src/java.management/share/classes/javax/management/remote/JMXConnectorFactory.java
> line 140:
>
>> 138: * implementation may choose to find providers by other means. For
>> 139: * example, it may support {@linkplain
>> 140: * java.base/java.util.ServiceLoader##developing-service-providers
>> service providers},
>
> is `java.base/` needed here? I am a bit surprised - it's first time I see a
> module name used in a regular link target.
Updated.
> src/java.management/share/classes/javax/management/remote/JMXConnectorServerFactory.java
> line 129:
>
>> 127: * MalformedURLException if there is none. An
>> 128: * implementation may choose to find providers by other means. For
>> 129: * example, it may support {@linkplain
>
> Same remark regarding `java.base/` prefix.
For the connector server factory, "java.util" is still needed in the link since
I didn't want to change the import statements of the class.
-
PR: https://git.openjdk.org/jdk/pull/12058
Re: RFR: JDK-8300357: Use generalized see and link tags in java.management [v3]
> Use new javadoc capabilities courtesy JDK-8200337 to have > more-readable-in-javadoc-source links to anchors in several management types. > Analogous change is out for review in core libs, JDK-8300133. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Improve link target per code review comments. - Changes: - all: https://git.openjdk.org/jdk/pull/12058/files - new: https://git.openjdk.org/jdk/pull/12058/files/01ac3743..f8c64422 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12058&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12058&range=01-02 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/12058.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12058/head:pull/12058 PR: https://git.openjdk.org/jdk/pull/12058
Re: RFR: JDK-8300357: Use generalized see and link tags in java.management [v2]
> Use new javadoc capabilities courtesy JDK-8200337 to have > more-readable-in-javadoc-source links to anchors in several management types. > Analogous change is out for review in core libs, JDK-8300133. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Reflow paragraph per review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/12058/files - new: https://git.openjdk.org/jdk/pull/12058/files/5813eb1c..01ac3743 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=12058&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=12058&range=00-01 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/12058.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12058/head:pull/12058 PR: https://git.openjdk.org/jdk/pull/12058
Re: RFR: JDK-8300357: Use generalized see and link tags in java.management
On Wed, 18 Jan 2023 07:32:15 GMT, Alan Bateman wrote:
>> Use new javadoc capabilities courtesy JDK-8200337 to have
>> more-readable-in-javadoc-source links to anchors in several management
>> types. Analogous change is out for review in core libs, JDK-8300133.
>
> src/java.management/share/classes/java/lang/management/ThreadMXBean.java line
> 38:
>
>> 36: * typically mapped to kernel threads scheduled by the operating system.
>> 37: * {@code ThreadMXBean} does not support monitoring or management of
>> 38: * {@linkplain Thread##virtual-threads virtual threads}.
>
> The use of ## looks fine but would you mind re-flowing the javadoc in this
> paragraph as the line break after platform-threads looks accidental. This
> paragraph is mostly new text since Java 19.
Sure; I opted to not re-flow the paragraphs in the initial review to make
seeing the diffs easier.
-
PR: https://git.openjdk.org/jdk/pull/12058
RFR: JDK-8300357: Use generalized see and link tags in java.management
Use new javadoc capabilities courtesy JDK-8200337 to have more-readable-in-javadoc-source links to anchors in several management types. Analogous change is out for review in core libs, JDK-8300133. - Commit messages: - JDK-8300357: Use generalized see and link tags in java.management Changes: https://git.openjdk.org/jdk/pull/12058/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=12058&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8300357 Stats: 11 lines in 3 files changed: 0 ins; 1 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/12058.diff Fetch: git fetch https://git.openjdk.org/jdk pull/12058/head:pull/12058 PR: https://git.openjdk.org/jdk/pull/12058
Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v7]
On Wed, 11 Jan 2023 03:30:03 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is generated for a constructor `A()` in a class `A`
>> when the compiler detects that the following situation is _in theory
>> possible:_
>> * Some subclass `B extends A` exists, and `B` is defined in a separate
>> source file (i.e., compilation unit)
>> * Some constructor `B()` of `B` invokes `A()` as its superclass constructor
>> * During the execution of `A()`, some non-static method of `B.foo()` could
>> get invoked, perhaps indirectly
>>
>> In the above scenario, `B.foo()` would execute before `A()` has returned and
>> before `B()` has performed any initialization. To the extent `B.foo()`
>> accesses any fields of `B` - all of which are still uninitialized - it is
>> likely to function incorrectly.
>>
>> Note, when determining if a 'this' escape is possible, the compiler makes no
>> assumptions about code outside of the current compilation unit. It doesn't
>> look outside of the current source file to see what might actually happen
>> when a method is invoked. It does follow method and constructors within the
>> current compilation unit, and applies a simplified
>> union-of-all-possible-branches data flow analysis to see where 'this' could
>> end up.
>>
>> From my review, virtually all of the warnings generated in the various JDK
>> modules are valid warnings in the sense that a 'this' escape, as defined
>> above, is really and truly possible. However, that doesn't imply that any
>> bugs were found within the JDK - only that the possibility of a certain type
>> of bug exists if certain superclass constructors are used by someone,
>> somewhere, someday.
>>
>> For several "popular" classes, this PR also adds `@implNote`'s to the
>> offending constructors so that subclass implementors are made aware of the
>> threat. For one example, `TreeMap(Map)` invokes `putAll()` and `put()`.
>>
>> More details and a couple of motivating examples are given in an included
>> [doc
>> file](https://github.com/archiecobbs/jdk/blob/ThisEscape/src/java.base/share/classes/java/lang/doc-files/ThisEscape.html)
>> that these `@implNote`'s link to. See also the recent thread on `amber-dev`
>> for some background.
>>
>> Ideally, over time the owners of the various modules would review their
>> `@SuppressWarnings("this-escape")` annotations and determine which other
>> constructors also warranted such an `@implNote`.
>>
>> Because of all the`@SuppressWarnings` annotations, this PR touches a bunch
>> of different JDK modules. My apologies for that. Adding these annotations
>> was determined to be the more conservative approach, as compared to just
>> excepting `this-escape` from various module builds globally.
>>
>> **Patch Navigation Guide**
>>
>> * Non-trivial compiler changes:
>> * `src/jdk.compiler/share/classes/com/sun/tools/javac/code/Lint.java`
>> * `src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java`
>> * `src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Flow.java`
>> * `src/jdk.compiler/share/classes/com/sun/tools/javac/tree/TreeInfo.java`
>> *
>> `src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java`
>> *
>> `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties`
>> *
>> `src/jdk.compiler/share/classes/com/sun/tools/javac/resources/javac.properties`
>>
>> * Javadoc additions of `@implNote`:
>>
>> * `src/java.base/share/classes/java/io/PipedReader.java`
>> * `src/java.base/share/classes/java/io/PipedWriter.java`
>> * `src/java.base/share/classes/java/lang/Throwable.java`
>> * `src/java.base/share/classes/java/util/ArrayDeque.java`
>> * `src/java.base/share/classes/java/util/EnumMap.java`
>> * `src/java.base/share/classes/java/util/HashSet.java`
>> * `src/java.base/share/classes/java/util/Hashtable.java`
>> * `src/java.base/share/classes/java/util/LinkedList.java`
>> * `src/java.base/share/classes/java/util/TreeMap.java`
>> * `src/java.base/share/classes/java/util/TreeSet.java`
>>
>> * New unit tests
>> * `test/langtools/tools/javac/warnings/ThisEscape/*.java`
>>
>> * **Everything else** is just adding `@SuppressWarnings("this-escape")`
>
> Archie L. Cobbs has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Use the more appropriate Type comparison method Types.isSameType().
> - Add some more comments to clarify how the analysis works.
Per the discussion in "Effective Java" on calling overridable methods in a
constructor, future refinements of the check under review here could be
extended to examine the bodies of clone and readObject methods.
-
PR: https://git.openjdk.org/jdk
Integrated: JDK-8297215: Update libs tests to use @enablePreview
On Thu, 17 Nov 2022 21:48:11 GMT, Joe Darcy wrote: > Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. This pull request has now been integrated. Changeset: 770ff5a8 Author: Joe Darcy URL: https://git.openjdk.org/jdk/commit/770ff5a812d7b895ed2badfef9bb4e0b211d55bb Stats: 101 lines in 35 files changed: 12 ins; 2 del; 87 mod 8297215: Update libs tests to use @enablePreview Reviewed-by: alanb, sspitsyn - PR: https://git.openjdk.org/jdk/pull/11222
Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v5]
> Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Remove unnecessary @compile directives. - Merge branch 'master' into JDK-8297215 - Respond to review feedback. - Respond to review feedback. - Merge branch 'master' into JDK-8297215 - Respond to review feedback. - JDK-8297215: Update libs tests to use @enablePreview - Changes: - all: https://git.openjdk.org/jdk/pull/11222/files - new: https://git.openjdk.org/jdk/pull/11222/files/c0bef63e..d03ba044 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=03-04 Stats: 6073 lines in 149 files changed: 3996 ins; 1399 del; 678 mod Patch: https://git.openjdk.org/jdk/pull/11222.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11222/head:pull/11222 PR: https://git.openjdk.org/jdk/pull/11222
Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v4]
On Thu, 1 Dec 2022 19:19:01 GMT, Erik Gahlin wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > test/jdk/jdk/jfr/threading/TestDeepVirtualStackTrace.java line 46: > >> 44: * @modules jdk.jfr/jdk.jfr.internal >> 45: * @enablePreview >> 46: * @compile TestDeepVirtualStackTrace.java > > Is compilation needed here? For the two tests that compiled a single file, I remove the @compile directive. Any additional refactoring left for future work. - PR: https://git.openjdk.org/jdk/pull/11222
Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v4]
> Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/11222/files - new: https://git.openjdk.org/jdk/pull/11222/files/6d11bbca..c0bef63e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=02-03 Stats: 5 lines in 5 files changed: 0 ins; 4 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11222.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11222/head:pull/11222 PR: https://git.openjdk.org/jdk/pull/11222
Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v3]
> Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Respond to review feedback. - Merge branch 'master' into JDK-8297215 - Respond to review feedback. - JDK-8297215: Update libs tests to use @enablePreview - Changes: - all: https://git.openjdk.org/jdk/pull/11222/files - new: https://git.openjdk.org/jdk/pull/11222/files/f3fc9e26..6d11bbca Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=01-02 Stats: 47274 lines in 976 files changed: 24551 ins; 8961 del; 13762 mod Patch: https://git.openjdk.org/jdk/pull/11222.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11222/head:pull/11222 PR: https://git.openjdk.org/jdk/pull/11222
Re: RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v32]
On Mon, 28 Nov 2022 19:29:08 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk.org/jeps/434
>
> Maurizio Cimadamore has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Address review comments
src/java.base/share/classes/java/lang/foreign/Linker.java line 288:
> 286:
> 287: /**
> 288: * {@return A linker option used to denote the index of the
> first variadic argument layout in a
Typo: "A linker" vs "a linker"
-
PR: https://git.openjdk.org/jdk/pull/10872
Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]
On Fri, 18 Nov 2022 19:06:02 GMT, Alan Bateman wrote:
>> Right; ideally when the feature becomes non-preview the test update would
>> just be removing the "@enablePreview" line. I didn't author these tests so I
>> initially left any "othervm" directives in place since they aren't
>> incorrect, just at worst a bit inefficient.
>
> `@enablePreview` wasn't available when most of these tests were initially
> created. I changed some of to use this tag as part of other changes but
> didn't cover over the remaining tests that still use `@compile
> --enable-preview -source ${jdk.version} ...` and `@run main/othervm
> --enable-preview ...`. I just scanned the tests in
> test/jdk/java/lang/Thread/virtual and they can all be changed the same way,
> if you want. If you leave it then we'll just change them at the next edit in
> this area.
I think I got most of those in the PR. There was a file or two I didn't update
because not all the @compile/@run directives in the file used --enablePreview
and the @enablePreview directive applies to all @compile and @run directives.
-
PR: https://git.openjdk.org/jdk/pull/11222
Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]
On Fri, 18 Nov 2022 08:28:22 GMT, Alan Bateman wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Respond to review feedback. > > test/jdk/java/lang/Thread/BuilderTest.java line 29: > >> 27: * @enablePreview >> 28: * @compile BuilderTest.java >> 29: * @run testng/othervm BuilderTest > > I assume `@compile` can be dropped from most of these tests now. Also I think > /othervm can be dropped too because jtreg will always use othervm for tests > that require --enable-preview. When the feature becomes permanent then it > would mean dropping the `@enablePreview` tag, no other changes. Right; ideally when the feature becomes non-preview the test update would just be removing the "@enablePreview" line. I didn't author these tests so I initially left any "othervm" directives in place since they aren't incorrect, just at worst a bit inefficient. - PR: https://git.openjdk.org/jdk/pull/11222
Re: RFR: JDK-8297215: Update libs tests to use @enablePreview [v2]
> Similar to an update recently done for langtools tests, update the libraries > regression tests to take advantage of the @enablePreview jtreg feature. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/11222/files - new: https://git.openjdk.org/jdk/pull/11222/files/88a566c6..f3fc9e26 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=00-01 Stats: 3 lines in 2 files changed: 0 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11222.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11222/head:pull/11222 PR: https://git.openjdk.org/jdk/pull/11222
RFR: JDK-8297215: Update libs tests to use @enablePreview
Similar to an update recently done for langtools tests, update the libraries regression tests to take advantage of the @enablePreview jtreg feature. - Commit messages: - JDK-8297215: Update libs tests to use @enablePreview Changes: https://git.openjdk.org/jdk/pull/11222/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11222&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8297215 Stats: 122 lines in 36 files changed: 33 ins; 1 del; 88 mod Patch: https://git.openjdk.org/jdk/pull/11222.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11222/head:pull/11222 PR: https://git.openjdk.org/jdk/pull/11222
Integrated: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java
On Mon, 14 Nov 2022 18:49:14 GMT, Joe Darcy wrote: > Update the compile command in JdbLastErrorTest.java so that it doesn't need > to be modified with each new JDK release to keep using preview features. This pull request has now been integrated. Changeset: 87530e66 Author: Joe Darcy URL: https://git.openjdk.org/jdk/commit/87530e66dd3e0b7cd95e6576998a0567884c7985 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8296913: Correct enable preview idiom in JdbLastErrorTest.java Reviewed-by: cjplummer, kevinw, alanb, sspitsyn - PR: https://git.openjdk.org/jdk/pull/11139
Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v4]
> Update the compile command in JdbLastErrorTest.java so that it doesn't need > to be modified with each new JDK release to keep using preview features. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'master' into JDK-8296913 - Update. - Respond to review feedback. - JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java - Changes: - all: https://git.openjdk.org/jdk/pull/11139/files - new: https://git.openjdk.org/jdk/pull/11139/files/7a8d00b4..86f11dc2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11139&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11139&range=02-03 Stats: 2463 lines in 52 files changed: 1414 ins; 678 del; 371 mod Patch: https://git.openjdk.org/jdk/pull/11139.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11139/head:pull/11139 PR: https://git.openjdk.org/jdk/pull/11139
Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v3]
> Update the compile command in JdbLastErrorTest.java so that it doesn't need > to be modified with each new JDK release to keep using preview features. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update. - Changes: - all: https://git.openjdk.org/jdk/pull/11139/files - new: https://git.openjdk.org/jdk/pull/11139/files/0e7972b8..7a8d00b4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11139&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11139&range=01-02 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/11139.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11139/head:pull/11139 PR: https://git.openjdk.org/jdk/pull/11139
Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v2]
On Mon, 14 Nov 2022 19:13:22 GMT, Alan Bateman wrote: >> Is that a new jtreg feature? I've used the idiom in the updated version of >> this file elsewhere in the JDK. > > https://bugs.openjdk.org/browse/CODETOOLS-7902654 > I only became aware of it a few months ago. Thanks @AlanBateman; I wasn't aware of the feature. Looks like there is still usage of the old idiom. - PR: https://git.openjdk.org/jdk/pull/11139
Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java [v2]
> Update the compile command in JdbLastErrorTest.java so that it doesn't need > to be modified with each new JDK release to keep using preview features. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/11139/files - new: https://git.openjdk.org/jdk/pull/11139/files/db01da1d..0e7972b8 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=11139&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11139&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11139.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11139/head:pull/11139 PR: https://git.openjdk.org/jdk/pull/11139
Re: RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java
On Mon, 14 Nov 2022 19:07:42 GMT, Alan Bateman wrote:
>> Update the compile command in JdbLastErrorTest.java so that it doesn't need
>> to be modified with each new JDK release to keep using preview features.
>
> test/jdk/com/sun/jdi/JdbLastErrorTest.java line 31:
>
>> 29: * @library /test/lib
>> 30: * @run compile --release ${jdk.version} --enable-preview
>> JdbLastErrorTest.java
>> 31: * @run main/othervm --enable-preview JdbLastErrorTest
>
> Better still would be to add `@enablePreview`. That would allow you the
> `@run compile` line to go away and you can drop the `--enable-preview` from
> the `@run main`.
Is that a new jtreg feature? I've used the idiom in the updated version of this
file elsewhere in the JDK.
-
PR: https://git.openjdk.org/jdk/pull/11139
RFR: JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java
Update the compile command in JdbLastErrorTest.java so that it doesn't need to be modified with each new JDK release to keep using preview features. - Commit messages: - JDK-8296913: Correct enable preview idiom in JdbLastErrorTest.java Changes: https://git.openjdk.org/jdk/pull/11139/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11139&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8296913 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/11139.diff Fetch: git fetch https://git.openjdk.org/jdk pull/11139/head:pull/11139 PR: https://git.openjdk.org/jdk/pull/11139
Integrated: JDK-8294618: Update openjdk.java.net => openjdk.org
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote: > With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. This pull request has now been integrated. Changeset: 536c9a51 Author:Joe Darcy URL: https://git.openjdk.org/jdk/commit/536c9a512ea90d97a1ae5310453410d55db98bdd Stats: 128 lines in 45 files changed: 0 ins; 0 del; 128 mod 8294618: Update openjdk.java.net => openjdk.org Reviewed-by: mikael, iris, joehw, prr, ihse - PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v9]
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision: - Merge branch 'master' into JDK-8294618 - Update accessibility URLs. - Merge branch 'master' into JDK-8294618 - Update make directory. - Update doc directory files. - Update hg URLs to git. - Merge branch 'master' into JDK-8294618 - http -> https - Undo manpage update. - Update copyright. - ... and 2 more: https://git.openjdk.org/jdk/compare/8aa24fec...eba2bd4b - Changes: - all: https://git.openjdk.org/jdk/pull/10501/files - new: https://git.openjdk.org/jdk/pull/10501/files/4055f1a6..eba2bd4b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=08 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=07-08 Stats: 1452 lines in 87 files changed: 912 ins; 312 del; 228 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v7]
On Mon, 3 Oct 2022 20:04:38 GMT, Phil Race wrote: >> Joe Darcy has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update make directory. > > src/jdk.accessibility/windows/native/include/bridge/AccessBridgeCalls.h line > 36: > >> 34: * >> https://git.openjdk.org/jdk/blob/master/src/jdk.accessibility/windows/native/bridge/AccessBridgeCalls.c >> 35: * >> 36: * Also note that the API is used in the jaccessinspector and >> jaccesswalker tools. > > The problem with this is, is that anyone who gets JDK 20 (or 21 the LTS) will > be forever more then pointed at the OpenJDK "tip" and if we made an > incompatible ABI change, that would be a problem. > At this point I'd prefer that this be updated to point to JDK 17, as in > https://github.com/openjdk/jdk17/blob/master/src/jdk.accessibility/windows/native/jaccesswalker/jaccesswalker.cpp > So it is a defined, known, compatible version. Updated to refer to JDK 17 specifically. - PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v8]
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 11 additional commits since the last revision: - Update accessibility URLs. - Merge branch 'master' into JDK-8294618 - Update make directory. - Update doc directory files. - Update hg URLs to git. - Merge branch 'master' into JDK-8294618 - http -> https - Undo manpage update. - Update copyright. - Revert unintended update to binary file. - ... and 1 more: https://git.openjdk.org/jdk/compare/7a8d31f3...4055f1a6 - Changes: - all: https://git.openjdk.org/jdk/pull/10501/files - new: https://git.openjdk.org/jdk/pull/10501/files/224ed7a0..4055f1a6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=06-07 Stats: 5510 lines in 75 files changed: 3554 ins; 1669 del; 287 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]
On Mon, 3 Oct 2022 17:17:39 GMT, Joe Darcy wrote: > > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it > > might warrant a separate PR..? > > Filed a few follow-up bugs: > > JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella) > JDK-8294725: Update openjdk.java.net => openjdk.org in java command man page And also filed JDK-8294728: Update openjdk.java.net => openjdk.org in hotspot unit test docs - PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v7]
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update make directory. - Changes: - all: https://git.openjdk.org/jdk/pull/10501/files - new: https://git.openjdk.org/jdk/pull/10501/files/6bf7bf61..224ed7a0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=05-06 Stats: 6 lines in 4 files changed: 0 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v6]
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update doc directory files. - Changes: - all: https://git.openjdk.org/jdk/pull/10501/files - new: https://git.openjdk.org/jdk/pull/10501/files/fbaf3d4c..6bf7bf61 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=04-05 Stats: 38 lines in 4 files changed: 0 ins; 0 del; 38 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]
On Fri, 30 Sep 2022 20:25:28 GMT, Joe Darcy wrote: > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it > might warrant a separate PR..? Filed a few follow-up bugs: JDK-8294724: Update openjdk.java.net => openjdk.org in tests (umbrella) JDK-8294725: Update openjdk.java.net => openjdk.org in java command man page - PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]
On Fri, 30 Sep 2022 17:38:54 GMT, Phil Race wrote: > This is correct. AccessBridge.h is published with the include/header files of > the JDK and anyone reading it there can't exactly make use of "../" Update to persistent git links. - PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]
On Fri, 30 Sep 2022 13:59:12 GMT, Magnus Ihse Bursie wrote: > Also, FWIW, there are 100+ hits in `test` as well. But that is so many it > might warrant a separate PR..? Yes; I think it is sufficient to update src and doc with this PR. - PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v5]
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Update hg URLs to git. - Merge branch 'master' into JDK-8294618 - http -> https - Undo manpage update. - Update copyright. - Revert unintended update to binary file. - JDK-8294618: Update openjdk.java.net => openjdk.org - Changes: - all: https://git.openjdk.org/jdk/pull/10501/files - new: https://git.openjdk.org/jdk/pull/10501/files/cee96d0a..fbaf3d4c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=04 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=03-04 Stats: 2670 lines in 133 files changed: 1729 ins; 406 del; 535 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org
On Fri, 30 Sep 2022 00:48:02 GMT, Mikael Vidstedt wrote: > Switch to https where needed/applicable while at it? Good idea; might as well do the update in a single changeset. - PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: http -> https - Changes: - all: https://git.openjdk.org/jdk/pull/10501/files - new: https://git.openjdk.org/jdk/pull/10501/files/04dfc3ef..cee96d0a Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=02-03 Stats: 22 lines in 6 files changed: 0 ins; 0 del; 22 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v3]
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Undo manpage update. - Changes: - all: https://git.openjdk.org/jdk/pull/10501/files - new: https://git.openjdk.org/jdk/pull/10501/files/2f257762..04dfc3ef Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=01-02 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v2]
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with two additional commits since the last revision: - Update copyright. - Revert unintended update to binary file. - Changes: - all: https://git.openjdk.org/jdk/pull/10501/files - new: https://git.openjdk.org/jdk/pull/10501/files/b12d774f..2f257762 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=00-01 Stats: 10 lines in 11 files changed: 0 ins; 0 del; 10 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
RFR: JDK-8294618: Update openjdk.java.net => openjdk.org
With the domain change from openjdk.java.net to openjdk.org, references to URLs in the sources should be updated. Updates were made using a shell script. I"ll run a copyright updater before any push. - Commit messages: - JDK-8294618: Update openjdk.java.net => openjdk.org Changes: https://git.openjdk.org/jdk/pull/10501/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10501&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8294618 Stats: 79 lines in 39 files changed: 0 ins; 0 del; 79 mod Patch: https://git.openjdk.org/jdk/pull/10501.diff Fetch: git fetch https://git.openjdk.org/jdk pull/10501/head:pull/10501 PR: https://git.openjdk.org/jdk/pull/10501
Re: RFR: 8289610: Degrade Thread.stop [v4]
On Sat, 17 Sep 2022 08:41:19 GMT, Alan Bateman wrote:
>> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for
>> removal, and remove the remaining special handling of ThreadDeath from the
>> JDK.
>>
>> Thread.stop is inherently unsafe and has been deprecated since JDK 1.2
>> (1998) with a link to a supplementary page that explains the rationale. Some
>> of the API surface has already been degraded or removed:
>> Thread.stop(Throwable) was degraded to throw UOE in Java 8 and removed in
>> Java 11, and ThreadGroup.stop was degraded to throw UOE in Java 19. As of
>> Java 19, the no-arg Thread.stop continues to work as before for platform
>> threads but throws UOE for virtual threads. The next step in the glacial
>> pace removal is the degrading of the no-arg Thread.stop method to throw UOE
>> for all threads.
>>
>> To keep things manageable, the change proposed here leaves JVM_StopThread in
>> place. A separate issue will remove it and do other cleanup/removal in the
>> VM. We have another JBS issue for the updates to the JLS and JVMS where
>> asynchronous exceptions are defined. There is also some remaining work on a
>> test class used by 6 jshell tests - if they aren't done in time then we will
>> temporarily exclude them.
>>
>> The change here has no impact on the debugger APIs (JVM TI StopThread, JDWP
>> ThreadReference/Stop, and JDI ThreadReference.stop). Debuggers can continue
>> to cause threads to throw an asynchronous exception, as might be done when
>> simulating code throwing an exception at some point in the code.
>
> Alan Bateman has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge/rebase. The pull request contains 12 additional
> commits since the last revision:
>
> - Merge
> - Updates to Java Thread Primitive Deprecation page
> - Repalce "it" with "victim thread"
> - Merge
> - Revert test/langtools/ProblemList.txt as jshell tests no longer rely on
> Thread.stop
> - become -> became in javadoc
> - Merge
> - Remove stopThread permission from RuntimePermission table, exclude jshell
> tests
> - Deprecate for removal
> - Next iteration, update dates in headers
> - ... and 2 more: https://git.openjdk.org/jdk/compare/c06e7ac5...93806f99
src/java.base/share/classes/java/lang/Thread.java line 1632:
> 1630:
> 1631: /**
> 1632: * Throws {@code UnsupportedOperationException}.
Consider using an implSpec tag here.
-
PR: https://git.openjdk.org/jdk/pull/10230
Re: [jdk19] Integrated: 8289857: ProblemList jdk/jfr/event/runtime/TestActiveSettingEvent.java
On Wed, 6 Jul 2022 20:45:22 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > jdk/jfr/event/runtime/TestActiveSettingEvent.java. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/117
