Integrated: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html
On Fri, 5 Apr 2024 12:50:04 GMT, Ludvig Janiuk wrote: > I used "fold -sw 120" and removed trailing whitespaces. This pull request has now been integrated. Changeset: 9acce7a6 Author:Ludvig Janiuk URL: https://git.openjdk.org/jdk/commit/9acce7a6f326543c302ca0408213cf333f5f778a Stats: 16 lines in 1 file changed: 10 ins; 0 del; 6 mod 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html Reviewed-by: kevinw - PR: https://git.openjdk.org/jdk/pull/18654
Re: RFR: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html
On Fri, 5 Apr 2024 12:50:04 GMT, Ludvig Janiuk wrote: > I used "fold -sw 120" and removed trailing whitespaces. I followed your suggestion, and also fixed a typo. - PR Comment: https://git.openjdk.org/jdk/pull/18654#issuecomment-2049055211
Re: RFR: 8329774: Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html [v2]
> I used "fold -sw 120" and removed trailing whitespaces. Ludvig Janiuk has updated the pull request incrementally with three additional commits since the last revision: - prepends - fold 100 - Revert "8329774 Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html" This reverts commit 12346b1b178e7ac3b1fbaddec76890f05edb9525. - Changes: - all: https://git.openjdk.org/jdk/pull/18654/files - new: https://git.openjdk.org/jdk/pull/18654/files/12346b1b..b722c9b5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18654=01 - incr: https://webrevs.openjdk.org/?repo=jdk=18654=00-01 Stats: 16 lines in 1 file changed: 2 ins; 0 del; 14 mod Patch: https://git.openjdk.org/jdk/pull/18654.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18654/head:pull/18654 PR: https://git.openjdk.org/jdk/pull/18654
RFR: 8329774 Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html
I used "fold -sw 120" and removed trailing whitespaces. - Commit messages: - 8329774 Break long lines in jdk/src/jdk.hotspot.agent/doc /transported_core.html Changes: https://git.openjdk.org/jdk/pull/18654/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18654=00 Issue: https://bugs.openjdk.org/browse/JDK-8329774 Stats: 11 lines in 1 file changed: 8 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/18654.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18654/head:pull/18654 PR: https://git.openjdk.org/jdk/pull/18654
Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information
On Wed, 31 Jan 2024 14:22:44 GMT, Kevin Walls wrote:
> Introduce the jcmd "VM.debug" to implement access to a useful set of the
> established debug.cpp utilities, with "jcmd PID VM.debug subcommand ...".
>
> Not recommended for live production use. Calling these "debug" utilities,
> and not including them in the jcmd help output, is to remind us they are not
> general customer-facing tools.
test/hotspot/jtreg/serviceability/dcmd/vm/VMDebugTest.java line 178:
> 176: String p = m.group(regexGroup);
> 177: ptr = new BigInteger(p, 16);
> 178: System.out.println("Found '" + pattern +"', using
> pointer: 0x" + ptr.toString(16));
Would it be more logical to say this?
"Found pointer: 0x" + ptr.toString(16)'" + " for pattern " +pattern
test/hotspot/jtreg/serviceability/dcmd/vm/VMDebugTest.java line 201:
> 199: run(new JMXExecutor());
> 200: }
> 201:*/
comment to remove
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1474686608
PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1474688481
Re: RFR: 8318026: jcmd should provide access to low-level JVM debug information
On Thu, 1 Feb 2024 15:47:24 GMT, Ludvig Janiuk wrote: >> Introduce the jcmd "VM.debug" to implement access to a useful set of the >> established debug.cpp utilities, with "jcmd PID VM.debug subcommand ...". >> >> Not recommended for live production use. Calling these "debug" utilities, >> and not including them in the jcmd help output, is to remind us they are not >> general customer-facing tools. > > test/hotspot/jtreg/serviceability/dcmd/vm/VMDebugTest.java line 201: > >> 199: run(new JMXExecutor()); >> 200: } >> 201:*/ > > comment to remove plus some formatting below in this file - PR Review Comment: https://git.openjdk.org/jdk/pull/17655#discussion_r1474688937
