Re: RFR: 8218885: Restore pop_frame and force_early_return functionality for Graal [v2]

2022-11-16 Thread Tom Rodriguez
> This logic no longer seems to be necessary since the adjustCompilationLevel 
> callback has been removed.

Tom Rodriguez has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains one commit:

  8218885: Restore pop_frame and force_early_return functionality for Graal

-

Changes: https://git.openjdk.org/jdk/pull/5625/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk=5625=01
  Stats: 8 lines in 1 file changed: 0 ins; 8 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/5625.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/5625/head:pull/5625

PR: https://git.openjdk.org/jdk/pull/5625


Re: RFR: 8218885: Restore pop_frame and force_early_return functionality for Graal

2022-11-16 Thread Alex Menkov
On Wed, 22 Sep 2021 05:40:40 GMT, Tom Rodriguez  wrote:

> This logic no longer seems to be necessary since the adjustCompilationLevel 
> callback has been removed.

Marked as reviewed by amenkov (Reviewer).

-

PR: https://git.openjdk.org/jdk/pull/5625


Re: RFR: 8218885: Restore pop_frame and force_early_return functionality for Graal

2022-11-16 Thread Serguei Spitsyn
On Wed, 22 Sep 2021 05:40:40 GMT, Tom Rodriguez  wrote:

> This logic no longer seems to be necessary since the adjustCompilationLevel 
> callback has been removed.

Yes.

-

PR: https://git.openjdk.org/jdk/pull/5625


Re: RFR: 8218885: Restore pop_frame and force_early_return functionality for Graal

2022-11-16 Thread Vladimir Kozlov
On Wed, 16 Nov 2022 17:56:12 GMT, Tom Rodriguez  wrote:

> mach5 runs with the requested options on a GraalVM have passed so I'm going 
> to merge this now.  Sound good?

Yes

-

PR: https://git.openjdk.org/jdk/pull/5625


Re: RFR: 8218885: Restore pop_frame and force_early_return functionality for Graal

2022-11-16 Thread Tom Rodriguez
On Wed, 22 Sep 2021 05:40:40 GMT, Tom Rodriguez  wrote:

> This logic no longer seems to be necessary since the adjustCompilationLevel 
> callback has been removed.

mach5 runs with the requested options on a GraalVM have passed so I'm going to 
merge this now.  Sound good?

-

PR: https://git.openjdk.org/jdk/pull/5625