Re: RFR: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread [v3]
On Fri, 28 Apr 2023 04:56:17 GMT, Serguei Spitsyn wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use NamedTask library class
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java
> line 214:
>
>> 212: }
>> 213:
>> 214: log2("..thread2 is " + (thread2.isVirtual() ? "" : "not ")
>> + "a virtual thread");
>
> Nit: Would it better to print "is a virtual thread" instead of "is not a
> virtual thread"?
I don't see your point. It prints one or the other depending on whether or not
the thread is virtual.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13696#discussion_r1179956252
Re: RFR: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread [v3]
On Thu, 27 Apr 2023 21:08:23 GMT, Chris Plummer wrote:
>> Convert this ThreadReference.interrupt() test to support virtual threads. I
>> believe this is the only test for ThreadReference.interrupt() that we have.
>>
>> Tested by running with and without -Dmain.wrapper=Virtual on all supported
>> platforms.
>
> Chris Plummer has updated the pull request incrementally with one additional
> commit since the last revision:
>
> use NamedTask library class
Looks good.
Thanks,
Serguei
test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java
line 214:
> 212: }
> 213:
> 214: log2("..thread2 is " + (thread2.isVirtual() ? "" : "not ") +
> "a virtual thread");
Nit: Would it better to print "is a virtual thread" instead of "is not a
virtual thread"?
-
Marked as reviewed by sspitsyn (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13696#pullrequestreview-1405223335
PR Review Comment: https://git.openjdk.org/jdk/pull/13696#discussion_r1179927700
Re: RFR: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread [v3]
On Thu, 27 Apr 2023 21:08:23 GMT, Chris Plummer wrote: >> Convert this ThreadReference.interrupt() test to support virtual threads. I >> believe this is the only test for ThreadReference.interrupt() that we have. >> >> Tested by running with and without -Dmain.wrapper=Virtual on all supported >> platforms. > > Chris Plummer has updated the pull request incrementally with one additional > commit since the last revision: > > use NamedTask library class Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/13696#pullrequestreview-1404929979
Re: RFR: 8282384: [LOOM] Need test for ThreadReference.interrupt() on a vthread [v3]
> Convert this ThreadReference.interrupt() test to support virtual threads. I > believe this is the only test for ThreadReference.interrupt() that we have. > > Tested by running with and without -Dmain.wrapper=Virtual on all supported > platforms. Chris Plummer has updated the pull request incrementally with one additional commit since the last revision: use NamedTask library class - Changes: - all: https://git.openjdk.org/jdk/pull/13696/files - new: https://git.openjdk.org/jdk/pull/13696/files/e417fee0..a7f277a9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=13696=02 - incr: https://webrevs.openjdk.org/?repo=jdk=13696=01-02 Stats: 5 lines in 1 file changed: 0 ins; 2 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/13696.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/13696/head:pull/13696 PR: https://git.openjdk.org/jdk/pull/13696
