Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-06-26 Thread Erik Joelsson
On Sat, 24 Jun 2023 06:47:48 GMT, Vladimir Sitnikov  
wrote:

> I've posted the suggetion to add .editorconfig on ide-support-dev, however, 
> the list does not seem to be active: 
> https://mail.openjdk.org/pipermail/ide-support-dev/2023-June/000281.html

I think that sounds like a reasonable idea. I'm not following that mailing 
list. I think you can just post a PR with your suggested contents and target 
build-dev (through the `build` label). I'm not familiar with this kind of file, 
so an explanation of which IDEs support it would be good to include.

-

PR Comment: https://git.openjdk.org/jdk/pull/11491#issuecomment-1607073914


Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-06-23 Thread Vladimir Sitnikov
On Mon, 16 Jan 2023 16:50:06 GMT, Magnus Ihse Bursie  wrote:

>> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an 
>> attempt to remove all trailing whitespace from properties files, and enable 
>> a jcheck verification that they did not come back, similar to other source 
>> code. It turned out that this was not so simple, however, since trailing 
>> whitespace in values is actually significant in properties files.
>> 
>> To address this, I have opened four bugs on different component teams to 
>> either remove the trailing significant whitespace (if it is there 
>> erroneously), or convert it to the unicode sequence `\u0020`: 
>> [JDK-8298042](https://bugs.openjdk.org/browse/JDK-8298042), 
>> [JDK-8298044](https://bugs.openjdk.org/browse/JDK-8298044), 
>> [JDK-8298045](https://bugs.openjdk.org/browse/JDK-8298045) and 
>> [JDK-8298046](https://bugs.openjdk.org/browse/JDK-8298046).
>> 
>> That leaves all the other trailing spaces, in blank lines and in the end of 
>> comments. These serve no purpose and should just be removed, and is what 
>> this issue concerns.
>> 
>> When this and the four "significant whitespace" bugs are all finally 
>> integrated, we can finally turn on the verification in jcheck for properties 
>> files as well.
>> 
>> The changes in this PR is based on 
>> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729), in #10792. I 
>> have restored all the "delete trailing whitespace" changes, except for those 
>> with significance. These changes were in turned created by  running `find . 
>> -type f -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to 
> a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into properties-eol-clean-safe
>  - 8298047: Remove all non-significant trailing whitespace from properties 
> files

I've posted the suggetion to add .editorconfig on ide-support-dev, however, the 
list does not seem to be active: 
https://mail.openjdk.org/pipermail/ide-support-dev/2023-June/000281.html

-

PR Comment: https://git.openjdk.org/jdk/pull/11491#issuecomment-1605290913


Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-17 Thread Magnus Ihse Bursie
On Tue, 17 Jan 2023 11:44:32 GMT, Vladimir Sitnikov  
wrote:

>> @RogerRiggs Thanks!
>
> @magicus , have you considered adding `.editorconfig` file (see 
> https://editorconfig.org/ ) so it configures developers' editors to trim the 
> whitespace?
> 
> Of course, `.editorconfig` does not enforce the policy, however, it would 
> make it easier for those who use editors that support `.editorconfig`. For 
> instance, IntelliJ editors support it by default.

@vlsi That is an interesting suggestion. My experience with `.editorconfig` is 
that it is a bit so-so about getting it to actually describe the coding 
practices of a project, but it can probably be used for a thing like stripping 
trailing whitespace.

I suggest we continue that discussion in ide-support-...@openjdk.org, to figure 
out exactly what can be added to an `.editorconfig file`, how it interacts with 
jcheck rules and test how different IDEs behave.

-

PR: https://git.openjdk.org/jdk/pull/11491


Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-17 Thread Vladimir Sitnikov
On Mon, 16 Jan 2023 18:52:24 GMT, Magnus Ihse Bursie  wrote:

>> The non-client parts look fine.
>
> @RogerRiggs Thanks!

@magicus , have you considered adding `.editorconfig` file (see 
https://editorconfig.org/ ) so it configures developers' editors to trim the 
whitespace?

Of course, `.editorconfig` does not enforce the policy, however, it would make 
it easier for those who use editors that support `.editorconfig`. For instance, 
IntelliJ editors support it by default.

-

PR: https://git.openjdk.org/jdk/pull/11491


Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-16 Thread Magnus Ihse Bursie
On Mon, 16 Jan 2023 17:22:36 GMT, Roger Riggs  wrote:

>> Magnus Ihse Bursie has updated the pull request with a new target base due 
>> to a merge or a rebase. The pull request now contains two commits:
>> 
>>  - Merge branch 'master' into properties-eol-clean-safe
>>  - 8298047: Remove all non-significant trailing whitespace from properties 
>> files
>
> The non-client parts look fine.

@RogerRiggs Thanks!

-

PR: https://git.openjdk.org/jdk/pull/11491


Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-16 Thread Roger Riggs
On Mon, 16 Jan 2023 16:50:06 GMT, Magnus Ihse Bursie  wrote:

>> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an 
>> attempt to remove all trailing whitespace from properties files, and enable 
>> a jcheck verification that they did not come back, similar to other source 
>> code. It turned out that this was not so simple, however, since trailing 
>> whitespace in values is actually significant in properties files.
>> 
>> To address this, I have opened four bugs on different component teams to 
>> either remove the trailing significant whitespace (if it is there 
>> erroneously), or convert it to the unicode sequence `\u0020`: 
>> [JDK-8298042](https://bugs.openjdk.org/browse/JDK-8298042), 
>> [JDK-8298044](https://bugs.openjdk.org/browse/JDK-8298044), 
>> [JDK-8298045](https://bugs.openjdk.org/browse/JDK-8298045) and 
>> [JDK-8298046](https://bugs.openjdk.org/browse/JDK-8298046).
>> 
>> That leaves all the other trailing spaces, in blank lines and in the end of 
>> comments. These serve no purpose and should just be removed, and is what 
>> this issue concerns.
>> 
>> When this and the four "significant whitespace" bugs are all finally 
>> integrated, we can finally turn on the verification in jcheck for properties 
>> files as well.
>> 
>> The changes in this PR is based on 
>> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729), in #10792. I 
>> have restored all the "delete trailing whitespace" changes, except for those 
>> with significance. These changes were in turned created by  running `find . 
>> -type f -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.
>
> Magnus Ihse Bursie has updated the pull request with a new target base due to 
> a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge branch 'master' into properties-eol-clean-safe
>  - 8298047: Remove all non-significant trailing whitespace from properties 
> files

The non-client parts look fine.

-

Marked as reviewed by rriggs (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11491


Re: RFR: 8298047: Remove all non-significant trailing whitespace from properties files [v2]

2023-01-16 Thread Magnus Ihse Bursie
> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an 
> attempt to remove all trailing whitespace from properties files, and enable a 
> jcheck verification that they did not come back, similar to other source 
> code. It turned out that this was not so simple, however, since trailing 
> whitespace in values is actually significant in properties files.
> 
> To address this, I have opened four bugs on different component teams to 
> either remove the trailing significant whitespace (if it is there 
> erroneously), or convert it to the unicode sequence `\u0020`: 
> [JDK-8298042](https://bugs.openjdk.org/browse/JDK-8298042), 
> [JDK-8298044](https://bugs.openjdk.org/browse/JDK-8298044), 
> [JDK-8298045](https://bugs.openjdk.org/browse/JDK-8298045) and 
> [JDK-8298046](https://bugs.openjdk.org/browse/JDK-8298046).
> 
> That leaves all the other trailing spaces, in blank lines and in the end of 
> comments. These serve no purpose and should just be removed, and is what this 
> issue concerns.
> 
> When this and the four "significant whitespace" bugs are all finally 
> integrated, we can finally turn on the verification in jcheck for properties 
> files as well.
> 
> The changes in this PR is based on 
> [JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729), in #10792. I have 
> restored all the "delete trailing whitespace" changes, except for those with 
> significance. These changes were in turned created by  running `find . -type 
> f -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.

Magnus Ihse Bursie has updated the pull request with a new target base due to a 
merge or a rebase. The pull request now contains two commits:

 - Merge branch 'master' into properties-eol-clean-safe
 - 8298047: Remove all non-significant trailing whitespace from properties files

-

Changes: https://git.openjdk.org/jdk/pull/11491/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11491&range=01
  Stats: 693 lines in 264 files changed: 0 ins; 0 del; 693 mod
  Patch: https://git.openjdk.org/jdk/pull/11491.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11491/head:pull/11491

PR: https://git.openjdk.org/jdk/pull/11491