Re: RFR: 8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method [v2]

2023-01-12 Thread Serguei Spitsyn 
On Thu, 12 Jan 2023 16:44:44 GMT, Chris Plummer  wrote:

>> `VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object)` is not 
>> used. Furthermore it confuses the reader that runs across 
>> `removeObjectMirror()` calls, because what is actually being called is 
>> `removeObjectMirror(SoftObjectReference ref)`.
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Make removeObjectMirror() private.

Looks good and simple. :)
Thanks,
Serguei

-

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11957

Re: RFR: 8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method [v2]

2023-01-12 Thread Alan Bateman 
On Thu, 12 Jan 2023 16:44:44 GMT, Chris Plummer  wrote:

>> `VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object)` is not 
>> used. Furthermore it confuses the reader that runs across 
>> `removeObjectMirror()` calls, because what is actually being called is 
>> `removeObjectMirror(SoftObjectReference ref)`.
>
> Chris Plummer has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Make removeObjectMirror() private.

Marked as reviewed by alanb (Reviewer).

-

PR: https://git.openjdk.org/jdk/pull/11957

Re: RFR: 8300012: Remove unused JDI VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object) method [v2]

2023-01-12 Thread Chris Plummer 
> `VirtualMachineImpl.removeObjectMirror(ObjectReferenceImpl object)` is not 
> used. Furthermore it confuses the reader that runs across 
> `removeObjectMirror()` calls, because what is actually being called is 
> `removeObjectMirror(SoftObjectReference ref)`.

Chris Plummer has updated the pull request incrementally with one additional 
commit since the last revision:

  Make removeObjectMirror() private.

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/11957/files
  - new: https://git.openjdk.org/jdk/pull/11957/files/fa48e07c..dbd2f3d5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11957&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11957&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/11957.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11957/head:pull/11957

PR: https://git.openjdk.org/jdk/pull/11957