Re: RFR: 8309673: Refactor ref_at methods in Serviceability ConstantPool [v2]
> The accessor methods in constantpool.cpp were previously cleaned up to allow > for different types of indices to be used, distinguishing them by the > bytecode. This patch adds the same changes to the hotspot serviceability > agent code. Verified with tier 1-5 tests. Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision: Removed unnecessary assignment - Changes: - all: https://git.openjdk.org/jdk/pull/14385/files - new: https://git.openjdk.org/jdk/pull/14385/files/2ee60bd1..6630cb2c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=14385=01 - incr: https://webrevs.openjdk.org/?repo=jdk=14385=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/14385.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14385/head:pull/14385 PR: https://git.openjdk.org/jdk/pull/14385
Re: RFR: 8309673: Refactor ref_at methods in Serviceability ConstantPool
On Thu, 8 Jun 2023 21:42:24 GMT, Matias Saavedra Silva wrote: > The accessor methods in constantpool.cpp were previously cleaned up to allow > for different types of indices to be used, distinguishing them by the > bytecode. This patch adds the same changes to the hotspot serviceability > code. Verified with tier 1-5 tests. Marked as reviewed by fparain (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/14385#pullrequestreview-1472650636
Re: RFR: 8309673: Refactor ref_at methods in Serviceability ConstantPool
On Thu, 8 Jun 2023 21:42:24 GMT, Matias Saavedra Silva wrote: > The accessor methods in constantpool.cpp were previously cleaned up to allow > for different types of indices to be used, distinguishing them by the > bytecode. This patch adds the same changes to the hotspot serviceability > code. Verified with tier 1-5 tests. Looks good. src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java line 262: > 260: case Bytecodes._invokedynamic: > 261: int poolIndex = > getCache().getIndyEntryAt(index).getConstantPoolIndex(); > 262: return poolIndex = invokeDynamicNameAndTypeRefIndexAt(poolIndex); probably don't need another assignment to poolIndex in the return statement. - Marked as reviewed by coleenp (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14385#pullrequestreview-1472334909 PR Review Comment: https://git.openjdk.org/jdk/pull/14385#discussion_r1224416163
RFR: 8309673: Refactor ref_at methods in Serviceability ConstantPool
The accessor methods in constantpool.cpp were previously cleaned up to allow for different types of indices to be used, distinguishing them by the bytecode. This patch adds the same changes to the hotspot serviceability code. Verified with tier 1-5 tests. - Commit messages: - 8309673: Refactor ref_at methods in Serviceability ConstantPool Changes: https://git.openjdk.org/jdk/pull/14385/files Webrev: https://webrevs.openjdk.org/?repo=jdk=14385=00 Issue: https://bugs.openjdk.org/browse/JDK-8309673 Stats: 95 lines in 4 files changed: 32 ins; 25 del; 38 mod Patch: https://git.openjdk.org/jdk/pull/14385.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14385/head:pull/14385 PR: https://git.openjdk.org/jdk/pull/14385
