Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 Our tier 1 builds have passed. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/14645#pullrequestreview-1497595990
Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 04:26:47 GMT, David Holmes wrote:
> > as is evident in the tests for this PR
>
> You mean the GHA builds? They don't seem to be building the failing
> `jdk.jdwp.agent-static-libs` target.
I can't recompile the JDK at the moment to compile ArrayReferenceImpl.c, but I
can devise a simple test for this:
#include
int main() {
_Alignas(8)
int i = 7;
printf("%i", i);
return 0;
}
`cl.exe -nologo -std:c11 -Fo:align.o align.c`
align.exe
7
The _Alignas specifier does the same thing as the __declspec(align()) one, so
there's no difference in which is used (which also means that the other places
where this is used being able to compile is proof of it working as well)
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606579037
Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 Okay I have it running through our tier1 builds at the moment. If that passes I will approve the PR. Thanks - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606580347
Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 04:23:58 GMT, Julian Waters wrote: > as is evident in the tests for this PR You mean the GHA builds? They don't seem to be building the failing `jdk.jdwp.agent-static-libs` target. - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606573575
Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 How was the original change tested? How was this change tested? - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606571300
Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Build failure after JDK- 8305341 _Alignas does work on Microsoft Visual C, fortunately - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606570803
Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 04:15:09 GMT, David Holmes wrote: > https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170 :/ > How was the original change tested? How was this change tested? I made the mistake of testing the original on gcc instead of the native compiler for Windows, I recompiled this one with the microsoft toolchain before writing the fix, which fortunately passes the compile step as is evident in the tests for this PR Sorry for the goof :( - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606570640 PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606572218
Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Microsoft, your C "conformance" is garbage https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170 - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606567568
Re: RFR: 8310863: Build failure after JDK- 8305341
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote: > Microsoft, your C "conformance" is garbage @dholmes-ora - PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606505881
RFR: 8310863: Build failure after JDK- 8305341
Microsoft, your C "conformance" is garbage - Commit messages: - ArrayReferenceImpl.c - GSSLibStub.c - 8310863 Changes: https://git.openjdk.org/jdk/pull/14645/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14645&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8310863 Stats: 11 lines in 3 files changed: 0 ins; 5 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/14645.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/14645/head:pull/14645 PR: https://git.openjdk.org/jdk/pull/14645
