Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]
On Tue, 26 Dec 2023 14:15:17 GMT, Taizo Kurashige wrote: >> Hi, >> >> I fixed the typos for JFR.start and JFR.dump. >> Acconding to issue's description, there is some typo in JFR.stop >> documentation, but I couldn't find that. I confirmed that there is no such >> typo in this repository. So I thought there was no need to fix JFR.stop >> documentation. >> >> I confirmed that the fixes are reflected and that all of the jdk_jfr tests >> pass. >> >> Could someone please review it? > > Taizo Kurashige has updated the pull request incrementally with one > additional commit since the last revision: > > 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump These changes seem fine to me. Hopefully @egahlin can also approve. BTW please merge your branch with master so that it is up to date. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16413#pullrequestreview-1902559381 PR Comment: https://git.openjdk.org/jdk/pull/16413#issuecomment-1965825683
Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]
On Tue, 26 Dec 2023 14:15:17 GMT, Taizo Kurashige wrote: >> Hi, >> >> I fixed the typos for JFR.start and JFR.dump. >> Acconding to issue's description, there is some typo in JFR.stop >> documentation, but I couldn't find that. I confirmed that there is no such >> typo in this repository. So I thought there was no need to fix JFR.stop >> documentation. >> >> I confirmed that the fixes are reflected and that all of the jdk_jfr tests >> pass. >> >> Could someone please review it? > > Taizo Kurashige has updated the pull request incrementally with one > additional commit since the last revision: > > 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump Could someone please review this PR? (Or will the review be done after https://bugs.openjdk.org/browse/JDK-8324089 is resolved?) - PR Comment: https://git.openjdk.org/jdk/pull/16413#issuecomment-1965659547
Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]
On Thu, 1 Feb 2024 05:07:13 GMT, David Holmes wrote: >> @dholmes-ora @egahlin >> >> I'm sorry that my slow response has prolonged this issue. I created a >> subtask and modified the source. If possible, please review them. > > Thanks @kurashige23 , the manpage subtask will be handled by someone from > Oracle. I'll leave it to JFR folk to do the review here. Thanks @dholmes-ora , I understood that the subtask will be handled by someone from Oracle. > I'll leave it to JFR folk to do the review here. Does it mean that this pull request will not be merged until the subtask is resolved? - PR Comment: https://git.openjdk.org/jdk/pull/16413#issuecomment-1931341003
Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]
On Wed, 31 Jan 2024 06:41:44 GMT, Taizo Kurashige wrote: >> Changes requested by dholmes (Reviewer). > > @dholmes-ora @egahlin > > I'm sorry that my slow response has prolonged this issue. I created a subtask > and modified the source. If possible, please review them. Thanks @kurashige23 , the manpage subtask will be handled by someone from Oracle. I'll leave it to JFR folk to do the review here. - PR Comment: https://git.openjdk.org/jdk/pull/16413#issuecomment-1920524186
Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]
On Mon, 30 Oct 2023 22:39:41 GMT, David Holmes wrote: >> Taizo Kurashige has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump > > Changes requested by dholmes (Reviewer). @dholmes-ora @egahlin I'm sorry that my slow response has prolonged this issue. I created a subtask and modified the source. If possible, please review them. - PR Comment: https://git.openjdk.org/jdk/pull/16413#issuecomment-1918482452
Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]
On Tue, 28 Nov 2023 07:44:27 GMT, David Holmes wrote: >> Thank you for telling me about how to jcmd.1 nroff file is managed. >> I will split this change into separate subtasks. Then if one of the Oracle >> engineers finds that subtask, will he/she work on it like any other bug? > > Yes it will be assigned and addressed. Thanks @dholmes-ora Sorry for the late response again. I issued sub-task. https://bugs.openjdk.org/browse/JDK-8324089 - PR Review Comment: https://git.openjdk.org/jdk/pull/16413#discussion_r1457086198
Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]
On Tue, 28 Nov 2023 07:44:27 GMT, David Holmes wrote: >> Thank you for telling me about how to jcmd.1 nroff file is managed. >> I will split this change into separate subtasks. Then if one of the Oracle >> engineers finds that subtask, will he/she work on it like any other bug? > > Yes it will be assigned and addressed. Thanks Sorry for the late response. I will ask my colleague to make it, so please wait a moment. - PR Review Comment: https://git.openjdk.org/jdk/pull/16413#discussion_r1436476251
Re: RFR: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump [v3]
> Hi, > > I fixed the typos for JFR.start and JFR.dump. > Acconding to issue's description, there is some typo in JFR.stop > documentation, but I couldn't find that. I confirmed that there is no such > typo in this repository. So I thought there was no need to fix JFR.stop > documentation. > > I confirmed that the fixes are reflected and that all of the jdk_jfr tests > pass. > > Could someone please review it? Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision: 8313710: jcmd: typo in the documentation of JFR.start and JFR.dump - Changes: - all: https://git.openjdk.org/jdk/pull/16413/files - new: https://git.openjdk.org/jdk/pull/16413/files/ec5b71ab..5fe59b39 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=16413&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=16413&range=01-02 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/16413.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/16413/head:pull/16413 PR: https://git.openjdk.org/jdk/pull/16413
