Re: RFR: 8325055: Rename Injector.h [v3]

2024-02-02 Thread Kim Barrett 
On Thu, 1 Feb 2024 07:12:08 GMT, David Holmes  wrote:

>> Kim Barrett has updated the pull request with a new target base due to a 
>> merge or a rebase. The incremental webrev excludes the unrelated changes 
>> brought in by the merge/rebase. The pull request contains three additional 
>> commits since the last revision:
>> 
>>  - Merge branch 'master' into Injector
>>  - fix name in README
>>  - rename Injector.h
>
> Seems fine.
> Thanks

Thanks for reviews @dholmes-ora , @alexmenkov , and @sspitsyn .

-

PR Comment: https://git.openjdk.org/jdk/pull/17656#issuecomment-1924195846

Re: RFR: 8325055: Rename Injector.h [v3]

2024-02-02 Thread Kim Barrett 
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp.
> 
> Testing: mach5 tier1

Kim Barrett has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains three additional commits since 
the last revision:

 - Merge branch 'master' into Injector
 - fix name in README
 - rename Injector.h

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/17656/files
  - new: https://git.openjdk.org/jdk/pull/17656/files/0ab5cf73..02077283

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=17656=02
 - incr: https://webrevs.openjdk.org/?repo=jdk=17656=01-02

  Stats: 6112 lines in 157 files changed: 4498 ins; 767 del; 847 mod
  Patch: https://git.openjdk.org/jdk/pull/17656.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17656/head:pull/17656

PR: https://git.openjdk.org/jdk/pull/17656

Re: RFR: 8325055: Rename Injector.h [v2]

2024-02-02 Thread Serguei Spitsyn 
On Wed, 31 Jan 2024 15:15:16 GMT, Kim Barrett  wrote:

>> Please review this trivial change that renames the file
>> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp.
>> 
>> Testing: mach5 tier1
>
> Kim Barrett has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix name in README

Marked as reviewed by sspitsyn (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/17656#pullrequestreview-1858886273

Re: RFR: 8325055: Rename Injector.h [v2]

2024-02-01 Thread Alex Menkov 
On Wed, 31 Jan 2024 15:15:16 GMT, Kim Barrett  wrote:

>> Please review this trivial change that renames the file
>> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp.
>> 
>> Testing: mach5 tier1
>
> Kim Barrett has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix name in README

Marked as reviewed by amenkov (Reviewer).

-

PR Review: https://git.openjdk.org/jdk/pull/17656#pullrequestreview-1857623975

Re: RFR: 8325055: Rename Injector.h [v2]

2024-02-01 Thread Kim Barrett 
On Thu, 1 Feb 2024 07:12:08 GMT, David Holmes  wrote:

> Seems fine. Thanks

Trivial?

-

PR Comment: https://git.openjdk.org/jdk/pull/17656#issuecomment-1922036034

Re: RFR: 8325055: Rename Injector.h [v2]

2024-01-31 Thread David Holmes 
On Wed, 31 Jan 2024 15:15:16 GMT, Kim Barrett  wrote:

>> Please review this trivial change that renames the file
>> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp.
>> 
>> Testing: mach5 tier1
>
> Kim Barrett has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix name in README

Seems fine.
Thanks

-

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/17656#pullrequestreview-1855696820

Re: RFR: 8325055: Rename Injector.h [v2]

2024-01-31 Thread Kim Barrett 
> Please review this trivial change that renames the file
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp.
> 
> Testing: mach5 tier1

Kim Barrett has updated the pull request incrementally with one additional 
commit since the last revision:

  fix name in README

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/17656/files
  - new: https://git.openjdk.org/jdk/pull/17656/files/ea9edad1..0ab5cf73

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk=17656=01
 - incr: https://webrevs.openjdk.org/?repo=jdk=17656=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/17656.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17656/head:pull/17656

PR: https://git.openjdk.org/jdk/pull/17656

RFR: 8325055: Rename Injector.h

2024-01-31 Thread Kim Barrett 
Please review this trivial change that renames the file
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp.

Testing: mach5 tier1

-

Commit messages:
 - rename Injector.h

Changes: https://git.openjdk.org/jdk/pull/17656/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk=17656=00
  Issue: https://bugs.openjdk.org/browse/JDK-8325055
  Stats: 9 lines in 4 files changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/17656.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17656/head:pull/17656

PR: https://git.openjdk.org/jdk/pull/17656