Re: RFR: 8325055: Rename Injector.h [v2]
On Wed, 31 Jan 2024 15:15:16 GMT, Kim Barrett wrote: >> Please review this trivial change that renames the file >> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp. >> >> Testing: mach5 tier1 > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revision: > > fix name in README Marked as reviewed by sspitsyn (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17656#pullrequestreview-1858886273
Re: RFR: 8325055: Rename Injector.h [v2]
On Wed, 31 Jan 2024 15:15:16 GMT, Kim Barrett wrote: >> Please review this trivial change that renames the file >> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp. >> >> Testing: mach5 tier1 > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revision: > > fix name in README Marked as reviewed by amenkov (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17656#pullrequestreview-1857623975
Re: RFR: 8325055: Rename Injector.h [v2]
On Thu, 1 Feb 2024 07:12:08 GMT, David Holmes wrote: > Seems fine. Thanks Trivial? - PR Comment: https://git.openjdk.org/jdk/pull/17656#issuecomment-1922036034
Re: RFR: 8325055: Rename Injector.h [v2]
On Wed, 31 Jan 2024 15:15:16 GMT, Kim Barrett wrote: >> Please review this trivial change that renames the file >> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp. >> >> Testing: mach5 tier1 > > Kim Barrett has updated the pull request incrementally with one additional > commit since the last revision: > > fix name in README Seems fine. Thanks - Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17656#pullrequestreview-1855696820
Re: RFR: 8325055: Rename Injector.h [v2]
> Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp. > > Testing: mach5 tier1 Kim Barrett has updated the pull request incrementally with one additional commit since the last revision: fix name in README - Changes: - all: https://git.openjdk.org/jdk/pull/17656/files - new: https://git.openjdk.org/jdk/pull/17656/files/ea9edad1..0ab5cf73 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17656&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17656&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/17656.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17656/head:pull/17656 PR: https://git.openjdk.org/jdk/pull/17656