Re: RFR: 8325055: Rename Injector.h [v3]
On Thu, 1 Feb 2024 07:12:08 GMT, David Holmes wrote: >> Kim Barrett has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'master' into Injector >> - fix name in README >> - rename Injector.h > > Seems fine. > Thanks Thanks for reviews @dholmes-ora , @alexmenkov , and @sspitsyn . - PR Comment: https://git.openjdk.org/jdk/pull/17656#issuecomment-1924195846
Re: RFR: 8325055: Rename Injector.h [v3]
> Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/Injector.h to Injector.hpp. > > Testing: mach5 tier1 Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into Injector - fix name in README - rename Injector.h - Changes: - all: https://git.openjdk.org/jdk/pull/17656/files - new: https://git.openjdk.org/jdk/pull/17656/files/0ab5cf73..02077283 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17656&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17656&range=01-02 Stats: 6112 lines in 157 files changed: 4498 ins; 767 del; 847 mod Patch: https://git.openjdk.org/jdk/pull/17656.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17656/head:pull/17656 PR: https://git.openjdk.org/jdk/pull/17656
