Re: RFR: 8325180: Rename jvmti_FollowRefObjects.h [v2]
> Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_FollowRefObjects.h > to jvmti_FollowRefObjects.hpp, and replaces uses of NULL in the file. > > Testing: mach5 tier1 Kim Barrett has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' into jvmti_FollowRefObjects - rename NULLs in jvmti_FollwRefObjects.hpp - rename jvmti_FollowRefObjects.h - Changes: - all: https://git.openjdk.org/jdk/pull/17689/files - new: https://git.openjdk.org/jdk/pull/17689/files/2fd44e24..bf1835b3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=17689=01 - incr: https://webrevs.openjdk.org/?repo=jdk=17689=00-01 Stats: 5673 lines in 180 files changed: 3451 ins; 1256 del; 966 mod Patch: https://git.openjdk.org/jdk/pull/17689.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17689/head:pull/17689 PR: https://git.openjdk.org/jdk/pull/17689
Re: RFR: 8325180: Rename jvmti_FollowRefObjects.h [v2]
On Fri, 2 Feb 2024 17:49:22 GMT, Serguei Spitsyn wrote: >> Kim Barrett has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - Merge branch 'master' into jvmti_FollowRefObjects >> - rename NULLs in jvmti_FollwRefObjects.hpp >> - rename jvmti_FollowRefObjects.h > > Looks good. Thanks for reviews, @sspitsyn , @lmesnik , and @TheShermanTanker . - PR Comment: https://git.openjdk.org/jdk/pull/17689#issuecomment-1930397715
Re: RFR: 8325180: Rename jvmti_FollowRefObjects.h
On Fri, 2 Feb 2024 16:34:19 GMT, Kim Barrett wrote: > Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_FollowRefObjects.h > to jvmti_FollowRefObjects.hpp, and replaces uses of NULL in the file. > > Testing: mach5 tier1 Marked as reviewed by lmesnik (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/17689#pullrequestreview-1864190777
Re: RFR: 8325180: Rename jvmti_FollowRefObjects.h
On Fri, 2 Feb 2024 16:34:19 GMT, Kim Barrett wrote: > Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_FollowRefObjects.h > to jvmti_FollowRefObjects.hpp, and replaces uses of NULL in the file. > > Testing: mach5 tier1 Marked as reviewed by jwaters (Committer). - PR Review: https://git.openjdk.org/jdk/pull/17689#pullrequestreview-1863209709
Re: RFR: 8325180: Rename jvmti_FollowRefObjects.h
On Fri, 2 Feb 2024 16:34:19 GMT, Kim Barrett wrote: > Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_FollowRefObjects.h > to jvmti_FollowRefObjects.hpp, and replaces uses of NULL in the file. > > Testing: mach5 tier1 Marked as reviewed by jwaters (Committer). - PR Review: https://git.openjdk.org/jdk/pull/17689#pullrequestreview-1861434363
Re: RFR: 8325180: Rename jvmti_FollowRefObjects.h
On Fri, 2 Feb 2024 16:34:19 GMT, Kim Barrett wrote: > Please review this trivial change that renames the file > test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_FollowRefObjects.h > to jvmti_FollowRefObjects.hpp, and replaces uses of NULL in the file. > > Testing: mach5 tier1 Looks good. - Marked as reviewed by sspitsyn (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17689#pullrequestreview-1859989205
RFR: 8325180: Rename jvmti_FollowRefObjects.h
Please review this trivial change that renames the file test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_FollowRefObjects.h to jvmti_FollowRefObjects.hpp, and replaces uses of NULL in the file. Testing: mach5 tier1 - Commit messages: - rename NULLs in jvmti_FollwRefObjects.hpp - rename jvmti_FollowRefObjects.h Changes: https://git.openjdk.org/jdk/pull/17689/files Webrev: https://webrevs.openjdk.org/?repo=jdk=17689=00 Issue: https://bugs.openjdk.org/browse/JDK-8325180 Stats: 8 lines in 5 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jdk/pull/17689.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17689/head:pull/17689 PR: https://git.openjdk.org/jdk/pull/17689
