Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
On Mon, 11 Mar 2024 15:19:08 GMT, Daniel Fuchs wrote: >>> Is there any value in keeping `SubjectDelegationPermission` after this >>> change? If so, I would mark that API deprecated for removal, so that it can >>> be removed in the next release or two. >> >> No, nothing uses SubjectDelegationPermission. That can be deprecated. >> >>> Are there remaining tests that test the JMX fine grained permissions >>> feature w/o depending on subject delegation? >> >> Yes there are some tests other than those changed here, which use >> MBeanPermission in policies and become irrelevant post-SM. > >> Is there any value in keeping `SubjectDelegationPermission` after this >> change? If so, I would mark that API deprecated for removal, so that it can >> be removed in the next release or two. > > No issue with deprecation. I guess it can be removed once > `java.security.Policy` is removed? Thanks @dfuch for the comments and review. 8-) - PR Comment: https://git.openjdk.org/jdk/pull/18025#issuecomment-1997329701
Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
On Mon, 11 Mar 2024 15:19:08 GMT, Daniel Fuchs wrote: > > Is there any value in keeping `SubjectDelegationPermission` after this > > change? If so, I would mark that API deprecated for removal, so that it can > > be removed in the next release or two. > > No issue with deprecation. I guess it can be removed once > `java.security.Policy` is removed? Yes, or to be more precise, when the `JavaPolicy` implementation of `java.security.Policy` is removed. - PR Comment: https://git.openjdk.org/jdk/pull/18025#issuecomment-1989444321
Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
On Fri, 8 Mar 2024 10:20:36 GMT, Kevin Walls wrote: > Is there any value in keeping `SubjectDelegationPermission` after this > change? If so, I would mark that API deprecated for removal, so that it can > be removed in the next release or two. No issue with deprecation. I guess it can be removed once `java.security.Policy` is removed? - PR Comment: https://git.openjdk.org/jdk/pull/18025#issuecomment-1988693902
Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
On Thu, 7 Mar 2024 19:58:35 GMT, Sean Mullan wrote: > Is there any value in keeping `SubjectDelegationPermission` after this > change? If so, I would mark that API deprecated for removal, so that it can > be removed in the next release or two. No, nothing uses SubjectDelegationPermission. That can be deprecated. > Are there remaining tests that test the JMX fine grained permissions feature > w/o depending on subject delegation? Yes there are some tests other than those changed here, which use MBeanPermission in policies and become irrelevant post-SM. - PR Comment: https://git.openjdk.org/jdk/pull/18025#issuecomment-1985429423
Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
On Thu, 7 Mar 2024 20:07:57 GMT, Sean Mullan wrote: >> Kevin Walls has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Test specifically that UOE is thrown. > > src/java.management/share/classes/javax/management/remote/JMXConnector.java > line 153: > >> 151: * >> 152: * @exception UnsupportedOperationException if a non-null >> delegationSubject >> 153: * is specifed. Subject Delegation has been removed. > > Typo: s/specifed/specified/ got it thanks. > src/java.management/share/classes/javax/management/remote/JMXConnector.java > line 158: > >> 156: * and is only useful in conjunction with other APIs which are >> deprecated and >> 157: * subject to removal in a future release. Consequently, this >> method is also >> 158: * deprecated and subject to removal. There is no replacement. > > Maybe you want to change this text to be more direct here that subject > delegation is no longer supported and what this method now does. Yes, that should be updated, the feature is gone with this change. - PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1516884990 PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1516885582
Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
On Wed, 6 Mar 2024 11:46:16 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > Test specifically that UOE is thrown. src/java.management/share/classes/javax/management/remote/JMXConnector.java line 153: > 151: * > 152: * @exception UnsupportedOperationException if a non-null > delegationSubject > 153: * is specifed. Subject Delegation has been removed. Typo: s/specifed/specified/ src/java.management/share/classes/javax/management/remote/JMXConnector.java line 158: > 156: * and is only useful in conjunction with other APIs which are > deprecated and > 157: * subject to removal in a future release. Consequently, this method > is also > 158: * deprecated and subject to removal. There is no replacement. Maybe you want to change this text to be more direct here that subject delegation is no longer supported and what this method now does. - PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1516758560 PR Review Comment: https://git.openjdk.org/jdk/pull/18025#discussion_r1516761404
Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
On Wed, 6 Mar 2024 11:46:16 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > Test specifically that UOE is thrown. Are there remaining tests that test the JMX fine grained permissions feature w/o depending on subject delegation? - PR Comment: https://git.openjdk.org/jdk/pull/18025#issuecomment-1984329809
Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
On Wed, 6 Mar 2024 11:46:16 GMT, Kevin Walls wrote: >> The deprecated Subject Delegation feature in JMX will be removed. >> >> This was marked in JDK 21 as deprecated for removal (JDK-8298966). > > Kevin Walls has updated the pull request incrementally with one additional > commit since the last revision: > > Test specifically that UOE is thrown. Is there any value in keeping `SubjectDelegationPermission` after this change? If so, I would mark that API deprecated for removal, so that it can be removed in the next release or two. - PR Comment: https://git.openjdk.org/jdk/pull/18025#issuecomment-1984324717
Re: RFR: 8326666: Remove the Java Management Extension (JMX) Subject Delegation feature [v5]
> The deprecated Subject Delegation feature in JMX will be removed. > > This was marked in JDK 21 as deprecated for removal (JDK-8298966). Kevin Walls has updated the pull request incrementally with one additional commit since the last revision: Test specifically that UOE is thrown. - Changes: - all: https://git.openjdk.org/jdk/pull/18025/files - new: https://git.openjdk.org/jdk/pull/18025/files/19ace691..c5256c3f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk=18025=04 - incr: https://webrevs.openjdk.org/?repo=jdk=18025=03-04 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/18025.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18025/head:pull/18025 PR: https://git.openjdk.org/jdk/pull/18025
