Re: RFR: 8328341: Remove deprecated per-thread compiler stats in sun.management
On Mon, 18 Mar 2024 09:42:13 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes per-thread compiler stats from > `sun.management` > > This removes: > > * The deprecated interface method > `HotspotCompilationMBean.getCompilerThreadStats()` along with the > implementation method in `HotspotCompilation` > * The class returned by these methods, `CompilerThreadStat` > * The nested class `HotspotCompilation.CompilerThreadInfo` which now falls > out of use > * The field `HotspotCompilation.threads`, along with its initialization in > `initCompilerCounters` > > This was initially discussed here: > https://mail.openjdk.org/pipermail/serviceability-dev/2024-March/054589.html > > Testing and verification: As this is purely a removal and cleanup PR of > unused code, no updates are made on the testing side. I have verified that > the string `getCompilerThreadStats` is not found in OpenJDK after this PR. Thanks for reviewing, Kevin! - PR Comment: https://git.openjdk.org/jdk/pull/18344#issuecomment-2007634465
Re: RFR: 8328341: Remove deprecated per-thread compiler stats in sun.management
On Mon, 18 Mar 2024 09:42:13 GMT, Eirik Bjørsnøs wrote: > Please review this cleanup PR which removes per-thread compiler stats from > `sun.management` > > This removes: > > * The deprecated interface method > `HotspotCompilationMBean.getCompilerThreadStats()` along with the > implementation method in `HotspotCompilation` > * The class returned by these methods, `CompilerThreadStat` > * The nested class `HotspotCompilation.CompilerThreadInfo` which now falls > out of use > * The field `HotspotCompilation.threads`, along with its initialization in > `initCompilerCounters` > > This was initially discussed here: > https://mail.openjdk.org/pipermail/serviceability-dev/2024-March/054589.html > > Testing and verification: As this is purely a removal and cleanup PR of > unused code, no updates are made on the testing side. I have verified that > the string `getCompilerThreadStats` is not found in OpenJDK after this PR. Yes, looks good. No problems with testst in test/jdk/javax/management or test/jdk/sun/management. - Marked as reviewed by kevinw (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/18344#pullrequestreview-1945428269
RFR: 8328341: Remove deprecated per-thread compiler stats in sun.management
Please review this cleanup PR which removes per-thread compiler stats from `sun.management` This removes: * The deprecated interface method `HotspotCompilationMBean.getCompilerThreadStats()` along with the implementation method in `HotspotCompilation` * The class returned by these methods, `CompilerThreadStat` * The nested class `HotspotCompilation.CompilerThreadInfo` which now falls out of use * The field `HotspotCompilation.threads`, along with its initialization in `initCompilerCounters` Testing and verification: As this is purely a removal and cleanup PR of unused code, no updates are made on the testing side. I have verified that the string `getCompilerThreadStats` is not found in OpenJDK after this PR. - Commit messages: - Remove HotspotCompilationMBean.getCompilerThreadStats() with associated implementation code Changes: https://git.openjdk.org/jdk/pull/18344/files Webrev: https://webrevs.openjdk.org/?repo=jdk=18344=00 Issue: https://bugs.openjdk.org/browse/JDK-8328341 Stats: 149 lines in 3 files changed: 0 ins; 147 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/18344.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18344/head:pull/18344 PR: https://git.openjdk.org/jdk/pull/18344
