Re: RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v6]
On Fri, 29 Mar 2024 20:45:14 GMT, Serguei Spitsyn wrote:
>> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp
>> line 164:
>>
>>> 162: fatal(jni, "Main: ensureAtBreakpoint: waited 10 sec");
>>> 163: }
>>> 164: LOG("Main: ensureAtBreakpoint: waitig 100 millis\n");
>>
>> Suggestion:
>>
>> LOG("Main: ensureAtBreakpoint: waiting 100 millis\n");
>
> Thanks, Chris. Will fix it.
Fixed and pushed.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1546232896
Re: RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v6]
On Fri, 29 Mar 2024 18:44:35 GMT, Chris Plummer wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: move log message to the right place
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp
> line 164:
>
>> 162: fatal(jni, "Main: ensureAtBreakpoint: waited 10 sec");
>> 163: }
>> 164: LOG("Main: ensureAtBreakpoint: waitig 100 millis\n");
>
> Suggestion:
>
> LOG("Main: ensureAtBreakpoint: waiting 100 millis\n");
Thanks, Chris. Will fix it.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1544856030
Re: RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v6]
On Fri, 29 Mar 2024 04:15:43 GMT, Serguei Spitsyn wrote:
>> This PR fixes a synchronization issue in the test:
>> `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest`
>>
>> The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it
>> has not reached an expected breakpoint yet.
>> The fix is to add a call to the method `ensureAtBreakpoint()` one more time
>> in the `B2` sub-test. It is needed after the top-most frame was popped with
>> the JVMTI `PopFrame`, and the target thread needs to reach the breakpoint
>> again after its execution was resumed.
>>
>> The time is very intermittent. At least, I was not able to reproduce the
>> timeout failure in thousands of mach5 runs with the `-Xcomp` option.
>>
>> Testing:
>> - Run the test
>> `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest` thousands
>> times in mach5
>
> Serguei Spitsyn has updated the pull request incrementally with one
> additional commit since the last revision:
>
> review: move log message to the right place
test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest/libPopFrameTest.cpp
line 164:
> 162: fatal(jni, "Main: ensureAtBreakpoint: waited 10 sec");
> 163: }
> 164: LOG("Main: ensureAtBreakpoint: waitig 100 millis\n");
Suggestion:
LOG("Main: ensureAtBreakpoint: waiting 100 millis\n");
-
PR Review Comment: https://git.openjdk.org/jdk/pull/18419#discussion_r1544769747
Re: RFR: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout [v6]
> This PR fixes a synchronization issue in the test: > `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest` > > The method `notifyAtBreakpoint()` can notify the `TestTask` thread when it > has not reached an expected breakpoint yet. > The fix is to add a call to the method `ensureAtBreakpoint()` one more time > in the `B2` sub-test. It is needed after the top-most frame was popped with > the JVMTI `PopFrame`, and the target thread needs to reach the breakpoint > again after its execution was resumed. > > The time is very intermittent. At least, I was not able to reproduce the > timeout failure in thousands of mach5 runs with the `-Xcomp` option. > > Testing: > - Run the test > `test/hotspot/jtreg/serviceability/jvmti/vthread/PopFrameTest` thousands > times in mach5 Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision: review: move log message to the right place - Changes: - all: https://git.openjdk.org/jdk/pull/18419/files - new: https://git.openjdk.org/jdk/pull/18419/files/14e0e60f..f8344149 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=18419&range=05 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18419&range=04-05 Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/18419.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/18419/head:pull/18419 PR: https://git.openjdk.org/jdk/pull/18419
