Re: RFR: 8330694: Rename 'HeapRegion' to 'G1HeapRegion' [v4]

2024-04-30 Thread Thomas Schatzl 
On Mon, 29 Apr 2024 22:54:18 GMT, Kim Barrett  wrote:

> > mach5 higher tier SA tests are fine. What are your plans for the remaining 
> > SA renames (would highly recommend to add) and the G1HeapRegion related 
> > helper classes?
> 
> I suggest the related helper classes be done in further followups, not make 
> this change even larger.

Fine with me, will file an issue about the helper classes.

-

PR Comment: https://git.openjdk.org/jdk/pull/18871#issuecomment-2084539234

Re: RFR: 8330694: Rename 'HeapRegion' to 'G1HeapRegion' [v4]

2024-04-29 Thread Kim Barrett 
On Mon, 29 Apr 2024 08:14:03 GMT, Thomas Schatzl  wrote:

> mach5 higher tier SA tests are fine. What are your plans for the remaining SA 
> renames (would highly recommend to add) and the G1HeapRegion related helper 
> classes?

I suggest the related helper classes be done in further followups, not make 
this change even larger.

-

PR Comment: https://git.openjdk.org/jdk/pull/18871#issuecomment-2083822517

Re: RFR: 8330694: Rename 'HeapRegion' to 'G1HeapRegion' [v4]

2024-04-29 Thread Thomas Schatzl 
On Sat, 27 Apr 2024 02:34:21 GMT, Lei Zaakjyu  wrote:

>> follow up 8267941
>
> Lei Zaakjyu has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   fix indentation

mach5 higher tier SA tests are fine.
What are your plans for the remaining SA renames (would highly recommend to 
add) and the G1HeapRegion related helper classes?

-

PR Comment: https://git.openjdk.org/jdk/pull/18871#issuecomment-2082124530

Re: RFR: 8330694: Rename 'HeapRegion' to 'G1HeapRegion' [v4]

2024-04-26 Thread Lei Zaakjyu 
> follow up 8267941

Lei Zaakjyu has updated the pull request incrementally with one additional 
commit since the last revision:

  fix indentation

-

Changes:
  - all: https://git.openjdk.org/jdk/pull/18871/files
  - new: https://git.openjdk.org/jdk/pull/18871/files/f02334fd..a76a71de

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=18871&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=18871&range=02-03

  Stats: 34 lines in 8 files changed: 0 ins; 2 del; 32 mod
  Patch: https://git.openjdk.org/jdk/pull/18871.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/18871/head:pull/18871

PR: https://git.openjdk.org/jdk/pull/18871